From nobody Mon Nov 3 06:35:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1731335500; cv=none; d=zohomail.com; s=zohoarc; b=DikpHcCO83YZuO60JzMyoVnmxdHocVVjEHHAT5hs4NWJE9xZWEDCGf/qzmI7aZxhNG9ywB/JqiIe07WvV1UPP5/988ycdAQltm4/bDkHvAkymQN/062CcrNzSSqEFTI3UtcgkZduIJrd9Cz6Cy8G16x43Yq6G5LDr1/nzBx39Ok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1731335500; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4PSMcaBDV1dD7xHWLdr1RBsu12mcxhSTEQJHJQ1FYmY=; b=mYKtADm4+ZKAFWHgpPHx72IxEO8Na2ZAksEE2zanEkA4HuC2aDCvFElUTxNoQlHbwwGvWnkDaJC9V/VgEVVxpAdu3n4ktZ7/3zS14QxJuOBAV7VZJpgY87tj5YD4q+5qBa4JMf2T9cbNu8IpyO1jGTs4kyy3sv59fSrUaLGEtUo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1731335500741669.5692153741223; Mon, 11 Nov 2024 06:31:40 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.833911.1249148 (Exim 4.92) (envelope-from ) id 1tAVRk-0001iu-5u; Mon, 11 Nov 2024 14:31:16 +0000 Received: by outflank-mailman (output) from mailman id 833911.1249148; Mon, 11 Nov 2024 14:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tAVRk-0001in-1r; Mon, 11 Nov 2024 14:31:16 +0000 Received: by outflank-mailman (input) for mailman id 833911; Mon, 11 Nov 2024 14:31:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tAVRj-0001ie-5I for xen-devel@lists.xenproject.org; Mon, 11 Nov 2024 14:31:15 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 955f9c6b-a039-11ef-a0c6-8be0dac302b0; Mon, 11 Nov 2024 15:31:05 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a9ed7d8c86cso821995966b.2 for ; Mon, 11 Nov 2024 06:31:05 -0800 (PST) Received: from andrewcoop.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0deebabsm595311266b.153.2024.11.11.06.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 06:31:03 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 955f9c6b-a039-11ef-a0c6-8be0dac302b0 X-Custom-Connection: eyJyZW1vdGVpcCI6IjJhMDA6MTQ1MDo0ODY0OjIwOjo2MmIiLCJoZWxvIjoibWFpbC1lajEteDYyYi5nb29nbGUuY29tIn0= X-Custom-Transaction: eyJpZCI6Ijk1NWY5YzZiLWEwMzktMTFlZi1hMGM2LThiZTBkYWMzMDJiMCIsInRzIjoxNzMxMzM1NDY1LjI4ODA1OCwic2VuZGVyIjoiYW5kcmV3LmNvb3BlckBjbG91ZC5jb20iLCJyZWNpcGllbnQiOiJ4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcifQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1731335464; x=1731940264; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4PSMcaBDV1dD7xHWLdr1RBsu12mcxhSTEQJHJQ1FYmY=; b=Jk/eqQu7KZjVdf3Omio80/uoy0IRexBE24SUMU65JA9AXMj1EkMhBcE0gd9SFzOdab Hkzb/BcgX9dl5VV818Aods5poa+w5HnU/k4R53Zxbn/sMynLh+Vd+zvooL5aMYD6xT/4 gt9f1GidnRTpK+s5khAqpy+pJPVtCWV1ny3VA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731335464; x=1731940264; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4PSMcaBDV1dD7xHWLdr1RBsu12mcxhSTEQJHJQ1FYmY=; b=mHsC5AyiV433h3BIy2bWg9ogPc8P1Go/jmkdKLQhIQWfSFgjYWzIwt6ZwUO7SSO/8V f0FTR69Bs2TD1fHRZT4mrtj0cW+1u9vYOIMsxZO/1zECkJSo+/AaNdFrDMOx+p3nEoST jIFPqzEXFkKDEZg/Ku6hjy08sFmsbCFnvUxPGmbBFulMJu+idyXszkSn1FG93kzg5rhu 4cbJFVEvXI18AzdO/6yrfjDG2rre2fpsGR5KZ7yyJJ+KOkYUacOX279nc32mQYD+TxNd Vs+HuT7c1hGMTsyTa9QbdAuXdZxa9/cDm+s26H5OiUZO+Roc0tadmoejD7Xrplxk2NnZ OlLg== X-Gm-Message-State: AOJu0YwNp3Z7StOEv0f1RlTiID67EvDKDPjtffwJP8mm80akpgTXtbej hjFODDyavpuTaw7mhjtp+TQLbJe7F3mautvShZI1ztdE4QLqMTwqKcc4Eop3oJM2MtLWt/+R84M b X-Google-Smtp-Source: AGHT+IHARdtWyLAttkk1YdFWiG60zvD/17Hohca9dsj1wbUtDZ3pR2uOkrvQcYxe3f5ZfEY5fhtNfg== X-Received: by 2002:a17:907:7dab:b0:a9a:3cf:cdb8 with SMTP id a640c23a62f3a-a9eeff3adaamr1208661066b.36.1731335464024; Mon, 11 Nov 2024 06:31:04 -0800 (PST) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , Juergen Gross Subject: [PATCH for-4.18] tools/libs/evtchn: Drop assert()s referencing MiniOS's main_thread Date: Mon, 11 Nov 2024 14:31:01 +0000 Message-Id: <20241111143101.996733-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1731335502516116600 Content-Type: text/plain; charset="utf-8" This breaks the build with debug active, as main_thread is not an exposed symbol. This is a minimal version of commit bc4fe94a69d4 ("tools/libs/evtchn: repla= ce assert()s in stubdom with proper locking"). It leaves MiniOS no worse off with respect to thread safety. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Juergen Gross Speculative fix. Gitlab is a little busy right now: https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1536597753 --- tools/libs/evtchn/minios.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c index 28743cb05575..e33ddec7e7f0 100644 --- a/tools/libs/evtchn/minios.c +++ b/tools/libs/evtchn/minios.c @@ -195,7 +195,6 @@ xenevtchn_port_or_error_t xenevtchn_bind_unbound_port(x= enevtchn_handle *xce, int ret; evtchn_port_t port; =20 - assert(get_current() =3D=3D main_thread); port_info =3D port_alloc(xce); if ( port_info =3D=3D NULL ) return -1; @@ -226,7 +225,6 @@ xenevtchn_port_or_error_t xenevtchn_bind_interdomain(xe= nevtchn_handle *xce, evtchn_port_t local_port; int ret; =20 - assert(get_current() =3D=3D main_thread); port_info =3D port_alloc(xce); if ( port_info =3D=3D NULL ) return -1; @@ -279,7 +277,6 @@ xenevtchn_port_or_error_t xenevtchn_bind_virq(xenevtchn= _handle *xce, struct port_info *port_info; evtchn_port_t port; =20 - assert(get_current() =3D=3D main_thread); port_info =3D port_alloc(xce); if ( port_info =3D=3D NULL ) return -1; base-commit: 2b18f341cb5c66bbc3260a8e0dd9f42b2f58d78c prerequisite-patch-id: 39749d67636f2c0377cd95d938cf0ae5da72403b prerequisite-patch-id: 75378607486a1a3909481c243f3dfd163ae433dc --=20 2.39.5