From nobody Thu Nov 21 19:50:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1728316398; cv=none; d=zohomail.com; s=zohoarc; b=Fy058m8ei43oq4Vek70zzHGlDF+XF4m1duUlEOh/wvrva88M7KQKVJ9A2iGmMI8qYBzXy3AGzwz+XK496zdBGias0lbRIDRP+EBNRsDIHZyfs6rzrQCDms5BfCkz6OYyUzjxoAsJTL8L9LvIjlxWC9hSGEUC7VLSDvxJm1cj3h0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728316398; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9TYzH8XXnpnrv/vwFrSTuoTElqLW4Sow9Xi2H8+/uD4=; b=EktEt5kmu2a6+Ag9zXB7zodgk48ov1JLb/F5tQN6ZEyQnz4vyJmkw45rTAild6mQqvQHoXgSdtg/47nTmzE4PCBqLnBSC1YJ9OjA/lWu1O8Hwz+dIxO5XNVx0GufGyp8a0dGnN0m1D5/zkiaBQ2h5aL8xy0xVF5Lu+SXdgeCucg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1728316398153982.2126042164111; Mon, 7 Oct 2024 08:53:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.812214.1224950 (Exim 4.92) (envelope-from ) id 1sxq2Y-0003sX-AD; Mon, 07 Oct 2024 15:52:54 +0000 Received: by outflank-mailman (output) from mailman id 812214.1224950; Mon, 07 Oct 2024 15:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxq2Y-0003sQ-7c; Mon, 07 Oct 2024 15:52:54 +0000 Received: by outflank-mailman (input) for mailman id 812214; Mon, 07 Oct 2024 15:52:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxq2W-0003e1-Og for xen-devel@lists.xenproject.org; Mon, 07 Oct 2024 15:52:52 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 345145c4-84c4-11ef-99a2-01e77a169b0f; Mon, 07 Oct 2024 17:52:49 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5c89f3e8a74so6453400a12.0 for ; Mon, 07 Oct 2024 08:52:49 -0700 (PDT) Received: from mewpvdipd1023.corp.cloud.com ([52.174.59.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99309aa6afsm386160366b.112.2024.10.07.08.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 08:52:48 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 345145c4-84c4-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1728316369; x=1728921169; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9TYzH8XXnpnrv/vwFrSTuoTElqLW4Sow9Xi2H8+/uD4=; b=ASJaZNn4/GJBhnjdt/jUz4gJ6SpY8OEMlq+HuRyw68dnVNGquDdTGqN4x5HlVbwkP6 dLszoEtEwz/WOgQMJfhyLE+VuIcQwo1A1LYJOLJvkq0vVlyArTVxjylqJq7997rE4Cna fK89GyuzK+vvHHSFBVf6Rj4KO9zduhfzsT2MM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728316369; x=1728921169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9TYzH8XXnpnrv/vwFrSTuoTElqLW4Sow9Xi2H8+/uD4=; b=jbNJv4xk+ATYHjizFIllfa7On7NIzNB6EOTSDTzL0fI9n0PInVHXxOiVbhJWSJS6dQ VKFttTDMHf+nc3nS5JqLEMJFWzHiryKd3iHpT+wW5O0uWzsiVSco3baFqqwENVxwxM5r ESLp56VVFLE68XeRY0nNeb4mjyy6o0h6iGWhXlnhZ9OUwaXyWbITT1kdfvmv/dArs25d fVE/1J8h3qmvIyz5De6v3MMJgcsEAhXWQoGlvmItoMDLgNscW9dVecA4d0p1clRTHf2n 1sW9zR24zTum01sOQqPR2nBcmWQ8dLHtH7vwefZ+fevVDpauFX/rS/ryugGcPMU46C78 rFTA== X-Gm-Message-State: AOJu0YxlfsSkdtdMgpN4UITLUfadvFWadOKCF1Cpp3IqKSjk9khdOoZv jNnA7YLXpcCzIUMPWloOsirWm26LnuwWXuQfQudEmJ2/dSMFzVpOu+I0RUxrCVQT3qEj0AmaQQX Hfr4= X-Google-Smtp-Source: AGHT+IFD+UoGl7Y5EgfhtlbByitJiOettPiLgEYOoIkKxFGeYn1wuwO0Qjdsd2PFWKnfZM2Ta5r92g== X-Received: by 2002:a17:907:960c:b0:a86:8b7b:7880 with SMTP id a640c23a62f3a-a991c06317fmr1040261066b.63.1728316368981; Mon, 07 Oct 2024 08:52:48 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 1/2] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu Date: Mon, 7 Oct 2024 16:52:39 +0100 Message-ID: <20241007155240.17186-2-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241007155240.17186-1-alejandro.vallejo@cloud.com> References: <20241007155240.17186-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1728316398827116600 Content-Type: text/plain; charset="utf-8" fpu_ctxt is either a pointer to the legacy x87/SSE save area (used by FXSAV= E) or a pointer aliased with xsave_area that points to its fpu_sse subfield. Such subfield is at the base and is identical in size and layout to the legacy buffer. This patch merges the 2 pointers in the arch_vcpu into a single XSAVE area.= In the very rare case in which the host doesn't support XSAVE all we're doing = is wasting a tiny amount of memory and trading those for a lot more simplicity= in the code. While at it, dedup the setup logic in vcpu_init_fpu() and integrate it into xstate_alloc_save_area(). Signed-off-by: Alejandro Vallejo -- v4: * Amend commit message with extra note about deduping vcpu_init_fpu() * Remove comment on top of cpu_user_regs (though I really think there ought to be a credible one, in one form or another). * Remove cast from blk.c so FXSAVE_AREA is "void *" * Simplify comment in xstate_alloc_save_area() for the "host has no XSAVE" case. --- xen/arch/x86/domctl.c | 6 ++++- xen/arch/x86/hvm/emulate.c | 4 +-- xen/arch/x86/hvm/hvm.c | 6 ++++- xen/arch/x86/i387.c | 45 +++++-------------------------- xen/arch/x86/include/asm/domain.h | 6 ----- xen/arch/x86/x86_emulate/blk.c | 2 +- xen/arch/x86/xstate.c | 12 ++++++--- 7 files changed, 28 insertions(+), 53 deletions(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 96d816cf1a7d..2d115395da90 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -1379,7 +1379,11 @@ void arch_get_info_guest(struct vcpu *v, vcpu_guest_= context_u c) #define c(fld) (c.nat->fld) #endif =20 - memcpy(&c.nat->fpu_ctxt, v->arch.fpu_ctxt, sizeof(c.nat->fpu_ctxt)); + BUILD_BUG_ON(sizeof(c.nat->fpu_ctxt) !=3D + sizeof(v->arch.xsave_area->fpu_sse)); + memcpy(&c.nat->fpu_ctxt, &v->arch.xsave_area->fpu_sse, + sizeof(c.nat->fpu_ctxt)); + if ( is_pv_domain(d) ) c(flags =3D v->arch.pv.vgc_flags & ~(VGCF_i387_valid|VGCF_in_kerne= l)); else diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index aa97ca1cbffd..f2bc6967dfcb 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -2371,7 +2371,7 @@ static int cf_check hvmemul_get_fpu( alternative_vcall(hvm_funcs.fpu_dirty_intercept); else if ( type =3D=3D X86EMUL_FPU_fpu ) { - const fpusse_t *fpu_ctxt =3D curr->arch.fpu_ctxt; + const fpusse_t *fpu_ctxt =3D &curr->arch.xsave_area->fpu_sse; =20 /* * Latch current register state so that we can back out changes @@ -2411,7 +2411,7 @@ static void cf_check hvmemul_put_fpu( =20 if ( aux ) { - fpusse_t *fpu_ctxt =3D curr->arch.fpu_ctxt; + fpusse_t *fpu_ctxt =3D &curr->arch.xsave_area->fpu_sse; bool dval =3D aux->dval; int mode =3D hvm_guest_x86_mode(curr); =20 diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 7b2e1c9813d6..77fe282118f7 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -914,7 +914,11 @@ static int cf_check hvm_save_cpu_ctxt(struct vcpu *v, = hvm_domain_context_t *h) =20 if ( v->fpu_initialised ) { - memcpy(ctxt.fpu_regs, v->arch.fpu_ctxt, sizeof(ctxt.fpu_regs)); + BUILD_BUG_ON(sizeof(ctxt.fpu_regs) !=3D + sizeof(v->arch.xsave_area->fpu_sse)); + memcpy(ctxt.fpu_regs, &v->arch.xsave_area->fpu_sse, + sizeof(ctxt.fpu_regs)); + ctxt.flags =3D XEN_X86_FPU_INITIALISED; } =20 diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c index 134e0bece519..fbb9d3584a3d 100644 --- a/xen/arch/x86/i387.c +++ b/xen/arch/x86/i387.c @@ -39,7 +39,7 @@ static inline void fpu_xrstor(struct vcpu *v, uint64_t ma= sk) /* Restore x87 FPU, MMX, SSE and SSE2 state */ static inline void fpu_fxrstor(struct vcpu *v) { - const fpusse_t *fpu_ctxt =3D v->arch.fpu_ctxt; + const fpusse_t *fpu_ctxt =3D &v->arch.xsave_area->fpu_sse; =20 /* * Some CPUs don't save/restore FDP/FIP/FOP unless an exception @@ -151,7 +151,7 @@ static inline void fpu_xsave(struct vcpu *v) /* Save x87 FPU, MMX, SSE and SSE2 state */ static inline void fpu_fxsave(struct vcpu *v) { - fpusse_t *fpu_ctxt =3D v->arch.fpu_ctxt; + fpusse_t *fpu_ctxt =3D &v->arch.xsave_area->fpu_sse; unsigned int fip_width =3D v->domain->arch.x87_fip_width; =20 if ( fip_width !=3D 4 ) @@ -212,7 +212,7 @@ void vcpu_restore_fpu_nonlazy(struct vcpu *v, bool need= _stts) * above) we also need to restore full state, to prevent subsequently * saving state belonging to another vCPU. */ - if ( v->arch.fully_eager_fpu || (v->arch.xsave_area && xstate_all(v)) ) + if ( v->arch.fully_eager_fpu || xstate_all(v) ) { if ( cpu_has_xsave ) fpu_xrstor(v, XSTATE_ALL); @@ -299,44 +299,14 @@ void save_fpu_enable(void) /* Initialize FPU's context save area */ int vcpu_init_fpu(struct vcpu *v) { - int rc; - v->arch.fully_eager_fpu =3D opt_eager_fpu; - - if ( (rc =3D xstate_alloc_save_area(v)) !=3D 0 ) - return rc; - - if ( v->arch.xsave_area ) - v->arch.fpu_ctxt =3D &v->arch.xsave_area->fpu_sse; - else - { - BUILD_BUG_ON(__alignof(v->arch.xsave_area->fpu_sse) < 16); - v->arch.fpu_ctxt =3D _xzalloc(sizeof(v->arch.xsave_area->fpu_sse), - __alignof(v->arch.xsave_area->fpu_sse)= ); - if ( v->arch.fpu_ctxt ) - { - fpusse_t *fpu_sse =3D v->arch.fpu_ctxt; - - fpu_sse->fcw =3D FCW_DEFAULT; - fpu_sse->mxcsr =3D MXCSR_DEFAULT; - } - else - rc =3D -ENOMEM; - } - - return rc; + return xstate_alloc_save_area(v); } =20 void vcpu_setup_fpu(struct vcpu *v, struct xsave_struct *xsave_area, const void *data, unsigned int fcw_default) { - /* - * For the entire function please note that vcpu_init_fpu() (above) po= ints - * v->arch.fpu_ctxt into v->arch.xsave_area when XSAVE is available. H= ence - * accesses through both pointers alias one another, and the shorter f= orm - * is used here. - */ - fpusse_t *fpu_sse =3D v->arch.fpu_ctxt; + fpusse_t *fpu_sse =3D &v->arch.xsave_area->fpu_sse; =20 ASSERT(!xsave_area || xsave_area =3D=3D v->arch.xsave_area); =20 @@ -373,10 +343,7 @@ void vcpu_setup_fpu(struct vcpu *v, struct xsave_struc= t *xsave_area, /* Free FPU's context save area */ void vcpu_destroy_fpu(struct vcpu *v) { - if ( v->arch.xsave_area ) - xstate_free_save_area(v); - else - xfree(v->arch.fpu_ctxt); + xstate_free_save_area(v); } =20 /* diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/d= omain.h index 5219c4fb0f69..b79d6badd71c 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -591,12 +591,6 @@ struct pv_vcpu =20 struct arch_vcpu { - /* - * guest context (mirroring struct vcpu_guest_context) common - * between pv and hvm guests - */ - - void *fpu_ctxt; struct cpu_user_regs user_regs; =20 /* Debug registers. */ diff --git a/xen/arch/x86/x86_emulate/blk.c b/xen/arch/x86/x86_emulate/blk.c index e790f4f90056..08a05f8453f7 100644 --- a/xen/arch/x86/x86_emulate/blk.c +++ b/xen/arch/x86/x86_emulate/blk.c @@ -11,7 +11,7 @@ !defined(X86EMUL_NO_SIMD) # ifdef __XEN__ # include -# define FXSAVE_AREA current->arch.fpu_ctxt +# define FXSAVE_AREA ((void *)¤t->arch.xsave_area->fpu_sse) # else # define FXSAVE_AREA get_fpu_save_area() # endif diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 57a0749f0d54..af9e345a7ace 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -508,9 +508,15 @@ int xstate_alloc_save_area(struct vcpu *v) unsigned int size; =20 if ( !cpu_has_xsave ) - return 0; - - if ( !is_idle_vcpu(v) || !cpu_has_xsavec ) + { + /* + * On non-XSAVE systems, we allocate an XSTATE buffer for simplici= ty. + * XSTATE is backwards compatible to FXSAVE, and only one cacheline + * larger. + */ + size =3D XSTATE_AREA_MIN_SIZE; + } + else if ( !is_idle_vcpu(v) || !cpu_has_xsavec ) { size =3D xsave_cntxt_size; BUG_ON(size < XSTATE_AREA_MIN_SIZE); --=20 2.46.0 From nobody Thu Nov 21 19:50:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1728316408; cv=none; d=zohomail.com; s=zohoarc; b=KtIybsKuKm73eCWV4kcHl8rO/Rs7BdW7S1GGUqG8JnJSnDVL8J+JMxJv7iwDD7aKUwx3w5krNktWoV3VQ783Yg3UlZ2CJ7pFEl+ojU6/E09+ar3p2Gu6Ed/iCs2/YOd6K2QPdcjkt/NieadcEvQFbj47eETjqQecnyPnEJBCIkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728316408; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+kQumULdyDnzcg6JI93dHiiynHRn4XaUPGErs4CDNzk=; b=FIfAcN2eXDqwpcao/pytsR1bzvpM3MO625VT00U7TGPzfKuBav4A3h3ql6tMdmUsix90AvdR4bm6ngJD+4lzleoUk2pzD1T6V7QMBDOBX5sFyzYNRyxONGfold3GJSZQZH1M9Ki3u3oZtnFpg/s7g28B5PcKCQFl9toQupZOMzI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1728316408391939.9649392036259; Mon, 7 Oct 2024 08:53:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.812215.1224956 (Exim 4.92) (envelope-from ) id 1sxq2Y-0003vh-K3; Mon, 07 Oct 2024 15:52:54 +0000 Received: by outflank-mailman (output) from mailman id 812215.1224956; Mon, 07 Oct 2024 15:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxq2Y-0003uj-F0; Mon, 07 Oct 2024 15:52:54 +0000 Received: by outflank-mailman (input) for mailman id 812215; Mon, 07 Oct 2024 15:52:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxq2W-0003e1-Vb for xen-devel@lists.xenproject.org; Mon, 07 Oct 2024 15:52:52 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34b65552-84c4-11ef-99a2-01e77a169b0f; Mon, 07 Oct 2024 17:52:50 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5c883459b19so5447844a12.2 for ; Mon, 07 Oct 2024 08:52:50 -0700 (PDT) Received: from mewpvdipd1023.corp.cloud.com ([52.174.59.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99309aa6afsm386160366b.112.2024.10.07.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 08:52:49 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34b65552-84c4-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1728316370; x=1728921170; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+kQumULdyDnzcg6JI93dHiiynHRn4XaUPGErs4CDNzk=; b=Cgx98B5sK8tLUOFDTo+wu1eXRcZ3obK8+V+/Enw+jztS1HUas/HlmqEnreFWSoqnRl bGVt9JbkRdu8mBS3evJBz2sXSRFngXtltRBzZHpTr6tC/ip8gZDveTBOI9D8oxGliI+t IfWDFI2nC/Mj+mkAw+LPf/6dn5KtISR3NkZpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728316370; x=1728921170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+kQumULdyDnzcg6JI93dHiiynHRn4XaUPGErs4CDNzk=; b=hDDFwTx8/C2XtLfSaYYXe9mYELFr1d3HyUt5CI57I0KxmOTnuG1lpYp4BtnbcbxmEE neVj1E9anZJb1WV5+17GKZYgHcX4Ok78Zsb5xUgsmLNcrurxjW52Z8HntLN/xwS1Q/ru rhQWIQydiiQ6YVVPXS+7d/kOMZHTfmH8dzXf1hawan3qHCdrdProfgB7+/jTgIEqckIW H+HKdR4Pz0ToKyZsR7R76Fp2c9fmrxCFgKUU1m4SNm7v83xz6zr8+XsxTZArSWc61CKk nEvQCcsOvsvQWNm5yOK0OQbn3pX5Xv9a49cPQOmXRDd0D7z0SyEZNmseqO7mp2LHDftC Mz1Q== X-Gm-Message-State: AOJu0Yw9MMA9TG3V829L7FsjImiyIo1CXgpz/SB9m3OMngTpZJtGU4B7 XSVZy4vXS4uYeYGfSZpzk6tq4ba8fnLlXc16gzFMAV3QZW2HV5mDs7Cjuk6eAjL88DF2h87XCuu /ls4= X-Google-Smtp-Source: AGHT+IFeS1aGikZa/2CCCW+bTi/6nxN6yDikauWJ9uayDE0wfguFSZ3Uanl+1QrXjk08rcRMni77Qg== X-Received: by 2002:a17:907:3f25:b0:a99:61f7:8413 with SMTP id a640c23a62f3a-a9961f78458mr97631566b.23.1728316369658; Mon, 07 Oct 2024 08:52:49 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 2/2] x86/fpu: Rework fpu_setup_fpu() uses to split it in two Date: Mon, 7 Oct 2024 16:52:40 +0100 Message-ID: <20241007155240.17186-3-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241007155240.17186-1-alejandro.vallejo@cloud.com> References: <20241007155240.17186-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1728316409075116600 Content-Type: text/plain; charset="utf-8" It was trying to do too many things at once and there was no clear way of defining what it was meant to do. This commit splits the function in two. 1. A function to return the FPU to power-on reset values. 2. A x87/SSE state loader (equivalent to the old function when it took a data pointer). The old function also had a concept of "default" values that the FPU would be configured for in some cases but not others. This patch removes that 3rd vague initial state and replaces it with power-on reset. While doing this make sure the abridged control tag is consistent with the manuals and starts as 0xFF Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich -- @Jan: The patch changed substantially. Are you still ok with this R-by? v4: * Reworded commit message and title * Remove vcpu_default_fpu() and replaced its uses with vcpu_reset_fpu() * s/FTW_RESET/FXSAVE_FTW_RESET/ (plus comment) * Remove FCW_DEFAULT, as it's the leftover reset value from the 80287 (which we largely don't care about anymore). --- xen/arch/x86/domain.c | 7 +++-- xen/arch/x86/hvm/hvm.c | 12 +++----- xen/arch/x86/i387.c | 51 +++++++++++-------------------- xen/arch/x86/include/asm/i387.h | 21 ++++++++++--- xen/arch/x86/include/asm/xstate.h | 1 + 5 files changed, 45 insertions(+), 47 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 89aad7e8978f..78a13e6812c9 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1186,9 +1186,10 @@ int arch_set_info_guest( is_pv_64bit_domain(d) ) v->arch.flags &=3D ~TF_kernel_mode; =20 - vcpu_setup_fpu(v, v->arch.xsave_area, - flags & VGCF_I387_VALID ? &c.nat->fpu_ctxt : NULL, - FCW_DEFAULT); + if ( flags & VGCF_I387_VALID ) + vcpu_setup_fpu(v, &c.nat->fpu_ctxt); + else + vcpu_reset_fpu(v); =20 if ( !compat ) { diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 77fe282118f7..44f4964aa036 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1163,10 +1163,10 @@ static int cf_check hvm_load_cpu_ctxt(struct domain= *d, hvm_domain_context_t *h) seg.attr =3D ctxt.ldtr_arbytes; hvm_set_segment_register(v, x86_seg_ldtr, &seg); =20 - /* Cover xsave-absent save file restoration on xsave-capable host. */ - vcpu_setup_fpu(v, xsave_enabled(v) ? NULL : v->arch.xsave_area, - ctxt.flags & XEN_X86_FPU_INITIALISED ? ctxt.fpu_regs : = NULL, - FCW_RESET); + if ( ctxt.flags & XEN_X86_FPU_INITIALISED ) + vcpu_setup_fpu(v, &ctxt.fpu_regs); + else + vcpu_reset_fpu(v); =20 v->arch.user_regs.rax =3D ctxt.rax; v->arch.user_regs.rbx =3D ctxt.rbx; @@ -4006,9 +4006,7 @@ void hvm_vcpu_reset_state(struct vcpu *v, uint16_t cs= , uint16_t ip) v->arch.guest_table =3D pagetable_null(); } =20 - if ( v->arch.xsave_area ) - v->arch.xsave_area->xsave_hdr.xstate_bv =3D 0; - vcpu_setup_fpu(v, v->arch.xsave_area, NULL, FCW_RESET); + vcpu_reset_fpu(v); =20 arch_vcpu_regs_init(v); v->arch.user_regs.rip =3D ip; diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c index fbb9d3584a3d..916d9b572598 100644 --- a/xen/arch/x86/i387.c +++ b/xen/arch/x86/i387.c @@ -303,41 +303,26 @@ int vcpu_init_fpu(struct vcpu *v) return xstate_alloc_save_area(v); } =20 -void vcpu_setup_fpu(struct vcpu *v, struct xsave_struct *xsave_area, - const void *data, unsigned int fcw_default) +void vcpu_reset_fpu(struct vcpu *v) { - fpusse_t *fpu_sse =3D &v->arch.xsave_area->fpu_sse; - - ASSERT(!xsave_area || xsave_area =3D=3D v->arch.xsave_area); - - v->fpu_initialised =3D !!data; - - if ( data ) - { - memcpy(fpu_sse, data, sizeof(*fpu_sse)); - if ( xsave_area ) - xsave_area->xsave_hdr.xstate_bv =3D XSTATE_FP_SSE; - } - else if ( xsave_area && fcw_default =3D=3D FCW_DEFAULT ) - { - xsave_area->xsave_hdr.xstate_bv =3D 0; - fpu_sse->mxcsr =3D MXCSR_DEFAULT; - } - else - { - memset(fpu_sse, 0, sizeof(*fpu_sse)); - fpu_sse->fcw =3D fcw_default; - fpu_sse->mxcsr =3D MXCSR_DEFAULT; - if ( v->arch.xsave_area ) - { - v->arch.xsave_area->xsave_hdr.xstate_bv &=3D ~XSTATE_FP_SSE; - if ( fcw_default !=3D FCW_DEFAULT ) - v->arch.xsave_area->xsave_hdr.xstate_bv |=3D X86_XCR0_X87; - } - } + v->fpu_initialised =3D false; + *v->arch.xsave_area =3D (struct xsave_struct) { + .fpu_sse =3D { + .mxcsr =3D MXCSR_DEFAULT, + .fcw =3D FCW_RESET, + .ftw =3D FXSAVE_FTW_RESET, + }, + .xsave_hdr.xstate_bv =3D X86_XCR0_X87, + }; +} =20 - if ( xsave_area ) - xsave_area->xsave_hdr.xcomp_bv =3D 0; +void vcpu_setup_fpu(struct vcpu *v, const void *data) +{ + v->fpu_initialised =3D true; + *v->arch.xsave_area =3D (struct xsave_struct) { + .fpu_sse =3D *(const fpusse_t*)data, + .xsave_hdr.xstate_bv =3D XSTATE_FP_SSE, + }; } =20 /* Free FPU's context save area */ diff --git a/xen/arch/x86/include/asm/i387.h b/xen/arch/x86/include/asm/i38= 7.h index a783549db991..652d7ad2deb6 100644 --- a/xen/arch/x86/include/asm/i387.h +++ b/xen/arch/x86/include/asm/i387.h @@ -31,10 +31,23 @@ void vcpu_restore_fpu_nonlazy(struct vcpu *v, bool need= _stts); void vcpu_restore_fpu_lazy(struct vcpu *v); void vcpu_save_fpu(struct vcpu *v); void save_fpu_enable(void); - int vcpu_init_fpu(struct vcpu *v); -struct xsave_struct; -void vcpu_setup_fpu(struct vcpu *v, struct xsave_struct *xsave_area, - const void *data, unsigned int fcw_default); void vcpu_destroy_fpu(struct vcpu *v); + +/* + * Restore v's FPU to power-on reset values + * + * @param v vCPU containing the FPU + */ +void vcpu_reset_fpu(struct vcpu *v); + +/* + * Load x87/SSE state into v's FPU + * + * Overrides the XSAVE header to set the state components to be x87 and SS= E. + * + * @param v vCPU containing the FPU + * @param data 512-octet blob for x87/SSE state + */ +void vcpu_setup_fpu(struct vcpu *v, const void *data); #endif /* __ASM_I386_I387_H */ diff --git a/xen/arch/x86/include/asm/xstate.h b/xen/arch/x86/include/asm/x= state.h index b4ee5559534a..07017cc4edfd 100644 --- a/xen/arch/x86/include/asm/xstate.h +++ b/xen/arch/x86/include/asm/xstate.h @@ -14,6 +14,7 @@ =20 #define FCW_DEFAULT 0x037f #define FCW_RESET 0x0040 +#define FXSAVE_FTW_RESET 0xFF /* Abridged Tag Word format */ #define MXCSR_DEFAULT 0x1f80 =20 extern uint32_t mxcsr_mask; --=20 2.46.0