From nobody Mon Feb 9 09:18:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1728309844; cv=none; d=zohomail.com; s=zohoarc; b=j4RvHh0PIIhpwHtEacbgmk4BKWbXe6pFU0C+OI0RILhrbkic4qtd7GC9XF0fV0KfCRXi0bl5MWCsxpnFhIq1B12U7iQRIoOf58Ss6AU+nxTBbvTLR0aY1YqRFetmNo7pKU9oBgjADv5oaunw6OmHf1QUwdkXu9WzqTMHT4dEoAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728309844; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CIibmESNiAHxwibKuOWS9nvVl03nkcPOYAxCILNTlPk=; b=Vlm3+5t+41db7rDD+wBJz5X+JQ4LZGMUt4cXg1N3uRQ07XwrimOtBuBjI/rOhyJ5rh6zdMFFudJu3IGKx7qlKP0CbGovadNhSMMEhEf83n8/1hvOu+/Y9PKoB69XjsKHCW3fPNtE+3lUJCDTwiBFkkxuN3eXOAeYgj9bRTHUX+4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1728309844753913.5132762144514; Mon, 7 Oct 2024 07:04:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.812020.1224670 (Exim 4.92) (envelope-from ) id 1sxoKm-0004TQ-L7; Mon, 07 Oct 2024 14:03:36 +0000 Received: by outflank-mailman (output) from mailman id 812020.1224670; Mon, 07 Oct 2024 14:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxoKm-0004TJ-IV; Mon, 07 Oct 2024 14:03:36 +0000 Received: by outflank-mailman (input) for mailman id 812020; Mon, 07 Oct 2024 14:03:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sxoKk-0004TD-Pr for xen-devel@lists.xenproject.org; Mon, 07 Oct 2024 14:03:34 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eff805ef-84b4-11ef-99a2-01e77a169b0f; Mon, 07 Oct 2024 16:03:32 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a9963e47b69so27454466b.1 for ; Mon, 07 Oct 2024 07:03:32 -0700 (PDT) Received: from localhost ([213.195.117.215]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a992e7840b6sm381824866b.101.2024.10.07.07.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 07:03:31 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eff805ef-84b4-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1728309812; x=1728914612; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CIibmESNiAHxwibKuOWS9nvVl03nkcPOYAxCILNTlPk=; b=EWgnLWjF/nFRc0vzUhhgQi3n3XkP+emVrSd++wLE4YdG8zBdMhzT5KHl9/2Gs0jRUf qq3aUEPB/4/mzZJawL0eo3GuEKXm6yBqZpauL4L5wbXnR5+1I0sYbzxHLQ0mICDPLBJW fF5vzl7lakuxDcPBKQ+KTGWgTkUjTtsRHq3bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728309812; x=1728914612; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CIibmESNiAHxwibKuOWS9nvVl03nkcPOYAxCILNTlPk=; b=WLNx8arVxcFiuf1Ny+FqGwC8RZwLODaumS0A3ivpvoDc3/bpJGuR0SbXzK59CzwELC Ab4/Ldf0yvcUPNpvr15OaGwNev6PZYC6Fn4HyduN27AirpcxoFyfubfxZeFhz4zaJniY 9VPQ27oRhsGIBmlUPtLs9RRl0sYUtRBhGU/c43CLT5o9clu57hTDwB1CHMYawuZgDYN3 GKs8itClbt18E56ZAzdVV9fbWW+NZKwv+x3RhYhhJ7FaG252faFAkbXSSyVoxrfHFg4K I/qgrwJJa5Ql0YNfo2yQL7gJ3AP6GnN+jD5MbsItSlN7L4sQXMOQT1vOJgOLvC4dRf6Y TpSg== X-Gm-Message-State: AOJu0Yw7/jO9uYWQxo4TEoQXrYqgqEY831Ho2E8cPfEKijl1E8R8cvVb 9xyUp78WPh5cfYxuJXc3TvBgJ81VUeR5A/GzygeXualZLt1pd4oIxTXWlUc1/MGhaKOG7zwUF0I A X-Google-Smtp-Source: AGHT+IFpnlGhKvrQdlxuo5jEFRzMdphsLWx6zGErXfZyCU73LLnfRAH2gFOxi0phbxKOxupSrdWmxg== X-Received: by 2002:a17:907:7248:b0:a99:5110:7a4d with SMTP id a640c23a62f3a-a99511081f3mr465254466b.61.1728309811812; Mon, 07 Oct 2024 07:03:31 -0700 (PDT) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper Subject: [PATCH] x86/msr: add log messages to MSR state load error paths Date: Mon, 7 Oct 2024 16:03:17 +0200 Message-ID: <20241007140317.67478-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1728309847376116600 Some error paths in the MSR state loading logic don't contain error message= s, which makes debugging them quite hard without adding extra patches to print= the information. Add two new log messages to the MSR state load path that print information about the entry that failed to load. No functional change intended. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/hvm/hvm.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 69a25571db8d..c71087f636c4 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1598,10 +1598,19 @@ static int cf_check hvm_load_cpu_msrs(struct domain= *d, hvm_domain_context_t *h) rc =3D guest_wrmsr(v, ctxt->msr[i].index, ctxt->msr[i].val); =20 if ( rc !=3D X86EMUL_OKAY ) + { + printk(XENLOG_G_ERR + "HVM%d.%d load MSR %#x with value %#lx failed: %d\n= ", + d->domain_id, vcpuid, ctxt->msr[i].index, + ctxt->msr[i].val, rc); return -ENXIO; + } break; =20 default: + printk(XENLOG_G_ERR + "HVM%d.%d attempted load of unhandled MSR %#x\n", + d->domain_id, vcpuid, ctxt->msr[i].index); return -ENXIO; } } --=20 2.46.0