From nobody Tue Feb 10 03:38:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1712677024; cv=none; d=zohomail.com; s=zohoarc; b=ePq7uUMZV9cuBO/U3orGKsNibbN47jFoGqYPe0xv8wQuGEgD8ZL9UVtm9NgQmtGsa1XFmEpM1b+PEAYtt7rhlHVMfTH5weOCMfxY/f7wk9nkajo73awp3MYtRYEkKUgdLQ6ZpBc4LLvvgD2zSFjDfyQwSe230l9WbwzfLMq4IJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712677024; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pkiNITyS2Gv4ORmeiWESmXZBMWeFqhOQWcTG7lLPN6s=; b=C0goJvAUAD8lhMZoO4rVfpk5DJ2GL4Vz7jsJ2OyS+eUjjAjEIeJyjv8sU7gFU0GsWXqYUtKZwDQbjkW1L23ClWZrpkwlcgiXsUtxCQmrr550vv5ijm/pDBWBQcY2BIEa+6b/goloIc9fNJvzyR0LDspUXr/37CzjxjwK6fFHqRg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1712677024752138.80572425496405; Tue, 9 Apr 2024 08:37:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.702505.1097618 (Exim 4.92) (envelope-from ) id 1ruDWe-0006YC-SM; Tue, 09 Apr 2024 15:36:44 +0000 Received: by outflank-mailman (output) from mailman id 702505.1097618; Tue, 09 Apr 2024 15:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ruDWe-0006Y0-OE; Tue, 09 Apr 2024 15:36:44 +0000 Received: by outflank-mailman (input) for mailman id 702505; Tue, 09 Apr 2024 15:36:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ruDWd-0005IN-AN for xen-devel@lists.xenproject.org; Tue, 09 Apr 2024 15:36:43 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f633d0cd-f686-11ee-94a3-07e782e9044d; Tue, 09 Apr 2024 17:36:41 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-516d47ce662so7418911e87.1 for ; Tue, 09 Apr 2024 08:36:41 -0700 (PDT) Received: from rayden.urgonet (h-217-31-164-171.A175.priv.bahnhof.se. [217.31.164.171]) by smtp.gmail.com with ESMTPSA id gs44-20020a1709072d2c00b00a46a3ad035esm5849000ejc.179.2024.04.09.08.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 08:36:39 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f633d0cd-f686-11ee-94a3-07e782e9044d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712677000; x=1713281800; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pkiNITyS2Gv4ORmeiWESmXZBMWeFqhOQWcTG7lLPN6s=; b=EPAM68IqZCexAA0Tgfi6dlwTN3cMb5kOWQCZmRBmF1GLPVnUB2AtcwHcpVxNUVJZPZ 5yR7z73HIrce3Y6puagjun/KXSLCQnrUd6vwDfWEsTPK1J+quByNt+wo6EHx1cWALow3 SzR2O9w5oWzvVRvH0M6HNE727vuOYb/snOZHhySb7ZQ88QFZckt3Fxa6dDDgjYjMfF1i m6jXdoezTaH/stU4xUyxfXJBrUlGJYPPN14Uksc0RovEhRVzGlSkQ63qU78PobIpplMK aDBUcmVBA6+QcJSewSSiK8UD0a6PmNABIt2pvngXWW5ixERy0e38C0jEhyzbn3U+b1f2 zfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712677000; x=1713281800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pkiNITyS2Gv4ORmeiWESmXZBMWeFqhOQWcTG7lLPN6s=; b=Aa8xqo08AyLA3TnfAtexvIRJm0az80R0DbbZhqAxpFHyX5497vjN31AfTCDiq93baK lFWUQAewphY6mvF2/iAnXFQHGcpWQfKPwAVVZInyXAqZtvcSCPxPKI+e9X2M+Dntk5e0 GRRskccYDbmc/DJpTZFGuUrnfOty42eTq+Glnu6W56PgA1KAM+ysgem3gGbfxy5eo2tW fcLHK3OLWSUp/3DLfwzIL4WB9ukSFzPfy3fR7zIB45G1z210OcA/cl/ZjDRU+/ZG1pRQ OyliJ5dJDT6g/akeHtRK5K20gv2IDIK5lV4cZptbALKq/2lSef1ZaYWnzmjwu+pzgV+K Z1CA== X-Gm-Message-State: AOJu0YyP2ysP1pwXVOV7oyZ2oY4yBXXj6N0z4xjdGszV22/JE04Z9CiF V1YNZQFyK4c84kIE8dHVp093ShmuwtCB0vhV9ggO7mwAwc6ZPt1dZFzN15Iw+F3THajBfWhoClI Z X-Google-Smtp-Source: AGHT+IEAky4+JDj2TctdrcJCyOVFPoPiRfvC26YHi7IvJM1efJOuaoiQa50MH8ZQ4INEeypAIdf0KA== X-Received: by 2002:a05:6512:475:b0:515:bfaa:fa12 with SMTP id x21-20020a056512047500b00515bfaafa12mr11383475lfd.22.1712677000297; Tue, 09 Apr 2024 08:36:40 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: patches@linaro.org, Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel Subject: [XEN PATCH v1 5/5] xen/arm: ffa: support notification Date: Tue, 9 Apr 2024 17:36:30 +0200 Message-Id: <20240409153630.2026584-6-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240409153630.2026584-1-jens.wiklander@linaro.org> References: <20240409153630.2026584-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1712677025421100009 Content-Type: text/plain; charset="utf-8" Add support for FF-A notifications, currently limited to an SP (Secure Partition) sending an asynchronous notification to a guest. Guests and Xen itself are made aware of pending notifications with an interrupt. The interrupt handler retrieves the notifications using the FF-A ABI and deliver them to their destinations. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/Makefile | 1 + xen/arch/arm/tee/ffa.c | 58 ++++++ xen/arch/arm/tee/ffa_notif.c | 319 +++++++++++++++++++++++++++++++++ xen/arch/arm/tee/ffa_private.h | 71 ++++++++ 4 files changed, 449 insertions(+) create mode 100644 xen/arch/arm/tee/ffa_notif.c diff --git a/xen/arch/arm/tee/Makefile b/xen/arch/arm/tee/Makefile index f0112a2f922d..7c0f46f7f446 100644 --- a/xen/arch/arm/tee/Makefile +++ b/xen/arch/arm/tee/Makefile @@ -2,5 +2,6 @@ obj-$(CONFIG_FFA) +=3D ffa.o obj-$(CONFIG_FFA) +=3D ffa_shm.o obj-$(CONFIG_FFA) +=3D ffa_partinfo.o obj-$(CONFIG_FFA) +=3D ffa_rxtx.o +obj-$(CONFIG_FFA) +=3D ffa_notif.o obj-y +=3D tee.o obj-$(CONFIG_OPTEE) +=3D optee.o diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 5209612963e1..ce9757bfeed1 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -39,6 +39,9 @@ * - at most 32 shared memory regions per guest * o FFA_MSG_SEND_DIRECT_REQ: * - only supported from a VM to an SP + * o FFA_NOTIFICATION_*: + * - only supports global notifications, that is, per vCPU notifications + * are not supported * * There are some large locked sections with ffa_tx_buffer_lock and * ffa_rx_buffer_lock. Especially the ffa_tx_buffer_lock spinlock used @@ -194,6 +197,8 @@ out: =20 static void handle_features(struct cpu_user_regs *regs) { + struct domain *d =3D current->domain; + struct ffa_ctx *ctx =3D d->arch.tee; uint32_t a1 =3D get_user_reg(regs, 1); unsigned int n; =20 @@ -240,6 +245,30 @@ static void handle_features(struct cpu_user_regs *regs) BUILD_BUG_ON(PAGE_SIZE !=3D FFA_PAGE_SIZE); ffa_set_regs_success(regs, 0, 0); break; + case FFA_FEATURE_NOTIF_PEND_INTR: + if ( ctx->notif.enabled ) + ffa_set_regs_success(regs, FFA_NOTIF_PEND_INTR_ID, 0); + else + ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); + break; + case FFA_FEATURE_SCHEDULE_RECV_INTR: + if ( ctx->notif.enabled ) + ffa_set_regs_success(regs, FFA_NOTIF_PEND_INTR_ID, 0); + else + ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); + break; + + case FFA_NOTIFICATION_BIND: + case FFA_NOTIFICATION_UNBIND: + case FFA_NOTIFICATION_GET: + case FFA_NOTIFICATION_SET: + case FFA_NOTIFICATION_INFO_GET_32: + case FFA_NOTIFICATION_INFO_GET_64: + if ( ctx->notif.enabled ) + ffa_set_regs_success(regs, 0, 0); + else + ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); + break; default: ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); break; @@ -305,6 +334,30 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) get_user_reg(regs, 1)= ), get_user_reg(regs, 3)); break; + case FFA_NOTIFICATION_BIND: + e =3D ffa_handle_notification_bind(get_user_reg(regs, 1), + get_user_reg(regs, 2), + get_user_reg(regs, 3), + get_user_reg(regs, 4)); + break; + case FFA_NOTIFICATION_UNBIND: + e =3D ffa_handle_notification_unbind(get_user_reg(regs, 1), + get_user_reg(regs, 3), + get_user_reg(regs, 4)); + break; + case FFA_NOTIFICATION_INFO_GET_32: + case FFA_NOTIFICATION_INFO_GET_64: + ffa_handle_notification_info_get(regs); + return true; + case FFA_NOTIFICATION_GET: + ffa_handle_notification_get(regs); + return true; + case FFA_NOTIFICATION_SET: + e =3D ffa_handle_notification_set(get_user_reg(regs, 1), + get_user_reg(regs, 2), + get_user_reg(regs, 3), + get_user_reg(regs, 4)); + break; =20 default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -348,6 +401,9 @@ static int ffa_domain_init(struct domain *d) if ( !ffa_partinfo_domain_init(d) ) return -EIO; =20 + if ( !ffa_notif_domain_init(d) ) + return -ENOMEM; + return 0; } =20 @@ -423,6 +479,7 @@ static int ffa_domain_teardown(struct domain *d) return 0; =20 ffa_rxtx_domain_destroy(d); + ffa_notif_domain_destroy(d); =20 ffa_domain_teardown_continue(ctx, true /* first_time */); =20 @@ -502,6 +559,7 @@ static bool ffa_probe(void) if ( !ffa_partinfo_init() ) goto err_rxtx_destroy; =20 + ffa_notif_init(); INIT_LIST_HEAD(&ffa_teardown_head); init_timer(&ffa_teardown_timer, ffa_teardown_timer_callback, NULL, 0); =20 diff --git a/xen/arch/arm/tee/ffa_notif.c b/xen/arch/arm/tee/ffa_notif.c new file mode 100644 index 000000000000..0173ee515362 --- /dev/null +++ b/xen/arch/arm/tee/ffa_notif.c @@ -0,0 +1,319 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2024 Linaro Limited + */ + +#include +#include +#include +#include + +#include +#include + +#include "ffa_private.h" + +static bool __ro_after_init notif_enabled; + +int ffa_handle_notification_bind(uint32_t src_dst, uint32_t flags, + uint32_t bitmap_lo, uint32_t bitmap_hi) +{ + struct domain *d =3D current->domain; + + if ( !notif_enabled ) + return FFA_RET_NOT_SUPPORTED; + + if ( (src_dst & 0xffff) !=3D ffa_get_vm_id(d) ) + return FFA_RET_INVALID_PARAMETERS; + + if ( flags ) /* Only global notifications are supported */ + return FFA_RET_DENIED; + + /* + * We only support notifications from SP so no need to check the sender + * endpoint ID, the SPMC will take care of that for us. + */ + return ffa_simple_call(FFA_NOTIFICATION_BIND, src_dst, flags, bitmap_h= i, + bitmap_lo); +} + +int ffa_handle_notification_unbind(uint32_t src_dst, uint32_t bitmap_lo, + uint32_t bitmap_hi) +{ + struct domain *d =3D current->domain; + + if ( !notif_enabled ) + return FFA_RET_NOT_SUPPORTED; + + if ( (src_dst & 0xffff) !=3D ffa_get_vm_id(d) ) + return FFA_RET_INVALID_PARAMETERS; + + /* + * We only support notifications from SP so no need to check the + * destination endpoint ID, the SPMC will take care of that for us. + */ + return ffa_simple_call(FFA_NOTIFICATION_UNBIND, src_dst, 0, bitmap_hi, + bitmap_lo); +} + +void ffa_handle_notification_info_get(struct cpu_user_regs *regs) +{ + struct domain *d =3D current->domain; + struct ffa_ctx *ctx =3D d->arch.tee; + bool pending_global; + + if ( !notif_enabled ) + { + ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); + return; + } + + spin_lock(&ctx->notif.lock); + pending_global =3D ctx->notif.secure_pending; + ctx->notif.secure_pending =3D false; + spin_unlock(&ctx->notif.lock); + + if ( pending_global ) + { + /* A pending global notification for the guest */ + ffa_set_regs(regs, FFA_SUCCESS_64, 0, + 1U << FFA_NOTIF_INFO_GET_ID_COUNT_SHIFT, ffa_get_vm_i= d(d), + 0, 0, 0, 0); + } + else + { + /* Report an error if there where no pending global notification */ + ffa_set_regs_error(regs, FFA_RET_NO_DATA); + } +} + +void ffa_handle_notification_get(struct cpu_user_regs *regs) +{ + struct domain *d =3D current->domain; + uint32_t recv =3D get_user_reg(regs, 1); + uint32_t flags =3D get_user_reg(regs, 2); + uint32_t w2 =3D 0; + uint32_t w3 =3D 0; + uint32_t w4 =3D 0; + uint32_t w5 =3D 0; + uint32_t w6 =3D 0; + uint32_t w7 =3D 0; + + if ( !notif_enabled ) + { + ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED); + return; + } + + if ( (recv & 0xffff) !=3D ffa_get_vm_id(d) ) + { + ffa_set_regs_error(regs, FFA_RET_INVALID_PARAMETERS); + return; + } + + if ( flags & ( FFA_NOTIF_FLAG_BITMAP_SP | FFA_NOTIF_FLAG_BITMAP_SPM ) ) + { + struct arm_smccc_1_2_regs arg =3D { + .a0 =3D FFA_NOTIFICATION_GET, + .a1 =3D recv, + .a2 =3D flags & ( FFA_NOTIF_FLAG_BITMAP_SP | + FFA_NOTIF_FLAG_BITMAP_SPM ), + }; + struct arm_smccc_1_2_regs resp; + int32_t e; + + arm_smccc_1_2_smc(&arg, &resp); + e =3D ffa_get_ret_code(&resp); + if ( e ) + { + ffa_set_regs_error(regs, e); + return; + } + + if ( flags & FFA_NOTIF_FLAG_BITMAP_SP ) + { + w2 =3D resp.a2; + w3 =3D resp.a3; + } + + if ( flags & FFA_NOTIF_FLAG_BITMAP_SPM ) + w6 =3D resp.a6; + } + + ffa_set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, w4, w5, w6, w7); +} + +int ffa_handle_notification_set(uint32_t src_dst, uint32_t flags, + uint32_t bitmap_lo, uint32_t bitmap_hi) +{ + struct domain *d =3D current->domain; + + if ( !notif_enabled ) + return FFA_RET_NOT_SUPPORTED; + + if ( (src_dst >> 16) !=3D ffa_get_vm_id(d) ) + return FFA_RET_INVALID_PARAMETERS; + + /* + * We only support notifications from SP so no need to check the sender + * endpoint ID, the SPMC will take care of that for us. + */ + return ffa_simple_call(FFA_NOTIFICATION_SET, src_dst, flags, bitmap_lo, + bitmap_hi); +} + +static uint16_t get_id_from_resp(struct arm_smccc_1_2_regs *resp, + unsigned int n) +{ + unsigned int ids_per_reg; + unsigned int reg_idx; + unsigned int reg_shift; + + if ( smccc_is_conv_64(resp->a0) ) + ids_per_reg =3D 4; + else + ids_per_reg =3D 2; + + reg_idx =3D n / ids_per_reg + 3; + reg_shift =3D ( n % ids_per_reg ) * 16; + + switch ( reg_idx ) + { + case 3: + return resp->a3 >> reg_shift; + case 4: + return resp->a4 >> reg_shift; + case 5: + return resp->a5 >> reg_shift; + case 6: + return resp->a6 >> reg_shift; + case 7: + return resp->a7 >> reg_shift; + default: + ASSERT(0); /* "Can't happen" */ + return 0; + } +} + +static void notif_irq_handler(int irq, void *data) +{ + const struct arm_smccc_1_2_regs arg =3D { + .a0 =3D FFA_NOTIFICATION_INFO_GET_64, + }; + struct arm_smccc_1_2_regs resp; + unsigned int id_pos; + unsigned int list_count; + uint64_t ids_count; + unsigned int n; + int32_t res; + + do { + arm_smccc_1_2_smc(&arg, &resp); + res =3D ffa_get_ret_code(&resp); + if ( res ) + { + if ( res !=3D FFA_RET_NO_DATA ) + printk(XENLOG_ERR "ffa: notification info get failed: erro= r %d\n", + res); + return; + } + + ids_count =3D resp.a2 >> FFA_NOTIF_INFO_GET_ID_LIST_SHIFT; + list_count =3D ( resp.a2 >> FFA_NOTIF_INFO_GET_ID_COUNT_SHIFT ) & + FFA_NOTIF_INFO_GET_ID_COUNT_MASK; + + id_pos =3D 0; + for ( n =3D 0; n < list_count; n++ ) + { + unsigned int count =3D ((ids_count >> 2 * n) & 0x3) + 1; + struct domain *d; + + d =3D ffa_get_domain_by_vm_id(get_id_from_resp(&resp, id_pos)); + + if ( d ) + { + struct ffa_ctx *ctx =3D d->arch.tee; + + spin_lock(&ctx->notif.lock); + ctx->notif.secure_pending =3D true; + spin_unlock(&ctx->notif.lock); + + /* + * Since we're only delivering global notification, always + * deliver to the first vCPU. It doesn't matter which we + * chose, as long as it's available. + */ + vgic_inject_irq(d, d->vcpu[0], FFA_NOTIF_PEND_INTR_ID, tru= e); + + put_domain(d); + } + + id_pos +=3D count; + } + + } while (resp.a2 & FFA_NOTIF_INFO_GET_MORE_FLAG); +} + +static int32_t ffa_notification_bitmap_create(uint16_t vm_id, + uint32_t vcpu_count) +{ + return ffa_simple_call(FFA_NOTIFICATION_BITMAP_CREATE, vm_id, vcpu_cou= nt, + 0, 0); +} + +static int32_t ffa_notification_bitmap_destroy(uint16_t vm_id) +{ + return ffa_simple_call(FFA_NOTIFICATION_BITMAP_DESTROY, vm_id, 0, 0, 0= ); +} + +void ffa_notif_init(void) +{ + const struct arm_smccc_1_2_regs arg =3D { + .a0 =3D FFA_FEATURES, + .a1 =3D FFA_FEATURE_SCHEDULE_RECV_INTR, + }; + struct arm_smccc_1_2_regs resp; + unsigned int irq; + int ret; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 !=3D FFA_SUCCESS_32 ) + return; + + irq =3D resp.a2; + if ( irq >=3D NR_GIC_SGI ) + irq_set_type(irq, IRQ_TYPE_EDGE_RISING); + ret =3D request_irq(irq, 0, notif_irq_handler, "FF-A notif", NULL); + if ( ret ) + printk(XENLOG_ERR "ffa: request_irq irq %u failed: error %d\n", + irq, ret); + notif_enabled =3D !ret; +} + +bool ffa_notif_domain_init(struct domain *d) +{ + struct ffa_ctx *ctx =3D d->arch.tee; + int32_t res; + + if ( !notif_enabled ) + return true; + + res =3D ffa_notification_bitmap_create(ffa_get_vm_id(d), d->max_vcpus); + if ( res ) + return false; + + ctx->notif.enabled =3D true; + + return true; +} + +void ffa_notif_domain_destroy(struct domain *d) +{ + struct ffa_ctx *ctx =3D d->arch.tee; + + if ( ctx->notif.enabled ) + { + ffa_notification_bitmap_destroy(ffa_get_vm_id(d)); + ctx->notif.enabled =3D false; + } +} diff --git a/xen/arch/arm/tee/ffa_private.h b/xen/arch/arm/tee/ffa_private.h index 98236cbf14a3..26c2af164d38 100644 --- a/xen/arch/arm/tee/ffa_private.h +++ b/xen/arch/arm/tee/ffa_private.h @@ -25,6 +25,7 @@ #define FFA_RET_DENIED -6 #define FFA_RET_RETRY -7 #define FFA_RET_ABORTED -8 +#define FFA_RET_NO_DATA -9 =20 /* FFA_VERSION helpers */ #define FFA_VERSION_MAJOR_SHIFT 16U @@ -60,6 +61,8 @@ */ #define FFA_PAGE_SIZE SZ_4K =20 +#define FFA_NOTIF_BITMAP_SIZE 64 + /* * The number of pages used for each of the RX and TX buffers shared with * the SPMC. @@ -97,6 +100,18 @@ */ #define FFA_MAX_SHM_COUNT 32 =20 +/* + * TODO How to manage the available SGIs? SGI 8-15 seem to be entirely + * unused, but that may change. + * + * SGI is the preferred delivery mechanism. SGIs 8-15 are normally not used + * by a guest as they in a non-virtualized system typically are assigned to + * the secure world. Here we're free to use SGI 8-15 since they are virtual + * and have nothing to do with the secure world. + */ +#define FFA_NOTIF_PEND_INTR_ID 8 +#define FFA_SCHEDULE_RECV_INTR_ID 9 + /* * The time we wait until trying to tear down a domain again if it was * blocked initially. @@ -175,6 +190,21 @@ */ #define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) =20 +/* Flags used in calls to FFA_NOTIFICATION_GET interface */ +#define FFA_NOTIF_FLAG_BITMAP_SP BIT(0, U) +#define FFA_NOTIF_FLAG_BITMAP_VM BIT(1, U) +#define FFA_NOTIF_FLAG_BITMAP_SPM BIT(2, U) +#define FFA_NOTIF_FLAG_BITMAP_HYP BIT(3, U) + +#define FFA_NOTIF_INFO_GET_MORE_FLAG BIT(0, U) +#define FFA_NOTIF_INFO_GET_ID_LIST_SHIFT 12 +#define FFA_NOTIF_INFO_GET_ID_COUNT_SHIFT 7 +#define FFA_NOTIF_INFO_GET_ID_COUNT_MASK 0x1F + +/* Feature IDs used with FFA_FEATURES */ +#define FFA_FEATURE_NOTIF_PEND_INTR 0x1U +#define FFA_FEATURE_SCHEDULE_RECV_INTR 0x2U + /* Function IDs */ #define FFA_ERROR 0x84000060U #define FFA_SUCCESS_32 0x84000061U @@ -213,6 +243,27 @@ #define FFA_MEM_FRAG_TX 0x8400007BU #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +#define FFA_NOTIFICATION_BITMAP_CREATE 0x8400007DU +#define FFA_NOTIFICATION_BITMAP_DESTROY 0x8400007EU +#define FFA_NOTIFICATION_BIND 0x8400007FU +#define FFA_NOTIFICATION_UNBIND 0x84000080U +#define FFA_NOTIFICATION_SET 0x84000081U +#define FFA_NOTIFICATION_GET 0x84000082U +#define FFA_NOTIFICATION_INFO_GET_32 0x84000083U +#define FFA_NOTIFICATION_INFO_GET_64 0xC4000083U + +struct ffa_ctx_notif { + bool enabled; + + /* Used to serialize access to the rest of this struct */ + spinlock_t lock; + + /* + * True if domain is reported by FFA_NOTIFICATION_INFO_GET to have + * pending global notifications. + */ + bool secure_pending; +}; =20 struct ffa_ctx { void *rx; @@ -228,6 +279,7 @@ struct ffa_ctx { struct list_head shm_list; /* Number of allocated shared memory object */ unsigned int shm_count; + struct ffa_ctx_notif notif; /* * tx_lock is used to serialize access to tx * rx_lock is used to serialize access to rx @@ -271,12 +323,31 @@ uint32_t ffa_handle_rxtx_map(uint32_t fid, register_t= tx_addr, uint32_t ffa_handle_rxtx_unmap(void); int32_t ffa_handle_rx_release(void); =20 +void ffa_notif_init(void); +bool ffa_notif_domain_init(struct domain *d); +void ffa_notif_domain_destroy(struct domain *d); + +int ffa_handle_notification_bind(uint32_t src_dst, uint32_t flags, + uint32_t bitmap_lo, uint32_t bitmap_hi); +int ffa_handle_notification_unbind(uint32_t src_dst, uint32_t bitmap_lo, + uint32_t bitmap_hi); +void ffa_handle_notification_info_get(struct cpu_user_regs *regs); +void ffa_handle_notification_get(struct cpu_user_regs *regs); +int ffa_handle_notification_set(uint32_t src_dst, uint32_t flags, + uint32_t bitmap_lo, uint32_t bitmap_hi); + static inline uint16_t ffa_get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ return d->domain_id + 1; } =20 +static inline struct domain *ffa_get_domain_by_vm_id(uint16_t vm_id) +{ + /* -1 to match ffa_get_vm_id() */ + return get_domain_by_id(vm_id - 1); +} + static inline void ffa_set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, register_t v2, register_t v= 3, register_t v4, register_t v5, register_t v= 6, --=20 2.34.1