From nobody Tue May 21 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1712217133; cv=pass; d=zohomail.com; s=zohoarc; b=d/qQ92OddFD8FhvyQ5P9OFj2TDj56RP9fKjKQ2uT1R5gzBKBzTpBDqkx7UzEMmsFM1LkDohMei20PsXkSQyQitoRYKG6njngQClDzP3D6yjJko92n4bOACVxFfvqcWH3f/B7GKEVFJx6z4TivIzdy6+YS4/wX6fqtoj2kA1puvc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712217133; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5YgJMInRV9+naJSvwvbifqXD4WV1M7F+04rZI69ZOn8=; b=dqzXbocO0EfSFK73yFcBtOBqKnlpzPCrADDt9n04/h4SVX5oP+Vkesu0sOo6xmc7So63ZsvWac6yseRCrchE+hZ19L65loyEKVa7e0zwtC8OoERE2sx5/dY/rCPa46e/deqJ0421JJdKrbZLkVhOH9NLJX2D8DO7wJliI5+DVAU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1712217133161797.6585028481015; Thu, 4 Apr 2024 00:52:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.700712.1094282 (Exim 4.92) (envelope-from ) id 1rsHt7-0006kc-Fi; Thu, 04 Apr 2024 07:51:57 +0000 Received: by outflank-mailman (output) from mailman id 700712.1094282; Thu, 04 Apr 2024 07:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsHt7-0006kV-As; Thu, 04 Apr 2024 07:51:57 +0000 Received: by outflank-mailman (input) for mailman id 700712; Thu, 04 Apr 2024 07:51:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsHt5-0006V3-H7 for xen-devel@lists.xenproject.org; Thu, 04 Apr 2024 07:51:55 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20601.outbound.protection.outlook.com [2a01:111:f403:240a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33951777-f258-11ee-afe5-a90da7624cb6; Thu, 04 Apr 2024 09:51:54 +0200 (CEST) Received: from BYAPR02CA0013.namprd02.prod.outlook.com (2603:10b6:a02:ee::26) by CY8PR12MB7290.namprd12.prod.outlook.com (2603:10b6:930:55::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 07:51:50 +0000 Received: from SJ1PEPF00001CDE.namprd05.prod.outlook.com (2603:10b6:a02:ee:cafe::c7) by BYAPR02CA0013.outlook.office365.com (2603:10b6:a02:ee::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Thu, 4 Apr 2024 07:51:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CDE.mail.protection.outlook.com (10.167.242.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Thu, 4 Apr 2024 07:51:49 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 02:51:48 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 02:51:47 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33951777-f258-11ee-afe5-a90da7624cb6 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bd9854KvNq4S3uQ8+2ks2kiI+T1QakE4UjO6MyWdByl8vZPjuCSu+9W5ZrKpnCgQig/wWcYfGd/bRK4sKKqYAH3WAK9IHjzpQQ/jz09fkxrGyVQfRhW1mhhup/KKJB39OPccE+SGZzktQcGzhYflFNwET17Ab179viif3qKutVwqiy/o+oQ81v3yqbvz8ALS3T3nwWi7Kpvmh4GUC5V9Zj1Q1eob0amx8zMdY8H9jL3VgQRBoFyWttgQglvD7d/YqIngqMonGv5A5w4cSaP3O3HACke5fM3LHq9kdsaWLTGEnMcxt6w5kgJFDuNiCQi1xvpEfrEoD4RUnrwtHCkcnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5YgJMInRV9+naJSvwvbifqXD4WV1M7F+04rZI69ZOn8=; b=by3dWBn+MgArNyZzfMIDrc3ABuF2ZkmTwtQG0d5UTIwiVwl58NA9jh+Jn9sxA0e25bQk7HwA4rECyiJUJHBbcW+yUTsuLza7YclRRDV/GS00reACBGsPTREVLLaK6sGhD/5cVre7eYTJtjeM7dklpCHCbkCbAwyBYElT4OUerc8NkH3HGsMZIhgcXO3/RtCXVda+Urh+H6S9Al9GDh/uEjMsMYaFNX8q8MVb2fkFgLkLpJLLia8HekF+mFSki+0DSPS0Dj7cksqXlqvbKPruzqrEwuGRLDCJ1EwJrryX6i9R3f8xIG8pPCwGDw1COjT8/WM0hjFp9Z2Z9uPWVlZEew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5YgJMInRV9+naJSvwvbifqXD4WV1M7F+04rZI69ZOn8=; b=0huK5KSRU5+iR4Eq05envINpSTw5G0sAmQCkXe4akmi356KW/RsJr5aN/USNu36L2/MVsGOVLGcr69ofTWmdrw19Q0fRJLjcecEFifaWu8QGT+1msthJWx2Z8TbN0okGF60SI5lhoCqPwYUMlXW/ZYvAumunO4ZvrM7sftL9zKQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] drivers: char: Drop useless suspend/resume stubs in Arm drivers Date: Thu, 4 Apr 2024 09:51:42 +0200 Message-ID: <20240404075143.25304-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240404075143.25304-1-michal.orzel@amd.com> References: <20240404075143.25304-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB04.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDE:EE_|CY8PR12MB7290:EE_ X-MS-Office365-Filtering-Correlation-Id: f601df77-d6ba-4b62-0b93-08dc547c15d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l2LXKuPZzeuJ+SSEo88tob8b8PJuuR25wmvOFHwZR+V4l3y6OKNHmNGikDT4dcTEZpQa/3lwewaILYIXQPeZxCbQwdWjANRc+9d8czpRlsd7uT5tN3mzw9Ro+9V7seHYV53DNdGdwqgTvGv3CNEHUWlJF+6u14c8g1TBdb6JsN7LRYBNhVwTFKZCfc8TXLqN/piPTaqZuuKLw5e5ISpHlT9tEQtfh2BmIJGlWWepw/lexE+GGLxBT481QQr0rN+BvzBKNd5Akt3JCk7X6wUB92XK2qZUjOwI9MWqpkK6MmgcSOEJ7+4zVRVrsFvA4rUy5J7D7m8jMgPESO8KKwiQfaMrfvuo6/ELae+cLvFmOAUtwhfsmrjLT51hfox57Gvbgfl8KKqv0vwIMZoXdExty+Zlcm4Z9lChFOri8nzqMxQ32rnchiZUlGvFjmYnuDa8RsDhjNgAc7XtV/IML5XI43dHInd52D+LqQM8L2Vgr/848L34qUofceg72gx2dECIJChCzdC7k4iu10s0ZZw1Z0ZWFYMdKAjlnJVqpHaLrxC0OemmQL92Qg0rwgduNPLutbcsQCBM2V3hiD3AZ93LAX/lbXcOr+Xkg8GSu3zaYP1bz77R5icvpxKKpw2BEe9l5TceNU8REgM6VnHCLqQE7cHhfPdQ0fbfYZL3bZUrv1ixIgJQMC3gtPdQLERan8sUL178oSVtd1dugy33di4usvTFMidoTyONazCdb1ZRjeEzPpXt//NL4x5yZun6SJnq X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 07:51:49.5539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f601df77-d6ba-4b62-0b93-08dc547c15d4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7290 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1712217134373100002 Content-Type: text/plain; charset="utf-8" On Arm we don't use console_{suspend,resume} and the corresponding stubs in serial drivers are being redundantly copied whenever a new driver is added. Drop them as well as useless .endboot =3D NULL assignment. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini Reviewed-by: Jan Beulich --- xen/drivers/char/cadence-uart.c | 13 ------------- xen/drivers/char/exynos4210-uart.c | 13 ------------- xen/drivers/char/imx-lpuart.c | 13 ------------- xen/drivers/char/meson-uart.c | 13 ------------- xen/drivers/char/mvebu-uart.c | 13 ------------- xen/drivers/char/omap-uart.c | 13 ------------- xen/drivers/char/pl011.c | 13 ------------- xen/drivers/char/scif-uart.c | 13 ------------- 8 files changed, 104 deletions(-) diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uar= t.c index 3618fa88d868..b2f379833f02 100644 --- a/xen/drivers/char/cadence-uart.c +++ b/xen/drivers/char/cadence-uart.c @@ -90,16 +90,6 @@ static void __init cuart_init_postirq(struct serial_port= *port) cuart_write(uart, R_UART_IER, UART_SR_INTR_RTRIG); } =20 -static void cuart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void cuart_resume(struct serial_port *port) -{ - BUG(); -} - static int cuart_tx_ready(struct serial_port *port) { struct cuart *uart =3D port->uart; @@ -143,9 +133,6 @@ static const struct vuart_info *cuart_vuart(struct seri= al_port *port) static struct uart_driver __read_mostly cuart_driver =3D { .init_preirq =3D cuart_init_preirq, .init_postirq =3D cuart_init_postirq, - .endboot =3D NULL, - .suspend =3D cuart_suspend, - .resume =3D cuart_resume, .tx_ready =3D cuart_tx_ready, .putc =3D cuart_putc, .getc =3D cuart_getc, diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos42= 10-uart.c index b29fd75c5a1c..58901df554cb 100644 --- a/xen/drivers/char/exynos4210-uart.c +++ b/xen/drivers/char/exynos4210-uart.c @@ -212,16 +212,6 @@ static void __init exynos4210_uart_init_postirq(struct= serial_port *port) exynos4210_write(uart, UMCON, exynos4210_read(uart, UMCON) | UMCON_INT= _EN); } =20 -static void exynos4210_uart_suspend(struct serial_port *port) -{ - BUG(); // XXX -} - -static void exynos4210_uart_resume(struct serial_port *port) -{ - BUG(); // XXX -} - static int exynos4210_uart_tx_ready(struct serial_port *port) { struct exynos4210_uart *uart =3D port->uart; @@ -286,9 +276,6 @@ static const struct vuart_info *exynos4210_vuart_info(s= truct serial_port *port) static struct uart_driver __read_mostly exynos4210_uart_driver =3D { .init_preirq =3D exynos4210_uart_init_preirq, .init_postirq =3D exynos4210_uart_init_postirq, - .endboot =3D NULL, - .suspend =3D exynos4210_uart_suspend, - .resume =3D exynos4210_uart_resume, .tx_ready =3D exynos4210_uart_tx_ready, .putc =3D exynos4210_uart_putc, .getc =3D exynos4210_uart_getc, diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c index 522680a25cec..faf4693b66e1 100644 --- a/xen/drivers/char/imx-lpuart.c +++ b/xen/drivers/char/imx-lpuart.c @@ -101,16 +101,6 @@ static void __init imx_lpuart_init_postirq(struct seri= al_port *port) imx_lpuart_write(uart, UARTCTRL, temp); } =20 -static void imx_lpuart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void imx_lpuart_resume(struct serial_port *port) -{ - BUG(); -} - static int imx_lpuart_tx_ready(struct serial_port *port) { struct imx_lpuart *uart =3D port->uart; @@ -185,9 +175,6 @@ static void imx_lpuart_stop_tx(struct serial_port *port) static struct uart_driver __read_mostly imx_lpuart_driver =3D { .init_preirq =3D imx_lpuart_init_preirq, .init_postirq =3D imx_lpuart_init_postirq, - .endboot =3D NULL, - .suspend =3D imx_lpuart_suspend, - .resume =3D imx_lpuart_resume, .tx_ready =3D imx_lpuart_tx_ready, .putc =3D imx_lpuart_putc, .getc =3D imx_lpuart_getc, diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c index 694381986d07..407a276085b7 100644 --- a/xen/drivers/char/meson-uart.c +++ b/xen/drivers/char/meson-uart.c @@ -116,16 +116,6 @@ static void __init meson_uart_init_postirq(struct seri= al_port *port) (AML_UART_RX_INT_EN | AML_UART_TX_INT_EN)); } =20 -static void meson_uart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void meson_uart_resume(struct serial_port *port) -{ - BUG(); -} - static void meson_uart_putc(struct serial_port *port, char c) { struct meson_uart *uart =3D port->uart; @@ -191,9 +181,6 @@ static int meson_uart_tx_ready(struct serial_port *port) static struct uart_driver __read_mostly meson_uart_driver =3D { .init_preirq =3D meson_uart_init_preirq, .init_postirq =3D meson_uart_init_postirq, - .endboot =3D NULL, - .suspend =3D meson_uart_suspend, - .resume =3D meson_uart_resume, .putc =3D meson_uart_putc, .getc =3D meson_uart_getc, .tx_ready =3D meson_uart_tx_ready, diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c index 1913fe8b5f91..db2418576ca5 100644 --- a/xen/drivers/char/mvebu-uart.c +++ b/xen/drivers/char/mvebu-uart.c @@ -125,16 +125,6 @@ static void __init mvebu3700_uart_init_postirq(struct = serial_port *port) mvebu3700_write(uart, UART_CTRL_REG, reg); } =20 -static void mvebu3700_uart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void mvebu3700_uart_resume(struct serial_port *port) -{ - BUG(); -} - static void mvebu3700_uart_putc(struct serial_port *port, char c) { struct mvebu3700_uart *uart =3D port->uart; @@ -213,9 +203,6 @@ static int mvebu3700_uart_tx_ready(struct serial_port *= port) static struct uart_driver __read_mostly mvebu3700_uart_driver =3D { .init_preirq =3D mvebu3700_uart_init_preirq, .init_postirq =3D mvebu3700_uart_init_postirq, - .endboot =3D NULL, - .suspend =3D mvebu3700_uart_suspend, - .resume =3D mvebu3700_uart_resume, .putc =3D mvebu3700_uart_putc, .getc =3D mvebu3700_uart_getc, .tx_ready =3D mvebu3700_uart_tx_ready, diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c index e4f5be22894b..f4368c158c06 100644 --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -242,16 +242,6 @@ static void __init omap_uart_init_postirq(struct seria= l_port *port) omap_write(uart, UART_IER, UART_IER_ERDAI|UART_IER_ETHREI|UART_IER_ELS= I); } =20 -static void omap_uart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void omap_uart_resume(struct serial_port *port) -{ - BUG(); -} - static int omap_uart_tx_ready(struct serial_port *port) { struct omap_uart *uart =3D port->uart; @@ -307,9 +297,6 @@ static const struct vuart_info *omap_vuart_info(struct = serial_port *port) static struct uart_driver __read_mostly omap_uart_driver =3D { .init_preirq =3D omap_uart_init_preirq, .init_postirq =3D omap_uart_init_postirq, - .endboot =3D NULL, - .suspend =3D omap_uart_suspend, - .resume =3D omap_uart_resume, .tx_ready =3D omap_uart_tx_ready, .putc =3D omap_uart_putc, .getc =3D omap_uart_getc, diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index 7260a988ca65..5f9913367d51 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -166,16 +166,6 @@ static void __init pl011_init_postirq(struct serial_po= rt *port) pl011_write(uart, IMSC, RTI|OEI|BEI|PEI|FEI|TXI|RXI); } =20 -static void pl011_suspend(struct serial_port *port) -{ - BUG(); // XXX -} - -static void pl011_resume(struct serial_port *port) -{ - BUG(); // XXX -} - static int pl011_tx_ready(struct serial_port *port) { struct pl011 *uart =3D port->uart; @@ -232,9 +222,6 @@ static void pl011_tx_start(struct serial_port *port) static struct uart_driver __read_mostly pl011_driver =3D { .init_preirq =3D pl011_init_preirq, .init_postirq =3D pl011_init_postirq, - .endboot =3D NULL, - .suspend =3D pl011_suspend, - .resume =3D pl011_resume, .tx_ready =3D pl011_tx_ready, .putc =3D pl011_putc, .getc =3D pl011_getc, diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index b7f86f882c85..757793ca4588 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -195,16 +195,6 @@ static void __init scif_uart_init_postirq(struct seria= l_port *port) params->irq_flags); } =20 -static void scif_uart_suspend(struct serial_port *port) -{ - BUG(); -} - -static void scif_uart_resume(struct serial_port *port) -{ - BUG(); -} - static int scif_uart_tx_ready(struct serial_port *port) { struct scif_uart *uart =3D port->uart; @@ -284,9 +274,6 @@ static void scif_uart_stop_tx(struct serial_port *port) static struct uart_driver __read_mostly scif_uart_driver =3D { .init_preirq =3D scif_uart_init_preirq, .init_postirq =3D scif_uart_init_postirq, - .endboot =3D NULL, - .suspend =3D scif_uart_suspend, - .resume =3D scif_uart_resume, .tx_ready =3D scif_uart_tx_ready, .putc =3D scif_uart_putc, .getc =3D scif_uart_getc, --=20 2.25.1 From nobody Tue May 21 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1712217133; cv=pass; d=zohomail.com; s=zohoarc; b=ULRi9fsx9j60+tUDTABMIDz/ZgIJm4mLuUiMsjaFmLjdbk9qRqOMZK9V5rr509DSgyqyewpxkUHrvfGLWaPT6u7UYTfovzz53eQF9BLErmyby76kICy6Ybu1fgNEvywS3/MI/7uCfVbiSpk77GX3ybg1OusOcD/wqae+jta5KYk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712217133; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lkHCkM+Kw7MqR749th2KyIyoSZrmeqh5RM1QSsKlVXU=; b=X9yAQCAH+RVcqYDuK7U8e4DlJjSMem/bBmFU04Q5ChqGkgN1+pPWXvno4g1JvsKycJmeNmNHdZ69DEJS7Oy0kgPIih/Nx68Sq0wYFDTBw0y+99UGI34tNPR4IftxJWKqkkcgqYIqQ/wHO+frumH/Gk2dxuApUALuzXCQ2xTYLug= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1712217133587697.3884634245392; Thu, 4 Apr 2024 00:52:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.700713.1094285 (Exim 4.92) (envelope-from ) id 1rsHt7-0006nR-NU; Thu, 04 Apr 2024 07:51:57 +0000 Received: by outflank-mailman (output) from mailman id 700713.1094285; Thu, 04 Apr 2024 07:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsHt7-0006mp-JK; Thu, 04 Apr 2024 07:51:57 +0000 Received: by outflank-mailman (input) for mailman id 700713; Thu, 04 Apr 2024 07:51:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rsHt5-0006V3-Rg for xen-devel@lists.xenproject.org; Thu, 04 Apr 2024 07:51:55 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f403:2414::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 340221b9-f258-11ee-afe5-a90da7624cb6; Thu, 04 Apr 2024 09:51:54 +0200 (CEST) Received: from MW4PR04CA0189.namprd04.prod.outlook.com (2603:10b6:303:86::14) by DS7PR12MB8251.namprd12.prod.outlook.com (2603:10b6:8:e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 07:51:52 +0000 Received: from MWH0EPF000A6735.namprd04.prod.outlook.com (2603:10b6:303:86:cafe::88) by MW4PR04CA0189.outlook.office365.com (2603:10b6:303:86::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26 via Frontend Transport; Thu, 4 Apr 2024 07:51:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by MWH0EPF000A6735.mail.protection.outlook.com (10.167.249.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Thu, 4 Apr 2024 07:51:51 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 02:51:50 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 00:51:49 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 02:51:48 -0500 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 340221b9-f258-11ee-afe5-a90da7624cb6 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sy0zGEhtFM/AH7FWPAAloKSrf+Tx8LSgfK+3g8LNLo9cLuvFSmjji60JLqjKOVbnadE1PZX4qDTHqsMn1IGs0g1tu2nmcpfhMnP24Xlj6xQBBosBSsfXojMSeC0s6Hx7u2iah3nBAjuvMfyMUeCFO4D1L5sDm8BAz8TYLSbg8FEFwPs5f8kHPtLQBQgPKIE27MOax1/ZQ1TGdLotlJZhgX6zuqgKCXXt3XyWS1hu1R6coiCH141UqXY0vtWt9D7JrLyKFu8IJsSw0YtNTnqYepZuHIxYjvS8iN2H7H/ZooRS2LPdi/mO64TPGs5jlspQywPsSGajjNoNEgUp94mKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lkHCkM+Kw7MqR749th2KyIyoSZrmeqh5RM1QSsKlVXU=; b=YWo94Mtd8vBw3bTNkDwWHuLsUc3DaxtpzSCY2q5V1tRTd8qWCINeqFJqj+z8UfdktJ8l8kwx7k2bDnYiGF4hr0qNS23+d9aAwsqPgzDObfmsqceEqcQUXKk9NCqO0RFWG2GbZfdyVSXlWDJHVxjR9apxRDVKH3Dg9CDm9Wd2uRmoTgmn6qrx/bJwvJxN3G6AMPBZPQZjwYxSXyO87ii2LbjGA86o3j+MiWjdAy6cYopfpFcOOpLdZPs/z03lk3JmBj+oBbrR3TEdjlRh2P3hlfzbJ9Tq2mwH7LwDNNEPkl8PP1ezgk+EL3cQujAZ2IgJwf1SpT9ZgJFjKaOJLbW1fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkHCkM+Kw7MqR749th2KyIyoSZrmeqh5RM1QSsKlVXU=; b=QQdHkUqMYse7PneSMKqLyLAIJ8ovF4pYLF0I2tFgi+CKb1OWOLHnyy1j0rIoglmv18G1NXTyl/0FwpXg7oI9CmVYYUAv+gB0ZVDQO13vaEI1nEBpBM53B79x6GKZ5BKoN6xIQPAXHWuhnn3QT+Df1VP9LfE/YMwzD+99KGiMQFU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] char: lpuart: Drop useless variables from UART structure Date: Thu, 4 Apr 2024 09:51:43 +0200 Message-ID: <20240404075143.25304-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240404075143.25304-1-michal.orzel@amd.com> References: <20240404075143.25304-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6735:EE_|DS7PR12MB8251:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b337963-06f1-47b2-8a10-08dc547c170d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lS5Fq7pW6DC4szhNW+r1GUIEDDUxbA5H8udv34ivPb+zCvR3ByNt1VWTtsUOONZFLvnzMxRVV3IcBky23QTSme7iu8FHH+8mTeUyoNQQ1kq/vIJtuRGWcGvfjy3DzInTN4iaGFWT6Y6BApeXvypr4kTgZb7wLkEI9js2vtXsou7ImOTv/wGyK4VkkfBJCL2kx4aJMw3T9DRD6rM4Mnp4KOgn747KakHeTg7gY2pfAOE3X0x/+dvxeIKh+j9NTqfbBS5Xgh9rx9kctgvSCAeSgPnLNUIuz3U8qVb2yjdzQF5hJ0WUE59n7o4f4tG1ZOTxo/TNH/hNfbvoNFtDFS7UafhPpgRL/7X0STnE8AQ7wwdLYMv4rv8e+mKm19fPkBIYqn9enVKL7hTBKOBpA8Cn0dRQLd7gMWXK/Vh9m7UnMvfeZV2df0uNfAV3U2L3fQGxdbQL6VLR3Jvla1BzclKg47cJIBSKsJakSpzFAvR/48haib/XKa2ZDfiIIWhEI/OTtX9gVgPc8x68xAxPg+zj29JPEalZLQI6ZE8ynPiv3PE2kxVAVLDCSHxYlDB8d5CaEauEX2BV75PY8qN64pDoKCpQUiNoSXmHY/SUy4fZhsEqOJtAyl+0wumSHa6bhkrnvZtcnLzbgV0tVCZcXfHMeUfmpamjVcsJSBCGpqRuVtftkjdf4c7VsRhYJn+6PNPPqvwiK6kIIh5Ey9IG5RgkNze3B5ZuNKGaKqIAD0OVhjcx3PYr156fMmiTMCJav2rz X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 07:51:51.5615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b337963-06f1-47b2-8a10-08dc547c170d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6735.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8251 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1712217134341100001 Content-Type: text/plain; charset="utf-8" These variables are useless. They are being assigned a value which is never used since UART is expected to be pre-configured. No functional change. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini --- xen/drivers/char/imx-lpuart.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c index faf4693b66e1..7770d158bf59 100644 --- a/xen/drivers/char/imx-lpuart.c +++ b/xen/drivers/char/imx-lpuart.c @@ -30,7 +30,6 @@ #define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + (off= )) =20 static struct imx_lpuart { - uint32_t baud, clock_hz, data_bits, parity, stop_bits, fifo_size; uint32_t irq; char __iomem *regs; struct irqaction irqaction; @@ -197,11 +196,6 @@ static int __init imx_lpuart_init(struct dt_device_nod= e *dev, =20 uart =3D &imx8_com; =20 - uart->baud =3D 115200; - uart->data_bits =3D 8; - uart->parity =3D 0; - uart->stop_bits =3D 1; - res =3D dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { --=20 2.25.1