From nobody Sun Feb 8 23:19:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1711019168; cv=none; d=zohomail.com; s=zohoarc; b=h3fC7Hz8b3re8KZFpA9GPDSu40OSNK9gy8bvnUocn5qo0+gkGmglKAZE7bR72EfxkYowJtfiwVScW9jgK8R0FxfVYLhjnvx7Wfgbo/nvA1vdOl407ae3m5168f4u6ahflvc14MEAyn7g81lqOs7MuxrbQ6J81XFT2hoO8qTUixw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711019168; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Q0RtmqqzFd4YUtX95+8cJsuMlOVlknAi1XayUzUdt2k=; b=MYMZ9lSk3fB+1NDI+kq+g1ZzD8KeT1i/h+1Q1aHpVWHL+br3WcvAqe0xj7GdZ1YbYA/7F5mWU3MtehyHDbJkyKL+D0hko25mbFyyAzsRRmt4tclE2W2F44YlpEjhm6IoEfh1++uR2zRcCdSZR2G/T5xhaATVSNhE86pP3yfJ6/U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1711019168249994.9425822830929; Thu, 21 Mar 2024 04:06:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.696331.1087205 (Exim 4.92) (envelope-from ) id 1rnGEs-0001b4-59; Thu, 21 Mar 2024 11:05:38 +0000 Received: by outflank-mailman (output) from mailman id 696331.1087205; Thu, 21 Mar 2024 11:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rnGEs-0001ax-0k; Thu, 21 Mar 2024 11:05:38 +0000 Received: by outflank-mailman (input) for mailman id 696331; Thu, 21 Mar 2024 11:05:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rnGEq-0001ar-UU for xen-devel@lists.xenproject.org; Thu, 21 Mar 2024 11:05:36 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0be5665-e772-11ee-a1ee-f123f15fe8a2; Thu, 21 Mar 2024 12:05:34 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4146a1ac117so5114985e9.0 for ; Thu, 21 Mar 2024 04:05:34 -0700 (PDT) Received: from localhost ([85.31.135.62]) by smtp.gmail.com with ESMTPSA id q18-20020adff792000000b0033ec9b26b7asm16943227wrp.25.2024.03.21.04.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 04:05:33 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0be5665-e772-11ee-a1ee-f123f15fe8a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1711019133; x=1711623933; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q0RtmqqzFd4YUtX95+8cJsuMlOVlknAi1XayUzUdt2k=; b=cISF5faALJ6IRD1WaDsUMTc4y040Qh8DVscH3aBH038IIvyQRYnIAk5L0rsgFCZYHo jvn70fmnjbv7touRRM1lwfGmeb8I12aYKtuj2GEqG9BLbtpWCeGHPDHmBCk2p2cVEfDu SNx/hLSNRs3hBX3cODZzC3fN/uU+nTfTb/UAc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711019133; x=1711623933; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q0RtmqqzFd4YUtX95+8cJsuMlOVlknAi1XayUzUdt2k=; b=ipDtM0qjoV9ap6Iz0vyCYLqkrwBN0LfKj4zMHtgoOuRMFPr4RbZv4MC0g2Yd1knb0I B3r2JnF5PbUgJkXTJegnWEpikSNNSZHdG2ske5cBt207Stk5auQj4ssHuD0ylIJDAUNC va9BztloKfhM4D2b5AroiATrgA4e1Oj6/Hqwv2j98mYH2eSivRsf0OprZ7yqZP7b5IrH vDRErFRcONioz6PmGoeLiS4LRPInEMv1ieVFhmhMCC9H18IGTUfq0lB6cXLXWvxbSyOS qNXHd8CFoz8k+crvTPrUHR0q057AGSpXxdWLc96M0n7fxvUvsfRok6GuG7XomSowqDif H6cw== X-Gm-Message-State: AOJu0YzsPyvXVVVqylpRqJjKwzaB2EpZP2jFpoba4iPiuaF4NsZ4Pv+g +9VxXW6MNVw4qbDFDgv49Duv1Vfzeg0ZCbhQbsKXOpvXALm/4NvzrZabNb1qlRwxVPLHoRTeas5 4 X-Google-Smtp-Source: AGHT+IGewDTEX5eCSP+WcLGjdD9PesY412II1Kwnpspv5QujOnEl8L9XgUrrHyPfl1vyfJM1XPIzXw== X-Received: by 2002:a05:600c:3149:b0:413:fdc2:d9da with SMTP id h9-20020a05600c314900b00413fdc2d9damr2144437wmo.12.1711019133582; Thu, 21 Mar 2024 04:05:33 -0700 (PDT) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/console: add comment about external console lock helper Date: Thu, 21 Mar 2024 12:05:03 +0100 Message-ID: <20240321110503.72916-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1711019169449100001 The current console_lock_recursive_irqsave() implementation is not speculat= ion safe, however it's only used to prevent interleaved output. Note this in t= he function declaration in order for callers to be aware of the limitation. No functional change. Signed-off-by: Roger Pau Monn=C3=A9 Acked-by: Jan Beulich --- xen/include/xen/console.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/xen/console.h b/xen/include/xen/console.h index 68759862e88d..6dfbade3ece3 100644 --- a/xen/include/xen/console.h +++ b/xen/include/xen/console.h @@ -20,6 +20,7 @@ void console_init_postirq(void); void console_endboot(void); int console_has(const char *device); =20 +/* Not speculation safe - only used to prevent interleaving of output. */ unsigned long console_lock_recursive_irqsave(void); void console_unlock_recursive_irqrestore(unsigned long flags); void console_force_unlock(void); --=20 2.44.0