From nobody Thu May 9 00:42:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1706606066; cv=none; d=zohomail.com; s=zohoarc; b=TFD1sNKAogzE+wxHbpkTQe7p0Q12vSmUE1FzA10ysS0QrjOGn+t2RlajmKljxv1ddBdmZ/npm9YeLf8EZZKM8wzWQOB8zdHQs59GbbhnV4VoLcwBJNtXNpWXoP0s6RqHmbsj1UyGQTO+ZVaZHIvjOD7dJ3NtBkA5kzvFKJvmBKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706606066; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R+oR8czXs/bOwfRvEg8m8bx8xQuQWdKcdIWuFikFvoM=; b=kivOIhETLgB/pSbrQHCRCqUu/Gh1ZImTABrJs1E+M+UqRr1XOVG5ETt0zLp+W02BOM58T1ZJS8+Q62Q3gLZ+mfylGRNAUA3xyvVWOTpGodIk2Y8Lsc2r5qIx/YAa7os+CFB4Ebq5JgesEzmstON4xnV/obC3jqbLkzD7KWM/aJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 170660606645844.20749400225327; Tue, 30 Jan 2024 01:14:26 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.673242.1047538 (Exim 4.92) (envelope-from ) id 1rUkC4-000538-9d; Tue, 30 Jan 2024 09:14:12 +0000 Received: by outflank-mailman (output) from mailman id 673242.1047538; Tue, 30 Jan 2024 09:14:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC4-00052T-3c; Tue, 30 Jan 2024 09:14:12 +0000 Received: by outflank-mailman (input) for mailman id 673242; Tue, 30 Jan 2024 09:14:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC2-0003rb-Hn for xen-devel@lists.xenproject.org; Tue, 30 Jan 2024 09:14:10 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec992eb0-bf4f-11ee-98f5-efadbce2ee36; Tue, 30 Jan 2024 10:14:09 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40eacb6067dso50835015e9.1 for ; Tue, 30 Jan 2024 01:14:09 -0800 (PST) Received: from localhost ([213.195.118.74]) by smtp.gmail.com with ESMTPSA id bn7-20020a056000060700b0033946c0f9e7sm10289572wrb.17.2024.01.30.01.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:14:07 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec992eb0-bf4f-11ee-98f5-efadbce2ee36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1706606048; x=1707210848; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R+oR8czXs/bOwfRvEg8m8bx8xQuQWdKcdIWuFikFvoM=; b=IeWBBMoHt0bjMe5C39T+PHCQC0pZBBBcqyilLAIj72/H1lYNHWqMl6Npeu551nbM49 WYhoPQi16TevkAT1nfHbm/XCTSv7xrsIvz7wh3l+KXiPnRDh3iZwweHXJnYHQ03fDHRG 8QSBTSYyLjdmwG926n087H9wDLEDcCpQtMO6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706606048; x=1707210848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R+oR8czXs/bOwfRvEg8m8bx8xQuQWdKcdIWuFikFvoM=; b=cTo2kwzeqgjxQsChDRGAjQd6kjhWauMdFRNPmab5GXk8Qr0NKPHlvPmLOdEIrkBcMo XPCjB0Km4ZKOkj2EmfrWWLKWnu26fkpO2+35z2yd9MiYSvCIK0lKrykvdopmBT2EJOOg ZBKmdh2YHCybvz+1y5LvBj0oW4DRa00h9RTww8EXU2gsC6fREclsB/JWO6GY0i5aoiVr Y8kiP4jWq1s+7JMIQEQAywwrCh6qcriz9o+8Z5EoU8bldxTNHsmqUeLd1NVuk02Ou8GT TuRLOYgBuClyQQ2vp2FsEqxVOI3Z/7oeqyOORunoNKabgVyiUraJ8G232j4zT0K8EYNg bE4w== X-Gm-Message-State: AOJu0YwxDQ1giWT6g14TtdRhFWrdGJfstzeZrtRkUWC3jMjDWfJXe0vS hmcGQ1e047dEvO5o/vRypjRw4XRxQyWqwysyDv3N6vPwJ49o58cJLcJATbwOkjhcsdA/OUegfDo 6 X-Google-Smtp-Source: AGHT+IGLO5rXBuj/zg3rp1lzBBGTk1Tt7ulOK5LYlgTh0tPl6x5P5UkASQ219JAQYPmkJ58gS5M7Gg== X-Received: by 2002:a05:600c:1f83:b0:40e:b1f6:2ed7 with SMTP id je3-20020a05600c1f8300b0040eb1f62ed7mr7606054wmb.32.1706606047683; Tue, 30 Jan 2024 01:14:07 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 1/3] x86/intel: expose IPRED_CTRL to guests Date: Tue, 30 Jan 2024 10:13:58 +0100 Message-ID: <20240130091400.50622-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130091400.50622-1-roger.pau@citrix.com> References: <20240130091400.50622-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1706606067357100001 The CPUID feature bit signals the presence of the IPRED_DIS_{U,S} controls = in SPEC_CTRL MSR. Note that those controls are not used by the hypervisor. Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- xen/arch/x86/msr.c | 3 +++ xen/include/public/arch-x86/cpufeatureset.h | 2 +- xen/tools/gen-cpuid.py | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index c33dc78cd8f6..d500f87a5fd1 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -324,6 +324,9 @@ uint64_t msr_spec_ctrl_valid_bits(const struct cpu_poli= cy *cp) return (SPEC_CTRL_IBRS | SPEC_CTRL_STIBP | (ssbd ? SPEC_CTRL_SSBD : 0) | (psfd ? SPEC_CTRL_PSFD : 0) | + (cp->feat.ipred_ctrl ? (SPEC_CTRL_IPRED_DIS_U | + SPEC_CTRL_IPRED_DIS_S) + : 0) | 0); } =20 diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/publ= ic/arch-x86/cpufeatureset.h index c897c2040136..e586e141c329 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -302,7 +302,7 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Prote= cted Processor Inventory =20 /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ -XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* MSR_SPEC_CTRL.IPRED_DIS_= * */ +XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /*A MSR_SPEC_CTRL.IPRED_DIS_= * */ XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /* MSR_SPEC_CTRL.RRSBA_DIS_= * */ XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDP_DIS_U = */ XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S = */ diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py index df5222a3cdd0..45fab5e75d1c 100755 --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -319,7 +319,8 @@ def crunch_numbers(state): # IBRSB/IBRS, and we pass this MSR directly to guests. Treating t= hem # as dependent features simplifies Xen's logic, and prevents the g= uest # from seeing implausible configurations. - IBRSB: [STIBP, SSBD, INTEL_PSFD, EIBRS], + IBRSB: [STIBP, SSBD, INTEL_PSFD, EIBRS, + IPRED_CTRL], IBRS: [AMD_STIBP, AMD_SSBD, PSFD, AUTO_IBRS, IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE], IBPB: [IBPB_RET, SBPB, IBPB_BRTYPE], --=20 2.43.0 From nobody Thu May 9 00:42:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1706606067; cv=none; d=zohomail.com; s=zohoarc; b=OpqdbrH7CRsHH47Y1Tc0+C3YOtKm5YuKydeiVAcBSq3Jao8tKRWl45Eac1GdnVLFzwWpdtAJIHZI6myqZ7AYKUpPRcvKfOeYVwN6UhX4r/npAsyZ13NHoltvfeWlAH9C9juVJ1mXue9CGwxMqIABczciKejsaUefvuctkXix0is= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706606067; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wG3Bmb4l/y398tdhK+NXGZhsbCood6uPoYoVyQV7KmU=; b=cuQ9tFgUj/5W23S5sNXvJLSh/5XpnwOC5ipwqPqFmIlaHaICAxBk4KBE5oxN4ZVX+hjyG/l5fmvYGXRQqWMjScCFbwHI6pvYm6pfqvQYMZClOB9GjW7cFzJZd0eUSqvpS+GFffvUEiSXHwYkZXtN2TuqiVXwnWel7ZsRbwVY+b4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1706606067513228.7068290871532; Tue, 30 Jan 2024 01:14:27 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.673241.1047532 (Exim 4.92) (envelope-from ) id 1rUkC3-0004zI-SA; Tue, 30 Jan 2024 09:14:11 +0000 Received: by outflank-mailman (output) from mailman id 673241.1047532; Tue, 30 Jan 2024 09:14:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC3-0004zB-PI; Tue, 30 Jan 2024 09:14:11 +0000 Received: by outflank-mailman (input) for mailman id 673241; Tue, 30 Jan 2024 09:14:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC2-0004AP-DC for xen-devel@lists.xenproject.org; Tue, 30 Jan 2024 09:14:10 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed393177-bf4f-11ee-8a43-1f161083a0e0; Tue, 30 Jan 2024 10:14:09 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-51117bfd452so1439764e87.3 for ; Tue, 30 Jan 2024 01:14:09 -0800 (PST) Received: from localhost ([213.195.118.74]) by smtp.gmail.com with ESMTPSA id j10-20020a05600c190a00b0040ed49605a0sm13822928wmq.47.2024.01.30.01.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:14:08 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed393177-bf4f-11ee-8a43-1f161083a0e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1706606049; x=1707210849; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wG3Bmb4l/y398tdhK+NXGZhsbCood6uPoYoVyQV7KmU=; b=sQNXVoVUGtuMFgUdsX1rfqdGOouSo7IJhgDcPWf1IpFlxEALUAKGKLNrj1DxO9SihA JLbk1LTL8AD2xo4unnBsztBDN/cd1IWM/4GqJ37bwPFtvj3bCE8w1AQAajAFJgZj04pC dnNIxaQ26tZYixUmZx711UOvIDQ6pevqRxYFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706606049; x=1707210849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wG3Bmb4l/y398tdhK+NXGZhsbCood6uPoYoVyQV7KmU=; b=eTfCxRUC5aZ5FRqzYhUt2ZLh2c8ggIkYjtMtgf/lXUtwVIWEpizoIGb772IQpMN4To scgr9VQOkK7S03aWik/gqdf883qDrZPq230yeyUNwzqB/t3LtLL/wGKH+kEMV6moih+Q yXnHh6x1zP1+H+UN14ReLh2DzfupYHjzpRwMoUdQWafNyC3S/kyyU7BhsukcVx6BzIs2 ZVOJAqPUda71bCPk1zwbOg6EqfadLB8zaTkgUJuCFMVYKrpvgoqXx7gsbA8bQG9gqWZg WKMQfD7YsUqkpScbY5amUcTZSDV4cx0ALMyZJc4MBsNu9LGsimbVJUjpHIu8bYYuojhL hRxQ== X-Gm-Message-State: AOJu0YxYZ8GmBO70jttkze/OEaHsBhNwo12+C+MKGDFaCHNR78GxdQiq y733mlMeo9N9bF2dQzHe65jv8Qhnf5eJom2GTWefD9sor4royrMNXtx582FqzV6Mho1gb1pXsAQ X X-Google-Smtp-Source: AGHT+IE0RvLj4H3KdecPGe9tNdehKzRC7ywegDzvuo8DHBbLGPMneK9XqUf3omz51ctinIxdleV+sg== X-Received: by 2002:a05:6512:1051:b0:510:146a:a122 with SMTP id c17-20020a056512105100b00510146aa122mr7378107lfb.46.1706606049284; Tue, 30 Jan 2024 01:14:09 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 2/3] x86/intel: expose RRSBA_CTRL to guests Date: Tue, 30 Jan 2024 10:13:59 +0100 Message-ID: <20240130091400.50622-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130091400.50622-1-roger.pau@citrix.com> References: <20240130091400.50622-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1706606069417100001 The CPUID feature bit signals the presence of the RRSBA_DIS_{U,S} controls = in SPEC_CTRL MSR. Note that those controls are not used by the hypervisor. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/msr.c | 3 +++ xen/include/public/arch-x86/cpufeatureset.h | 2 +- xen/tools/gen-cpuid.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index d500f87a5fd1..b3b4f75c021a 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -327,6 +327,9 @@ uint64_t msr_spec_ctrl_valid_bits(const struct cpu_poli= cy *cp) (cp->feat.ipred_ctrl ? (SPEC_CTRL_IPRED_DIS_U | SPEC_CTRL_IPRED_DIS_S) : 0) | + (cp->feat.rrsba_ctrl ? (SPEC_CTRL_RRSBA_DIS_U | + SPEC_CTRL_RRSBA_DIS_S) + : 0) | 0); } =20 diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/publ= ic/arch-x86/cpufeatureset.h index e586e141c329..bade4edab30c 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -303,7 +303,7 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Prote= cted Processor Inventory /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /*A MSR_SPEC_CTRL.IPRED_DIS_= * */ -XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /* MSR_SPEC_CTRL.RRSBA_DIS_= * */ +XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /*A MSR_SPEC_CTRL.RRSBA_DIS_= * */ XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDP_DIS_U = */ XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S = */ XEN_CPUFEATURE(MCDT_NO, 13*32+ 5) /*A MCDT_NO */ diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py index 45fab5e75d1c..1c6d76244177 100755 --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -320,7 +320,7 @@ def crunch_numbers(state): # as dependent features simplifies Xen's logic, and prevents the g= uest # from seeing implausible configurations. IBRSB: [STIBP, SSBD, INTEL_PSFD, EIBRS, - IPRED_CTRL], + IPRED_CTRL, RRSBA_CTRL], IBRS: [AMD_STIBP, AMD_SSBD, PSFD, AUTO_IBRS, IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE], IBPB: [IBPB_RET, SBPB, IBPB_BRTYPE], --=20 2.43.0 From nobody Thu May 9 00:42:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1706606069; cv=none; d=zohomail.com; s=zohoarc; b=hgAfDVp6dX+3Hudbj9PCXnEsCnIt1ExWfJYown+JCsYalW+iJCvV5kJflKrJNLWs61HJMghXTQXr07H58hFgjo9StlPZCBECqoN1cjgg4lpbqzPOX+oey204Av1QNtMoWB2CBUxmc3gVbenvrvnucxKUl4BwYhM/f44wgRueHq8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706606069; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KzWDOBti4Ac7c4/U3wTwSVGQoEFDbLGV4XyQW2tHCJY=; b=YdOtNX6iyyBqmKkrJFVau5TQXt3cjy19gu2l6gp1dDy+sLM/wqIHyGd3ynst06xrG7W2ii7oUKbvwuSs4Pcz6E1H6Ccl4ET2PrDI2fdo5CangQ1H3GoIDZ8qCpBdOXJP6fmMoZdD+BdGZq4MSgvlIzQlq1rVbO2j1yXXvyKsVAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1706606069350400.2387653517253; Tue, 30 Jan 2024 01:14:29 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.673243.1047552 (Exim 4.92) (envelope-from ) id 1rUkC5-0005XF-Lu; Tue, 30 Jan 2024 09:14:13 +0000 Received: by outflank-mailman (output) from mailman id 673243.1047552; Tue, 30 Jan 2024 09:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC5-0005W9-Hh; Tue, 30 Jan 2024 09:14:13 +0000 Received: by outflank-mailman (input) for mailman id 673243; Tue, 30 Jan 2024 09:14:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUkC4-0004AP-5S for xen-devel@lists.xenproject.org; Tue, 30 Jan 2024 09:14:12 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee38650d-bf4f-11ee-8a43-1f161083a0e0; Tue, 30 Jan 2024 10:14:11 +0100 (CET) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-33ae74e5394so1190368f8f.3 for ; Tue, 30 Jan 2024 01:14:11 -0800 (PST) Received: from localhost ([213.195.118.74]) by smtp.gmail.com with ESMTPSA id ay12-20020a5d6f0c000000b0033ad47d7b86sm10256583wrb.27.2024.01.30.01.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:14:10 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee38650d-bf4f-11ee-8a43-1f161083a0e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1706606050; x=1707210850; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KzWDOBti4Ac7c4/U3wTwSVGQoEFDbLGV4XyQW2tHCJY=; b=s5g196EDsmWYTyun2KaVvb65UCW0yhhjAWM61aGtH35j5pEJX0J8p3rtSAak4o4sIR wsDCNSdIPNiSBZqKfn0/UxP0oAU7iWW/d95lxUnZjTiGS5KzQ7bU0G4NMXmfGzHayPCt k4kxKH7XKvc9eCT7+oi7h0gQofDw5z8nyBves= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706606050; x=1707210850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KzWDOBti4Ac7c4/U3wTwSVGQoEFDbLGV4XyQW2tHCJY=; b=aTw4VW3gCAMjpQZ7F2SAT3tMr7J3uo6vqIt4EOBCZXS23s42T057tZGvm5e8V9eLM8 AY0TI8zrHJhEbOoHNg8BPn0MFPtGY1oFkVFGn4LVnrtgNkB88ei/5Uf/DMTFZs4At1X4 CTOEchByQE7kFdRIlOn7EYKPuTerQmYJDx0t7mZra1OUp05OebFgxQvTezVlRr0loWXz Oh6rh0optZ5DQEBq6QiSmosPt3XUxBFhZGCNjWMcjzA+mpEkng475wyc7I6vNK+EGLMd hztyxGbG3PZkMNWk1xeGw1/BTkWBd69tRBywqD2DF8jcSKaBaiAAdkkS2UxLgGbxB4nP jwRQ== X-Gm-Message-State: AOJu0YzqJ5w0IIB9RyNubUyk0VoyU+ZxRWGL0YOBsWeJrIuKB/G9Rl6F uofcN3yBsKr+gS2UizWsfuIqtywTYHvqOwFawTaLMSZLmWpHEN0ldIg0btFvYep2fyiLtE5DGL3 y X-Google-Smtp-Source: AGHT+IHqpPjbhO0DJaXjbOw4/qEYb5MD4uiG72JSNkJ9c0XXJa7NWreeS6rJiCDS9mZtjHVMKM3//w== X-Received: by 2002:a05:6000:2c3:b0:33a:f5ea:bd7d with SMTP id o3-20020a05600002c300b0033af5eabd7dmr2416882wry.69.1706606050557; Tue, 30 Jan 2024 01:14:10 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 3/3] x86/intel: expose BHI_CTRL to guests Date: Tue, 30 Jan 2024 10:14:00 +0100 Message-ID: <20240130091400.50622-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130091400.50622-1-roger.pau@citrix.com> References: <20240130091400.50622-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1706606071344100003 The CPUID feature bit signals the presence of the BHI_DIS_S control in SPEC_CTRL MSR. Note that those controls are not used by the hypervisor. Signed-off-by: Roger Pau Monn=C3=A9 --- xen/arch/x86/msr.c | 1 + xen/include/public/arch-x86/cpufeatureset.h | 2 +- xen/tools/gen-cpuid.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index b3b4f75c021a..e0d57bce40ec 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -330,6 +330,7 @@ uint64_t msr_spec_ctrl_valid_bits(const struct cpu_poli= cy *cp) (cp->feat.rrsba_ctrl ? (SPEC_CTRL_RRSBA_DIS_U | SPEC_CTRL_RRSBA_DIS_S) : 0) | + (cp->feat.bhi_ctrl ? SPEC_CTRL_BHI_DIS_S : 0) | 0); } =20 diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/publ= ic/arch-x86/cpufeatureset.h index bade4edab30c..be5c1b748e27 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -305,7 +305,7 @@ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_S= PEC_CTRL.PSFD */ XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /*A MSR_SPEC_CTRL.IPRED_DIS_= * */ XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /*A MSR_SPEC_CTRL.RRSBA_DIS_= * */ XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDP_DIS_U = */ -XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S = */ +XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /*A MSR_SPEC_CTRL.BHI_DIS_S = */ XEN_CPUFEATURE(MCDT_NO, 13*32+ 5) /*A MCDT_NO */ =20 /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py index 1c6d76244177..25d329ce486f 100755 --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -320,7 +320,7 @@ def crunch_numbers(state): # as dependent features simplifies Xen's logic, and prevents the g= uest # from seeing implausible configurations. IBRSB: [STIBP, SSBD, INTEL_PSFD, EIBRS, - IPRED_CTRL, RRSBA_CTRL], + IPRED_CTRL, RRSBA_CTRL, BHI_CTRL], IBRS: [AMD_STIBP, AMD_SSBD, PSFD, AUTO_IBRS, IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE], IBPB: [IBPB_RET, SBPB, IBPB_BRTYPE], --=20 2.43.0 From nobody Thu May 9 00:42:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1706610475; cv=none; d=zohomail.com; s=zohoarc; b=WGZkQpujHvBBsKnveE5VutTCEnL7cbIAkRcu8TFBDpYE9/Dgv6ggr6Gt16Q9Gy+LAoBH1ys821Zjpl0tGeIBI8MBzyksuhpU426yNWZmKjfN8fJSAzubNfvxh075eXti69VEyRkcAf0kgeWumnV+7r9MnZC0cH3sbzO2I8EPxlo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706610475; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ygxe54Oc/vFuzE6cnM13pQ0IrBJU0/x6Xb08+E2WI5A=; b=mH1B75WIyB9HVbI+yb3GqvAqZ8n04LpheoyZ8LQRMiTX5mDcfL4PBSN28kFeAnNnAUpDmAIRwZSV1B5sY+c6YNm2uz0cBYSCoc5vB0PcRLlnDW61pYC9gcJzBZeSfzJDIjMw9yRFutAR/1edfQEv5Wy1MTuPToux+niVHV4ydXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1706610475389967.4563874574885; Tue, 30 Jan 2024 02:27:55 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.673290.1047622 (Exim 4.92) (envelope-from ) id 1rUlKx-00078U-F4; Tue, 30 Jan 2024 10:27:27 +0000 Received: by outflank-mailman (output) from mailman id 673290.1047622; Tue, 30 Jan 2024 10:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUlKx-00078N-Bg; Tue, 30 Jan 2024 10:27:27 +0000 Received: by outflank-mailman (input) for mailman id 673290; Tue, 30 Jan 2024 10:27:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rUlKw-00075d-HD for xen-devel@lists.xenproject.org; Tue, 30 Jan 2024 10:27:26 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28d72c99-bf5a-11ee-8a43-1f161083a0e0; Tue, 30 Jan 2024 11:27:25 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40e8fec0968so44914335e9.1 for ; Tue, 30 Jan 2024 02:27:25 -0800 (PST) Received: from localhost ([213.195.118.74]) by smtp.gmail.com with ESMTPSA id h9-20020a05600c350900b0040faf3df118sm494063wmq.32.2024.01.30.02.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:27:23 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28d72c99-bf5a-11ee-8a43-1f161083a0e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1706610444; x=1707215244; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ygxe54Oc/vFuzE6cnM13pQ0IrBJU0/x6Xb08+E2WI5A=; b=mxpQrlV3MdTW3Qoy4/u8I3AsH1lIocVaPt9IOX3cUnBVGpAA7sed7X2SFFZV4qQ5ML GFlXL9gEgCcB8kUXClh2mXCRQMB3lOxaT6EjT7aFgqKDesnIAVsvDH3ZE0ZfbnGJZT4+ XG2ZZK1aMdtGvuaSr6jhMgCFl/wPIws/43X1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706610444; x=1707215244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ygxe54Oc/vFuzE6cnM13pQ0IrBJU0/x6Xb08+E2WI5A=; b=H3u+jvrOUTfAR8l5jLKyF4J0VFf24HRKZx508hY8IbqvX9xF3iZ18e5fziEo/9Aab8 Yr0ok0griKn0JE/cgwWYLghcWOB7anic5w3NzoU7T5/KS8jD7SOcfbB31l04DnBiYBU1 OqztxZxDYR9+CC+2qcREWHLQSUhXDjelGD5K2gjY3zxZ0ojOsjwq7p1NLsVblBbt/0uD tqMzMxY/RcRJb4acf4guQk0C1ZP6XO8yvxhcp/sFafVLl61XbgshgCT4NRWGBz7/Kc+p j3Ox4fE5H/gUNGroM22YLCPvCi4RhIRuG78n0sA/JKEnLVUttigRGd/yKVzSiGE9Yj7t vNWA== X-Gm-Message-State: AOJu0YwbADb3WVEyPP7TxrXwGeHjFUD4SxiGAwKibzEwR5K2m8w7EPud i+qOFSTJZgH6/teFwm+CGyt2uzngmc++4DeMpr/ePL0FJJ+Kzg6gqTHMcrMVT4+Xvsu5+CSLLEF 6 X-Google-Smtp-Source: AGHT+IH/y21ecbbJBQGgnFww+l9ax8d5rBE56KK6xIIDCWEN5QIrQqzBH/oHfulTGwUB+HKYOtRIvA== X-Received: by 2002:a05:600c:468d:b0:40f:4b78:7d4b with SMTP id p13-20020a05600c468d00b0040f4b787d4bmr600767wmo.41.1706610444127; Tue, 30 Jan 2024 02:27:24 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne Subject: [PATCH] XTF: tests SPEC_CTRL added bits Date: Tue, 30 Jan 2024 11:27:19 +0100 Message-ID: <20240130102719.51150-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130091400.50622-1-roger.pau@citrix.com> References: <20240130091400.50622-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1706610476999100001 Content-Type: text/plain; charset="utf-8" Dummy set/clear tests for additional spec_ctrl bits. --- docs/all-tests.dox | 2 + tests/test/Makefile | 9 ++++ tests/test/main.c | 100 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 111 insertions(+) create mode 100644 tests/test/Makefile create mode 100644 tests/test/main.c diff --git a/docs/all-tests.dox b/docs/all-tests.dox index 892a9e474743..5a66ac252ea5 100644 --- a/docs/all-tests.dox +++ b/docs/all-tests.dox @@ -187,3 +187,5 @@ states. =20 @subpage test-nested-vmx - Nested VT-x tests. */ +# Placeholder: Merge into the appropriate location above +@subpage test-test - @todo title diff --git a/tests/test/Makefile b/tests/test/Makefile new file mode 100644 index 000000000000..19bc4b6a4639 --- /dev/null +++ b/tests/test/Makefile @@ -0,0 +1,9 @@ +include $(ROOT)/build/common.mk + +NAME :=3D test +CATEGORY :=3D utility +TEST-ENVS :=3D hvm32 pv64 + +obj-perenv +=3D main.o + +include $(ROOT)/build/gen.mk diff --git a/tests/test/main.c b/tests/test/main.c new file mode 100644 index 000000000000..9a25e95d91b7 --- /dev/null +++ b/tests/test/main.c @@ -0,0 +1,100 @@ +/** + * @file tests/test/main.c + * @ref test-test + * + * @page test-test test + * + * @todo Docs for test-test + * + * @see tests/test/main.c + */ +#include + +#define MSR_SPEC_CTRL 0x00000048 +#define SPEC_CTRL_IPRED_DIS_U (_AC(1, ULL) << 3) +#define SPEC_CTRL_IPRED_DIS_S (_AC(1, ULL) << 4) +#define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5) +#define SPEC_CTRL_RRSBA_DIS_S (_AC(1, ULL) << 6) +#define SPEC_CTRL_DDP_DIS_U (_AC(1, ULL) << 8) +#define SPEC_CTRL_BHI_DIS_S (_AC(1, ULL) << 10) + +const char test_title[] =3D "SPEC_CTRL"; + +static void update_spec_ctrl(uint64_t mask, bool set) +{ + uint64_t spec_ctrl =3D rdmsr(MSR_SPEC_CTRL); + + if ( set ) + spec_ctrl |=3D mask; + else + spec_ctrl &=3D ~mask; + + wrmsr(MSR_SPEC_CTRL, spec_ctrl); +} + +static void assert_spec_ctrl(uint64_t mask, bool set) +{ + uint64_t spec_ctrl =3D rdmsr(MSR_SPEC_CTRL); + + if ( (spec_ctrl & mask) !=3D (set ? mask : 0) ) + { + xtf_failure("SPEC_CTRL expected: %#" PRIx64 " got: %#" PRIx64 "\n", + set ? (spec_ctrl | mask) : (spec_ctrl & ~mask), + spec_ctrl); + xtf_exit(); + } +} + +static void test_loop(uint64_t mask) +{ + update_spec_ctrl(mask, true); + assert_spec_ctrl(mask, true); + /* Ensure context switch to Xen. */ + hypercall_yield(); + assert_spec_ctrl(mask, true); + + update_spec_ctrl(mask, false); + assert_spec_ctrl(mask, false); + /* Ensure context switch to Xen. */ + hypercall_yield(); + assert_spec_ctrl(mask, false); +} + +void test_main(void) +{ + static const struct { + const char *name; + unsigned int feat; + uint64_t mask; + } tests[] =3D { + { "IPRED CTRL", 1, SPEC_CTRL_IPRED_DIS_U | SPEC_CTRL_IPRED_DIS_S }, + { "RRSBA CTRL", 2, SPEC_CTRL_RRSBA_DIS_U | SPEC_CTRL_RRSBA_DIS_S }, + { "DDP DIS", 3, SPEC_CTRL_DDP_DIS_U }, + { "BHI DIS", 4, SPEC_CTRL_BHI_DIS_S }, + }; + unsigned int i; + uint32_t regs[4]; + + cpuid_count(7, 2, ®s[0], ®s[1], ®s[2], ®s[3]); + + for ( i =3D 0; i < ARRAY_SIZE(tests); i++ ) + { + if ( !test_bit(tests[i].feat, ®s[3]) ) + continue; + + printk("Testing %s\n", tests[i].name); + test_loop(tests[i].mask); + } + + xtf_success(NULL); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ --=20 2.43.0