From nobody Mon Feb 9 21:12:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1705014833; cv=none; d=zohomail.com; s=zohoarc; b=Wlx/UmZr4nS26XRXzCRJHb2G35/6a10XGyzB7KWbT3vJR+dWRCd+Dyqohaj0bRXn9tBBShCHODoKs3+4Art6p5hlafMJaXS0d8Lrr8qDBfzUqoKEjmVy/LimAg98Y5kqmU7A43tJhr73VfjdcsOGAz3w3U5DR6VnmTCAg6ck/C8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705014833; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tQBG4Wv9YHRXR3l5NRi4xR48jlF7kee7EW5QxQr4nfU=; b=dX3Si8PQaNa3P/bBe/zPRxE5C+9aASQ8n3HCNIrDVbn2aI5tQEKUxDCGJsYz1gItKREAjxpyWFXnDMvgETFl/QsU2vegCRbQgXf+OfzytBtkgdlld89o3kNubZOoE8uG4URgpqSFjEsDDiw+sHI3zX77SFYsSgZtY7B9r2MzgZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1705014833306725.4989370012945; Thu, 11 Jan 2024 15:13:53 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.666556.1037283 (Exim 4.92) (envelope-from ) id 1rO4Ez-0006vq-F3; Thu, 11 Jan 2024 23:13:37 +0000 Received: by outflank-mailman (output) from mailman id 666556.1037283; Thu, 11 Jan 2024 23:13:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rO4Ez-0006vh-B5; Thu, 11 Jan 2024 23:13:37 +0000 Received: by outflank-mailman (input) for mailman id 666556; Thu, 11 Jan 2024 23:13:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rO4Ey-0006Rc-1v for xen-devel@lists.xenproject.org; Thu, 11 Jan 2024 23:13:36 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0aa9a961-b0d7-11ee-98f0-6d05b1d4d9a1; Fri, 12 Jan 2024 00:13:35 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aa9a961-b0d7-11ee-98f0-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1705014815; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Dpm9/S8+MidX9muncwSRV0Kdv7DqGRwPQQ3rsiXm2ss=; b=A2Hq6fhnxWtyZKxgi9k2Mnh38zkg9o/VLmgUH/TQLFNrrjTLdeEWhO3V QFVeP8IJCO+/MWbf4syOpAktBrmrCK6Ucn/O90OHaCXdP/FEk/y2otX6/ +k+gg9eHf/WZqY2/pkSAWXhEe+6G1PeGXW4kUCQmlW/7SmkOJNB4Dwxu6 Y=; X-CSE-ConnectionGUID: uyTfX/LfTRC34w9FxF0y2A== X-CSE-MsgGUID: KuJK4YPoTpmmr6ZKUJK6Ug== Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 129351772 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.159.70 X-Policy: $RELAYED X-ThreatScanner-Verdict: Negative IronPort-Data: A9a23:hiCaa6M1vRya2FnvrR3ml8FynXyQoLVcMsEvi/4bfWQNrUoj3jIBx jQZUG2GM66KM2T9L9l+OY2/8EoBvJTcx4JhGwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CQ6jefQAOOkVIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/7rRC9H5qyo5GtB5wVmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vtmPW9+s tgWFAomNUyc1sym7uqqEMA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEOHwwNHwsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9I4bbHpgMwRnCz o7A10fkIDJGBeSY9SKA92jytMzyvwClZY1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFamlBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6cLqScCj wHT2YmzXHo27ezTFir1GqqoQS2aJDkpI19FQSE4dyBev8ayjpEd1gOVZ4M2eEKqteEZCQ0c0 hjT83Bi3uRL05JWv5hX62wrlN5Fm3QocuLWzl+ONo5dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt 2Uels6V4YgmVM7VyHXcGrVSRer4u55p1QEwZnY2QvEcG8mFoSb/Lei8HhkiTKuWDir0UWCwO xKC0e+gzJRSIGGrfcdKj3GZUqwXIVzbPY29DJj8N4MeCqWdgSfbpEmCk2bMhTGy+KXt+IljU aqmnTGEVC1KUfU+nWDsF4/wE9YDn0gD+I8afrijpzzP7FZUTCf9pWstWLdWUt0E0Q== IronPort-HdrOrdr: A9a23:SOIL+6yNIcKRI8tNSK7GKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA== X-Talos-CUID: 9a23:8o3Xem6ci53tkW0aJtss6V8oFPBiVnPh9lyLf1DpJ3ZHEKzPYArF X-Talos-MUID: =?us-ascii?q?9a23=3AhCUvqwwVwFluFiha55BoNTkwbv+aqIezKmNRoK0?= =?us-ascii?q?Bh9GBMDYuCRSgrhfpf4Byfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.04,187,1695700800"; d="scan'208";a="129351772" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap Subject: [PATCH v2 1/3] x86/vmx: Collect all emtpy VMExit cases together Date: Thu, 11 Jan 2024 23:13:21 +0000 Message-ID: <20240111231323.4043461-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240111231323.4043461-1-andrew.cooper3@citrix.com> References: <20240111231323.4043461-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1705014835238100001 ... rather than having them spread out. Explain consicely why each is empt= y. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu CC: George Dunlap v2: * New. --- xen/arch/x86/hvm/vmx/vmx.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 8ff675883c2b..829c27f1fa33 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4374,9 +4374,7 @@ void asmlinkage vmx_vmexit_handler(struct cpu_user_re= gs *regs) } break; } - case EXIT_REASON_EXTERNAL_INTERRUPT: - /* Already handled above. */ - break; + case EXIT_REASON_TRIPLE_FAULT: hvm_triple_fault(); break; @@ -4539,9 +4537,6 @@ void asmlinkage vmx_vmexit_handler(struct cpu_user_re= gs *regs) hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; =20 - case EXIT_REASON_TPR_BELOW_THRESHOLD: - break; - case EXIT_REASON_APIC_ACCESS: if ( !vmx_handle_eoi_write() && !handle_mmio() ) hvm_inject_hw_exception(X86_EXC_GP, 0); @@ -4680,15 +4675,6 @@ void asmlinkage vmx_vmexit_handler(struct cpu_user_r= egs *regs) vmx_handle_descriptor_access(exit_reason); break; =20 - case EXIT_REASON_BUS_LOCK: - /* - * Nothing to do: just taking a vmexit should be enough of a pause= to - * prevent a VM from crippling the host with bus locks. Note - * EXIT_REASON_BUS_LOCK will always have bit 26 set in exit_reason= , and - * hence the perf counter is already increased. - */ - break; - case EXIT_REASON_NOTIFY: __vmread(EXIT_QUALIFICATION, &exit_qualification); =20 @@ -4705,6 +4691,11 @@ void asmlinkage vmx_vmexit_handler(struct cpu_user_r= egs *regs) =20 break; =20 + case EXIT_REASON_EXTERNAL_INTERRUPT: /* Handled earlier */ + case EXIT_REASON_TPR_BELOW_THRESHOLD: /* Handled later in vmx_intr_ass= ist() */ + case EXIT_REASON_BUS_LOCK: /* Nothing to do (rate-limit onl= y) */ + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ --=20 2.30.2