From nobody Mon May 13 00:49:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1701445607; cv=pass; d=zohomail.com; s=zohoarc; b=C+k7kDjy4HLuCRf1fZxE3kT3IPDFjfNTK1Af3+acTIdfEaHdum7mp8BqwX/TtDeXz9EeJQjyy+8LdT+xttUnFSFz0DtTwg9WMEW+VByvdiDYz7+MpvY6kmQ396xSSoawT9DV/+BUb4/OcIWV0MsjoJjUYo5NGZPO3Mfrp2FhHms= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701445607; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZDImNmQvmow/A3Kv7ezsy4crKxW4vHq4MtXRtyPI1zY=; b=GyeyJkBZ2N3BkxOxBh10Uuf/Ksv6Nydb0ajT39pQqs9O2KcVaGGf7P8RnJz5Ysp6GIPfEbLxLmcJc5eGLTuRaSmfHnBQxzBJmL+b0iEwNTCRsJaR0p6tf9ruWa3D6cXngGN7kbXmdGzIbD/f8OuF8vIR80WF9h60eiXqfxf3ezw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1701445607032751.0997934312841; Fri, 1 Dec 2023 07:46:47 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.645609.1007806 (Exim 4.92) (envelope-from ) id 1r95ii-0005nQ-N8; Fri, 01 Dec 2023 15:46:24 +0000 Received: by outflank-mailman (output) from mailman id 645609.1007806; Fri, 01 Dec 2023 15:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r95ii-0005nF-KF; Fri, 01 Dec 2023 15:46:24 +0000 Received: by outflank-mailman (input) for mailman id 645609; Fri, 01 Dec 2023 15:46:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r95ig-0005mO-Js for xen-devel@lists.xenproject.org; Fri, 01 Dec 2023 15:46:22 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062e.outbound.protection.outlook.com [2a01:111:f400:7e8a::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3e81cd0-9060-11ee-9b0f-b553b5be7939; Fri, 01 Dec 2023 16:46:18 +0100 (CET) Received: from CY8P220CA0011.NAMP220.PROD.OUTLOOK.COM (2603:10b6:930:46::28) by SJ0PR12MB5471.namprd12.prod.outlook.com (2603:10b6:a03:300::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Fri, 1 Dec 2023 15:46:14 +0000 Received: from CY4PEPF0000EDD1.namprd03.prod.outlook.com (2603:10b6:930:46:cafe::e0) by CY8P220CA0011.outlook.office365.com (2603:10b6:930:46::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.29 via Frontend Transport; Fri, 1 Dec 2023 15:46:14 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EDD1.mail.protection.outlook.com (10.167.241.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Fri, 1 Dec 2023 15:46:13 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 09:46:13 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 09:46:13 -0600 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Fri, 1 Dec 2023 09:46:11 -0600 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3e81cd0-9060-11ee-9b0f-b553b5be7939 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jaYmsDq8gM0H/336UPukUvxuKiLdl+YX2ybIYdN9PHhoVehQlS51bjThInv4eiZWQGbdettkFpdl9BQ/cEE1weWHqJ6+X8eQUE7PTWelT1ApCmX8146Asl+ec3z5PgQ6jGRiBiF4B/ndRdKh+TOcpZzp386OXRLK7/YUTNoGPv4FHL5eV+grASlTQr6LW3aQgDPUtmuuP3rDBlIR80kkbxrf1FMZYogjnhFymx2hJK4GVO45MfsE6NIvGq13W67AWyS/t9FpEmbH4tFtPxDb8yULjaAlFue/+HWw2vipLx8D1m45degxrxLTfODYeYrYPegLjthVMXbSoTa7Sx5yJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZDImNmQvmow/A3Kv7ezsy4crKxW4vHq4MtXRtyPI1zY=; b=TJeJAR9lnq9g/UpXmExoBPnZ4H9owrrHoZbre9M/NuHZ+ypswddJZXOd11LLWNIFkiZYesFrRDfjjWZVbRYIy/thhA3lUtFiHvjo8ISiI9fY82BCUt+jcnDj4JIs1cDkAoZRsLKv48TDwBK+IHbTcSC9qQozK+TIb+XxX6vIeTAqLAtF+UrAw+dgGkE5pxVkJTst96wO3uAYzXL6q1/yGcIomJNq7uJTPTgKXURzYBENjkoHRAc5MpJ3DcRINHGHRY/qq3vnZUVdFjL5Yer9TxZ3aRahxaadjnxQ95+aezRgtmSYQJxpo8Hp67bOpo/9beP7/NeCckd2wMQjECObWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZDImNmQvmow/A3Kv7ezsy4crKxW4vHq4MtXRtyPI1zY=; b=mupsIUX6tFN5/9C2XuoezkscgvIurPBnFMhTtYf7gyx/fpHm8+F3L/gwGPh2cB7nAOR13nduUPxS6M8865HYVUHPQJ8Tz1u7UR2U+ybx1XGEJWlBf6/Ihf4nNCfhrO2XreioCNWUb3dcRh3TdIoUcoa68f8YFmT1TxVn3s8TSf0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" Subject: [PATCH v9 1/2] xen/vpci: header: status register handler Date: Fri, 1 Dec 2023 10:45:49 -0500 Message-ID: <20231201154552.3066321-2-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231201154552.3066321-1-stewart.hildebrand@amd.com> References: <20231201154552.3066321-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD1:EE_|SJ0PR12MB5471:EE_ X-MS-Office365-Filtering-Correlation-Id: 83055f4a-11e6-49d7-b1c1-08dbf284a625 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TJ3gZz1uLUtsiMUFbq6o/9OaLs48CAJQC+bE8GmAlNjTVzRdYjvrj0uhba/ZOYQib+HpKuNVZibRADiDJI+mMhEpGVozvJE1MXqehTUzW3wjpeR8PkfXAt8ZDK6F3SKaYsMgLnzUMHk34L37LjEetrIMFaGEPKEMqd8mA9OBBNzJFY3BP6tJTA8FamPeFdpROXiwhDLtPINMoNy2ZsE9SE45vQ1E4Azu0NPLSpaJcOl2BwUSmPMQLCJzgsTdGZiSt0POtDZcrAuq+phNDeQBAk0H0uT5RBdCo+xc8UeBejpsvZqy474M8PVK9WWLBng6iVEgqZbHJNaPaOWEs6HRK7Cg3hSxBZjTgnEvNsmXlnsvh8tGTa0Hf1e8IvnImxO5BYbLqnUcj3XdyfTAgSEjdTFqkSlvf5osH6op+2Ii0p4GTyaCJSggHPkpCoh6JkuSmmv7rKQuTUpLQBkiIJAJRFsWZUqcddrM2FjpENI8WCYsyqqOfeLEWz9znoMA0LhYWLfHwRR6kzGERhCwQBtnwbqCradL/otBmz/5DliQh5M8A1QFLA/hHIxKrWkMQyUaVbWHSlxe34cmoLZiPuLVx9su20h4ncv5M4BfcQxp8JVVrYexJdEzh4fOds0woAfXLf7w5q7V2py+UwlwNXEn/bbfS8b6mHe1+NBk2cgq/kSAjPgwSgMJI1FnUsU4Vr2LfoUX3Mb0HqCcfm5r4FaonSDkitmih+U7pNz37Dv823/eMG+slFSQkmzCsVRkvurVLSMa9BcQcYL1TVBomwNskg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(396003)(136003)(346002)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(82310400011)(46966006)(40470700004)(36840700001)(478600001)(356005)(426003)(336012)(316002)(81166007)(36756003)(70206006)(70586007)(4326008)(6916009)(1076003)(40460700003)(8936002)(8676002)(26005)(54906003)(66899024)(2616005)(19627235002)(966005)(82740400003)(6666004)(5660300002)(2906002)(30864003)(47076005)(40480700001)(36860700001)(86362001)(44832011)(83380400001)(41300700001)(36900700001)(357404004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 15:46:13.9212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83055f4a-11e6-49d7-b1c1-08dbf284a625 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5471 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1701445608426000003 Content-Type: text/plain; charset="utf-8" Introduce a handler for the PCI status register, with ability to mask the capabilities bit. The status register contains RsvdZ bits, read-only bits, and write-1-to-clear bits. Additionally, we use RsvdP to mask the capabilities bit. Introduce bitmasks to handle these in vPCI. If a bit in the bitmask is set, then the special meaning applies: ro_mask: read normal, guest write ignore (preserve on write to hardware) rw1c_mask: read normal, write 1 to clear rsvdp_mask: read as zero, guest write ignore (preserve on write to hardwa= re) rsvdz_mask: read as zero, guest write ignore (write zero to hardware) The RO/RW1C/RsvdP/RsvdZ naming and definitions were borrowed from the PCI Express Base 6.1 specification. RsvdP/RsvdZ bits help Xen enforce our view of the world. Xen preserves the value of read-only bits on write to hardware, discarding the guests write value. This is done in case hardware wrongly implements R/O bits as R/W. The mask_cap_list flag will be set in a follow-on patch. Signed-off-by: Stewart Hildebrand Reviewed-by: Roger Pau Monn=C3=A9 --- v8->v9: * check that masks don't have bits set above register size * rename variable in vpci_write_helper() * only export one vpci_add_register* function, make the other one static in= line * style fixups v7->v8: * move PCI_STATUS_UDF to rsvdz_mask (per PCI Express Base 6 spec) * add support for rsvdp bits * add tests for ro/rw1c/rsvdp/rsvdz bits in tools/tests/vpci/main.c * dropped R-b tag [1] since the patch has changed moderately since the last= rev [1] https://lists.xenproject.org/archives/html/xen-devel/2023-09/msg00909.h= tml v6->v7: * re-work args passed to vpci_add_register_mask() (called in init_bars()) * also check for overlap of (rsvdz_mask & ro_mask) in add_register() * slightly adjust masking operation in vpci_write_helper() v5->v6: * remove duplicate PCI_STATUS_CAP_LIST in constant definition * style fixup in constant definitions * s/res_mask/rsvdz_mask/ * combine a new masking operation into single line * preserve r/o bits on write * get rid of status_read. Instead, use rsvdz_mask for conditionally masking PCI_STATUS_CAP_LIST bit * add comment about PCI_STATUS_CAP_LIST and rsvdp behavior * add sanity checks in add_register * move mask_cap_list from struct vpci_header to local variable v4->v5: * add support for res_mask * add support for ro_mask (squash ro_mask patch) * add constants for reserved, read-only, and rw1c masks v3->v4: * move mask_cap_list setting to the capabilities patch * single pci_conf_read16 in status_read * align mask_cap_list bitfield in struct vpci_header * change to rw1c bit mask instead of treating whole register as rw1c * drop subsystem prefix on renamed add_register function v2->v3: * new patch --- tools/tests/vpci/main.c | 111 +++++++++++++++++++++++++++++++++++++ xen/drivers/vpci/header.c | 12 ++++ xen/drivers/vpci/vpci.c | 52 ++++++++++++----- xen/include/xen/pci_regs.h | 9 +++ xen/include/xen/vpci.h | 24 ++++++-- 5 files changed, 189 insertions(+), 19 deletions(-) diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c index b9a0a6006bb9..64d4552936c7 100644 --- a/tools/tests/vpci/main.c +++ b/tools/tests/vpci/main.c @@ -70,6 +70,28 @@ static void vpci_write32(const struct pci_dev *pdev, uns= igned int reg, *(uint32_t *)data =3D val; } =20 +struct mask_data { + uint32_t val; + uint32_t rw1c_mask; +}; + +static uint32_t vpci_read32_mask(const struct pci_dev *pdev, unsigned int = reg, + void *data) +{ + const struct mask_data *md =3D data; + + return md->val; +} + +static void vpci_write32_mask(const struct pci_dev *pdev, unsigned int reg, + uint32_t val, void *data) +{ + struct mask_data *md =3D data; + + md->val =3D val | (md->val & md->rw1c_mask); + md->val &=3D ~(val & md->rw1c_mask); +} + #define VPCI_READ(reg, size, data) ({ \ data =3D vpci_read((pci_sbdf_t){ .sbdf =3D 0 }, reg, size); \ }) @@ -94,9 +116,21 @@ static void vpci_write32(const struct pci_dev *pdev, un= signed int reg, assert(!vpci_add_register(test_pdev.vpci, fread, fwrite, off, size, = \ &store)) =20 +#define VPCI_ADD_REG_MASK(fread, fwrite, off, size, store, = \ + ro_mask, rw1c_mask, rsvdp_mask, rsvdz_mask) = \ + assert(!vpci_add_register_mask(test_pdev.vpci, fread, fwrite, off, siz= e, \ + &store, = \ + ro_mask, rw1c_mask, rsvdp_mask, rsvdz_m= ask)) + #define VPCI_ADD_INVALID_REG(fread, fwrite, off, size) = \ assert(vpci_add_register(test_pdev.vpci, fread, fwrite, off, size, NUL= L)) =20 +#define VPCI_ADD_INVALID_REG_MASK(fread, fwrite, off, size, = \ + ro_mask, rw1c_mask, rsvdp_mask, rsvdz_ma= sk) \ + assert(vpci_add_register_mask(test_pdev.vpci, fread, fwrite, off, size= , \ + NULL, ro_mask, rw1c_mask, rsvdp_mask, = \ + rsvdz_mask)) + #define VPCI_REMOVE_REG(off, size) = \ assert(!vpci_remove_register(test_pdev.vpci, off, size)) =20 @@ -154,6 +188,7 @@ main(int argc, char **argv) uint16_t r20[2] =3D { }; uint32_t r24 =3D 0; uint8_t r28, r30; + struct mask_data r32; unsigned int i; int rc; =20 @@ -213,6 +248,24 @@ main(int argc, char **argv) /* Try to add a register with missing handlers. */ VPCI_ADD_INVALID_REG(NULL, NULL, 8, 2); =20 + /* Try to add registers with the same bits set in multiple masks. */ + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 1, 1, 0, 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 1, 0, 1, 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 1, 0, 0, 1); + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 0, 1, 1, 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 0, 1, 0, 1); + VPCI_ADD_INVALID_REG_MASK(vpci_read32, vpci_write32, 8, 4, 0, 0, 1, 1); + + /* Try to add registers with mask bits set beyond the register size */ + VPCI_ADD_INVALID_REG_MASK(vpci_read8, vpci_write8, 8, 1, 0x100U, 0, 0,= 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read8, vpci_write8, 8, 1, 0, 0x100U, 0,= 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read8, vpci_write8, 8, 1, 0, 0, 0x100U,= 0); + VPCI_ADD_INVALID_REG_MASK(vpci_read8, vpci_write8, 8, 1, 0, 0, 0, 0x10= 0U); + VPCI_ADD_INVALID_REG_MASK(vpci_read16, vpci_write16, 8, 2, 0x10000U,0,= 0,0); + VPCI_ADD_INVALID_REG_MASK(vpci_read16, vpci_write16, 8, 2, 0,0x10000U,= 0,0); + VPCI_ADD_INVALID_REG_MASK(vpci_read16, vpci_write16, 8, 2, 0,0,0x10000= U,0); + VPCI_ADD_INVALID_REG_MASK(vpci_read16, vpci_write16, 8, 2, 0,0,0,0x100= 00U); + /* Read/write of unset register. */ VPCI_READ_CHECK(8, 4, 0xffffffff); VPCI_READ_CHECK(8, 2, 0xffff); @@ -287,6 +340,64 @@ main(int argc, char **argv) VPCI_ADD_REG(vpci_read8, vpci_write8, 30, 1, r30); VPCI_WRITE_CHECK(28, 4, 0xffacffdc); =20 + /* + * Test ro/rw1c/rsvdp/rsvdz masks. + * + * 32 24 16 8 0 + * +------+------+------+------+ + * |rsvdz |rsvdp | rw1c | ro | 32 + * +------+------+------+------+ + * + */ + r32.rw1c_mask =3D 0x0000ff00U; + VPCI_ADD_REG_MASK(vpci_read32_mask, vpci_write32_mask, 32, 4, r32, + 0x000000ffU /* RO */, + r32.rw1c_mask /* RW1C */, + 0x00ff0000U /* RsvdP */, + 0xff000000U /* RsvdZ */); + + /* ro */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(32, 1, 0x0f); + VPCI_WRITE(32, 1, 0x5a); + VPCI_READ_CHECK(32, 1, 0x0f); + assert(r32.val =3D=3D 0x000f0f0fU); + + /* rw1c */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(33, 1, 0x0f); + VPCI_WRITE(33, 1, 0x5a); + VPCI_READ_CHECK(33, 1, 0x05); + assert(r32.val =3D=3D 0x000f050fU); + + /* rsvdp */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(34, 1, 0); + VPCI_WRITE(34, 1, 0x5a); + VPCI_READ_CHECK(34, 1, 0); + assert(r32.val =3D=3D 0x000f0f0fU); + + /* rsvdz */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(35, 1, 0); + VPCI_WRITE(35, 1, 0x5a); + VPCI_READ_CHECK(35, 1, 0); + assert(r32.val =3D=3D 0x000f0f0fU); + + /* write all 0's */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(32, 4, 0x00000f0fU); + VPCI_WRITE(32, 4, 0); + VPCI_READ_CHECK(32, 4, 0x00000f0fU); + assert(r32.val =3D=3D 0x000f0f0fU); + + /* write all 1's */ + r32.val =3D 0x0f0f0f0fU; + VPCI_READ_CHECK(32, 4, 0x00000f0fU); + VPCI_WRITE(32, 4, 0xffffffffU); + VPCI_READ_CHECK(32, 4, 0x0000000fU); + assert(r32.val =3D=3D 0x000f000fU); + /* Finally try to remove a couple of registers. */ VPCI_REMOVE_REG(28, 1); VPCI_REMOVE_REG(24, 4); diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 767c1ba718d7..351318121e48 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -521,6 +521,7 @@ static int cf_check init_bars(struct pci_dev *pdev) struct vpci_header *header =3D &pdev->vpci->header; struct vpci_bar *bars =3D header->bars; int rc; + bool mask_cap_list =3D false; =20 switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f ) { @@ -544,6 +545,17 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( rc ) return rc; =20 + /* Utilize rsvdp_mask to hide PCI_STATUS_CAP_LIST from the guest. */ + rc =3D vpci_add_register_mask(pdev->vpci, vpci_hw_read16, vpci_hw_writ= e16, + PCI_STATUS, 2, NULL, + PCI_STATUS_RO_MASK & + ~(mask_cap_list ? PCI_STATUS_CAP_LIST = : 0), + PCI_STATUS_RW1C_MASK, + mask_cap_list ? PCI_STATUS_CAP_LIST : 0, + PCI_STATUS_RSVDZ_MASK); + if ( rc ) + return rc; + if ( pdev->ignore_bars ) return 0; =20 diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 3bec9a4153da..d569f596a4c3 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -29,6 +29,10 @@ struct vpci_register { unsigned int offset; void *private; struct list_head node; + uint32_t ro_mask; + uint32_t rw1c_mask; + uint32_t rsvdp_mask; + uint32_t rsvdz_mask; }; =20 #ifdef __XEN__ @@ -145,9 +149,17 @@ uint32_t cf_check vpci_hw_read32( return pci_conf_read32(pdev->sbdf, reg); } =20 -int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler, - vpci_write_t *write_handler, unsigned int offset, - unsigned int size, void *data) +void cf_check vpci_hw_write16( + const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) +{ + pci_conf_write16(pdev->sbdf, reg, val); +} + +int vpci_add_register_mask(struct vpci *vpci, vpci_read_t *read_handler, + vpci_write_t *write_handler, unsigned int offse= t, + unsigned int size, void *data, uint32_t ro_mask, + uint32_t rw1c_mask, uint32_t rsvdp_mask, + uint32_t rsvdz_mask) { struct list_head *prev; struct vpci_register *r; @@ -155,7 +167,14 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *= read_handler, /* Some sanity checks. */ if ( (size !=3D 1 && size !=3D 2 && size !=3D 4) || offset >=3D PCI_CFG_SPACE_EXP_SIZE || (offset & (size - 1)) || - (!read_handler && !write_handler) ) + (!read_handler && !write_handler) || (ro_mask & rw1c_mask) || + (ro_mask & rsvdp_mask) || (ro_mask & rsvdz_mask) || + (rw1c_mask & rsvdp_mask) || (rw1c_mask & rsvdz_mask) || + (rsvdp_mask & rsvdz_mask) ) + return -EINVAL; + + if ( size !=3D 4 && + ((ro_mask | rw1c_mask | rsvdp_mask | rsvdz_mask) >> (8 * size)) ) return -EINVAL; =20 r =3D xmalloc(struct vpci_register); @@ -167,6 +186,10 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *= read_handler, r->size =3D size; r->offset =3D offset; r->private =3D data; + r->ro_mask =3D ro_mask; + r->rw1c_mask =3D rw1c_mask; + r->rsvdp_mask =3D rsvdp_mask; + r->rsvdz_mask =3D rsvdz_mask; =20 spin_lock(&vpci->lock); =20 @@ -376,6 +399,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, u= nsigned int size) } =20 val =3D r->read(pdev, r->offset, r->private); + val &=3D ~(r->rsvdp_mask | r->rsvdz_mask); =20 /* Check if the read is in the middle of a register. */ if ( r->offset < emu.offset ) @@ -407,26 +431,26 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,= unsigned int size) =20 /* * Perform a maybe partial write to a register. - * - * Note that this will only work for simple registers, if Xen needs to - * trap accesses to rw1c registers (like the status PCI header register) - * the logic in vpci_write will have to be expanded in order to correctly - * deal with them. */ static void vpci_write_helper(const struct pci_dev *pdev, const struct vpci_register *r, unsigned int = size, unsigned int offset, uint32_t data) { + uint32_t curval =3D 0; + uint32_t preserved_mask =3D r->ro_mask | r->rsvdp_mask; + ASSERT(size <=3D r->size); =20 - if ( size !=3D r->size ) + if ( (size !=3D r->size) || preserved_mask ) { - uint32_t val; - - val =3D r->read(pdev, r->offset, r->private); - data =3D merge_result(val, data, size, offset); + curval =3D r->read(pdev, r->offset, r->private); + curval &=3D ~r->rw1c_mask; + data =3D merge_result(curval, data, size, offset); } =20 + data &=3D ~(preserved_mask | r->rsvdz_mask); + data |=3D curval & preserved_mask; + r->write(pdev, r->offset, data & (0xffffffffU >> (32 - 8 * r->size)), r->private); } diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index 84b18736a85d..9909b27425a5 100644 --- a/xen/include/xen/pci_regs.h +++ b/xen/include/xen/pci_regs.h @@ -66,6 +66,15 @@ #define PCI_STATUS_REC_MASTER_ABORT 0x2000 /* Set on master abort */ #define PCI_STATUS_SIG_SYSTEM_ERROR 0x4000 /* Set when we drive SERR */ #define PCI_STATUS_DETECTED_PARITY 0x8000 /* Set on parity error */ +#define PCI_STATUS_RSVDZ_MASK 0x0046 /* Includes PCI_STATUS_UDF */ + +#define PCI_STATUS_RO_MASK (PCI_STATUS_IMM_READY | PCI_STATUS_INTERRUPT |= \ + PCI_STATUS_CAP_LIST | PCI_STATUS_66MHZ | PCI_STATUS_FAST_BACK | \ + PCI_STATUS_DEVSEL_MASK) +#define PCI_STATUS_RW1C_MASK (PCI_STATUS_PARITY | \ + PCI_STATUS_SIG_TARGET_ABORT | PCI_STATUS_REC_TARGET_ABORT | \ + PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_SIG_SYSTEM_ERROR | \ + PCI_STATUS_DETECTED_PARITY) =20 #define PCI_CLASS_REVISION 0x08 /* High 24 bits are class, low 8 revision = */ #define PCI_REVISION_ID 0x08 /* Revision ID */ diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index d743d96a10b8..85c52a1ebac7 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -32,11 +32,23 @@ int __must_check vpci_add_handlers(struct pci_dev *pdev= ); void vpci_remove_device(struct pci_dev *pdev); =20 /* Add/remove a register handler. */ -int __must_check vpci_add_register(struct vpci *vpci, - vpci_read_t *read_handler, - vpci_write_t *write_handler, - unsigned int offset, unsigned int size, - void *data); +int __must_check vpci_add_register_mask(struct vpci *vpci, + vpci_read_t *read_handler, + vpci_write_t *write_handler, + unsigned int offset, unsigned int = size, + void *data, uint32_t ro_mask, + uint32_t rw1c_mask, uint32_t rsvdp= _mask, + uint32_t rsvdz_mask); +static inline int __must_check vpci_add_register(struct vpci *vpci, + vpci_read_t *read_handler, + vpci_write_t *write_handl= er, + unsigned int offset, + unsigned int size, void *= data) +{ + return vpci_add_register_mask(vpci, read_handler, write_handler, offse= t, + size, data, 0, 0, 0, 0); +} + int __must_check vpci_remove_register(struct vpci *vpci, unsigned int offs= et, unsigned int size); =20 @@ -50,6 +62,8 @@ uint32_t cf_check vpci_hw_read16( const struct pci_dev *pdev, unsigned int reg, void *data); uint32_t cf_check vpci_hw_read32( const struct pci_dev *pdev, unsigned int reg, void *data); +void cf_check vpci_hw_write16( + const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data= ); =20 /* * Check for pending vPCI operations on this vcpu. Returns true if the vcpu --=20 2.43.0 From nobody Mon May 13 00:49:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1701445610; cv=pass; d=zohomail.com; s=zohoarc; b=UtOI1ibX1mf8KyX506fROtr3fuvEVtfF7PKEpaaRrdFm5xaj3P5uBR7ubeivmwP72/kh5fLJfeHdJGmTUOi7R0YTeZQVyENsVe7vhJYPfwj5sveCib38qqfFb/M0mrHjiyxyB/5y+jHV6kUKIlNX2oUdmA27rqo5glB3uZt3Aso= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701445610; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3rDW8TKwJYFddUpSjwpZw1tdKMfC4BlAOpTAFnwuQrg=; b=R3BXBSJMy5ycnqaAdyg8cYsLT8ZLY5RTRbrn7UXD8ZH3K3sc05Mk9SzFW4w6qhb6S4o8PSt5t48nPaAVabaG6d3y08fFI7UHlB0CCpb8kRBxo7ghiASXJ4Kpsu+UBytejYyZ+6JsDw/nNcjDAkhG5BFntPSkLVK60LriQKQ2+jw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 170144561057587.69267206743064; Fri, 1 Dec 2023 07:46:50 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.645610.1007815 (Exim 4.92) (envelope-from ) id 1r95is-0006BA-4M; Fri, 01 Dec 2023 15:46:34 +0000 Received: by outflank-mailman (output) from mailman id 645610.1007815; Fri, 01 Dec 2023 15:46:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r95is-0006B3-1a; Fri, 01 Dec 2023 15:46:34 +0000 Received: by outflank-mailman (input) for mailman id 645610; Fri, 01 Dec 2023 15:46:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r95iq-0005mO-MK for xen-devel@lists.xenproject.org; Fri, 01 Dec 2023 15:46:32 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20612.outbound.protection.outlook.com [2a01:111:f400:7e88::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb527ef3-9060-11ee-9b0f-b553b5be7939; Fri, 01 Dec 2023 16:46:30 +0100 (CET) Received: from MN2PR02CA0036.namprd02.prod.outlook.com (2603:10b6:208:fc::49) by BN9PR12MB5384.namprd12.prod.outlook.com (2603:10b6:408:105::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.27; Fri, 1 Dec 2023 15:46:27 +0000 Received: from BL6PEPF0001AB77.namprd02.prod.outlook.com (2603:10b6:208:fc:cafe::b6) by MN2PR02CA0036.outlook.office365.com (2603:10b6:208:fc::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23 via Frontend Transport; Fri, 1 Dec 2023 15:46:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB77.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Fri, 1 Dec 2023 15:46:26 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 09:46:26 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 09:46:25 -0600 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Fri, 1 Dec 2023 09:46:24 -0600 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb527ef3-9060-11ee-9b0f-b553b5be7939 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D0KOgS8egHPfQTV2UewXgY9J722V3x2i/YZ/SIfwAj71rVe4aiZyO1h5INdI9mufKiJSjpeuE3GhFMcVVED83i/yuDO18eVa5glxXPUTB7Wz/krScCjqi+jN9h7UJg7gp9DsoqhCUoWVUFrlqdGN6wKv10rpo/Dn8qyu8mI4KhlPrCv9P8bdoBMGTQ+ztjyi5TnVo2DReRl6MDSfmKNdsmJ0DvLY/q0bZyJ227vl63jocBRp9QFYy3Y+S++1fyC1EjuWJpxmDUpo9ysC97k5a0SDqAmDyx7F5etNdFfrs5xGI7pFFtSbGp6NhNY7UT+FbAsSUKq6ZFYpk1Oy5SSuCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3rDW8TKwJYFddUpSjwpZw1tdKMfC4BlAOpTAFnwuQrg=; b=lU6MqkdtNQHGGCknJFmO1YYskMfyr5rrd0KomhbcmYfHh5PwZNOMGR5ZGMNX6sTPP/QDAHzVrrgDxlSQ1qedeXDJRAsu0yVE78OIQ7ElKA5oXc5MTIUgUVW2L+Sh9QNEyR2ZxXy9VgSDsBPWz2KTOSZ85JPh8gO+JkZmCvCecAPLLx8ZBHAiBo3cCmx4e4WBTXbHSBqjtIp11smujjz3blUoUZcOTDJE+227bu/PNcChL36uF67hKNPubYNy6JvwYSCzbVdvuXoNEPH9wJQsECfKO0JSdwig5UAdfzWn+tUcaSGPf/3qpfWVF8QIe8cC56oj4EmpA7AtSlwNYMFxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3rDW8TKwJYFddUpSjwpZw1tdKMfC4BlAOpTAFnwuQrg=; b=eiy+8h3r995brPcv9YOni6X5chbk5TbOmO8sJPTdlOhRb1acRQdNkP8+EE3RR1JiQ7hAxnp5Fki6/O4N1okVBzOC4lSUOXBPSq0rHs7eGymb5IUcNNcBMETf5prrops05d5Qvjm375kEXbEhXaOSG9d2OUmTOrnsEXQaAMLd6oE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v9 2/2] xen/vpci: header: filter PCI capabilities Date: Fri, 1 Dec 2023 10:45:50 -0500 Message-ID: <20231201154552.3066321-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231201154552.3066321-1-stewart.hildebrand@amd.com> References: <20231201154552.3066321-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB77:EE_|BN9PR12MB5384:EE_ X-MS-Office365-Filtering-Correlation-Id: 5583f7cb-54cb-4036-4100-08dbf284adc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kLGLqGEGcHPMLjFGap2eTEwdluUOpdVVEkC7pVfl3/0PK8tWd1wuS5TdEtEQDBeDvypcGEjAq50pisolWS7cE/69kJ633oUXSWctgyQkA0qy1Jk8Lzytz9+7wzHFm61ZgotbLym2gX7t4PnNu7LpNw3tQKZdlC0hqEz3zZkwkqV8PwD0TjrtB/88EJIvmy4DKm93vKEHLjGE6+75PwSWfRVG0HrMjaft3gTKyXmQ3XopkHMp0kGVDVzRt9ox8WibvYm7I3hxmiYHMrvXNcNxqA0kwACjYgrgYVDwGNSsngfjQGEi6V9ULu/OK/X8il8Neej0hsGhLdh/nxJ5YYNUrPhxV8yUqtVv/H4GdbXQapfgOd1yqj3zpTv10dti7AF6EzSZY+q2NMz5ChBSdzx+7nVa8XlZeZCvlG6XjeSNrtiyH/KmJTY7hbCCkZNFy42OvnXEXi4ShL/pqcpxcQBp9JR609KFG42S+zRbNQ1z4Odi26e9o0rp2pxbChh0sK0FQ05DJoB4IlISXKu1E2MB2aWmqFy7o9YczQZoWQ4ogNeronjwAiJpvHTVPkvMc7GMEggC62rM9sk5vgm+MRkjmYYgxi2Kb+EAWxaE84epvN58XFHdNBEmgRqumzl25CjmTMTzotvnNfgvE8DSYCAFHdZoElul8H7j/PLvd4E+C05AlD0XmbuDp4Pgy53mRPYmX2Eu9E5S61QtyWkHFzZY1eHxlSrLRW3r+0xFOyUkOQxNNgIBLKwplST8Gk8swuQMADtD7r3yk7EWGzDukrFEEA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(39860400002)(136003)(396003)(346002)(230922051799003)(1800799012)(82310400011)(451199024)(64100799003)(186009)(36840700001)(40470700004)(46966006)(36756003)(41300700001)(2906002)(5660300002)(44832011)(86362001)(40460700003)(1076003)(2616005)(40480700001)(6666004)(83380400001)(26005)(82740400003)(426003)(336012)(478600001)(356005)(47076005)(81166007)(36860700001)(4326008)(6916009)(54906003)(316002)(8936002)(70206006)(70586007)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 15:46:26.7251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5583f7cb-54cb-4036-4100-08dbf284adc0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB77.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5384 X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1701445611818000001 Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabiliti= es. Hide all other PCI capabilities (including extended capabilities) from domU= s for now, even though there may be certain devices/drivers that depend on being = able to discover certain capabilities. We parse the physical PCI capabilities linked list and add vPCI register handlers for the next elements, inserting our own next value, thus presenti= ng a modified linked list to the domU. Introduce helper functions vpci_hw_read8 and vpci_read_val. The vpci_read_v= al helper function returns a fixed value, which may be used for read as zero registers, or registers whose value doesn't change. Introduce pci_find_next_cap_ttl() helper while adapting the logic from pci_find_next_cap() to suit our needs, and implement the existing pci_find_next_cap() in terms of the new helper. Signed-off-by: Stewart Hildebrand Reviewed-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich --- v8->v9: * move local variable definitions inside loop in pci_find_next_cap_ttl() * constify supported_caps array and cap parameter of pci_find_next_cap_ttl() * add comment by vpci_read_val() helper * rename s/init_bars/init_header/ * add Roger's R-b tag v7->v8: * use to array instead of match function * include lib.h for ARRAY_SIZE * don't emulate PCI_CAPABILITY_LIST register if PCI_STATUS_CAP_LIST bit is = not set in hardware * spell out RAZ/WI acronym * dropped R-b tag since the patch has changed moderately since the last rev v6->v7: * no change v5->v6: * add register handlers before status register handler in init_bars() * s/header->mask_cap_list/mask_cap_list/ v4->v5: * use more appropriate types, continued * get rid of unnecessary hook function * add Jan's R-b v3->v4: * move mask_cap_list setting to this patch * leave pci_find_next_cap signature alone * use more appropriate types v2->v3: * get rid of > 0 in loop condition * implement pci_find_next_cap in terms of new pci_find_next_cap_ttl functio= n so that hypothetical future callers wouldn't be required to pass &ttl. * change NULL to (void *)0 for RAZ value passed to vpci_read_val * change type of ttl to unsigned int * remember to mask off the low 2 bits of next in the initial loop iteration * change return type of pci_find_next_cap and pci_find_next_cap_ttl * avoid wrapping the PCI_STATUS_CAP_LIST condition by using ! instead of = =3D=3D 0 v1->v2: * change type of ttl to int * use switch statement instead of if/else * adapt existing pci_find_next_cap helper instead of rolling our own * pass ttl as in/out * "pass through" the lower 2 bits of the next pointer * squash helper functions into this patch to avoid transient dead code situ= ation * extended capabilities RAZ/WI --- xen/drivers/pci/pci.c | 33 ++++++++++++------- xen/drivers/vpci/header.c | 67 +++++++++++++++++++++++++++++++++++++-- xen/drivers/vpci/vpci.c | 12 +++++++ xen/include/xen/pci.h | 3 ++ xen/include/xen/vpci.h | 6 ++++ 5 files changed, 108 insertions(+), 13 deletions(-) diff --git a/xen/drivers/pci/pci.c b/xen/drivers/pci/pci.c index 3569ccb24e9e..e6ccc86214ba 100644 --- a/xen/drivers/pci/pci.c +++ b/xen/drivers/pci/pci.c @@ -39,31 +39,42 @@ unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, unsig= ned int cap) return 0; } =20 -unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, - unsigned int cap) +unsigned int pci_find_next_cap_ttl(pci_sbdf_t sbdf, unsigned int pos, + const unsigned int *cap, unsigned int n, + unsigned int *ttl) { - u8 id; - int ttl =3D 48; - - while ( ttl-- ) + while ( (*ttl)-- ) { + unsigned int id, i; + pos =3D pci_conf_read8(sbdf, pos); if ( pos < 0x40 ) break; =20 - pos &=3D ~3; - id =3D pci_conf_read8(sbdf, pos + PCI_CAP_LIST_ID); + id =3D pci_conf_read8(sbdf, (pos & ~3) + PCI_CAP_LIST_ID); =20 if ( id =3D=3D 0xff ) break; - if ( id =3D=3D cap ) - return pos; + for ( i =3D 0; i < n; i++ ) + { + if ( id =3D=3D cap[i] ) + return pos; + } =20 - pos +=3D PCI_CAP_LIST_NEXT; + pos =3D (pos & ~3) + PCI_CAP_LIST_NEXT; } + return 0; } =20 +unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, + unsigned int cap) +{ + unsigned int ttl =3D 48; + + return pci_find_next_cap_ttl(sbdf, pos, &cap, 1, &ttl) & ~3; +} + /** * pci_find_ext_capability - Find an extended capability * @sbdf: PCI device to query diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 351318121e48..3be2e21cd925 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -18,6 +18,7 @@ */ =20 #include +#include #include #include #include @@ -513,7 +514,7 @@ static void cf_check rom_write( rom->addr =3D val & PCI_ROM_ADDRESS_MASK; } =20 -static int cf_check init_bars(struct pci_dev *pdev) +static int cf_check init_header(struct pci_dev *pdev) { uint16_t cmd; uint64_t addr, size; @@ -545,6 +546,68 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( rc ) return rc; =20 + if ( !is_hardware_domain(pdev->domain) ) + { + if ( pci_conf_read16(pdev->sbdf, PCI_STATUS) & PCI_STATUS_CAP_LIST= ) + { + /* Only expose capabilities to the guest that vPCI can handle.= */ + unsigned int next, ttl =3D 48; + const unsigned int supported_caps[] =3D { + PCI_CAP_ID_MSI, + PCI_CAP_ID_MSIX, + }; + + next =3D pci_find_next_cap_ttl(pdev->sbdf, PCI_CAPABILITY_LIST, + supported_caps, + ARRAY_SIZE(supported_caps), &ttl); + + rc =3D vpci_add_register(pdev->vpci, vpci_read_val, NULL, + PCI_CAPABILITY_LIST, 1, + (void *)(uintptr_t)next); + if ( rc ) + return rc; + + next &=3D ~3; + + if ( !next ) + /* + * If we don't have any supported capabilities to expose t= o the + * guest, mask the PCI_STATUS_CAP_LIST bit in the status + * register. + */ + mask_cap_list =3D true; + + while ( next && ttl ) + { + unsigned int pos =3D next; + + next =3D pci_find_next_cap_ttl(pdev->sbdf, + pos + PCI_CAP_LIST_NEXT, + supported_caps, + ARRAY_SIZE(supported_caps), &= ttl); + + rc =3D vpci_add_register(pdev->vpci, vpci_hw_read8, NULL, + pos + PCI_CAP_LIST_ID, 1, NULL); + if ( rc ) + return rc; + + rc =3D vpci_add_register(pdev->vpci, vpci_read_val, NULL, + pos + PCI_CAP_LIST_NEXT, 1, + (void *)(uintptr_t)next); + if ( rc ) + return rc; + + next &=3D ~3; + } + } + + /* Extended capabilities read as zero, write ignore */ + rc =3D vpci_add_register(pdev->vpci, vpci_read_val, NULL, 0x100, 4, + (void *)0); + if ( rc ) + return rc; + } + /* Utilize rsvdp_mask to hide PCI_STATUS_CAP_LIST from the guest. */ rc =3D vpci_add_register_mask(pdev->vpci, vpci_hw_read16, vpci_hw_writ= e16, PCI_STATUS, 2, NULL, @@ -642,7 +705,7 @@ static int cf_check init_bars(struct pci_dev *pdev) =20 return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0; } -REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); +REGISTER_VPCI_INIT(init_header, VPCI_PRIORITY_MIDDLE); =20 /* * Local variables: diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index d569f596a4c3..72ef277c4f8e 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -137,6 +137,18 @@ static void cf_check vpci_ignored_write( { } =20 +uint32_t cf_check vpci_read_val( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + return (uintptr_t)data; +} + +uint32_t cf_check vpci_hw_read8( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + return pci_conf_read8(pdev->sbdf, reg); +} + uint32_t cf_check vpci_hw_read16( const struct pci_dev *pdev, unsigned int reg, void *data) { diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 50d7dfb2a2fd..1509f8f466f1 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -205,6 +205,9 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, int pci_mmcfg_write(unsigned int seg, unsigned int bus, unsigned int devfn, int reg, int len, u32 value); unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, unsigned int cap); +unsigned int pci_find_next_cap_ttl(pci_sbdf_t sbdf, unsigned int pos, + const unsigned int *cap, unsigned int n, + unsigned int *ttl); unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, unsigned int cap); unsigned int pci_find_ext_capability(pci_sbdf_t sbdf, unsigned int cap); diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 85c52a1ebac7..d20c301a3db3 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -57,7 +57,13 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, un= signed int size); void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size, uint32_t data); =20 +/* Helper to return the value passed in data. */ +uint32_t cf_check vpci_read_val( + const struct pci_dev *pdev, unsigned int reg, void *data); + /* Passthrough handlers. */ +uint32_t cf_check vpci_hw_read8( + const struct pci_dev *pdev, unsigned int reg, void *data); uint32_t cf_check vpci_hw_read16( const struct pci_dev *pdev, unsigned int reg, void *data); uint32_t cf_check vpci_hw_read32( --=20 2.43.0