From nobody Sat May 18 07:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1696855940; cv=none; d=zohomail.com; s=zohoarc; b=CPoQwoKJzqZ+BqlOjcD5BNfchVN8tmgBY7aI97LkGmk1LalvpKxowXK2SI8ttpZBgIADKRtneGIimrUFRJjJzDS9mnvD39IGyc7Q9GmLr6KczHw+zkrWZvBMUA77exdothHfIXCCm2bdKpyYL2sNFtCHPtqNYgYnTmboaYwWUUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696855940; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6stkbuoMjurJJxIep2GjOtQsiPgi52HYjGuQHL8XeTA=; b=EJg+A97qNC7VqB89DtG0vpO2A37A6r4FqyYWxOlJa6e4lCeG2le+m6yjQ+nmT4U9w0Izc/5hpx1AUKuwTQzFONleLvXdJS1+ZQX9tknXWlWMAPT2uD8puvXmYdcoe+LpXABaxyATIMR6l+TL4szVnpE2QgG20niVpqrVy54epMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1696855940788866.4441820170382; Mon, 9 Oct 2023 05:52:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.614360.955372 (Exim 4.92) (envelope-from ) id 1qppjh-0007CK-HX; Mon, 09 Oct 2023 12:51:49 +0000 Received: by outflank-mailman (output) from mailman id 614360.955372; Mon, 09 Oct 2023 12:51:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjh-0007BN-B2; Mon, 09 Oct 2023 12:51:49 +0000 Received: by outflank-mailman (input) for mailman id 614360; Mon, 09 Oct 2023 12:51:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjg-00078l-HL for xen-devel@lists.xenproject.org; Mon, 09 Oct 2023 12:51:48 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b0f8110-66a2-11ee-98d3-6d05b1d4d9a1; Mon, 09 Oct 2023 14:51:46 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3231d6504e1so4169940f8f.2 for ; Mon, 09 Oct 2023 05:51:46 -0700 (PDT) Received: from georged-x-u.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b00324ae863ac1sm9589576wru.35.2023.10.09.05.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:51:45 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b0f8110-66a2-11ee-98d3-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1696855906; x=1697460706; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6stkbuoMjurJJxIep2GjOtQsiPgi52HYjGuQHL8XeTA=; b=UkwUn+FIuR+viR52eNz1ac04R4sbTeOiJyacIMZ4XTIkFtKpfF6OFY2BvzCCi2nZ4K 4cdLS3GE4lL+BtbmnkQayh3EG+0h5MlL6G0YefndyYQfu+s253UQa6L5va9AIFwhLymI 0/GEQrAOlwLUOaPQ6ewFiZJyGHd3jS4ubhI5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855906; x=1697460706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6stkbuoMjurJJxIep2GjOtQsiPgi52HYjGuQHL8XeTA=; b=hWTGRbPc1WXA1Jjy+tkdnk39Wxn1Bg+2uqI5SPxEkKdtb4dT+0hxhLe8GB4YWWHSMI Gbm2v3NHadNubN+u1F5KZ2JgbiE9/VDx84aJDZt3+TuzVt+IOIFJXgpe8z2Q5uWTld02 RlFam3QEVl3ZVYzHaaYE8AK3MKJ85UWUY3HJb2Uf2SxGITHDo0nZvsDB/MmBBgR4kMMV tSlxJFYo86DwybE2sT84OGvvV+34WcpAJ5fKCg3oySkg3e39bUHH221RxTEyGIA/0nri UEEA/10NKLvVEucOWZuocbNUGYUZnFNLShBWpqV+/yXEA4qlZ6vi3HF2rJC6I3qj19o2 vCpg== X-Gm-Message-State: AOJu0YxdbuprtNlDIZX7wbm+i0AuGYT/o3Hj5SOy2w9loNblAiyqtq48 43aqkqXdZeenGzPpG5Df+J//9G8JFRgad66rYmI= X-Google-Smtp-Source: AGHT+IHlGUQPPC9qfmT0Qyh34OC4lfMNEfG2cjBVEKz0WNNE916f49D85GHpAAladmXXCTSP3Uq15Q== X-Received: by 2002:a5d:4cc3:0:b0:31f:e761:d47c with SMTP id c3-20020a5d4cc3000000b0031fe761d47cmr13041144wrt.32.1696855906074; Mon, 09 Oct 2023 05:51:46 -0700 (PDT) From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Henry Wang , George Dunlap , Anthony Perard , Stefano Stabellini , Xenia Ragiodakou Subject: [PATCH for-4.18 1/5] xenalyze: Only accumulate data from one vmexit without a handler Date: Mon, 9 Oct 2023 13:51:33 +0100 Message-Id: <20231009125137.1329146-2-george.dunlap@cloud.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231009125137.1329146-1-george.dunlap@cloud.com> References: <20231009125137.1329146-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1696855941939100001 Content-Type: text/plain; charset="utf-8" If a vmentry/exit arc unexpectedly doesn't have a handler, we throw an error, and then log the information under HVM event 0; thus those particular traces within the vmexit reason will have stats gathered, and will show up with "(no handler)". This is useful in the event that there are unusual paths through the hypervisor which don't have trace points. However, if there are more than one of these, then although we detect and w= arn that this is happening, we subsequently continue to stuff data about all ex= its into that one exit, even though we only show it in one place. Instead, refator things to only allow a single exit reason to be accumulated into any given event. Also put a comment explaining what's going on, and how to fix it. Signed-off-by: George Dunlap Acked-by: Anthony PERARD --- Release justification: This is a bug fix; a minor one, but also in a non-critical part of the code. CC: Anthony Perard CC: Stefano Stabellini CC: Xenia Ragiodakou --- tools/xentrace/xenalyze.c | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 4cb67062c9..1359e096f9 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -4652,6 +4652,19 @@ void hvm_generic_postprocess(struct hvm_data *h) ? "[clipped]" : h->exit_reason_name[h->exit_reason]); warned[h->exit_reason]=3D1; + + /*=20 + * NB that we don't return here; the result will be that `evt` + * will be "0", and there will be a "(no handler)" entry for t= he + * given VMEXIT. + *=20 + * This does mean that if two different exits have no HVM + * handlers, that only the first one will accumulate data; + * if accumulating a separate "(no handler)" data for more + * than one exit reason is needed, we'll have to make Yet + * Another Array. But for now, since we try to avoid + * it happening, just tolerate it. + */=20 } } =20 @@ -4664,18 +4677,19 @@ void hvm_generic_postprocess(struct hvm_data *h) } =20 if(opt.summary_info) { - update_cycles(&h->summary.generic[evt], - h->arc_cycles); - /* NB that h->exit_reason may be 0, so we offset by 1 */ if ( registered[evt] ) { static unsigned warned[HVM_EXIT_REASON_MAX] =3D { 0 }; - if ( registered[evt] !=3D h->exit_reason+1 && !warned[h->exit_= reason]) + if ( registered[evt] !=3D h->exit_reason+1 ) { - fprintf(warn, "%s: HVM evt %lx in %x and %x!\n", - __func__, evt, registered[evt]-1, h->exit_reason); - warned[h->exit_reason]=3D1; + if ( !warned[h->exit_reason] ) + { + fprintf(warn, "%s: HVM evt %lx in %x and %x!\n", + __func__, evt, registered[evt]-1, h->exit_reas= on); + warned[h->exit_reason]=3D1; + } + return; } } else @@ -4686,7 +4700,11 @@ void hvm_generic_postprocess(struct hvm_data *h) __func__, ret); registered[evt]=3Dh->exit_reason+1; } - /* HLT checked at hvm_vmexit_close() */ + + update_cycles(&h->summary.generic[evt], + h->arc_cycles); + + /* HLT checked at hvm_vmexit_close() */ } } =20 --=20 2.25.1 From nobody Sat May 18 07:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1696855935; cv=none; d=zohomail.com; s=zohoarc; b=KJDzN969DZPF+Bxz70w64aIKT82fjknMlyii68eRZ6kih1wws/PhDw0olviZzDi2zxb2iRW3tlK9BAhrK6D1MkhjNoKg15wFwqzIbMcSibGN/PxdimtbsrYJT0UQgQF0rHQ0uIlgcZJOrmrPh2EmDwEAsvfcZEGBBSuSJXI6jaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696855935; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DD/Rtcmf93B68CFAL5jWDoRcvsTne4a1HEEQsNM+F40=; b=I1WqgXUsGM5ZvmmH/MuSEKZ3w9LnBW8vIGI37/+kLmSKbhjDYc1z6n8P28K+m48/5rsh2XFttB3FsjXzugMaa326KNKmMCIkFuzV46lTDmbmjyGv9STT+PyybK4V9noGMrTZWGIVR/AAvB3gnc/FcvuOwWaGasAEH/Yrr5fa3mE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1696855935649915.9275579801697; Mon, 9 Oct 2023 05:52:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.614363.955401 (Exim 4.92) (envelope-from ) id 1qppjn-0007yy-Dk; Mon, 09 Oct 2023 12:51:55 +0000 Received: by outflank-mailman (output) from mailman id 614363.955401; Mon, 09 Oct 2023 12:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjn-0007yb-7z; Mon, 09 Oct 2023 12:51:55 +0000 Received: by outflank-mailman (input) for mailman id 614363; Mon, 09 Oct 2023 12:51:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjl-0007s6-EK for xen-devel@lists.xenproject.org; Mon, 09 Oct 2023 12:51:53 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b7511a3-66a2-11ee-9b0d-b553b5be7939; Mon, 09 Oct 2023 14:51:47 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3231df68584so4187563f8f.1 for ; Mon, 09 Oct 2023 05:51:47 -0700 (PDT) Received: from georged-x-u.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b00324ae863ac1sm9589576wru.35.2023.10.09.05.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:51:46 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b7511a3-66a2-11ee-9b0d-b553b5be7939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1696855907; x=1697460707; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DD/Rtcmf93B68CFAL5jWDoRcvsTne4a1HEEQsNM+F40=; b=l0sln6m8nBF7dF4t8pdCSij8Tgs86p94L3ICslQuE09vCyXcufLg3uKedeLUWtv3vU 4b+1Ghiu82S/8JHmiEQpyUFqAIaYFDaPsC/rxkzFpuB80O3LZsIlTx5s2EeTSBuQmYZR B9I4rqSorWCL6wpQ8JNHMEPvfaFUQoMA+KsHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855907; x=1697460707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DD/Rtcmf93B68CFAL5jWDoRcvsTne4a1HEEQsNM+F40=; b=UKK4d24BjZQkpG7ClJA2OxJNjwssIDjAH5pUb4DwudvIa3dDStmVNnksMPJZTIzNX5 MPDoAqzViH11rbzfYO2ulLcQaOK2BbWrczh/PDqiyHKwQIpR+OiRexy1L+AekOEFaRO3 +/jsPpn6UNIJGrMr7gvr/61qUYZtf+ul4UWPrxi2H00A0Jv/JlkzuOcydIC+sCQq6jFh PmndvV3nhX6kJ0hHD2/FiP34+hs95gTxYXs3Mvs1ezU9QRNF/lD89QlayfYalsojHOIa Jq6RH+w7dkVT4COzjA6X70coBhqxdlNlyuHkgKtmDHfI+0CbeLl5nEFNvYApkToy8Hba gO/g== X-Gm-Message-State: AOJu0Yz0lQj/Twh4f5RZBLs8FC/8C/n0CrnXC6I/5idii+dm0WlXECH9 cAcVbvS8qxn5xW4oqqDSCkiWX4jPKvTrla1wh5I= X-Google-Smtp-Source: AGHT+IHWmt4KguiMPo7Vjsf42uLk6RSQqhQqtBY8Q5VlJ+kitI+BnI6wYokp+Gg5XEHJcYs8F0a22g== X-Received: by 2002:a5d:6681:0:b0:317:618a:c72 with SMTP id l1-20020a5d6681000000b00317618a0c72mr12976740wru.64.1696855906869; Mon, 09 Oct 2023 05:51:46 -0700 (PDT) From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Henry Wang , George Dunlap , Stefano Stabellini , Xenia Ragiadakou , Anthony Perard Subject: [PATCH for-4.18 2/5] xenalyze: AMD's VMEXIT_VINTR doesn't need a trace record Date: Mon, 9 Oct 2023 13:51:34 +0100 Message-Id: <20231009125137.1329146-3-george.dunlap@cloud.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231009125137.1329146-1-george.dunlap@cloud.com> References: <20231009125137.1329146-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1696855938085100005 Content-Type: text/plain; charset="utf-8" Just like Intel's PENDING_VIRT_INTR, AMD's VINTR doesn't need an HVM trace record. Expect that. Signed-off-by: George Dunlap Acked-by: Anthony PERARD --- Release justification: This is a bug fix. It's a *very* small one, but then the code path is not very critical either. CC: Stefano Stabellini CC: Xenia Ragiadakou CC: Anthony Perard --- tools/xentrace/xenalyze.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 1359e096f9..fc25ac3589 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -4628,6 +4628,13 @@ void hvm_generic_postprocess(struct hvm_data *h) /* Some exits we don't expect a handler; just return */ if(opt.svm_mode) { + switch(h->exit_reason) + { + case VMEXIT_VINTR: /* Equivalent of PENDING_VIRT_INTR */ + return; + default: + break; + } } else { --=20 2.25.1 From nobody Sat May 18 07:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1696855944; cv=none; d=zohomail.com; s=zohoarc; b=WODCv7N3a79hk4tof3FBf03/OZPbv4kT5OQ4nZ+Qq75/mkc2jEqfAWljqYw8kqDCSKx7sL5uBBdh0Al07TJzDns+GNjwynZ9q+HcyJs1vL9uC6ROpf+pDffeQ5jx7K97MdnddWjP39J9ybeD1o+czHzC8Eia1RU3zlJMu16DdSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696855944; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RJrVk7LMkW0zXyVZPEan5SEC7eFr57cgF9BbE1wu9kQ=; b=XPcMuE1Xv23RWYnZ/4abD8DU0E7xjbecnKvFCqA5+s6XsR8GeRSYfl1VQD8E3U5Mewa4qbn/6pyKHRvmsPfDmirCpvckjdj354OGO5enrmaP1i2GQXY0F9+iZCAWLcEEfArLMJzOgVfauFEeJYz3m1g3W+zEWMak2vzG8BaVFI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1696855944309370.6044044755481; Mon, 9 Oct 2023 05:52:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.614364.955406 (Exim 4.92) (envelope-from ) id 1qppjn-00085C-O2; Mon, 09 Oct 2023 12:51:55 +0000 Received: by outflank-mailman (output) from mailman id 614364.955406; Mon, 09 Oct 2023 12:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjn-00082y-Is; Mon, 09 Oct 2023 12:51:55 +0000 Received: by outflank-mailman (input) for mailman id 614364; Mon, 09 Oct 2023 12:51:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjm-0007s6-43 for xen-devel@lists.xenproject.org; Mon, 09 Oct 2023 12:51:54 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c04f31c-66a2-11ee-9b0d-b553b5be7939; Mon, 09 Oct 2023 14:51:48 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40684f53bfcso41473925e9.0 for ; Mon, 09 Oct 2023 05:51:48 -0700 (PDT) Received: from georged-x-u.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b00324ae863ac1sm9589576wru.35.2023.10.09.05.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:51:47 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c04f31c-66a2-11ee-9b0d-b553b5be7939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1696855907; x=1697460707; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RJrVk7LMkW0zXyVZPEan5SEC7eFr57cgF9BbE1wu9kQ=; b=dMJKf9gUQMIb2G9kivhJBzjZ8FeeqDer0X3ES1cNX/7GztKs3RUU/lJCX0BvN9GYu5 Q9nrsqgqNJ585dOArfjkXx0j+JlQ2dnc2BgEJjudEoLVS+gP1BOh8gfSFEYqMfzEAjG2 wkJ9XKY1kTa8TNQlRlXUpoWxZ0mMpdhmZOTd4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855907; x=1697460707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RJrVk7LMkW0zXyVZPEan5SEC7eFr57cgF9BbE1wu9kQ=; b=dQRGs0vBp4b0H1LEhfuDB4H/7S5A/eIq1gVTCXM9q0eDXlSUJdzqprEMzyFuzta7CQ moJXhe4fk47XnpJgH+2oTFlWkzJcNiifxdaHrCuyoFXctk7jO1XpVZAnVAD5PLQQLm5s INvxudxCVEmB1oU8Laj0GwaFTkVMJJxhnFEgJw9bg2mHElUYB0AcQ6Fw3LoE8t6n15cv YIhY1sQY9KteNckqiuSnHQ7WS575CUPWHRhyVPhy4WIsqT2jg6iFUJPsgRSqBVrHAU1s 9FtZ60GLx6RxeY+GcLSkh7tBu8PmEgyrC3rC3PgfGcfnRaHpQaL/Tk77kBOR7sEz/B2e //Pw== X-Gm-Message-State: AOJu0YzzJasZ1WQxjXhIdmpr1FP3LGeo+SUCFOgdvXY3AU5WMMxEzv3N ++dFTfQBhZs68z2k4F3DP79Silu7XLCoawiqhqA= X-Google-Smtp-Source: AGHT+IESjYH2aLK0ihomB1LR5F4AseZXlMV2cuD6IJLvNY5H4vuHIn7kzIHSjhTNJ93N/w3aW2SXyQ== X-Received: by 2002:a5d:6051:0:b0:321:4b47:d1c0 with SMTP id j17-20020a5d6051000000b003214b47d1c0mr11245954wrt.71.1696855907562; Mon, 09 Oct 2023 05:51:47 -0700 (PDT) From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Henry Wang , George Dunlap , Anthony Perard , Stefano Stabellini , Xenia Ragiodakou Subject: [PATCH for-4.18 3/5] xenalyze: Don't expect an HVM_HANDLER trace for PAUSE vmexits Date: Mon, 9 Oct 2023 13:51:35 +0100 Message-Id: <20231009125137.1329146-4-george.dunlap@cloud.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231009125137.1329146-1-george.dunlap@cloud.com> References: <20231009125137.1329146-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1696855945979100002 Content-Type: text/plain; charset="utf-8" Neither vmx nor svm trace anything, nor is there anything obvious worth tracing. Signed-off-by: George Dunlap Acked-by: Anthony PERARD --- Release justification: This is a bug fix; a minor one, but also in a non-critical part of the code. CC: Anthony Perard CC: Stefano Stabellini CC: Xenia Ragiodakou --- tools/xentrace/xenalyze.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index fc25ac3589..2faf66500d 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -4631,6 +4631,7 @@ void hvm_generic_postprocess(struct hvm_data *h) switch(h->exit_reason) { case VMEXIT_VINTR: /* Equivalent of PENDING_VIRT_INTR */ + case VMEXIT_PAUSE: return; default: break; @@ -4643,6 +4644,7 @@ void hvm_generic_postprocess(struct hvm_data *h) /* These just need us to go through the return path */ case EXIT_REASON_PENDING_VIRT_INTR: case EXIT_REASON_TPR_BELOW_THRESHOLD: + case EXIT_REASON_PAUSE_INSTRUCTION: /* Not much to log now; may need later */ case EXIT_REASON_WBINVD: return; --=20 2.25.1 From nobody Sat May 18 07:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1696855940; cv=none; d=zohomail.com; s=zohoarc; b=FojBfIvyp5Xiv8qQk3S/HbUgd0rL5Mt9T8QY8jPg9AfYIEemLUBaWa2Ii0Q5jsUNHkja8QDqotnfnWjrjA8OAVAWCYIjG4nnGjwSmG3BtZSuG3zcJUM5tNwIlIVPDMnWeL0dBX1YlB1BD6HzJapsU3XsByC885jNmFA/dE0d2hY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696855940; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Nhjljp1hIYeTK8QNgAPsHEKUsnXQ5nu3twtO4N6FJQ8=; b=ASAgA2/Xg2PkwTTKdhqY4wEfodYekD/s9PbCGqz4E3BRBz7tlCGGCqKeIZZF05pajc+9BA81FGjWCpE+0D9W6ccBOcXDB6bE6GEPMQg7GiyNcC1UPpXVBv18uGb5j/wWZZ8jJqM6bEXPww0wqv+DPAZVN0MW9DJ1FUyQb2GvGCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1696855940771688.5468217087822; Mon, 9 Oct 2023 05:52:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.614362.955396 (Exim 4.92) (envelope-from ) id 1qppjn-0007ve-2V; Mon, 09 Oct 2023 12:51:55 +0000 Received: by outflank-mailman (output) from mailman id 614362.955396; Mon, 09 Oct 2023 12:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjm-0007vX-Ve; Mon, 09 Oct 2023 12:51:54 +0000 Received: by outflank-mailman (input) for mailman id 614362; Mon, 09 Oct 2023 12:51:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjl-0007s6-7M for xen-devel@lists.xenproject.org; Mon, 09 Oct 2023 12:51:53 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c46ed85-66a2-11ee-9b0d-b553b5be7939; Mon, 09 Oct 2023 14:51:48 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-31c5cac3ae2so4057909f8f.3 for ; Mon, 09 Oct 2023 05:51:48 -0700 (PDT) Received: from georged-x-u.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b00324ae863ac1sm9589576wru.35.2023.10.09.05.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:51:47 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c46ed85-66a2-11ee-9b0d-b553b5be7939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1696855908; x=1697460708; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nhjljp1hIYeTK8QNgAPsHEKUsnXQ5nu3twtO4N6FJQ8=; b=g6KASNx/Bog4uPepRD/A2p29Ni5PXtZQviC9mw0jQ2FyEbJqgBIC4ef3Uwqfy4pyTV czQzXvOl+qI+ZHjdojQfSTd6GHw0IVWjdJJdMVKlrXYCRFpzX+M+aKvzYo2OHuC35HfI lyk0DSYZ1FHt9RbRFMT35t0UFm6XXPa9zhJFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855908; x=1697460708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nhjljp1hIYeTK8QNgAPsHEKUsnXQ5nu3twtO4N6FJQ8=; b=KwlOSQJl4I22deEogY5S3beZyF2+H/MQVb9i6efWRMVKqA48VotPzYVGm7GLlyh8sk YnNOQmJLnzBe5masAmzhura8jeOnAc3ZQF5/9KQMKu10F0UkzATsD7mkLZ4OWxfvRqcM Btu/zzMlvM137Niv+Ahn5Y8CIRAhymvwJXSLEVno5Bq45LpSPH2Fdbmgoy1LyWmgecru Pby8NUOGXD55xFB5Srqxnbvx4F+vTWLpWrzQTgNbWODSHxWHdQY4ODYkT7y1RCFdA0k0 ax43WNztJSDcACdy1JlohYHxNaMVXAMStmwhtSzeJ1klevumwHaYp7SBWxiDp6Q+Sk7h sSug== X-Gm-Message-State: AOJu0YyA+wPP4G4HLerib43CoLIFWl182OJkrrjfBuftCqI6IKzVcPRA LeHXyJc08JK0cHno6U2nkvJtwvuZygTvVxCjNU0= X-Google-Smtp-Source: AGHT+IGAIWOrXAv49CGPWktBV8PFQWL29FrsyRsuJ2gKs92LU+0NH/i0uCDvwzkLHmCwqrXMt+hN3Q== X-Received: by 2002:a05:6000:110b:b0:31f:a259:73c with SMTP id z11-20020a056000110b00b0031fa259073cmr13213365wrw.27.1696855908096; Mon, 09 Oct 2023 05:51:48 -0700 (PDT) From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Henry Wang , George Dunlap , Anthony Perard , Stefano Stabellini , Xenia Ragiodakou Subject: [PATCH for-4.18 4/5] xenalyze: Fix interrupt EIP reporting Date: Mon, 9 Oct 2023 13:51:36 +0100 Message-Id: <20231009125137.1329146-5-george.dunlap@cloud.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231009125137.1329146-1-george.dunlap@cloud.com> References: <20231009125137.1329146-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1696855945973100001 Content-Type: text/plain; charset="utf-8" EIP lists are generalized across several use cases. For many of them, it make sense to have a cycle per sample; but not really for interrupt EIP lists. For this reason, it normally just passes 0 as for the tsc value, which will in turn down at the bottom of update_cycles(), update only the summary.event_count, but nothing else. The dump_eip() function attempted to handle this by calling the generic cycle print handler if the summary contained *any* cycles, and by collecting and printing its own stats, based solely on counts, if not. Unfortunately, it used the wrong element for this: it collected the total from samples.count rather samples.event_count; in the case that there are no cycles, this will always be zero. It then divided by this zero value. This results in output that looked like this: ``` ffff89d29656 : 0 -nan% ffff89d298b6 : 0 -nan% ffff89d298c0 : 0 -nan% ``` It's better than nothing, but a lot less informative than one would like. Use event_count rather than count for collecting the total, and the reporting when there are no cycles in the summary information. This results in output that looks like this: ``` ffff89d29656 : 2 1.2= 1% ffff89d298b6 : 1 0.6= 1% ffff89d298c0 : 1 0.6= 1% ``` Signed-off-by: George Dunlap Acked-by: Anthony PERARD --- Rationale: This is a bug fix. It's a minor one, but it's also in a non-critical part of the code. CC: Anthony Perard CC: Stefano Stabellini CC: Xenia Ragiodakou --- tools/xentrace/xenalyze.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 2faf66500d..4b6db59d87 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -2866,7 +2866,7 @@ void dump_eip(struct eip_list_struct *head) { =20 for(p=3Dhead; p; p=3Dp->next) { - total +=3D p->summary.count; + total +=3D p->summary.event_count; N++; } =20 @@ -2901,8 +2901,8 @@ void dump_eip(struct eip_list_struct *head) { p->eip, find_symbol(p->eip)); printf(" %7d %5.2lf%%\n", - p->summary.count, - ((double)p->summary.count*100)/total); + p->summary.event_count, + ((double)p->summary.event_count*100)/total); } =20 =20 --=20 2.25.1 From nobody Sat May 18 07:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=cloud.com ARC-Seal: i=1; a=rsa-sha256; t=1696855934; cv=none; d=zohomail.com; s=zohoarc; b=MTiC1pm82KvlayObWBdd/LM0WAv+Vz/Q/lOrKZFs1cZ3ydk3lDNRibYPVPHbiOUean1+TBGFwDMd7CQQyBvWH1YQyEjjB52fsih4KX1n+S7Zi3RmdkxnaVH8taFzxkSe3fpAvKq5SkSzbcWPCumqq+4xRD21/rynVkhrU1hj19M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696855934; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=THzNB7D3yfsNIFN3S2Q+YKzkNqwGb3jd/DGHxsmTa/0=; b=ngy61KXjmGaC7tp9MVSFt/i8CxbSgBPRLPgPJ9UD9/Wq8rT2Jp6txOVtmawqPawsNgGPaRUbnfsQ5ovCu5pFZMm3J2XVCc1Mq/hCtpXUUjz/WG91mcLoU1e+ALTt0lFGqOA328SX9mbOrvY7KMRnOsWzVw7vI1vEfxHakr8MEyw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1696855934464779.072828980735; Mon, 9 Oct 2023 05:52:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.614361.955386 (Exim 4.92) (envelope-from ) id 1qppji-0007cj-QY; Mon, 09 Oct 2023 12:51:50 +0000 Received: by outflank-mailman (output) from mailman id 614361.955386; Mon, 09 Oct 2023 12:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppji-0007cc-NX; Mon, 09 Oct 2023 12:51:50 +0000 Received: by outflank-mailman (input) for mailman id 614361; Mon, 09 Oct 2023 12:51:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qppjh-00078l-Ol for xen-devel@lists.xenproject.org; Mon, 09 Oct 2023 12:51:49 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c74c572-66a2-11ee-98d3-6d05b1d4d9a1; Mon, 09 Oct 2023 14:51:49 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-307d58b3efbso4066747f8f.0 for ; Mon, 09 Oct 2023 05:51:49 -0700 (PDT) Received: from georged-x-u.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id c16-20020a5d4f10000000b00324ae863ac1sm9589576wru.35.2023.10.09.05.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:51:48 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c74c572-66a2-11ee-98d3-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1696855908; x=1697460708; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=THzNB7D3yfsNIFN3S2Q+YKzkNqwGb3jd/DGHxsmTa/0=; b=UQ+qzgUsGoEMX6kMisYTtrX9leU2grjl0fmR+3Wl1h4Kwd8Low9YPfEWzjUINfXq6X sTcJzPVWzNx3cH+DuU4AEGu/Y/LtZQbU99bjmZ7RcodQTKkwmBYfaOdZvRUsPgXQTN+D WMoqRjuMYdemuq/kfs4h1lJGso0TyqrcorOrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855908; x=1697460708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=THzNB7D3yfsNIFN3S2Q+YKzkNqwGb3jd/DGHxsmTa/0=; b=mA5g8XUIjnJXHxjGCBmOpB3J9NcjrPS+tN6Pg9pQD/UcuEnc8NkxcO9I3m4mQWFNyj TmCfBI+WWFmgOBEAjOsM4+Vh7kSw1d11OkzCLb0PulGHzFl3eIa0ArVvOn6YEXMu2YkZ KyU6OCPz/q4IBARGr3Q6+XG93vCOIpGN0QA5mf1ILnLfzfJXKJQNk9Bvn7EOFbSNUcuy mDEsQYa1vyt6kxDg+xkCWEGQxXrP+XAq+iR4aDle9vrA/g4eLQNhdmi9ufsbNMRf2b1A wZP5HdgHaX0bVzFQhSe2Yn+qvGRYIWmXfcAVfuyQDNHjLumDWYuNexmfDsiaNTyfFfh3 cmLg== X-Gm-Message-State: AOJu0YyK+YQtMuDAWh7CBy5uSamnoXzAxMJ0+yQkfErWAZkoFeQrHBza nwN5WSBmAXs7Lv7L7dSBEa1TfAxcoGrD9sKzWK0= X-Google-Smtp-Source: AGHT+IE0KzyEMxN/4/m/o1Fbe6ulKEZNjItfXCB2hJEiVHe7D+kt9WF0YiVDc6JrIceOeblEGvckvA== X-Received: by 2002:adf:f20c:0:b0:320:77f:a982 with SMTP id p12-20020adff20c000000b00320077fa982mr14105036wro.45.1696855908547; Mon, 09 Oct 2023 05:51:48 -0700 (PDT) From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Henry Wang , George Dunlap , Anthony Perard , Stefano Stabellini , Xenia Ragiodakou Subject: [PATCH for-4.18 5/5] xenalyze: Reduce warnings about leaving a vcpu in INIT Date: Mon, 9 Oct 2023 13:51:37 +0100 Message-Id: <20231009125137.1329146-6-george.dunlap@cloud.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231009125137.1329146-1-george.dunlap@cloud.com> References: <20231009125137.1329146-1-george.dunlap@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @cloud.com) X-ZM-MESSAGEID: 1696855935846100001 Content-Type: text/plain; charset="utf-8" We warn when we see data for a vcpu moving into a non-RUNNING state, just so that people know why we're ignoring it. On full traces, this happens only once. However, if the trace was limited to a subset of pcpus, then this will happen every time the domain in question is woken on that pcpu. Add a 'delayed_init' flag to the vcpu struct to indicate when a vcpu has experienced a delayed init. Print a warning message once when entering the state, and once when leaving it. Signed-off-by: George Dunlap Acked-by: Anthony PERARD --- Release justification: By removing extraneous output which makes the tool annoying to use, this could be considered a bug fix; a minor one, but also in a non-critical part of the code. CC: Anthony Perard CC: Stefano Stabellini CC: Xenia Ragiodakou --- tools/xentrace/xenalyze.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 4b6db59d87..ce6a85d50b 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -1625,7 +1625,7 @@ struct vlapic_struct { struct vcpu_data { int vid; struct domain_data *d; /* up-pointer */ - unsigned activated:1; + unsigned activated:1, delayed_init:1; =20 int guest_paging_levels; =20 @@ -6979,10 +6979,17 @@ void vcpu_start(struct pcpu_info *p, struct vcpu_da= ta *v, * bring a vcpu out of INIT until it's seen to be actually * running somewhere. */ if ( new_runstate !=3D RUNSTATE_RUNNING ) { - fprintf(warn, "First schedule for d%dv%d doesn't take us into a ru= nning state; leaving INIT\n", - v->d->did, v->vid); + if ( !v->delayed_init ) { + fprintf(warn, "First schedule for d%dv%d doesn't take us into = a running state; leaving in INIT\n", + v->d->did, v->vid); + v->delayed_init =3D 1; + } =20 return; + } else if ( v->delayed_init ) { + fprintf(warn, "d%dv%d RUNSTATE_RUNNING detected, leaving INIT", + v->d->did, v->vid); + v->delayed_init =3D 0; } =20 tsc =3D ri_tsc; --=20 2.25.1