From nobody Mon Feb 9 23:42:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1688972463; cv=none; d=zohomail.com; s=zohoarc; b=i4P0mXdCrrVdUY1q6XLXnP+C900s1b+kxBYBW7ZlwcEpt7x236NxsFojkps+cayuq9ZjaWjd+t0mJXmNVP6cGacpGWAAp6ZDWLUdeCu17UlP28ZTwOLAzOPvPJrkga++VSlWA7CQKCqhsVboRL9k1Cq9FsRaWMFfDGPuTVqj2O0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688972463; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uX1UtLDeHIuSncID7ztx+3m5/A25DEYmNmT0JgfiUNQ=; b=h2Ffh+4PQw6XKP7bY2A8MFsf6i7cLnrmC4Qlv1J8KgYTLzlS1DBpN7HdMy3XbPNAsjtgYv9Xie9GVYPpQK+ic516KZAWnc+2rafEPAE3X1QbHhUqY39Tt0duCR1ktwuLYKnrkNL6MAK21tK4BWNF1DXTH6ZSTsvICH/pmpT1ikw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 168897246302935.56728844146073; Mon, 10 Jul 2023 00:01:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.560965.877191 (Exim 4.92) (envelope-from ) id 1qIksv-00072Q-Fc; Mon, 10 Jul 2023 07:00:37 +0000 Received: by outflank-mailman (output) from mailman id 560965.877191; Mon, 10 Jul 2023 07:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qIksv-00072D-Bp; Mon, 10 Jul 2023 07:00:37 +0000 Received: by outflank-mailman (input) for mailman id 560965; Mon, 10 Jul 2023 07:00:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qIksu-0002xd-DS for xen-devel@lists.xenproject.org; Mon, 10 Jul 2023 07:00:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 782b6cab-1eef-11ee-b239-6b7b168915f2; Mon, 10 Jul 2023 09:00:35 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A47761F88C; Mon, 10 Jul 2023 07:00:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 729FE1361C; Mon, 10 Jul 2023 07:00:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hJ2OGpOsq2T3YgAAMHmgww (envelope-from ); Mon, 10 Jul 2023 07:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 782b6cab-1eef-11ee-b239-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688972435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uX1UtLDeHIuSncID7ztx+3m5/A25DEYmNmT0JgfiUNQ=; b=RG1r3QY6qqWMTTwHNomt9UbriFqZ9RasnX1HCWxp2EaIpb3ej32ug23RE7FJeCSD5KC2ok IxeuEL0zn9SlA/F5I/Hgfa2EwftmL3B7yBGU5euAyt+27vTaqbygBdN5ttclA+MXi2sd55 kr+fA3fvd1Obh7T1f2VVjIqJav1Oeqg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v2 08/18] tools/xenstore: make hashtable key and value parameters const Date: Mon, 10 Jul 2023 08:59:37 +0200 Message-Id: <20230710065947.4201-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230710065947.4201-1-jgross@suse.com> References: <20230710065947.4201-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1688972463631100001 Content-Type: text/plain; charset="utf-8" The key is never modified by hashtable code, so it should be marked as const. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/hashtable.c | 5 +++-- tools/xenstore/hashtable.h | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index 11f6bf8f15..9daddd9782 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -11,7 +11,8 @@ =20 struct entry { - void *k, *v; + const void *k; + void *v; unsigned int h; struct entry *next; }; @@ -140,7 +141,7 @@ static int hashtable_expand(struct hashtable *h) return 0; } =20 -int hashtable_add(struct hashtable *h, void *k, void *v) +int hashtable_add(struct hashtable *h, const void *k, void *v) { /* This method allows duplicate keys - but they shouldn't be used */ unsigned int index; diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index 5a2cc4a4be..792f6cda7b 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -48,8 +48,8 @@ create_hashtable(const void *ctx, const char *name, * If in doubt, remove before insert. */ =20 -int=20 -hashtable_add(struct hashtable *h, void *k, void *v); +int +hashtable_add(struct hashtable *h, const void *k, void *v); =20 /*************************************************************************= **** * hashtable_search --=20 2.35.3