From nobody Fri May 17 07:56:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1688558164; cv=none; d=zohomail.com; s=zohoarc; b=ij2KJouke+D7JeUpC1fu2GswhrgbH19v6EeZn9MMVvGiSVZc6HSV+2OsuzIqBdmS3xwvmSXDD5MMHZHNAMw7+jg1nCSGfa4RDl1ivV3oNHgX5Q4p9wJ1fOAplXfm1m9e85sqDqVwRjxkMJ7bQ10D28BNHtne9jJGUuEheGm2kpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688558164; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1NOg8Ty/xGUQ867fNNCVthaQPTx0ZAW3TR9lv7vglH0=; b=QeyMXW+okOqC7/gDAPPXbOAvxDjX0NVzH+Sx3CMmsTUQsblFG069QGnZHniF+q6WG9JpPMIeANYZJM2Ja+SIMkhaZ8v6hV5gvgmkijAM2wNAg13Lg3PVqBItcAkgYjxaMYGJaWXBo9GLK2VHPgw6P5lOBcMZ3DOJ0Qhwi8MyKoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1688558164700705.9487334448014; Wed, 5 Jul 2023 04:56:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.559136.873844 (Exim 4.92) (envelope-from ) id 1qH16h-00041r-GR; Wed, 05 Jul 2023 11:55:39 +0000 Received: by outflank-mailman (output) from mailman id 559136.873844; Wed, 05 Jul 2023 11:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qH16h-00041k-Du; Wed, 05 Jul 2023 11:55:39 +0000 Received: by outflank-mailman (input) for mailman id 559136; Wed, 05 Jul 2023 11:55:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qH16g-00041e-QF for xen-devel@lists.xenproject.org; Wed, 05 Jul 2023 11:55:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qH16g-0006eb-3D; Wed, 05 Jul 2023 11:55:38 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qH16f-0004DO-Qu; Wed, 05 Jul 2023 11:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=1NOg8Ty/xGUQ867fNNCVthaQPTx0ZAW3TR9lv7vglH0=; b=AOfokm TxwyT4ziekBzHE67ftDkHNIiHvy5S93fxkqLB7lbYH1L2wfSp3l3NChWNUEXG/TlprsiDSbisdpEK bq8/zflPhe4gjSpYWKlOG565ND9cmx5Okm/f+WD3SeKYXylyPFwLfwnaaoapijKHGCF7s9rcRXjoH RPbWEzQvke8=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, michal.orzel@amd.com, Henry.Wang@arm.com, andrew.cooper3@citrix.com, Penny.Zheng@arm.com, wei.chen@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: Kconfig: ACPI should depend on UEFI Date: Wed, 5 Jul 2023 12:55:34 +0100 Message-Id: <20230705115534.26004-1-julien@xen.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) X-ZM-MESSAGEID: 1688558166460100001 Content-Type: text/plain; charset="utf-8" From: Julien Grall On Arm, it is not possible to use ACPI without UEFI. In fact disabling UEFI but not ACPI will lead to a compilation error: ld: prelink.o: in function `acpi_os_get_root_pointer': /builds/xen-project/people/andyhhp/xen/xen/drivers/acpi/osl.c:73: undefined reference to `efi' /builds/xen-project/people/andyhhp/xen/xen/drivers/acpi/osl.c:73:(.init.tex= t+0x8ac0): relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against undefined symbol `efi' So make the dependency clear in the Kconfig. This was spotted by the randconfig build in gitlab CI. Fixes: 12314be5749e ("xen/arm: make ARM_EFI selectable for Arm64") Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis --- xen/arch/arm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index c30f32457388..439cc94f3344 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -63,11 +63,11 @@ source "arch/Kconfig" =20 config ACPI bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPOR= TED)" if UNSUPPORTED - depends on ARM_64 + depends on ARM_64 && ARM_EFI ---help--- =20 Advanced Configuration and Power Interface (ACPI) support for Xen is - an alternative to device tree on ARM64. + an alternative to device tree on ARM64. This requires UEFI. =20 config ARM_EFI bool "UEFI boot service support" --=20 2.40.1