From nobody Tue Feb 10 01:16:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1686586428; cv=none; d=zohomail.com; s=zohoarc; b=jd8birBIu+HIjFuiLRlW7pk9oUoXiDcWGp4k0rLnndWfS74H/L4NjxTh5E8UVnptHGDkc8ar7PgDG9mPRYwVRXs3qGQ6WwVplBTbmeNyrgAHPdFMNd6TZzNRIkyAlD3jKJmALBmooEBrJ30yiR3ixGVqPVa3cda20ThVC9iY5Hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686586428; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qI+ld/E3VZTFXL+oFl2r8JorgHNkIg9dKKL2AWxA234=; b=VKbavr+waHnWQgayYNYhRfjyoX/ZbIbmUDD4ncmnA/lqPagqoFrxr22QEIrAd3+0zz2WsjPgNHUMunTBQV65jxU80XH9H6oRMt8se+/FJA7i2FGQoxOs8mRAR9BbMoahXcZQGjgq4LvXx8k9Px0KEzlCDLRzBpJ+MjTNqAsuHB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 168658642826582.05384621713085; Mon, 12 Jun 2023 09:13:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.547358.854705 (Exim 4.92) (envelope-from ) id 1q8kAW-0002HT-Pq; Mon, 12 Jun 2023 16:13:24 +0000 Received: by outflank-mailman (output) from mailman id 547358.854705; Mon, 12 Jun 2023 16:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8kAW-0002HM-N6; Mon, 12 Jun 2023 16:13:24 +0000 Received: by outflank-mailman (input) for mailman id 547358; Mon, 12 Jun 2023 16:13:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q8kAV-00021a-O2 for xen-devel@lists.xenproject.org; Mon, 12 Jun 2023 16:13:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cd50c72-093c-11ee-b232-6b7b168915f2; Mon, 12 Jun 2023 18:13:22 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cd50c72-093c-11ee-b232-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1686586402; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=juo+5nxjgfadIrJ0bP+JWsuC+QxOfTnJ4UTN/JsNx78=; b=T76T3SpWW2FMzv6hnjsrSw1o8cvy7adj20k4NHhUnpdOHCbGklHm4OC8 ZMceQv7Ee1S0BGP/Y6YRzTf5ivtbkelne2F8+74/6R1LLB1sHHB1DqwEI yu5wyqBGzUUoY/SnBPEJDTNhgXVe3a1DCdl3dYTW9Zbi+Q1UPw8+Zf63v k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 112508902 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:iZxsrqq5eyK7lLZ2EpQ1JEWuhRJeBmJiZRIvgKrLsJaIsI4StFCzt garIBnSM/mNa2X8ctglOdjk/R4DucLRx99iGwZs/3g0Fi8V85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GtwUmAWP6gR5weAziNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD9dRRWMos+q/L22CdZW2eguKOb5GoxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jufpTmhUkBCbrRzzxKq9W6pm9Dt3h/GArIuJra2+cU0gwWqkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3FPdgfueBPoUyMKs/Lmr6Qeki7AQ5VcKvGZg9naCxf/l mXiQDcFu1kDsSIa//zlrQ6d02n398Whoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoKiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPawS4m9BqyMP4ISPPCdkTNrGwk0PCatM53FyhBwwcnTx 7/GGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlnyaPU6lTCfNE98taQLeBt3VGYvY+G05B f4DbZrVo/ieOcWiChTqHXk7dwBadCVqWcqn96S6tIere2JbJY3oMNeJqZtJRmCvt/09ejvgl p1lZnJl9Q== IronPort-HdrOrdr: A9a23:7rNLOqlub87YOFMeUI53yRFk9NvpDfIH3DAbv31ZSRFFG/Fw9v re+cjzsCWf5Qr5N0tNpTntAsa9qArnhOdICOoqTNWftWvd2FdARbsKhbcKpQePJ8SUzJ8/6U 4PSclD4erLfDxHZJbBizVQy+xQu+VvKprY49s2Ek0dKj2Ct5sQlzuR1DzraHFLeA== X-Talos-CUID: 9a23:1QnkNmOigS1zOu5DV3lM8UExN9wZfXCe802PD0K8JnRPR+jA X-Talos-MUID: 9a23:XMpfsAakS/nW++BTmDjwgSxdFoRU3v6eNHIGn5o95crcDHkl X-IronPort-AV: E=Sophos;i="6.00,236,1681185600"; d="scan'208";a="112508902" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 1/4] x86/spec-ctrl: Use a taint for CET without MSR_SPEC_CTRL Date: Mon, 12 Jun 2023 17:13:03 +0100 Message-ID: <20230612161306.2739572-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230612161306.2739572-1-andrew.cooper3@citrix.com> References: <20230612161306.2739572-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1686586429640100005 Reword the comment for 'S' to include an incompatbile set of features on the same core. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu v3: * New --- xen/arch/x86/spec_ctrl.c | 3 +++ xen/common/kernel.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index cd5ea6aa52d9..05b86edf73d3 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -1132,7 +1132,10 @@ void __init init_speculation_mitigations(void) if ( read_cr4() & X86_CR4_CET ) { if ( !has_spec_ctrl ) + { printk(XENLOG_WARNING "?!? CET active, but no MSR_SPEC_CTRL?\n= "); + add_taint(TAINT_CPU_OUT_OF_SPEC); + } else if ( opt_ibrs =3D=3D -1 ) opt_ibrs =3D ibrs =3D true; =20 diff --git a/xen/common/kernel.c b/xen/common/kernel.c index fd975ae21ebc..719b08d6c76a 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -373,7 +373,7 @@ unsigned int tainted; * 'H' - HVM forced emulation prefix is permitted. * 'I' - Platform is insecure (usually due to an errata on the platform). * 'M' - Machine had a machine check experience. - * 'S' - Out of spec CPU (One core has a feature incompatible with others= ). + * 'S' - Out of spec CPU (Incompatible features on one or more cores). * * The string is overwritten by the next call to print_taint(). */ --=20 2.30.2