From nobody Tue May 7 15:55:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (Bad Signature) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1685086206996224.4531900714295; Fri, 26 May 2023 00:30:06 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.539982.841385 (Exim 4.92) (envelope-from ) id 1q2RtO-0003UK-6S; Fri, 26 May 2023 07:29:42 +0000 Received: by outflank-mailman (output) from mailman id 539982.841385; Fri, 26 May 2023 07:29:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtO-0003UD-2r; Fri, 26 May 2023 07:29:42 +0000 Received: by outflank-mailman (input) for mailman id 539982; Fri, 26 May 2023 07:29:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtM-0003Ci-Nj for xen-devel@lists.xenproject.org; Fri, 26 May 2023 07:29:40 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.160]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11cfd26e-fb97-11ed-8611-37d641c3527e; Fri, 26 May 2023 09:29:37 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz4Q7TV64U (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 26 May 2023 09:29:31 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11cfd26e-fb97-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1685086171; cv=none; d=strato.com; s=strato-dkim-0002; b=H/D+yzWwuRwNmOJCusUnT3mbUQFvhvq4V4befm3R/bj1yR8Iw5A7gv9CTBDnBS1yVJ AD0TR2a3h/AJqqKmsLz3VjdLSvulHRzRRliCu5ZLlR+mCjreC6dOITwOz190XPO9/8F+ +YxJ8dHgPrkuGr3oqfAyzJTbUaH6V6uXaQKQ+DU1CGtE3CGrx9yBhcqt/LdZXUHoJHXB yatqjrcgmmTY8hwySxNgS1PoNp+WhVIUPGPLycu+ma+igzsZ8ipwZmWBcr6wgSGHxRTR 7DntscX9NjZmRhpA4EU3yQoMUpynTmAQdm95ur8PxMJ9aYoPUFU5cKeALcPHKI2sRqPy Lbbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086171; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xlUaEBLrDwvOI31K8HyKZ+e2YJX5bW2ka7iFu75oZV0=; b=TolnBD0bn9B5uc4F/hAEjsr97WdpDc6OznbUV6sa/ETcmvT2Ew30QWcBM6m0drjvKi bdILLfCWmbS5Fojjxy/kNtGxGF/OTa4oKwpR7pJ1Vzib0acmnPpOnNYSpp79RoWBeW7D in45eGYsUiRo+Bq5MHl3IWFqiZeQDkM22osTZvPKnEXCvk60bWDmdNfXW+TNKCigvTR3 6JU30d6jz7arS8VL5tr4OCI9PxSq7AQlIXJRQZu9uJCv11rHnwS2yb3dH/pLSMoJ8ym0 IojFsGIy3apHCEaijSBmoV+z7NPAwJZO7qgvfoDlM/1EVX57/QbaGn8/W2rd8mH+LVB/ nWgA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086171; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xlUaEBLrDwvOI31K8HyKZ+e2YJX5bW2ka7iFu75oZV0=; b=k0GlIgy9QGsr5QrtCgd0GqyeNVnC15yE/VDdnX3Inglo+desuHaVZUc2iUzjFAC5WC +nSfTnJQ6J0rIH+pIPxkJgh+CXWgMH/qEq0evn/v+KnaPV0eVFNuvJW58UIS8JQnX8MS oF8wBdjSpQ4gxUQ9dP1fUGuZRqJlwUvY6ugEd50o1EcQ/1eKsxrKzmg3GIANf81N/6jA BB7fiuzsbci86YL1WfbpHR0+nqqrs+QJzMmQRZjEzOu6XKywvgqyzzrMc69svmE03Kaq u7HYHGTdJc+pffTd4g2uZzW0nXq+WGYOQUYyBkO53GloBMqyHFu4sxfUkH4EPm7zrJD0 Y6lA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1685086171; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xlUaEBLrDwvOI31K8HyKZ+e2YJX5bW2ka7iFu75oZV0=; b=GSWj0tmQJHv1LO/CZ10iNM94Pd5Ry6/9Vp1KdrRND+ItjXNGtFQ53S8BDUztz673cW 0yuTA3lo+cA98DhB23BQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4xqFv7EJ0tgRX/vKfT/e8Ig6v0dNw4QAWpzMWrRQ==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: George Dunlap , Wei Liu , Anthony PERARD Subject: [PATCH v1 1/3] xentrace: allow xentrace to write to stdout Date: Fri, 26 May 2023 09:29:14 +0200 Message-Id: <20230526072916.7424-2-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230526072916.7424-1-olaf@aepfle.de> References: <20230526072916.7424-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1685086209342100001 Content-Type: text/plain; charset="utf-8" The output file is optional. In case it is missing, xentrace is supposed to write to stdout - unless it is a tty, which is checked prior using it. Signed-off-by: Olaf Hering Acked-by: George Dunlap --- tools/xentrace/xentrace.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index 864e30d50c..b81abe8a51 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -1152,11 +1152,9 @@ static void parse_args(int argc, char **argv) } } =20 - /* get outfile (required last argument) */ - if (optind !=3D (argc-1)) - usage(); - - opts.outfile =3D argv[optind]; + /* get outfile (optional last argument) */ + if (argc > optind) + opts.outfile =3D argv[optind]; } =20 /* *BSD has no O_LARGEFILE */ From nobody Tue May 7 15:55:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (Bad Signature) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1685086209972333.50301958295745; Fri, 26 May 2023 00:30:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.539983.841396 (Exim 4.92) (envelope-from ) id 1q2RtP-0003kA-Dc; Fri, 26 May 2023 07:29:43 +0000 Received: by outflank-mailman (output) from mailman id 539983.841396; Fri, 26 May 2023 07:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtP-0003k3-AX; Fri, 26 May 2023 07:29:43 +0000 Received: by outflank-mailman (input) for mailman id 539983; Fri, 26 May 2023 07:29:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtO-0003UM-FD for xen-devel@lists.xenproject.org; Fri, 26 May 2023 07:29:42 +0000 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12f7af00-fb97-11ed-b230-6b7b168915f2; Fri, 26 May 2023 09:29:41 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz4Q7TX64X (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 26 May 2023 09:29:33 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12f7af00-fb97-11ed-b230-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1685086173; cv=none; d=strato.com; s=strato-dkim-0002; b=l1i/SpN7IoXyLCxtKbRcE8qxemJPzqzhZiiabaWtd8WLn+qgtkSOJOsO07vC8PyCrH 0tU5ArybFAiqgIrW3AyIPnYeZBX/ilDR+HtbCuUcphuFrpuYhCsD9TCQf9pmrNHdPyzO O4KMPY6v4oJAICXF853449xMDiyRgaQLIvC3Mgl6M7HI2fwAdySVQj+OOkcgEKdUcdLi TkPpyp1D+8CiENDUdERdN5tYYTp/kmxico2RCNYFfxKWpPgp6f0iaibJbH2+ZW36+mm9 wa0TtLEe07LgMAHTZjySnonJU9xwv9RCcGXsL/MFskehM0QxxUTSfITeVNQwxSh72DbG VK9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086173; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=WpoeBuGWahQjx/3EeADqCoRxafSHjWOb2yRv/RTe6Uo=; b=CNJ3dvKAoMGNLpiIxAvXaQHTpNikEjPtwMG9JacnTIOf/iKgd7MdCIEQ1RSANa5M1y E8zfs63wZJKlHIhW9WLT5BKZTX+jl34aA4Pvx2AUztlO6y+0YdvBFTztLJOMm6/AQ2Cq 5ZReVSJHjmKabF/skGUxoTW7TjaAdiDkuc2Gzq7iybW8yP09N4Hw5OyMRFXNxWqhn5Lp ILfnRosz5OCSKTLCPjsA7e8nLdOvhwQAbyG9ap/uwFiQfMm2tCz4zyiVVwZc9a90fyOH hYQ5CliZGoyip+WCXl8gLRXzMsSRnwXs5ZseL55Bbv1viJWAvDq/Hm9vXmBCBjfP7Mx4 oL2g== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086173; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=WpoeBuGWahQjx/3EeADqCoRxafSHjWOb2yRv/RTe6Uo=; b=T5w+qTlNfVPYH50sWMUQyIOgq2tZbX8fDtIAT+Rq9j6GRIDMB6NL0pHmsWW5B2c3N+ iCFt3SSZYaI6LMvvLK9eK00+S20chnJyigJRQXQZNB/fr4JWpNtuBCyoQzWmwLwewEP0 5BXurV1dRGRfXu+kKLSR1kiCwo3YbnZm/if2AUwHq4pbYnj6RovPTeDjWLlwsJt/3Yam ea4+8selNmD6cfQwzfATMgc9IqXVp5SezkOy0km1OWyg5rDW1sKhCmRkd8Dwxo9ab2bC m3/V7M491uiPxP1jgo00pY3dw6tirenWI3NcrtRDHUkGi59kX0X5W8VyKTGF5qs+aTLx kJlg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1685086173; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=WpoeBuGWahQjx/3EeADqCoRxafSHjWOb2yRv/RTe6Uo=; b=0huKukAolae739l9QzADDZQTc3VDAUFQwHadcUOSh4Vlxh7dRZQHLrz913NCWi2egX 09Ywh8DrvlUFlCLeVJDQ== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4xqFv7EJ0tgRX/vKfT/e8Ig6v0dNw4QAWpzMWrRQ==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: George Dunlap , Wei Liu , Anthony PERARD Subject: [PATCH v1 2/3] xentrace: remove return value from monitor_tbufs Date: Fri, 26 May 2023 09:29:15 +0200 Message-Id: <20230526072916.7424-3-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230526072916.7424-1-olaf@aepfle.de> References: <20230526072916.7424-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1685086211895100001 Content-Type: text/plain; charset="utf-8" The function always returns zero. Signed-off-by: Olaf Hering Reviewed-by: George Dunlap --- tools/xentrace/xentrace.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index b81abe8a51..a073cab26d 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -668,7 +668,7 @@ static void wait_for_event_or_timeout(unsigned long mil= liseconds) * monitor_tbufs - monitor the contents of tbufs and output to a file * @logfile: the FILE * representing the file to log to */ -static int monitor_tbufs(void) +static void monitor_tbufs(void) { int i; =20 @@ -795,8 +795,6 @@ static int monitor_tbufs(void) free(data); /* don't need to munmap - cleanup is automatic */ close(outfd); - - return 0; } =20 =20 @@ -1164,7 +1162,6 @@ static void parse_args(int argc, char **argv) =20 int main(int argc, char **argv) { - int ret; struct sigaction act; =20 opts.outfile =3D 0; @@ -1226,9 +1223,9 @@ int main(int argc, char **argv) sigaction(SIGINT, &act, NULL); sigaction(SIGALRM, &act, NULL); =20 - ret =3D monitor_tbufs(); + monitor_tbufs(); =20 - return ret; + return 0; } =20 /* From nobody Tue May 7 15:55:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=fail (Bad Signature) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1685086212042160.8202807035799; Fri, 26 May 2023 00:30:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.539984.841402 (Exim 4.92) (envelope-from ) id 1q2RtP-0003n6-PZ; Fri, 26 May 2023 07:29:43 +0000 Received: by outflank-mailman (output) from mailman id 539984.841402; Fri, 26 May 2023 07:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtP-0003mO-I4; Fri, 26 May 2023 07:29:43 +0000 Received: by outflank-mailman (input) for mailman id 539984; Fri, 26 May 2023 07:29:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RtO-0003Ci-GV for xen-devel@lists.xenproject.org; Fri, 26 May 2023 07:29:42 +0000 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13aa6cd4-fb97-11ed-8611-37d641c3527e; Fri, 26 May 2023 09:29:40 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.4.0 AUTH) with ESMTPSA id x6987cz4Q7Ta64Y (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 26 May 2023 09:29:36 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13aa6cd4-fb97-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1685086176; cv=none; d=strato.com; s=strato-dkim-0002; b=RAqu1yHSHxgRyjWc+mh6lftf8lCD1fl4SAElcfkzB2KkjlTPYR1UmDbkHSJbibZKn4 CSxDWsO2eMx2cmAMEOmbT3svp/tOC+mxaa89Y06r2FOUS3vJvRAYWhEOTzjHaBCFbM59 xQ8flx0m89L7ZEphGyRlsg26r/7nwmEmJpWjJ4fLTOE55tYrdCPGQgSPmnUFkURKI3Zj 4RHcbMpsc+h6z3UquEe2k7UCECE/rB9U664p5n6zozLaDUP/45qpKb1lqSLxWXOZUsfR OKtkanyZLfXuI/2sCkgYozt3kRIJAdGmMIzB9cZjvB6raihuvzT6TuEPm4458avyXb80 PtVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086176; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=S9fPMSqhE3ipoGZSZM4sNJyNsCfbZYCsqL8IUbcARXw=; b=aDOvrs9KzVLHyoDJ3Z+DvNde7Ddzq5Va3a1UbIrTZHuLnM4MzMrsvGQyUsYeJ/jNul wIrsTMXKxX2XLQ/uM9ZV/dP5KxiJEW48CjkFU5cQzU25D9n4YFDRoTsz3Q3EZlWu+f8X PMxJY/SsqTTXNwlz0ZaQ8UcgSTLnGoDURmAISgI4lQNFR3ZwI4nRXXXyqDZ9mnM98Cu8 6IqzBa2zq2du2jWpLLAe8qaFeaLuCnRdhh3L5jdOkyCPAEvXtXeZtn81NSmh2xAcS21d LdSoljnzprqbMT1KzGgdCHvF9N5fSxdszYqKweq59DxOM4N5rAWDwHn15WbKA/MgLDq2 2Tzg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086176; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=S9fPMSqhE3ipoGZSZM4sNJyNsCfbZYCsqL8IUbcARXw=; b=pWnFatpRSi7NIG8u86l6nkWRr1ZTeC1IktYz6Lrb/tHwg4aBAL2ByevDmk3W1lwhQ7 C8MTIUtirgzlEZrd/oQb/Zn7tKOjqyGeNRwog0TC4Ja6uLaHdyft9aS1NHFuGLymZiCL 4RMeycPNWCTlTFx1kRIBkXsAFXPs6IwX3AGj9RE7iJmxx5jop2CY3XiVHuxbZpWwsK5t jy55ihCzo41wr6gOuUESWAeDNFajU8r/psIlvKfC7ZXuabxrzKfyY7n6xL/thBOpTEJx ld78/uoFw4DYow7Hj3pSAzw+NN2gMW1cJEaPSW1YOxiCpwESAAXvfhrWusf1nHk996ra Gq8Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1685086176; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=S9fPMSqhE3ipoGZSZM4sNJyNsCfbZYCsqL8IUbcARXw=; b=hPVQ0e7hJGk5SflODIvVj8uOgvQm0ZnSqnb4EW2uECxsL0FLB2rPLHYhunnkxtAd9l KczprFLs/MSbHqociQAw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAg4xqFv7EJ0tgRX/vKfT/e8Ig6v0dNw4QAWpzMWrRQ==" From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: George Dunlap , Wei Liu , Anthony PERARD Subject: [PATCH v1 3/3] xentrace: close output file in the function which opened it Date: Fri, 26 May 2023 09:29:16 +0200 Message-Id: <20230526072916.7424-4-olaf@aepfle.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230526072916.7424-1-olaf@aepfle.de> References: <20230526072916.7424-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1685086213220100005 Content-Type: text/plain; charset="utf-8" Signed-off-by: Olaf Hering Reviewed-by: George Dunlap --- tools/xentrace/xentrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index a073cab26d..3548255123 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -794,7 +794,6 @@ static void monitor_tbufs(void) free(meta); free(data); /* don't need to munmap - cleanup is automatic */ - close(outfd); } =20 =20 @@ -1225,6 +1224,7 @@ int main(int argc, char **argv) =20 monitor_tbufs(); =20 + close(outfd); return 0; }