From nobody Sat May 11 04:42:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680703025; cv=none; d=zohomail.com; s=zohoarc; b=VPMxnWPNms5apDGcs+zPVkt9leMchS8ho6G7mK9V8Q4NXqJxCAD5P/GjMk4vgEgv8I2U1gsMgupZWwmm6T5kgM9MGkvaYU9RktLS7xHmy2x1isSzpY0MuzDBuLXHyAqdkKNU6C4G0Sm4zix+GSZCuXgZ8UjyeoOlp5QXiot13+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680703025; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QJpVodEY5mLUPTwqhB6PQxZ33ssAbKfS1kQ6CEUaSKQ=; b=XrmmNPKcQDJXhLZNFBZZie84uPlVn472psa9VGOxLgAU0VSVbhzZj82n5PqHkvlizqECQgqvxuZuDdpTKDeb0vuBCT6mAH2Be1w8V+rcOwzU3fOC/3yvfGGF5xQ7L+8y+Yjvo0V1NfrvmHBnTzw251dddnEat6OCFiDAhCxVkl8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680703025251268.83041252069086; Wed, 5 Apr 2023 06:57:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.518540.805214 (Exim 4.92) (envelope-from ) id 1pk3cu-00082a-Tw; Wed, 05 Apr 2023 13:56:40 +0000 Received: by outflank-mailman (output) from mailman id 518540.805214; Wed, 05 Apr 2023 13:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cu-00082P-Qq; Wed, 05 Apr 2023 13:56:40 +0000 Received: by outflank-mailman (input) for mailman id 518540; Wed, 05 Apr 2023 13:56:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cs-0007mI-TH for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:56:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aebb4c0b-d3b9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:56:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2780F20634; Wed, 5 Apr 2023 13:56:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0A4213A31; Wed, 5 Apr 2023 13:56:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cCeONRR+LWTSeAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aebb4c0b-d3b9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680702997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJpVodEY5mLUPTwqhB6PQxZ33ssAbKfS1kQ6CEUaSKQ=; b=ICMD0WG228KSxZpnbPT9WhTr77YIy+K2/4tIt2/1rxBAm33MSOIT5lZcnBXbdPAo165omS tibC4ydjOIu/4lEN2EmBEmqKafzYNwZ7irgtWCTYjikvA7EkRQlcS64l+jI9hR2k5+WNdS Xb7SGc9jYF1y4cFySy5JbUiOwPpTPmA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section Date: Wed, 5 Apr 2023 15:56:28 +0200 Message-Id: <20230405135629.21829-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405135629.21829-1-jgross@suse.com> References: <20230405135629.21829-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680703026188100003 Content-Type: text/plain; charset="utf-8" In order to support hypervisor analysis of crash dumps, xen-syms needs to contain debug_info. It should be allowed to configure the hypervisor to be built with CONFIG_DEBUG_INFO in non-debug builds without having to enable EXPERT. Using a rather oldish gcc (7.5) it was verified that code generation doesn't really differ between CONFIG_DEBUG_INFO on or off without CONFIG_DEBUG being set (only observed differences were slightly different symbol addresses, verified via "objdump -d", resulting from the different config.gz in the binary). The old gcc version selection was based on the assumption, that newer gcc won't regress in this regard. So move CONFIG_DEBUG_INFO out of the section guarded by EXPERT. It should be mentioned that there have been reports that the linking of the xen.efi might take considerably longer with CONFIG_DEBUG_INFO selected when using newer binutils. Signed-off-by: Juergen Gross Acked-by: Jan Beulich Tested-by: Dietmar Hahn --- V2: - expanded commit message (Jan Beulich) V3: - move DEBUG_INFO block to the end of the file (Jan Beulich) --- xen/Kconfig.debug | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index fad3050d4f..279dbe8274 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -28,13 +28,6 @@ config GDBSX If you want to enable support for debugging guests from dom0 via gdbsx then say Y. =20 -config DEBUG_INFO - bool "Compile Xen with debug info" - default y - ---help--- - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. - config FRAME_POINTER bool "Compile Xen with frame pointers" default DEBUG @@ -132,4 +125,11 @@ source "arch/$(SRCARCH)/Kconfig.debug" =20 endif # DEBUG || EXPERT =20 +config DEBUG_INFO + bool "Compile Xen with debug info" + default DEBUG + help + If you say Y here the resulting Xen will include debugging info + resulting in a larger binary image. + endmenu --=20 2.35.3 From nobody Sat May 11 04:42:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680703025; cv=none; d=zohomail.com; s=zohoarc; b=NyrlGXHj4e6o1FJCj7JMpQdrEdLytPE9hK3HmfftI2Bo9h3DNJA/oBl5t6v8+IiO/BRS6I62JgbabNqZfGjI4W3vygTxq1UVmQaP4NhEs1O18IUKJS6kcokSdRDo055/Ewz23+C4pryYtrcVcRMDrpcDRykgERw/1U592Uu5+3c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680703025; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h7E8xLpIHHyBj6gOvbHVGHsCDEUl39NE+WedwK4I/34=; b=LDiV00NAwVOuw6li7EJDvibWtkmNwuN+L+DLnk1BzBiLCvX++Gm6DLp1uPu+r7xxl0To3iiKR7Vs2194Z4eoFkkzUBPmHXgRJcK1DJoSRgCShTkemkhlfJbZCHFK7RSm4fkfIbFGL4v6+XDfdd0Zs5GizuOxoLqFPx8vCcf5H1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680703025791663.8379441545085; Wed, 5 Apr 2023 06:57:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.518541.805224 (Exim 4.92) (envelope-from ) id 1pk3cz-0008KX-86; Wed, 05 Apr 2023 13:56:45 +0000 Received: by outflank-mailman (output) from mailman id 518541.805224; Wed, 05 Apr 2023 13:56:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cz-0008KQ-4o; Wed, 05 Apr 2023 13:56:45 +0000 Received: by outflank-mailman (input) for mailman id 518541; Wed, 05 Apr 2023 13:56:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pk3cy-0007mI-Kd for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 13:56:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b21a5398-d3b9-11ed-b464-930f4c7d94ae; Wed, 05 Apr 2023 15:56:43 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C81BD20634; Wed, 5 Apr 2023 13:56:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8864513A31; Wed, 5 Apr 2023 13:56:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aZsHIBp+LWTeeAAAMHmgww (envelope-from ); Wed, 05 Apr 2023 13:56:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b21a5398-d3b9-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680703002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7E8xLpIHHyBj6gOvbHVGHsCDEUl39NE+WedwK4I/34=; b=MxDaNNi+YFuqUHP7aB796xrZ4HmTYr/kmjo7qmjvN1Tpga2ne9dHvL83hwTuBHGVdDsq/w OEPIkmzi/YgnHxOG9TOPMcAeoa923Ia58r3Y3uMV0P71qbeBjCsURWOcMwHXTz9XNH3A8X xW0xz7fVyw2rQyr01HbJ/MM/MfsnOFI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 2/2] xen: update CONFIG_DEBUG_INFO help text Date: Wed, 5 Apr 2023 15:56:29 +0200 Message-Id: <20230405135629.21829-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405135629.21829-1-jgross@suse.com> References: <20230405135629.21829-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680703027078100005 Content-Type: text/plain; charset="utf-8" Update the help text of the CONFIG_DEBUG_INFO option to be a little bit more specific. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- V2: - expand help text, especially mentioning INSTALL_EFI_STRIP (Jan Beulich) V3: - expand help text even more (Jan Beulich) --- xen/Kconfig.debug | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 279dbe8274..94e818ee09 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -129,7 +129,15 @@ config DEBUG_INFO bool "Compile Xen with debug info" default DEBUG help - If you say Y here the resulting Xen will include debugging info - resulting in a larger binary image. + Say Y here if you want to build Xen with debug information. This + information is needed e.g. for doing crash dump analysis of the + hypervisor via the "crash" tool. + Saying Y will increase the size of the xen-syms and xen.efi + binaries. In case the space on the EFI boot partition is rather + limited, you may want to install a stripped variant of xen.efi in + the EFI boot partition (look for "INSTALL_EFI_STRIP" in + docs/misc/efi.pandoc for more information - when not using + "make install-xen" for installing xen.efi, stripping needs to be + done outside the Xen build environment). =20 endmenu --=20 2.35.3