From nobody Mon Feb 9 23:39:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680678299; cv=none; d=zohomail.com; s=zohoarc; b=NMrg75P7g1kAz/pYmal7hi4/XmDRTvL2mcMcwQcF4Ic8ujyhtZSOMkFrUX1be4BjDj/YhVcsUGpzjutI/2JxOFxoQQTJL2lMqLeTh+0c9cSe38AvvRraZjwqUkQembpDGUEe3yQThzp4+PKGxhk/6gC6HV5UMjHXrxsVSqYVxVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680678299; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yXnL6y0xe3ujnGIrpffgz9CI+U2tC4w1dZmiNxkMXsw=; b=hYaDaNatgzD7xsQgqDVgdnUnDE3MSXUQylHu7nIPPqMwMXMB0kbiNupWrYb2nvRLjYFQCwdj5wrtTFzl8xOSx5F00B0L33OwwY1nPTrUlTmc6AsUfmkpQHPQuU9UiF8PkgXyn442syhOjXZnJE9VzyLSJrmPQjbBxDv8vP3ZJ5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680678299636461.6187975697968; Wed, 5 Apr 2023 00:04:59 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.518244.804598 (Exim 4.92) (envelope-from ) id 1pjxC6-0005Fx-1l; Wed, 05 Apr 2023 07:04:34 +0000 Received: by outflank-mailman (output) from mailman id 518244.804598; Wed, 05 Apr 2023 07:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC5-0005F8-U0; Wed, 05 Apr 2023 07:04:33 +0000 Received: by outflank-mailman (input) for mailman id 518244; Wed, 05 Apr 2023 07:04:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pjxC3-0002UC-Rz for xen-devel@lists.xenproject.org; Wed, 05 Apr 2023 07:04:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cacb26e-d380-11ed-85db-49a42c6b2330; Wed, 05 Apr 2023 09:04:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BCE9D229FF; Wed, 5 Apr 2023 07:04:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F10E13A31; Wed, 5 Apr 2023 07:04:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id whOiIX4dLWTHEwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 07:04:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cacb26e-d380-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680678270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXnL6y0xe3ujnGIrpffgz9CI+U2tC4w1dZmiNxkMXsw=; b=W7D+JLybanPWNvnVDx6eoSXB/U3WJR6A7WZ9HEE3UUKI5O26jvf9gW0MfxlUvBkM7mydAw llKH5a7EwZZXjTgpPQxN7NF4APfwC9TjembZO5rkzqIuoTkLjxb6ghyYN2iBRTzH/hlIyU os3novb/1onmO6ME64axrSDcIZqN0po= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values Date: Wed, 5 Apr 2023 09:03:43 +0200 Message-Id: <20230405070349.25293-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230405070349.25293-1-jgross@suse.com> References: <20230405070349.25293-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680678301834100003 Content-Type: text/plain; charset="utf-8" Add the accounting of per-domain usage of Xenstore memory, watches, and outstanding requests to the array based mechanism. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 +-- tools/xenstore/xenstored_domain.c | 111 +++++++++++------------------- tools/xenstore/xenstored_domain.h | 10 +-- 3 files changed, 52 insertions(+), 77 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 88ae674523..67aa7c1578 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -255,7 +255,7 @@ static void free_buffered_data(struct buffered_data *ou= t, req->pend.ref.event_cnt--; if (!req->pend.ref.event_cnt && !req->on_out_list) { if (req->on_ref_list) { - domain_outstanding_domid_dec( + domain_outstanding_dec(conn, req->pend.ref.domid); list_del(&req->list); } @@ -271,7 +271,7 @@ static void free_buffered_data(struct buffered_data *ou= t, out->on_ref_list =3D true; return; } else - domain_outstanding_dec(conn); + domain_outstanding_dec(conn, conn->id); =20 talloc_free(out); } @@ -1077,7 +1077,7 @@ void send_reply(struct connection *conn, enum xsd_soc= kmsg_type type, /* Queue for later transmission. */ list_add_tail(&bdata->list, &conn->out_list); bdata->on_out_list =3D true; - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); } =20 /* @@ -3320,7 +3320,7 @@ static void add_buffered_data(struct buffered_data *b= data, * request have been delivered. */ if (bdata->hdr.msg.type !=3D XS_WATCH_EVENT) - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); /* * We are restoring the state after Live-Update and the new quota may * be smaller. So ignore it. The limit will be applied for any resource diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_d= omain.c index f94812610a..22836ae881 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -72,19 +72,12 @@ struct domain /* Accounting data for this domain. */ unsigned int acc[ACC_N]; =20 - /* Amount of memory allocated for this domain. */ - int memory; + /* Memory quota data for this domain. */ bool soft_quota_reported; bool hard_quota_reported; time_t mem_last_msg; #define MEM_WARN_MINTIME_SEC 10 =20 - /* number of watch for this domain */ - int nbwatch; - - /* Number of outstanding requests. */ - int nboutstanding; - /* write rate limit */ wrl_creditt wrl_credit; /* [ -wrl_config_writecost, +_dburst ] */ struct wrl_timestampt wrl_timestamp; @@ -202,14 +195,15 @@ static bool domain_can_write(struct connection *conn) =20 static bool domain_can_read(struct connection *conn) { - struct xenstore_domain_interface *intf =3D conn->domain->interface; + struct domain *domain =3D conn->domain; + struct xenstore_domain_interface *intf =3D domain->interface; =20 if (domain_is_unprivileged(conn)) { - if (conn->domain->wrl_credit < 0) + if (domain->wrl_credit < 0) return false; - if (conn->domain->nboutstanding >=3D quota_req_outstanding) + if (domain->acc[ACC_OUTST] >=3D quota_req_outstanding) return false; - if (conn->domain->memory >=3D quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM] >=3D quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -440,10 +434,10 @@ int domain_get_quota(const void *ctx, struct connecti= on *conn, if (!resp) return ENOMEM =20 ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->nbwatch); + ent(watches, d->acc[ACC_WATCH]); ent(transactions, ta); - ent(outstanding, d->nboutstanding); - ent(memory, d->memory); + ent(outstanding, d->acc[ACC_OUTST]); + ent(memory, d->acc[ACC_MEM]); =20 #undef ent =20 @@ -1186,14 +1180,16 @@ unsigned int domain_nbentry(struct connection *conn) ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } =20 -static bool domain_chk_quota(struct domain *domain, int mem) +static bool domain_chk_quota(struct connection *conn, unsigned int mem) { time_t now; + struct domain *domain; =20 - if (!domain || !domid_is_unprivileged(domain->domid) || - (domain->conn && domain->conn->is_ignored)) + if (!conn || !domid_is_unprivileged(conn->id) || + conn->is_ignored) return false; =20 + domain =3D conn->domain; now =3D time(NULL); =20 if (mem >=3D quota_memory_per_domain_hard && @@ -1238,80 +1234,57 @@ static bool domain_chk_quota(struct domain *domain,= int mem) int domain_memory_add(struct connection *conn, unsigned int domid, int mem, bool no_quota_check) { - struct domain *domain; + int ret; =20 - domain =3D find_domain_struct(domid); - if (domain) { - /* - * domain_chk_quota() will print warning and also store whether - * the soft/hard quota has been hit. So check no_quota_check - * *after*. - */ - if (domain_chk_quota(domain, domain->memory + mem) && - !no_quota_check) - return ENOMEM; - domain->memory +=3D mem; - } else { - /* - * The domain the memory is to be accounted for should always - * exist, as accounting is done either for a domain related to - * the current connection, or for the domain owning a node - * (which is always existing, as the owner of the node is - * tested to exist and deleted or replaced by domid 0 if not). - * So not finding the related domain MUST be an error in the - * data base. - */ - errno =3D ENOENT; - corrupt(NULL, "Accounting called for non-existing domain %u\n", - domid); - return ENOENT; - } + ret =3D domain_acc_add(conn, domid, ACC_MEM, 0, true); + if (ret < 0) + return -ret; + + /* + * domain_chk_quota() will print warning and also store whether the + * soft/hard quota has been hit. So check no_quota_check *after*. + */ + if (domain_chk_quota(conn, ret + mem) && !no_quota_check) + return ENOMEM; + + /* + * The domain the memory is to be accounted for should always exist, + * as accounting is done either for a domain related to the current + * connection, or for the domain owning a node (which is always + * existing, as the owner of the node is tested to exist and deleted + * or replaced by domid 0 if not). + * So not finding the related domain MUST be an error in the data base. + */ + domain_acc_add(conn, domid, ACC_MEM, mem, true); =20 return 0; } =20 void domain_watch_inc(struct connection *conn) { - if (!conn || !conn->domain) - return; - conn->domain->nbwatch++; + domain_acc_add(conn, conn->id, ACC_WATCH, 1, true); } =20 void domain_watch_dec(struct connection *conn) { - if (!conn || !conn->domain) - return; - if (conn->domain->nbwatch) - conn->domain->nbwatch--; + domain_acc_add(conn, conn->id, ACC_WATCH, -1, true); } =20 int domain_watch(struct connection *conn) { return (domain_is_unprivileged(conn)) - ? conn->domain->nbwatch + ? domain_acc_add(conn, conn->id, ACC_WATCH, 0, true) : 0; } =20 -void domain_outstanding_inc(struct connection *conn) +void domain_outstanding_inc(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding++; + domain_acc_add(conn, domid, ACC_OUTST, 1, true); } =20 -void domain_outstanding_dec(struct connection *conn) +void domain_outstanding_dec(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding--; -} - -void domain_outstanding_domid_dec(unsigned int domid) -{ - struct domain *d =3D find_domain_by_domid(domid); - - if (d) - d->nboutstanding--; + domain_acc_add(conn, domid, ACC_OUTST, -1, true); } =20 static wrl_creditt wrl_config_writecost =3D WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_d= omain.h index 5cfd730cf6..0d61bf4344 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -28,7 +28,10 @@ enum accitem { ACC_NODES, ACC_REQ_N, /* Number of elements per request. */ ACC_TR_N =3D ACC_REQ_N, /* Number of elements per transaction. */ - ACC_N =3D ACC_TR_N, /* Number of elements per domain. */ + ACC_WATCH =3D ACC_TR_N, + ACC_OUTST, + ACC_MEM, + ACC_N, /* Number of elements per domain. */ }; =20 void handle_event(void); @@ -107,9 +110,8 @@ static inline void domain_memory_add_nochk(struct conne= ction *conn, void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); -void domain_outstanding_inc(struct connection *conn); -void domain_outstanding_dec(struct connection *conn); -void domain_outstanding_domid_dec(unsigned int domid); +void domain_outstanding_inc(struct connection *conn, unsigned int domid); +void domain_outstanding_dec(struct connection *conn, unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); =20 --=20 2.35.3