From nobody Mon Feb 9 19:25:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680166248; cv=none; d=zohomail.com; s=zohoarc; b=WgtdXUuWIVkzpDtV3jybBRKc4nkYp+wg2/gV9DnQ+DDdFSrgeG9P63wDNupgwmBQ3JPEv9tyrXJ4iPN1W92L6Cn8km2i1wmNqsJFTDsPAoQyc2ZbVFGw4sQBqy3asPs++GHl3EgsYKvqXRl4HTG/wFKFnnKTydFolgVfElJZAoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680166248; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3pO10sPGTtdz9QC6xsd1+0esIC5/k5/zllx/QTVNu38=; b=ccrZ7msUVuVtKtopsyBt3wCxGzeLMBZtQ+rYeSlXR5bw67vVkAJbIth020J9MZYY+drOVYDzOXLwAHs+ohErBmxKlinz5wgzXzOSmKy1udhrS9CF4jSiqbV8zC2GmPVaj5oT1z/7YJnStxZhxBtyrEzi61135RUSLMJz8+1DlzI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680166248488748.2466221150893; Thu, 30 Mar 2023 01:50:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.516499.800692 (Exim 4.92) (envelope-from ) id 1phnzC-0005gn-LV; Thu, 30 Mar 2023 08:50:22 +0000 Received: by outflank-mailman (output) from mailman id 516499.800692; Thu, 30 Mar 2023 08:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phnzC-0005gg-I7; Thu, 30 Mar 2023 08:50:22 +0000 Received: by outflank-mailman (input) for mailman id 516499; Thu, 30 Mar 2023 08:50:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phnzA-0005fr-Ov for xen-devel@lists.xenproject.org; Thu, 30 Mar 2023 08:50:20 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e671c27c-ced7-11ed-85db-49a42c6b2330; Thu, 30 Mar 2023 10:50:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AFFD51FEAC; Thu, 30 Mar 2023 08:50:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8241F138FF; Thu, 30 Mar 2023 08:50:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id j1JwHktNJWTPIgAAMHmgww (envelope-from ); Thu, 30 Mar 2023 08:50:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e671c27c-ced7-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680166219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3pO10sPGTtdz9QC6xsd1+0esIC5/k5/zllx/QTVNu38=; b=DmhuzkqIdzhODt2DGUTtmkrxBKyvhZmORveGHb5t49odyVkcBxg58Ldul7gle+17oGkE0y l9C4qHDpsceHqSHpg9zOdTqSo8Qtp6NnVmsRbhjdQtPbw5qtyXiYukkqxwjxnmDsDshn3P PiNT3392sf+M+hK/TwxuQhWgOJECEZM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v2 01/13] tools/xenstore: verify command line parameters better Date: Thu, 30 Mar 2023 10:49:59 +0200 Message-Id: <20230330085011.9170-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230330085011.9170-1-jgross@suse.com> References: <20230330085011.9170-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680166249536100001 Content-Type: text/plain; charset="utf-8" Add some more verification of command line parameters. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- tools/xenstore/xenstored_core.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 6e2fc06840..7214b3df03 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2809,7 +2809,7 @@ int main(int argc, char *argv[]) no_domain_init =3D true; break; case 'E': - hard_quotas[ACC_NODES].val =3D strtoul(optarg, NULL, 10); + hard_quotas[ACC_NODES].val =3D get_optval_int(optarg); break; case 'F': pidfile =3D optarg; @@ -2827,10 +2827,10 @@ int main(int argc, char *argv[]) recovery =3D false; break; case 'S': - hard_quotas[ACC_NODESZ].val =3D strtoul(optarg, NULL, 10); + hard_quotas[ACC_NODESZ].val =3D get_optval_int(optarg); break; case 't': - hard_quotas[ACC_TRANS].val =3D strtoul(optarg, NULL, 10); + hard_quotas[ACC_TRANS].val =3D get_optval_int(optarg); break; case 'T': tracefile =3D optarg; @@ -2850,14 +2850,13 @@ int main(int argc, char *argv[]) verbose =3D true; break; case 'W': - hard_quotas[ACC_WATCH].val =3D strtoul(optarg, NULL, 10); + hard_quotas[ACC_WATCH].val =3D get_optval_int(optarg); break; case 'A': - hard_quotas[ACC_NPERM].val =3D strtoul(optarg, NULL, 10); + hard_quotas[ACC_NPERM].val =3D get_optval_int(optarg); break; case 'M': - hard_quotas[ACC_PATHLEN].val =3D - strtoul(optarg, NULL, 10); + hard_quotas[ACC_PATHLEN].val =3D get_optval_int(optarg); hard_quotas[ACC_PATHLEN].val =3D min((unsigned int)XENSTORE_REL_PATH_MAX, hard_quotas[ACC_PATHLEN].val); @@ -2872,13 +2871,13 @@ int main(int argc, char *argv[]) set_timeout(optarg); break; case 'e': - dom0_event =3D strtol(optarg, NULL, 10); + dom0_event =3D get_optval_int(optarg); break; case 'm': - dom0_domid =3D strtol(optarg, NULL, 10); + dom0_domid =3D get_optval_int(optarg); break; case 'p': - priv_domid =3D strtol(optarg, NULL, 10); + priv_domid =3D get_optval_int(optarg); break; #ifndef NO_LIVE_UPDATE case 'U': --=20 2.35.3