From nobody Fri May 10 14:49:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680077013; cv=none; d=zohomail.com; s=zohoarc; b=TWKES8FIAPlI5KcQgbiofCLRla21+nd81tHfmvbLnrZhzA02WR6anaqUKN6avpC7X45uirPeWfE+LCWY9ihlfSHVcNUIeJA8pxMkIWtNWIMuwQm4+8NQrFwmVn0rULRepZj8u8gMeXSNGUqUXNmtgHznBdJGuQnrlIXexEPNv0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680077013; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=XkIlKbNA1TkczV1RQwGRPvUdSOv/P1LFG2UzjXLvDSU=; b=NIgwKUOkJQIeFpSP1T6Z5cmrTmhI+XpVvUvLEz0JHPQ8bgKGQxDf1bD5/ESgrNhV1Nw6z9/A2JNjnvmBh0+CoojOxmWhp09mK7ozpXabLsfXkk1r/eg7VENzh0OJoTEsjWIkbgTMUpAHK17dVVCNDjF/q8X3IIL3Olm67TctNZo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680077013338688.7817363289715; Wed, 29 Mar 2023 01:03:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.516098.799668 (Exim 4.92) (envelope-from ) id 1phQlw-0002y1-AM; Wed, 29 Mar 2023 08:03:08 +0000 Received: by outflank-mailman (output) from mailman id 516098.799668; Wed, 29 Mar 2023 08:03:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phQlw-0002xu-7R; Wed, 29 Mar 2023 08:03:08 +0000 Received: by outflank-mailman (input) for mailman id 516098; Wed, 29 Mar 2023 08:03:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phQlv-0002xm-3Z for xen-devel@lists.xenproject.org; Wed, 29 Mar 2023 08:03:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 21d3d7c8-ce08-11ed-85db-49a42c6b2330; Wed, 29 Mar 2023 10:03:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A91031FE0C; Wed, 29 Mar 2023 08:03:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5602A139D3; Wed, 29 Mar 2023 08:03:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gP+dE7fwI2QLVAAAMHmgww (envelope-from ); Wed, 29 Mar 2023 08:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21d3d7c8-ce08-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680076983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XkIlKbNA1TkczV1RQwGRPvUdSOv/P1LFG2UzjXLvDSU=; b=l686GUWRSYDUHgUznltiyuVdym2edkLnSc7FQgWFkIM47r7WpN2eCj0rOSOWAOPRzKIbcn MzsbTQUYdGLGBtUVfeL7hzX+43Sf0U78MmmZWgWiwD85yibarwgOUC4rWn+AtBS3389qCJ o3va+i7x9e5FYkdI02qO0JklhX3jyjI= From: Juergen Gross To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, Jan Beulich Subject: [PATCH v3] xen/netback: use same error messages for same errors Date: Wed, 29 Mar 2023 10:02:59 +0200 Message-Id: <20230329080259.14823-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680077014457100001 Content-Type: text/plain; charset="utf-8" Issue the same error message in case an illegal page boundary crossing has been detected in both cases where this is tested. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - new patch V3: - modify message text (Jan Beulich) --- drivers/net/xen-netback/netback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/ne= tback.c index 9ca4b69d3b39..dbaead243737 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *= queue, =20 /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { - netdev_err(queue->vif->dev, - "txreq.offset: %u, size: %u, end: %lu\n", - txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); + netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, siz= e: %u\n", + txreq.offset, txreq.size); xenvif_fatal_tx_err(queue->vif); break; } --=20 2.35.3