From nobody Fri May 3 21:30:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1680014161; cv=none; d=zohomail.com; s=zohoarc; b=k3z1Yb9zaD+m4HXAip3lGhYoZhjDktnZPfwOsxyS7/O0C9YpmOGL4+HVYv4nFDro1FEkImR/Z8AQLBcnffNs3B5n+MAlY3eTR5zlZ67EntQmmi2hX/tDL+zWPgMHRRWjVz2V5y/1pXBqqtVxIUNtACpcbZQluWKkz9jFK7a7GEY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680014161; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cpP+qMBWSkWzFGiAjKpXztpzxl2tQH7Ol5+fc07JFl8=; b=Z83RinKZ8XIoB1wU5d20zqCZ8crFF0l1KNFBesbXe9T4D/iBZUy2h5E8C8kXpXaxmGH54L0jCoUIKgFDWw/quMEcllS8/KN66Bd+edijdxr+PWttDXckG8aXiSpvSJ0AwlLb0gJMeDTfp/ve1BIri7is2WiDEZ8kCSiyRZ09Q4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1680014161962571.7083294356397; Tue, 28 Mar 2023 07:36:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.515903.799240 (Exim 4.92) (envelope-from ) id 1phAQ1-0002z7-4B; Tue, 28 Mar 2023 14:35:25 +0000 Received: by outflank-mailman (output) from mailman id 515903.799240; Tue, 28 Mar 2023 14:35:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phAQ1-0002z0-1Y; Tue, 28 Mar 2023 14:35:25 +0000 Received: by outflank-mailman (input) for mailman id 515903; Tue, 28 Mar 2023 14:35:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phAQ0-0002yu-LQ for xen-devel@lists.xenproject.org; Tue, 28 Mar 2023 14:35:24 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c54a345c-cd75-11ed-b464-930f4c7d94ae; Tue, 28 Mar 2023 16:35:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F13081FDD8; Tue, 28 Mar 2023 14:35:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD68F1390D; Tue, 28 Mar 2023 14:35:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yFw+LCn7ImQNewAAMHmgww (envelope-from ); Tue, 28 Mar 2023 14:35:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c54a345c-cd75-11ed-b464-930f4c7d94ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680014121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=cpP+qMBWSkWzFGiAjKpXztpzxl2tQH7Ol5+fc07JFl8=; b=QDfBS3AijC3KKlnDh41hx7ETWI84MuyaMBZy9LOUpv3fq9RUc/HFLrT7BsWSNDJBvQyRyH qi13l9FFlQe7E2/LTFmn3sWC5ONcnm1hvSMqB5umACJEI1r9wKl0aeNVX42Kr/7fXNvOAH xe0B9W9TyToq4X0fJEwfunKEnMjEkCI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v2] tools/xenstore: remove stale comment in create_node() Date: Tue, 28 Mar 2023 16:35:20 +0200 Message-Id: <20230328143520.5988-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1680014162855100001 Content-Type: text/plain; charset="utf-8" There is a part of a comment in create_node() which should have been deleted when modifying the related coding. Fixes: 1cd3cc7ea27c ("tools/xenstore: create_node: Don't defer work to undo= any changes on failure") Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - add Fixes: tag (Julien Grall) --- tools/xenstore/xenstored_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 7348f935bc..a61db2db2d 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1480,9 +1480,6 @@ static struct node *create_node(struct connection *co= nn, const void *ctx, * All new created nodes will have i->parent set, while the final * node will be already existing and won't have i->parent set. * New nodes are subject to quota handling. - * Initially set a destructor for all new nodes removing them from - * TDB again and undoing quota accounting for the case of an error - * during the write loop. */ for (i =3D node; i; i =3D i->parent) { /* i->parent is set for each new node, so check quota. */ --=20 2.35.3