From nobody Mon Feb 9 14:33:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1674035443; cv=none; d=zohomail.com; s=zohoarc; b=cHna8UXwDokSgMmhkN7h993NFLNBhyPbGOr1E4tDQ0bMk17UeFmC1gYMefSQer2hJ2nFwU0CwHOrwxkUYZ5wsZ4WhC51CcAbVOiSE+oFHodzf94ncbq1/Kx459Llm/BWx1s7MjqilScb1eoZ2Pnk1tZtGzseR+wXFxrrschUISg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674035443; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CmJqgfwW3rgZ4aM9nfaFZhVOgg064OnswcLCYgVlRWM=; b=fpw5tifF4sPCHOLdw51cVEX3SoQK01/oN0SR4hM9v/WHvqrQd6s8w5qj3G6ptH1OBj+y5EwPSqakWcOTEER4pvX298Xlcg6h5TM2HFnxMOL8rbiwW7GAL1oAX6S3NI/fs51pgcEMgebNKpy2zdzlKs8ZPGI+U3Vhl7tFiifJaQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1674035443383883.7872047443624; Wed, 18 Jan 2023 01:50:43 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.480310.744646 (Exim 4.92) (envelope-from ) id 1pI55P-0001VQ-Ml; Wed, 18 Jan 2023 09:50:27 +0000 Received: by outflank-mailman (output) from mailman id 480310.744646; Wed, 18 Jan 2023 09:50:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pI55P-0001VJ-Il; Wed, 18 Jan 2023 09:50:27 +0000 Received: by outflank-mailman (input) for mailman id 480310; Wed, 18 Jan 2023 09:50:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pI55O-0001BV-UU for xen-devel@lists.xenproject.org; Wed, 18 Jan 2023 09:50:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5389e1da-9715-11ed-b8d1-410ff93cb8f0; Wed, 18 Jan 2023 10:48:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D1E1520C51; Wed, 18 Jan 2023 09:50:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A11F7139D2; Wed, 18 Jan 2023 09:50:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8B8CJuDAx2MrQwAAMHmgww (envelope-from ); Wed, 18 Jan 2023 09:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5389e1da-9715-11ed-b8d1-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674035424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmJqgfwW3rgZ4aM9nfaFZhVOgg064OnswcLCYgVlRWM=; b=btpHFKt8tGY6pgUSEfVbx9hsSYlWovpVvBz+Fu/mzw0Tl1juUL3rCqfspkcoPh4lvSn9wa NklWmiLRUSO96+x0IGHwrKyYw7TS4ZPM+g69ihDVNlXqhVQ3rJyrcRCBHXG0LMccv+B+EA VGuushRO1XLowRrR1VyyPeTpRe3iqgc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v4 01/17] tools/xenstore: let talloc_free() preserve errno Date: Wed, 18 Jan 2023 10:50:00 +0100 Message-Id: <20230118095016.13091-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230118095016.13091-1-jgross@suse.com> References: <20230118095016.13091-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1674035443705100001 Content-Type: text/plain; charset="utf-8" Today talloc_free() is not guaranteed to preserve errno, especially in case a custom destructor is being used. So preserve errno in talloc_free(). This allows to remove some errno saving outside of talloc.c. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - drop wrapper (Julien Grall) --- tools/xenstore/talloc.c | 21 +++++++++++++-------- tools/xenstore/xenstored_core.c | 2 -- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index d7edcf3a93..23c3a23b19 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -541,38 +541,39 @@ static void talloc_free_children(void *ptr) */ int talloc_free(void *ptr) { + int saved_errno =3D errno; struct talloc_chunk *tc; =20 if (ptr =3D=3D NULL) { - return -1; + goto err; } =20 tc =3D talloc_chunk_from_ptr(ptr); =20 if (tc->null_refs) { tc->null_refs--; - return -1; + goto err; } =20 if (tc->refs) { talloc_reference_destructor(tc->refs); - return -1; + goto err; } =20 if (tc->flags & TALLOC_FLAG_LOOP) { /* we have a free loop - stop looping */ - return 0; + goto success; } =20 if (tc->destructor) { talloc_destructor_t d =3D tc->destructor; if (d =3D=3D (talloc_destructor_t)-1) { - return -1; + goto err; } tc->destructor =3D (talloc_destructor_t)-1; if (d(ptr) =3D=3D -1) { tc->destructor =3D d; - return -1; + goto err; } tc->destructor =3D NULL; } @@ -594,10 +595,14 @@ int talloc_free(void *ptr) tc->flags |=3D TALLOC_FLAG_FREE; =20 free(tc); + success: + errno =3D saved_errno; return 0; -} - =20 + err: + errno =3D saved_errno; + return -1; +} =20 /* A talloc version of realloc. The context argument is only used if diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 78a3edaa4e..1650821922 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -771,9 +771,7 @@ struct node *read_node(struct connection *conn, const v= oid *ctx, return node; =20 error: - err =3D errno; talloc_free(node); - errno =3D err; return NULL; } =20 --=20 2.35.3