From nobody Mon Feb 9 16:19:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1673946771; cv=none; d=zohomail.com; s=zohoarc; b=dmcaev8RCNDgDht+3j9fu79ZlrEWIszf3OE+Mq0PaLXpH286KHxXdC39G9s9yOCKGLDr9K0GwPZV4WbthQnHQSV7p87VZ4Sn3OtOxpRvfyxqtTAPRgKb8or2X9rkr7AHb0EdXOlLv8xmwrLN9SZjugNO0mDsWkuNyBs/AgReP3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673946771; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qxN+8k08vTt0nMXkeJr8ru9QvmOMBTZNPN5l16ahebE=; b=V2mf24dmj3pgrSmbjvR3+OH80OHCeTEFkfo5PS3bq3nm9qJaUJrBv8wBvB3cBXrkaUWSlLI5EOCTr5TIy1Oc2FRwb9hbEvwlYORLMui5Xe0bDHG1W6FekE7uHYXMIxOW4HriVlmvpUw+dJJFbcxS9GQcleBWwSQbXnHypCs86UE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1673946771400148.73618248376147; Tue, 17 Jan 2023 01:12:51 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.479157.742841 (Exim 4.92) (envelope-from ) id 1pHi17-0002iZ-RB; Tue, 17 Jan 2023 09:12:29 +0000 Received: by outflank-mailman (output) from mailman id 479157.742841; Tue, 17 Jan 2023 09:12:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pHi17-0002iS-NB; Tue, 17 Jan 2023 09:12:29 +0000 Received: by outflank-mailman (input) for mailman id 479157; Tue, 17 Jan 2023 09:12:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pHi17-000725-CK for xen-devel@lists.xenproject.org; Tue, 17 Jan 2023 09:12:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10b7f7da-9647-11ed-91b6-6bf2151ebd3b; Tue, 17 Jan 2023 10:12:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 79FA7683D9; Tue, 17 Jan 2023 09:12:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 493381390C; Tue, 17 Jan 2023 09:12:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B+WyEHxmxmNvcAAAMHmgww (envelope-from ); Tue, 17 Jan 2023 09:12:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10b7f7da-9647-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673946748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxN+8k08vTt0nMXkeJr8ru9QvmOMBTZNPN5l16ahebE=; b=P/WKj3ov4+KtXochZB1lePMqmyq2VdvkXDHVrF7Ukb5Z8pdCVPkL5S78vRf479Q1V3/jPG nl2xTTR9/ookdhP4zN+OVj7VEYqdOlZWlAK2Dy6nz2vj+dHTdCQ85pP+cbWwd1whyOTDJE mYfSGxwCj6LxETmyoKoyBLaG7m9FiS0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v3 11/17] tools/xenstore: let chk_domain_generation() return a bool Date: Tue, 17 Jan 2023 10:11:18 +0100 Message-Id: <20230117091124.22170-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230117091124.22170-1-jgross@suse.com> References: <20230117091124.22170-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1673946771944100001 Content-Type: text/plain; charset="utf-8" Instead of returning 0 or 1 let chk_domain_generation() return a boolean value. Simplify the only caller by removing the ret variable. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_domain.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_d= omain.c index 55a93eccdb..1723c9804a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -985,20 +985,20 @@ void domain_deinit(void) * count (used for testing whether a node permission is older than a domai= n). * * Return values: - * 0: domain has higher generation count (it is younger than a node with = the - * given count), or domain isn't existing any longer - * 1: domain is older than the node + * false: domain has higher generation count (it is younger than a node w= ith + * the given count), or domain isn't existing any longer + * true: domain is older than the node */ -static int chk_domain_generation(unsigned int domid, uint64_t gen) +static bool chk_domain_generation(unsigned int domid, uint64_t gen) { struct domain *d; =20 if (!xc_handle && domid =3D=3D dom0_domid) - return 1; + return true; =20 d =3D find_domain_struct(domid); =20 - return (d && d->generation <=3D gen) ? 1 : 0; + return d && d->generation <=3D gen; } =20 /* @@ -1033,14 +1033,12 @@ int domain_alloc_permrefs(struct node_perms *perms) int domain_adjust_node_perms(struct node *node) { unsigned int i; - int ret; =20 for (i =3D 1; i < node->perms.num; i++) { if (node->perms.p[i].perms & XS_PERM_IGNORE) continue; - ret =3D chk_domain_generation(node->perms.p[i].id, - node->generation); - if (!ret) + if (!chk_domain_generation(node->perms.p[i].id, + node->generation)) node->perms.p[i].perms |=3D XS_PERM_IGNORE; } =20 --=20 2.35.3