From nobody Thu Nov 28 13:47:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1670947292; cv=none; d=zohomail.com; s=zohoarc; b=h4RYrZ84NTHbN+HIjx82fxI26RWr9CiaI82hgJ9vqCQL9FrTc+KW0nStDspZ01DlxtAPDAwP+BeZsbKvjI+kxVZAwknKwG6ek0S57NaGp0Oy/usQaJjQMhBBpAjABxlZCWsA1wnue368joFxxKLT55ch07jAgR1Ix28bZxQ6NxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670947292; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IYyxVkScp9Y7u/oG4opchX0eSNjJmBkYlufg+dfmLdE=; b=ZawY4xbMK5ADxmgLbKzPhn9FAZIrAIh2YQKuJTm5DELvK4j/UstfrIvMVs6i0TuBno943XQEGi8uWxvJxY0JtEl9b/Wokoua6IvqWu9JEvxqmChnZUkzyujsSAuayjcluAfm4i6JLS48XuKWz8IrrkysG+Xmi8ePPENRwiOqZyg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1670947292282240.44817768556186; Tue, 13 Dec 2022 08:01:32 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.460723.718704 (Exim 4.92) (envelope-from ) id 1p57iH-0002DQ-6K; Tue, 13 Dec 2022 16:01:01 +0000 Received: by outflank-mailman (output) from mailman id 460723.718704; Tue, 13 Dec 2022 16:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p57iH-0002DJ-3H; Tue, 13 Dec 2022 16:01:01 +0000 Received: by outflank-mailman (input) for mailman id 460723; Tue, 13 Dec 2022 16:01:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p57iG-0001ta-32 for xen-devel@lists.xenproject.org; Tue, 13 Dec 2022 16:01:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55b84f6f-7aff-11ed-8fd2-01056ac49cbb; Tue, 13 Dec 2022 17:00:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0487622A1E; Tue, 13 Dec 2022 16:00:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CC2D1138EE; Tue, 13 Dec 2022 16:00:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6EmZMLqhmGNvKQAAMHmgww (envelope-from ); Tue, 13 Dec 2022 16:00:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55b84f6f-7aff-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670947259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IYyxVkScp9Y7u/oG4opchX0eSNjJmBkYlufg+dfmLdE=; b=CexiKLaWiHw5fmoZEGl+11vnfDxFaZ+lSpvXDUaIgn2C2liNnO6jOONuw/76WNq9Nq8u3b +SAI6jN0jXBlPJ0PAo2ndAL5wf0AhdLmhiipqQO+ckIV5tCFfj2pojaq8pf9sprKyACzQy zZM3WMAs8vQT6gVhwgzlGZ2yg2FS3LE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH v2 02/19] tools/xenstore: let tdb_logger() preserve errno Date: Tue, 13 Dec 2022 17:00:28 +0100 Message-Id: <20221213160045.28170-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221213160045.28170-1-jgross@suse.com> References: <20221213160045.28170-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1670947294385100007 Content-Type: text/plain; charset="utf-8" tdb_logger() is called by TDB for logging errors. As errno is checked often after doing the logging, tdb_logger() should preserve errno. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 5a174b9881..d48208ecfe 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2345,6 +2345,7 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, c= onst char * fmt, ...) { va_list ap; char *s; + int saved_errno =3D errno; =20 va_start(ap, fmt); s =3D talloc_vasprintf(NULL, fmt, ap); @@ -2360,6 +2361,8 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, c= onst char * fmt, ...) trace("talloc failure during logging\n"); syslog(LOG_ERR, "talloc failure during logging\n"); } + + errno =3D saved_errno; } =20 void setup_structure(bool live_update) --=20 2.35.3