From nobody Thu Nov 28 13:59:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1670947545; cv=none; d=zohomail.com; s=zohoarc; b=IBi14ws8j5prDbOPTT23xkW5uqppr5kN4ay5L858nF+uqB7tchErKM17m7thoVxeYOevKYY30EP3SmT+Jrx2TrQ/gNn6/fjbQf/X1g4Egyd7EuDDVwISV6j/OeDHF12xfPuRlNuGMOHILJmv1iJroLff9pS31tFDgRdcHZLmA/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670947545; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wTUWj5ykTPwfIHjTYHUnZ+eNs/GAKQHItmGrRO3n/AA=; b=d0cu0qOLA1dVI3gAu06pVyp9SS1bL9UWPN4MNBwknxQaUmkzCn9jXWBj6iwt9Z0M+sLhIGooBbMXERjmrKoqxa7pM/6nhw/jX+1VX1NkgzS389G7KMKadf2cK6bOZg8xyQM4QFOV0Y5ARMvBjP/v+h36hNmePCXUNNM32Gc+DM4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1670947545362345.5384695252951; Tue, 13 Dec 2022 08:05:45 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.460761.718758 (Exim 4.92) (envelope-from ) id 1p57mC-0005Vj-1s; Tue, 13 Dec 2022 16:05:04 +0000 Received: by outflank-mailman (output) from mailman id 460761.718758; Tue, 13 Dec 2022 16:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p57mB-0005Va-Ul; Tue, 13 Dec 2022 16:05:03 +0000 Received: by outflank-mailman (input) for mailman id 460761; Tue, 13 Dec 2022 16:05:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p57j4-0001ta-9X for xen-devel@lists.xenproject.org; Tue, 13 Dec 2022 16:01:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73a6837e-7aff-11ed-8fd2-01056ac49cbb; Tue, 13 Dec 2022 17:01:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4CFFA1FDAE; Tue, 13 Dec 2022 16:01:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21963138EE; Tue, 13 Dec 2022 16:01:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yFLaBu2hmGPyKQAAMHmgww (envelope-from ); Tue, 13 Dec 2022 16:01:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73a6837e-7aff-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670947309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wTUWj5ykTPwfIHjTYHUnZ+eNs/GAKQHItmGrRO3n/AA=; b=cZBHJkGxhDHKy0rtA26FhFzuEEtjsLoow0RmLdDNhELNrYqIz0PFsKDNg/3KCVfIL9kwHX 8Jptgffyy0XDFRGMV8K5kgQFSBybL93p6YX5KkGqjozgUV6eAGkeYP+OM1vm0EIwSqIj0H T+1O0Iz3PqwJ9Whj0J0AbJi7hnogYH8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction Date: Tue, 13 Dec 2022 17:00:37 +0100 Message-Id: <20221213160045.28170-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221213160045.28170-1-jgross@suse.com> References: <20221213160045.28170-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1670947547264100005 Content-Type: text/plain; charset="utf-8" The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows to create arbitrary number of nodes. The transaction will finally fail due to exceeding the number of nodes quota, but before closing the transaction an unprivileged guest could cause Xenstore to use a lot of memory. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_d= omain.c index 40b24056c5..1ae79b5b54 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1118,9 +1118,8 @@ int domain_nbentry_fix(unsigned int domid, int num, b= ool update) =20 int domain_nbentry(struct connection *conn) { - return (domain_is_unprivileged(conn)) - ? conn->domain->nbentry - : 0; + return domain_is_unprivileged(conn) + ? domain_nbentry_add(conn, conn->id, 0, true) : 0; } =20 static bool domain_chk_quota(struct domain *domain, int mem) --=20 2.35.3