From nobody Tue Feb 10 19:08:05 2026
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates
 192.237.175.120 as permitted sender) client-ip=192.237.175.120;
 envelope-from=xen-devel-bounces@lists.xenproject.org;
 helo=lists.xenproject.org;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of lists.xenproject.org designates
 192.237.175.120 as permitted sender)
  smtp.mailfrom=xen-devel-bounces@lists.xenproject.org
ARC-Seal: i=1; a=rsa-sha256; t=1670838956; cv=none;
	d=zohomail.com; s=zohoarc;
	b=FKvSI45j4PMx6t36HV6xmwehv12Z01+pZ9RxT8LIZIf6HwP52g1yVxPqKrNghm8u9oK/Kyom6TN+oTkPOaIQwCo4tYoEIUTGPQXMjVtnY+RLQzDpZTAgio/d8oLUrH0ZkNHJbYmtDWUYBKKa1py98bdCiXdytRrB8UCsroetkUY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1670838956;
 h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=8XTTu/Hz4Y+O0ljKPi9Gp8h5CZ8CZj743R2YHfvL9wM=;
	b=QnMV1EQb/Dwin2uAUmyyFvq5euQRePwLXaV4vG/1c/B3QwzTkLzyol4thA/Glpvt2z5BDqzlyfQ37R4w3nYa+MlvuawWjkKGXaHQTOYb8azwyShboSOfBryS+dLsDwRqBz36cbfJ8ilP0Y0uA8wKk5FK0Da29xWLoPp6isMaCSo=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of lists.xenproject.org designates
 192.237.175.120 as permitted sender)
  smtp.mailfrom=xen-devel-bounces@lists.xenproject.org
Return-Path: <xen-devel-bounces@lists.xenproject.org>
Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120])
 by mx.zohomail.com
	with SMTPS id 167083895629689.82310092907721;
 Mon, 12 Dec 2022 01:55:56 -0800 (PST)
Received: from list by lists.xenproject.org with
 outflank-mailman.459261.716999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1p4fX5-0004OF-1K; Mon, 12 Dec 2022 09:55:35 +0000
Received: by outflank-mailman (output) from mailman id 459261.716999;
 Mon, 12 Dec 2022 09:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1p4fX4-0004ND-QV; Mon, 12 Dec 2022 09:55:34 +0000
Received: by outflank-mailman (input) for mailman id 459261;
 Mon, 12 Dec 2022 09:55:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1p4fX3-0004Ae-R9
 for xen-devel@lists.xenproject.org; Mon, 12 Dec 2022 09:55:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1p4fX3-0001Ss-ID; Mon, 12 Dec 2022 09:55:33 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1p4fX3-0001lz-Am; Mon, 12 Dec 2022 09:55:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=8XTTu/Hz4Y+O0ljKPi9Gp8h5CZ8CZj743R2YHfvL9wM=; b=U367eq51tXzXTpAIBNPLuA4+7/
	u9Z/Cp11p4d6pLtN1uA3J5bOk7fj/l+/xsp1tYVcYmESN7dG9A03uM//V7tQvgReTZTD8oHh3AHIL
	/6HhxU3CIObSbHlxTBw2PAnoF/8LWo//cGHy+vcvZj3dq1DELbq1OqPEFOwMKhpYKbvA=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Luca.Fancellu@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 06/18] xen/arm32: head: Replace "ldr rX,
 =<label>" with "mov_w rX, <label>"
Date: Mon, 12 Dec 2022 09:55:11 +0000
Message-Id: <20221212095523.52683-7-julien@xen.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221212095523.52683-1-julien@xen.org>
References: <20221212095523.52683-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @xen.org)
X-ZM-MESSAGEID: 1670838957270100005
Content-Type: text/plain; charset="utf-8"

From: Julien Grall <jgrall@amazon.com>

"ldr rX, =3D<label>" is used to load a value from the literal pool. This
implies a memory access.

This can be avoided by using the macro mov_w which encode the value in
the immediate of two instructions.

So replace all "ldr rX, =3D<label>" with "mov_w rX, <label>".

No functional changes intended.

Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---

    Changes in v3:
        * Patch added
---
 xen/arch/arm/arm32/head.S | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index a558c2a6876e..ce680be91be1 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -62,7 +62,7 @@
 .endm
=20
 .macro load_paddr rb, sym
-        ldr   \rb, =3D\sym
+        mov_w \rb, \sym
         add   \rb, \rb, r10
 .endm
=20
@@ -149,7 +149,7 @@ past_zImage:
         mov   r8, r2                 /* r8 :=3D DTB base address */
=20
         /* Find out where we are */
-        ldr   r0, =3Dstart
+        mov_w r0, start
         adr   r9, start              /* r9  :=3D paddr (start) */
         sub   r10, r9, r0            /* r10 :=3D phys-offset */
=20
@@ -170,7 +170,7 @@ past_zImage:
         bl    enable_mmu
=20
         /* We are still in the 1:1 mapping. Jump to the runtime Virtual Ad=
dress. */
-        ldr   r0, =3Dprimary_switched
+        mov_w r0, primary_switched
         mov   pc, r0
 primary_switched:
         /*
@@ -190,7 +190,7 @@ primary_switched:
         /* Setup the arguments for start_xen and jump to C world */
         mov   r0, r10                /* r0 :=3D Physical offset */
         mov   r1, r8                 /* r1 :=3D paddr(FDT) */
-        ldr   r2, =3Dstart_xen
+        mov_w r2, start_xen
         b     launch
 ENDPROC(start)
=20
@@ -198,7 +198,7 @@ GLOBAL(init_secondary)
         cpsid aif                    /* Disable all interrupts */
=20
         /* Find out where we are */
-        ldr   r0, =3Dstart
+        mov_w r0, start
         adr   r9, start              /* r9  :=3D paddr (start) */
         sub   r10, r9, r0            /* r10 :=3D phys-offset */
=20
@@ -227,7 +227,7 @@ GLOBAL(init_secondary)
=20
=20
         /* We are still in the 1:1 mapping. Jump to the runtime Virtual Ad=
dress. */
-        ldr   r0, =3Dsecondary_switched
+        mov_w r0, secondary_switched
         mov   pc, r0
 secondary_switched:
         /*
@@ -236,7 +236,7 @@ secondary_switched:
          *
          * XXX: This is not compliant with the Arm Arm.
          */
-        ldr   r4, =3Dinit_ttbr         /* VA of HTTBR value stashed by CPU=
 0 */
+        mov_w r4, init_ttbr          /* VA of HTTBR value stashed by CPU 0=
 */
         ldrd  r4, r5, [r4]           /* Actual value */
         dsb
         mcrr  CP64(r4, r5, HTTBR)
@@ -254,7 +254,7 @@ secondary_switched:
 #endif
         PRINT("- Ready -\r\n")
         /* Jump to C world */
-        ldr   r2, =3Dstart_secondary
+        mov_w r2, start_secondary
         b     launch
 ENDPROC(init_secondary)
=20
@@ -297,8 +297,8 @@ ENDPROC(check_cpu_mode)
  */
 zero_bss:
         PRINT("- Zero BSS -\r\n")
-        ldr   r0, =3D__bss_start       /* r0 :=3D vaddr(__bss_start) */
-        ldr   r1, =3D__bss_end         /* r1 :=3D vaddr(__bss_start) */
+        mov_w r0, __bss_start        /* r0 :=3D vaddr(__bss_start) */
+        mov_w r1, __bss_end          /* r1 :=3D vaddr(__bss_start) */
=20
         mov   r2, #0
 1:      str   r2, [r0], #4
@@ -330,8 +330,8 @@ cpu_init:
=20
 cpu_init_done:
         /* Set up memory attribute type tables */
-        ldr   r0, =3DMAIR0VAL
-        ldr   r1, =3DMAIR1VAL
+        mov_w r0, MAIR0VAL
+        mov_w r1,MAIR1VAL
         mcr   CP32(r0, HMAIR0)
         mcr   CP32(r1, HMAIR1)
=20
@@ -341,10 +341,10 @@ cpu_init_done:
          * PT walks are write-back, write-allocate in both cache levels,
          * Full 32-bit address space goes through this table.
          */
-        ldr   r0, =3D(TCR_RES1|TCR_SH0_IS|TCR_ORGN0_WBWA|TCR_IRGN0_WBWA|TC=
R_T0SZ(0))
+        mov_w r0, (TCR_RES1|TCR_SH0_IS|TCR_ORGN0_WBWA|TCR_IRGN0_WBWA|TCR_T=
0SZ(0))
         mcr   CP32(r0, HTCR)
=20
-        ldr   r0, =3DHSCTLR_SET
+        mov_w r0, HSCTLR_SET
         mcr   CP32(r0, HSCTLR)
         isb
=20
@@ -452,7 +452,7 @@ ENDPROC(cpu_init)
  */
 create_page_tables:
         /* Prepare the page-tables for mapping Xen */
-        ldr   r0, =3DXEN_VIRT_START
+        mov_w r0, XEN_VIRT_START
         create_table_entry boot_pgtable, boot_second, r0, 1
         create_table_entry boot_second, boot_third, r0, 2
=20
@@ -576,7 +576,7 @@ remove_identity_mapping:
         cmp   r1, #XEN_FIRST_SLOT
         beq   1f
         /* It is not in slot 0, remove the entry */
-        ldr   r0, =3Dboot_pgtable      /* r0 :=3D root table */
+        mov_w r0, boot_pgtable       /* r0 :=3D root table */
         lsl   r1, r1, #3             /* r1 :=3D Slot offset */
         strd  r2, r3, [r0, r1]
         b     identity_mapping_removed
@@ -590,7 +590,7 @@ remove_identity_mapping:
         cmp   r1, #XEN_SECOND_SLOT
         beq   identity_mapping_removed
         /* It is not in slot 1, remove the entry */
-        ldr   r0, =3Dboot_second       /* r0 :=3D second table */
+        mov_w r0, boot_second        /* r0 :=3D second table */
         lsl   r1, r1, #3             /* r1 :=3D Slot offset */
         strd  r2, r3, [r0, r1]
=20
@@ -620,7 +620,7 @@ ENDPROC(remove_identity_mapping)
 setup_fixmap:
 #if defined(CONFIG_EARLY_PRINTK)
         /* Add UART to the fixmap table */
-        ldr   r0, =3DEARLY_UART_VIRTUAL_ADDRESS
+        mov_w r0, EARLY_UART_VIRTUAL_ADDRESS
         create_mapping_entry xen_fixmap, r0, r11, type=3DPT_DEV_L3
 #endif
         /* Map fixmap into boot_second */
@@ -643,7 +643,7 @@ ENDPROC(setup_fixmap)
  * Clobbers r3
  */
 launch:
-        ldr   r3, =3Dinit_data
+        mov_w r3, init_data
         add   r3, #INITINFO_stack    /* Find the boot-time stack */
         ldr   sp, [r3]
         add   sp, #STACK_SIZE        /* (which grows down from the top). */
--=20
2.38.1