From nobody Wed Apr 24 01:45:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1668790410; cv=none; d=zohomail.com; s=zohoarc; b=k6t92MUhp1C0Y4o3pq3sSmCaWytvs/9Tvf/2t/7kP6MiUhFEF8+S9vpK2MczWwcbWVud8qKwYaInTAyTFbaTKZ8lSjUzBleKv75HkoBzCT1y1BsF+YvYlPS/WVQFEsRf694FVcjHGIwu5gDn1axg2nbZY81EEe28C7HAUjaxiCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668790410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Qc0Y+ecPYClEFvuKh/K4FeHjJmkl8sYktVF46VkpxGs=; b=k5VAjDP2qPmLiMW3vXfWH/ni6j7rPuvgrLCMLMCVvPGeJoHC7XssszLL0j5+a+Sfb2VKIzLVYQyUKAwrYONu3MXjD79WAiOvyHx1dKHkYezwyz//TMpS1qS8PsEFTs8Far7WV8odGP+F8YRAHn+t3+jaxb48ET5GnxyrS+BhH5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1668790410575961.6910885091803; Fri, 18 Nov 2022 08:53:30 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.445847.701258 (Exim 4.92) (envelope-from ) id 1ow4bk-0005rf-F8; Fri, 18 Nov 2022 16:52:52 +0000 Received: by outflank-mailman (output) from mailman id 445847.701258; Fri, 18 Nov 2022 16:52:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4bk-0005rY-BY; Fri, 18 Nov 2022 16:52:52 +0000 Received: by outflank-mailman (input) for mailman id 445847; Fri, 18 Nov 2022 16:52:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4bi-0005rM-ON for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 16:52:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6caf5f4d-6761-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 17:52:47 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6caf5f4d-6761-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668790366; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=J2CiieSJZxtkuKEWP4p8/1ZixIJQEx/CBNf7XOvZuew=; b=hmLyHFO6DoDprPar3+HP8uGJfuP/dXWRvOokfGqZAcSnaUpfvkyMIbgl kRh8R/f+1crfluauUSqxie5QlpJoiLmSH+BCaqd34Jtbv5eUvDxHhwiq6 uiU5RhRHT7ob7rO1hz8PH4bPXFusu83KJZS0hnlYYl3xQvOwuYISyM8yd I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84189304 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qDwk46lLDhnkXmm5lNwq1sDo5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJLXWzVbKuINmCnLdtwaImz8BtQvp7TyYdmSVdorik1FyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5Q+GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 foJJiEqRU6EvcKJ8oq5e8B329x/dNa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zhrB9 jOdpziR7hcyboOT+R+M4HiW1vLBk2D0AqkRCr7oz6s/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIsorI171eDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 lKPhcKvOjVpv5WcU3fb/bCRxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5lAaCkqfarHgvQ/ AKyrhkXnOgL0ZYUgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K374105CHx7ZiHCgUpLj2WZVawXIVDIT4iNaxwtRoMmj1gYXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhKVv46kWfsGb5FuVPO+szY7TmLLXwc5032uYdymVbPEetVWLdwRr9RAFy4TPX9r I8EapriJ+R3W+zieCjHmbP/3nhTRUXWxPne9aRqSwJ0ClA7QT54UKeOn+5Jlk4Mt/09q9okN 0qVAidwoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:LI5eY6xi1bUE00zMAEIBKrPwJr1zdoMgy1knxilNoRw8SKOlfq eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78 tdmtBFeb7NMWQ= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84189304" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code Date: Fri, 18 Nov 2022 16:52:35 +0000 Message-ID: <20221118165235.14143-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1668790414060100001 Content-Type: text/plain; charset="utf-8" Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_ap= ply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk --- tools/libs/light/libxl_dom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index b59bbe00bb..fa5c79e4f6 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -377,6 +377,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, state->console_port =3D xc_evtchn_alloc_unbound(ctx->xch, domid, state= ->console_domid); =20 rc =3D libxl__arch_domain_create(gc, d_config, state, domid); + if (rc) goto out; =20 /* Construct a CPUID policy, but only for brand new domains. Domains * being migrated-in/restored have CPUID handled during the @@ -384,6 +385,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, if (!state->restore) rc =3D libxl__cpuid_legacy(ctx, domid, false, info); =20 +out: return rc; } =20 --=20 Anthony PERARD