From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938294; cv=none; d=zohomail.com; s=zohoarc; b=FqZSpfWJeJry9w2rgJG9JlLjnrqhFLr5logp81GJrnjbrBZ+FrsJMCMVHCjwOtK8XcCsdR1tt6w0tM113xnjcmTsXJVMd940LXNzXE6Piw+GGGlFw1JlKUwH3q7P1aRooZJCSIq4fAWWhnD7XQgk/uHIOe9mAZjoad7yaXzyXtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938294; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gpTcdGFtIggM/ndfLTOOJqJh1Gq2EXeW+frcQK8u79M=; b=SHmmJYMhK8o1SOUQyaorSRRDOL2/vq8pIvadGI7QL5Q4hqhMlR+AsmS+xUocPxdLDAkGWmDvDl2sck+cpjz16S/1NfXzcoHn0oZ0NFlaPjAnOss6V8CG+o1zjc8otr4EARMOmmtiY3mmqmbMOPQTDeW4U012J8pCwrzUNS3Mbpw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16609382945961009.9287541907897; Fri, 19 Aug 2022 12:44:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390436.627861 (Exim 4.92) (envelope-from ) id 1oP7uv-0004jh-Jv; Fri, 19 Aug 2022 19:44:29 +0000 Received: by outflank-mailman (output) from mailman id 390436.627861; Fri, 19 Aug 2022 19:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uv-0004ja-FR; Fri, 19 Aug 2022 19:44:29 +0000 Received: by outflank-mailman (input) for mailman id 390436; Fri, 19 Aug 2022 19:44:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uu-0004jK-8c for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:28 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 558633b9-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:27 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id w3so6858614edc.2 for ; Fri, 19 Aug 2022 12:44:27 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:25 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 558633b9-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=gpTcdGFtIggM/ndfLTOOJqJh1Gq2EXeW+frcQK8u79M=; b=dtaR3prsgnjJDmkr7VI0C4cWEqVDMSufqNJmumXQDW6cYpg1+ydZms5U+Ro51MXB5t jo6f7iofh9BCu5a7fDaW18oVUAFeYaLiHsDf+JxnBCHVS1+W+1W20RKbHHqhYhQ1S4tP ndKBkqHMhdvVqgQW1r/YrADrAsmB4eSkpNuRagkM0FYdUcJyWYt2opGdRNe1icyRm7KC 2sdcaC5feSQKirxeJ0PX6ZvwGikfmSpYX+hopRPwwUalqNGxKrdOHI3SrJSem3hNnW7e TPTgl2OiiF7AOIGnQc5HCjCJ40jlluGlk2JspR/nzkwDtkl3HutsPjKVdB4q4aePzw8D OGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=gpTcdGFtIggM/ndfLTOOJqJh1Gq2EXeW+frcQK8u79M=; b=JifNCpKhn4P3yCNzugmMKrSidCGAe2Dz4HpMh7yfdyA+dxe8F5Kb/iG7yCbExgb8uS r0MQW2YuVip0AjZ+QY/3GWbMAueBOJn/RSvdtMQGBMjshGKJDC8BgpeprHal0R1GHtv+ 6ge6oi3c5ay83Ch+b4aTADcV4fXUxYFuAbQNqiYg7fP3HMYwK5ug2jpV9wvDMmEXCt2n umjIOQ6ppoODX/1iMYiNsPbpjFPlP8b5qH4Nf0ADnmkKHPYUopjAvKmVoByQ/aryeZlY SHt4MQbo0buN4LYLZwCS4NQRRFC6vIRGG/QsiELTlGS9XdhTfyO7xuwtJ3gf9pkfDL5D S3Ag== X-Gm-Message-State: ACgBeo24GGTGYwuLhgtOVevWtovBIuI1dlAyFFQrlumlOg/yJ7O6ev7+ /shj3fnoYTkmOmIK9YlrEe7FpvygD0A= X-Google-Smtp-Source: AA6agR74rrbOHONcU0veZ6EMafv63MPWQH4nz6HQlpQSSKjLWTEQwOqaIF7pExtS3v5N87nnzPRrNg== X-Received: by 2002:a05:6402:2753:b0:43a:d6f2:9839 with SMTP id z19-20020a056402275300b0043ad6f29839mr7013799edd.73.1660938266474; Fri, 19 Aug 2022 12:44:26 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/7] xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations Date: Fri, 19 Aug 2022 22:43:53 +0300 Message-Id: <20220819194359.1196539-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296181100009 Content-Type: text/plain; charset="utf-8" In macros GITS_TYPER_DEVICE_ID_BITS(), GITS_TYPER_EVENT_ID_BITS() and GITS_BASER_ENTRY_SIZE(), add parentheses around the macro parameter to prevent against unintended expansions. Realign subsequent lines, if any. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/gic_v3_its.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/a= sm/gic_v3_its.h index 94e5cb99c5..168617097f 100644 --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -46,13 +46,13 @@ #define GITS_TYPER_PTA BIT(19, UL) #define GITS_TYPER_DEVIDS_SHIFT 13 #define GITS_TYPER_DEVIDS_MASK (0x1fUL << GITS_TYPER_DEVIDS_SHIFT) -#define GITS_TYPER_DEVICE_ID_BITS(r) (((r & GITS_TYPER_DEVIDS_MASK) >> \ - GITS_TYPER_DEVIDS_SHIFT) + = 1) +#define GITS_TYPER_DEVICE_ID_BITS(r) ((((r) & GITS_TYPER_DEVIDS_MASK) >= > \ + GITS_TYPER_DEVIDS_SHIFT) = + 1) =20 #define GITS_TYPER_IDBITS_SHIFT 8 #define GITS_TYPER_IDBITS_MASK (0x1fUL << GITS_TYPER_IDBITS_SHIFT) -#define GITS_TYPER_EVENT_ID_BITS(r) (((r & GITS_TYPER_IDBITS_MASK) >> \ - GITS_TYPER_IDBITS_SHIFT) + = 1) +#define GITS_TYPER_EVENT_ID_BITS(r) ((((r) & GITS_TYPER_IDBITS_MASK) >= > \ + GITS_TYPER_IDBITS_SHIFT) = + 1) =20 #define GITS_TYPER_ITT_SIZE_SHIFT 4 #define GITS_TYPER_ITT_SIZE_MASK (0xfUL << GITS_TYPER_ITT_SIZE_SHIF= T) @@ -75,7 +75,7 @@ #define GITS_BASER_TYPE_RESERVED7 7UL #define GITS_BASER_ENTRY_SIZE_SHIFT 48 #define GITS_BASER_ENTRY_SIZE(reg) \ - (((reg >> GITS_BASER_ENTRY_SIZE_SHIFT) & 0x1f) + 1) + ((((reg) >> GITS_BASER_ENTRY_SIZE_SHIFT) & 0x1f) += 1) #define GITS_BASER_SHAREABILITY_SHIFT 10 #define GITS_BASER_PAGE_SIZE_SHIFT 8 #define GITS_BASER_SIZE_MASK 0xff --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938293; cv=none; d=zohomail.com; s=zohoarc; b=oLaFJRufOGMNIEBenjfoLHA7gaMj0wLxcWBCuiKH1g5IaygZVv5m79QpGnHmbAISeyAluw95k24+iU66jJ4FztoW4SZXJz920ozBifUEu45ivTkXvCIHzEip0fFZ5shh03iZmhLhUAN6+BCAGRt91sQhny6BPUoMpvJgAnoMZww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938293; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/HbANI3UeAtTK4BSnuJuxW7e2mu0WZGzY+TmqE1A7bY=; b=Jh8w9gH5CINEgxggtM/uJ69KxtmX3VNiA879oVXRdgLZHSirJBpIKCPb17SFtw3iux7LcBjNBdoM//wqsLc8LYRDMsV9t7DcpnEghgqeZuLQEdDjBWaAucFKbwir/tpRNM3dupFSnhxjbPpUhZdvuNj4UDYQ2W0Ztbtw3caX2so= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938293841100.61853674664076; Fri, 19 Aug 2022 12:44:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390438.627883 (Exim 4.92) (envelope-from ) id 1oP7ux-0005FI-6X; Fri, 19 Aug 2022 19:44:31 +0000 Received: by outflank-mailman (output) from mailman id 390438.627883; Fri, 19 Aug 2022 19:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7ux-0005F7-1A; Fri, 19 Aug 2022 19:44:31 +0000 Received: by outflank-mailman (input) for mailman id 390438; Fri, 19 Aug 2022 19:44:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uv-0004jJ-5f for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:29 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 562e351b-1ff7-11ed-9250-1f966e50362f; Fri, 19 Aug 2022 21:44:28 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id gi31so4144483ejc.5 for ; Fri, 19 Aug 2022 12:44:28 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 562e351b-1ff7-11ed-9250-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=/HbANI3UeAtTK4BSnuJuxW7e2mu0WZGzY+TmqE1A7bY=; b=mYnFGTkCEIxQYyuCFlnzy+qIf7fcTM7SWqBrDw3j9zoLc626t2DGNjyFrKiqgHsn7M JB8HI2urhJiZn7rMFz84Zj4np7uXRe0apjN/hLWitx05BOR7GioDQxErOfRfA+z4mAo4 r5W65T+O6xIWOHNCUTwAo8KYTHmF+e35mkU7i3xYh5cu6Gd8ob+ypxF/Uyanz/21pFc1 7HVmEJLeY/c+F3sjictsCzEgYT3UgRyGDG5DenBSuuRI8lfRFechk1e1KGbCD8KIvouo DeM4/aNMlsn3x+OTxvdekjBZAfgxmiaXYryhfSGw+bq9pplJ//sDjBvZZxSeqfXh2RJ9 CuLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=/HbANI3UeAtTK4BSnuJuxW7e2mu0WZGzY+TmqE1A7bY=; b=cC2dzX7k2UWDElSKILjonbOx1ESfyXpTjpI/ImskmZrJ9zRf6iVXRNN3YOEK6kwT3O NFKEhNVL7T3W8kh2+XitnX9yMewLb2QMqkZLsZJZZcmX33r9ZLHOVzVyMU1ysxUnC1Dg xd3lE5Nm1I0OInvH0d9IbSD6EirPGN9BnloQHCnuOyQyFj7v2wzFP7lbwEDfw8PTS33W nYNcaF6sg/eFZQQW9QQ7i5Xs0CGr9xDJjfLNIx0GuClRTVditvskEH+hqnQrlw5nujHb ktsAy2drvr3YbHj2ts+bZcHQedjw4XfAQVdUr4PL3D01wuGfRZACSJvcBjbTWuSE1eUL dFpw== X-Gm-Message-State: ACgBeo20sapyvtCR1eaos8MDOGCt3jRgI6rGNFP+WQNitvG7CxrjLm1x j1dYuAVDQdWhsllcLnEmS4nzjtWNhJc= X-Google-Smtp-Source: AA6agR6JAOo63yvmQzBV6tN/muN9TPp6fGbM8KwYzl4I1ICVIld73kLbCHnhFkhsZKr+dkt6Pms/Yw== X-Received: by 2002:a17:907:2c78:b0:730:df57:1237 with SMTP id ib24-20020a1709072c7800b00730df571237mr5690032ejc.196.1660938267549; Fri, 19 Aug 2022 12:44:27 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" Subject: [PATCH 2/7] xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations Date: Fri, 19 Aug 2022 22:43:54 +0300 Message-Id: <20220819194359.1196539-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296251100012 Content-Type: text/plain; charset="utf-8" In macros SIDTAB_HASH(), INIT_SIDTAB_LOCK(), SIDTAB_LOCK() and SIDTAB_UNLOC= K(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou Acked-by: Daniel P. Smith Reviewed-by: Stefano Stabellini --- xen/xsm/flask/ss/sidtab.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/xsm/flask/ss/sidtab.c b/xen/xsm/flask/ss/sidtab.c index 74babfac9c..69fc3389b3 100644 --- a/xen/xsm/flask/ss/sidtab.c +++ b/xen/xsm/flask/ss/sidtab.c @@ -14,11 +14,11 @@ #include "security.h" #include "sidtab.h" =20 -#define SIDTAB_HASH(sid) (sid & SIDTAB_HASH_MASK) +#define SIDTAB_HASH(sid) ((sid) & SIDTAB_HASH_MASK) =20 -#define INIT_SIDTAB_LOCK(s) spin_lock_init(&s->lock) -#define SIDTAB_LOCK(s) spin_lock(&s->lock) -#define SIDTAB_UNLOCK(s) spin_unlock(&s->lock) +#define INIT_SIDTAB_LOCK(s) spin_lock_init(&(s)->lock) +#define SIDTAB_LOCK(s) spin_lock(&(s)->lock) +#define SIDTAB_UNLOCK(s) spin_unlock(&(s)->lock) =20 int sidtab_init(struct sidtab *s) { --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938293; cv=none; d=zohomail.com; s=zohoarc; b=jhMS1OeD+yXictn0UuQZXz8UvbaolvSu1wY54IOrUaEXM2rTC7bNViDJKfv3pLB0K8BJ3JW/usyRE+lksDjbKeiVT5QkTmZsCvqzCyCxHu4LgkY3AnwihAxi+B4aik/ICF21nI2qsXKn3Cw3e464ZxK/vpL+gyk3mbsjmD7Fp1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938293; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HDuuxFY/YE94TPNe9W54PeY/2YGWcZav7WGy8V8/S+M=; b=DSqwDg+eyPMRF5VoAle4qCUoXYhuKPyM9sayh8oxCj1FN9IkiaBkpNNdqd51+91ileHdZOA/+JPk1iZ+YnPLn/YQVi/yIi4D+MeaaHJLZyzSdvEMuyssEPbCu8dMpQA7XXAef2vobkyjNVC/VhadmHUXE2VwzIwdjRjJCwRlxbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938293922308.95109402781884; Fri, 19 Aug 2022 12:44:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390439.627888 (Exim 4.92) (envelope-from ) id 1oP7ux-0005M1-J9; Fri, 19 Aug 2022 19:44:31 +0000 Received: by outflank-mailman (output) from mailman id 390439.627888; Fri, 19 Aug 2022 19:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7ux-0005Jc-EK; Fri, 19 Aug 2022 19:44:31 +0000 Received: by outflank-mailman (input) for mailman id 390439; Fri, 19 Aug 2022 19:44:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uw-0004jK-EK for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:30 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57100c84-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:29 +0200 (CEST) Received: by mail-ej1-x62a.google.com with SMTP id fy5so10670938ejc.3 for ; Fri, 19 Aug 2022 12:44:29 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:28 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57100c84-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=HDuuxFY/YE94TPNe9W54PeY/2YGWcZav7WGy8V8/S+M=; b=JQXRD4F6Ddf1NWf18s2PCtlt7A0tVn7g1AIawlf++LC6axyaosDtPLbWtF6A7HgklM 2jUfPVwjdF0XfDzkxtqT82NO3Be+sTtaEX81qyBhK6VVCghh5A4pEJIxzPfwiIYUA+Zh fS6hYKTtvyn32GrBz16qW+VTOFVAMFONWyqMWf4s0B/J2dDniubKlRwrt6hKV6PINHgZ WoPlfgtDBLv109SelCcM+T4141Xa03AiXlOkmZiLZ1r8jp1iuMLT+V+Qwkjsiy8lJAD4 gER8tGI+FNxkfemEnTeX82T1D5ppNZW5x80OsFWpgp4HvG7wcxpgqibLip0+0x3k6M9f hLXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=HDuuxFY/YE94TPNe9W54PeY/2YGWcZav7WGy8V8/S+M=; b=w3iGMnMI607yICipIqIyJU4ZivsoZ1x+J8doMu+iY3nbPOgyFMAcq+XJlVWUZywmEp YJ5fr+fIj9gZzOU2CeYz/5QPO3+oEE+5Z29HVTg0SGdgC1/iVkhokf1S4Des2Eio0vKh rvHJYB2fvCenTbz3YK8gK7DElQognEtIkhiEb+7bd5boZjysySlk7XY508B9o2TJUu5b QlJY3Cq8w0C7Z8MQMjjQrdr5unBrGMph6acef1jXNVDJ2kAXXZtTCYbIZ5gK71CN6d7f qDBZcd1nxVzx4bvfTyxer6Np1cfGq+QyBFnIDaQpHBHuO+IOlhrXWqmoEkWoPSnMyd3O 9uXw== X-Gm-Message-State: ACgBeo2aW24BIMhemK+SFwpCybw7WK1ZzDGvwhv7vZ6oNQh7N7z2uoox 5Z6GTtziGddnDHZbzD5LVp9CtQ4vakY= X-Google-Smtp-Source: AA6agR41DpyasU1bwDPTT9rxNNwBCW+BMdM30h+lAaNbCAPVmTDiDSK/SrHWCtmh/+oG1xinDHQBQw== X-Received: by 2002:a17:906:cc0e:b0:731:6844:880a with SMTP id ml14-20020a170906cc0e00b007316844880amr5822271ejb.514.1660938269092; Fri, 19 Aug 2022 12:44:29 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 3/7] xen/elf: Fix MISRA C 2012 Rule 20.7 violations Date: Fri, 19 Aug 2022 22:43:55 +0300 Message-Id: <20220819194359.1196539-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296011100001 Content-Type: text/plain; charset="utf-8" In macros ELF32_ST_TYPE() and ELF64_ST_TYPE(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/include/xen/elfstructs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h index 616ebf9269..0a7c558a80 100644 --- a/xen/include/xen/elfstructs.h +++ b/xen/include/xen/elfstructs.h @@ -305,11 +305,11 @@ typedef struct { =20 /* Extract symbol info - st_info */ #define ELF32_ST_BIND(x) ((x) >> 4) -#define ELF32_ST_TYPE(x) (((unsigned int) x) & 0xf) +#define ELF32_ST_TYPE(x) (((unsigned int) (x)) & 0xf) #define ELF32_ST_INFO(b,t) (((b) << 4) + ((t) & 0xf)) =20 #define ELF64_ST_BIND(x) ((x) >> 4) -#define ELF64_ST_TYPE(x) (((unsigned int) x) & 0xf) +#define ELF64_ST_TYPE(x) (((unsigned int) (x)) & 0xf) #define ELF64_ST_INFO(b,t) (((b) << 4) + ((t) & 0xf)) =20 /* Symbol Binding - ELF32_ST_BIND - st_info */ --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938294; cv=none; d=zohomail.com; s=zohoarc; b=BaZSPYrKvGkslqyZ21RMqgoLTxhllZ5S5pgTJJSoyXv2N3yHSN7xVBJkcRCGAsLQW2uVsvxeMnwNWlFZo0Zy5ymDFTHLqXwhvdw7HMFa6fsvuiHpxnl57yMDfZBDD+hO6l2LTrEY5ldX2SjilUQWOPcoJa6dgKJk+7uzstIwzNY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938294; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xsltoJ+dF+zfeCEbbMIuZE8kHB12dqzZs8TVxgAefJ4=; b=mWPmNlCp5E7zbbF93G9kXp7LcEus8PzgpU0Gpqt7+XkxP9PGZ2EyNOOITlerZPSh+Mb62fm+LM5qtD4qHkWZUa13AepiPlAwN+0wF7OcFc84aYO6MC6CvDeJZDfPeQAw9SNpgEid6VZHxywCpoFh0XAfr8K/xHPpmAhq1sl9Gv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938294088747.789750443854; Fri, 19 Aug 2022 12:44:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390440.627905 (Exim 4.92) (envelope-from ) id 1oP7uy-0005lk-TA; Fri, 19 Aug 2022 19:44:32 +0000 Received: by outflank-mailman (output) from mailman id 390440.627905; Fri, 19 Aug 2022 19:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uy-0005l7-Ob; Fri, 19 Aug 2022 19:44:32 +0000 Received: by outflank-mailman (input) for mailman id 390440; Fri, 19 Aug 2022 19:44:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7ux-0004jK-On for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:31 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57dfb0a4-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:31 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id j8so10624301ejx.9 for ; Fri, 19 Aug 2022 12:44:31 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:30 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57dfb0a4-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=xsltoJ+dF+zfeCEbbMIuZE8kHB12dqzZs8TVxgAefJ4=; b=hkGJIU1aGvYGm0v+Am6NTz5xNmDSGroHAYI6UuB20/aEDzeVw737lQzzrQ3d7nJb/g Vn77nJESXhO9IpFsIxIn30XMhSFav7IF9W4iy+hzE1r+5F08Hd9r6opWTPHLVqZgkw0S CP0Yn6X5qrcAcs0O92cXhXitbJ9IwPyd/2ROX+hGPKdsPNjsc/JWiKSjFaftrqWU5pQB rLWyfEh/Yaly//Pw1tOQLsWmD3gQUPf4mTWNxgURjRKSd6NYFMrHEiZl9RBLD+zulsai FZU7cxhwEzWYhMKt9n1HDL76cGBh6SWD6WwUEN0DXTeNS9aYHtyhgJ/aFHyU2l6Qih+n W6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=xsltoJ+dF+zfeCEbbMIuZE8kHB12dqzZs8TVxgAefJ4=; b=ZE7nMcODzewHL1bpwcKjLJoOfPuts6mS2zXC3sVa4VLawhtZaqY8zpGSSLTwH1kl9v sVH7yDkZNDl6KiXEPuFWBPzHaofFUdaK+XEDbrp3vFHeGQD/0WuKY95Zin5JJA2Ll/i9 rn9D0H4G1CAJ5+Nu5tZR4BMmypZMTF1ZvNV/BhaK7gavfEmpBSzTkck0HymJP0fhkUjr d2tB5yIQcdnXNw2wj9MYitXnnCSZmhee4v//EPTCEnfzjsIVIa9KX47PwZMOptpU0i7a 2O0j2c7qJcYl45EAz3FpyvTNjJsB9YM2jerjmWydNDyXx62Hmb9v48C9TZCXXMi3gefJ OAZQ== X-Gm-Message-State: ACgBeo3iA/wK2Olf/8xIzmFl1fe4IH95yaYTo9fB0W7+zFGtZadU2RX1 NMQEng4Wdwd/KsKgMm7soczRIdn88go= X-Google-Smtp-Source: AA6agR5kNgSC8WIOR/guTy01VB6ZBeKd18XpapZrxSp3zFJUChmBFUeJdYroXwEyJhgbetNcj0wBgw== X-Received: by 2002:a17:907:7ea8:b0:731:4fa1:d034 with SMTP id qb40-20020a1709077ea800b007314fa1d034mr5815250ejc.758.1660938270375; Fri, 19 Aug 2022 12:44:30 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 4/7] xen/vgic: Fix MISRA C 2012 Rule 20.7 violation Date: Fri, 19 Aug 2022 22:43:56 +0300 Message-Id: <20220819194359.1196539-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296013100002 Content-Type: text/plain; charset="utf-8" In macro VGIC_V3_LR_INDEX(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/new_vgic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm= /new_vgic.h index ab57fcd91d..b7fa9ab11a 100644 --- a/xen/arch/arm/include/asm/new_vgic.h +++ b/xen/arch/arm/include/asm/new_vgic.h @@ -43,7 +43,7 @@ enum vgic_type { =20 #define VGIC_V2_MAX_LRS (1 << 6) #define VGIC_V3_MAX_LRS 16 -#define VGIC_V3_LR_INDEX(lr) (VGIC_V3_MAX_LRS - 1 - lr) +#define VGIC_V3_LR_INDEX(lr) (VGIC_V3_MAX_LRS - 1 - (lr)) =20 #define VGIC_CONFIG_EDGE false #define VGIC_CONFIG_LEVEL true --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938294; cv=none; d=zohomail.com; s=zohoarc; b=W4DJjuPpV5d7eSwI2klrCy83wq9ymQg9LYzFxr07U24t7hSVT/kFPbstK1YsBzwCUKEx+mpGYP5HLrtNwD8ryunIzPH+C0Oh/i+kpz0xqWymG56kEWhy9JoK/GpPvnm4y7g/CGAQHK/252Q0Og3PnyvTRrWapRxSvLHsHKJoiXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938294; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oaP6VIExQ6VB20XSakrb2m2jk5jIzbKw+InFoPyPqpQ=; b=nmfsJ9HgnqDO5+/jvk8VYriqmKapnc6+n/pQ2bCtZA0J5KYWtvpddDaPIbStBUd4Pd0yucvKAObSU/Kh0cVs9PaTd2wpTOm5bmSt7q80d1QiL67WGdWBxC4mzQnPDJOwJ3ytAwbAEAXP/XVcSv4IdSeJtTmwbP5xEnxLVLrluL8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938294982227.96752727417197; Fri, 19 Aug 2022 12:44:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390441.627916 (Exim 4.92) (envelope-from ) id 1oP7v1-00065w-6B; Fri, 19 Aug 2022 19:44:35 +0000 Received: by outflank-mailman (output) from mailman id 390441.627916; Fri, 19 Aug 2022 19:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7v1-00065k-26; Fri, 19 Aug 2022 19:44:35 +0000 Received: by outflank-mailman (input) for mailman id 390441; Fri, 19 Aug 2022 19:44:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7uz-0004jK-CC for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:33 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58d37be8-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:32 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id s11so6822506edd.13 for ; Fri, 19 Aug 2022 12:44:32 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:31 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58d37be8-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=oaP6VIExQ6VB20XSakrb2m2jk5jIzbKw+InFoPyPqpQ=; b=Kz5hlhDsAbE0V+Hdu1MkI+s4ScUYUw82Sk7ZdPlemeKVuLsEpXlxQb4oL3hG77d8uQ hG6zGuv0HkHplTMk90v9s74MUJ8iZFvXkfQ0Bi9BnOH9mKWH87JDFRxyIx2Xhye13I0M VDf7tis8w04matFtPdEsCVryt9Xg7N5+OmuIZdqE1maHVol/qy6qDMQfETEF+Mq+WatC ZfWnniIkX0UwC3ad3z8/e4+5hKDMJSTFOb38hJGYh8GYGBo/cUgZxAm1MxuLvPjWqkcR 42Bk6ZZuSjFOm1ibIu3QaRJQ4HUAKhMV780Tplom+baXVv06cb7gLgoxWneCOg1kHnWA I3qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=oaP6VIExQ6VB20XSakrb2m2jk5jIzbKw+InFoPyPqpQ=; b=jaP2bWz0K0EgX3i9t9Ufems4Q6gMMJlCbjdEJXOYAHz6TJubbEJnXckpzj1NnhmQa2 UfZbfj70h2YWXAhZMwIHT3L4gvhUhxqFmhlsgy2eMnsrk0wWuUF2JhsSL0Cb1Liw3UDZ XrIiDB6i+JB+589H975NZhRMdOFeyzftV8ITiocWScgDcfzMZTDrsrk1aShnpokOKU89 TcQ/N7rGUwLejn6Eb/Q2vh6juknV+O6EY4fSjiA+GpqSIwl38uCa/LC7Ovui49GlFdZp zRrKVMzmNSqYqMY1SuIo7W+ddOVXRPzYiHVt8QIt2ayDRgAULLRKgfwx+febNAZeWv6q jtRQ== X-Gm-Message-State: ACgBeo0YJYd34GAFO14T+80fFQlN9oFNVC1XGbC02GP4eR8T4T6N1QpA bm8e7RJJEptKNQqx07yQkFHzjE5mHwk= X-Google-Smtp-Source: AA6agR5ALNTr5VEXaywB+zWMCz2vNmDS8Jlmfx3ifRTq40lScBZJBLJj4C0orNke/WLKx35poe6nyg== X-Received: by 2002:a05:6402:2706:b0:43e:5df1:2e04 with SMTP id y6-20020a056402270600b0043e5df12e04mr7137371edd.315.1660938272143; Fri, 19 Aug 2022 12:44:32 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 5/7] xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation Date: Fri, 19 Aug 2022 22:43:57 +0300 Message-Id: <20220819194359.1196539-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296014100003 Content-Type: text/plain; charset="utf-8" In macro __rb_parent(), add parentheses around the macro parameter to preve= nt against unintended expansions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/lib/rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index 85a4f20313..eb418baabb 100644 --- a/xen/lib/rbtree.c +++ b/xen/lib/rbtree.c @@ -46,7 +46,7 @@ #define RB_RED 0 #define RB_BLACK 1 =20 -#define __rb_parent(pc) ((struct rb_node *)(pc & ~3)) +#define __rb_parent(pc) ((struct rb_node *)((pc) & ~3)) =20 #define __rb_color(pc) ((pc) & 1) #define __rb_is_black(pc) __rb_color(pc) --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938294; cv=none; d=zohomail.com; s=zohoarc; b=UcZDrcUeFQA5KtzB7w8YQaLMm1mKmuz+qt71cHOTYrpkTNBQNaKUNNyEnngJV1hulNYyNDMSkcOY9ZRysL2WcBm3sU6pBASmX2fXtKNVC4wBI3jig4d/v/m776MeqXL1UVfTWyv9iRs3VSi5G3axbOCT8hx1sjbkreW2BTBE+bU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938294; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qdHyhH5cSdeW97ssWYPbvEhezNy6ogyo1GiaHowDr9E=; b=YV9AzTy0HcqF8bHOSw3TsvxboUURHa9E7Opsb4Qe7/zdnfoqpNxLZ56aS2H9truflP63sBTvn1ZXkhK/KiATO4T7Z77GXpU/+EbSVAfxnw3PTpWLb0elmrQXa3NCnxvfPPNaoavsi3pRyrTD63EUkt/tV4lqqBv7feo2APFuzKM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938294186451.2006085265415; Fri, 19 Aug 2022 12:44:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390442.627927 (Exim 4.92) (envelope-from ) id 1oP7v2-0006N1-Jq; Fri, 19 Aug 2022 19:44:36 +0000 Received: by outflank-mailman (output) from mailman id 390442.627927; Fri, 19 Aug 2022 19:44:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7v2-0006MK-DQ; Fri, 19 Aug 2022 19:44:36 +0000 Received: by outflank-mailman (input) for mailman id 390442; Fri, 19 Aug 2022 19:44:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7v0-0004jK-SW for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:34 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59b74f91-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:34 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id y13so10601466ejp.13 for ; Fri, 19 Aug 2022 12:44:34 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:33 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59b74f91-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=qdHyhH5cSdeW97ssWYPbvEhezNy6ogyo1GiaHowDr9E=; b=LIs9vals9lwAXZy6OsKuaNRbCwKABh1zuTArxjplkPXuYCvzC/tCtwb7IjAIHmLl0t tx4G11HXMmu8kq1WU+MgdXkT8mgUMWOz8wlgnE8+24025rVDHw2dGkNgxoJH01KKZBzh cmJ4q0T2prC9N60yPkCpz+uDECZl1+TxF5SrjNMSzrKzUp+g4AqDPL1O6e6u0fiPQMEn 1P/TAjktKvX8Uf0SCi3g6Fi7Rx6WPf7zqpnfc1w0/JRTs1lF+cC+HaG+eeWOReJEVAoT YUmYKIuJ99SOVXk8isrztxW8Ric2uU2UNJ7EvrAbDmkW6MklJ/p+7EedzoUjVgiBERwb v87A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=qdHyhH5cSdeW97ssWYPbvEhezNy6ogyo1GiaHowDr9E=; b=rlegrfq901/5+57MoDl3Djn4//goly5+ExCJW6JtB0t5pL8lWDmBeJsHK+UxrfwJCS Owl0+QlGFgUtBwSCeNAusmvmR/ebOAK7tjpaG48AA16OKpI/tNlPo8BmBAMVB1k7pXbK 90BXWM6mJOPspO8SIvdxgjETycwejypmFtAkaAEqiA3P6ZWtmXYckM7rCM5M35blCerJ sxRgwigV8FkfqC9DDmAheluKHF/FlrZ9nCXBheecwPYK2Mgiz/Dj+8bwdLZtPlv++Iij dgwQLGwGott1DvniSkcrQpbnoIkb0ykMIpaozXX14GYCDb1FpHeieRnJNdp4QbcgALpq OEhg== X-Gm-Message-State: ACgBeo323dfVJJC7dnBIFbF/eRq85PIevR41mpGJkwIwpW2L/IIJUHR3 OPEVgax3QEpuRgQ3Ln4XsACI78usCAo= X-Google-Smtp-Source: AA6agR749ueZHOkVbxZH5onEpwlF2SVUhZeIT1JILZCMYBvqbiXiftJkACWjDXsB13H4QebyslO+8g== X-Received: by 2002:a17:907:72d3:b0:73a:d85:a0e2 with SMTP id du19-20020a17090772d300b0073a0d85a0e2mr5774788ejc.550.1660938273598; Fri, 19 Aug 2022 12:44:33 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 6/7] xen/arm: processor: Fix MISRA C 2012 Rule 20.7 violations Date: Fri, 19 Aug 2022 22:43:58 +0300 Message-Id: <20220819194359.1196539-7-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938296120100007 Content-Type: text/plain; charset="utf-8" In macros MPIDR_LEVEL_SHIFT() and MPIDR_AFFINITY_LEVEL(), add parentheses around the macro parameters 'level' and 'mpidr', respectively, to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/as= m/processor.h index 55f56b33bc..1dd81d7d52 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -127,10 +127,10 @@ #define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1) =20 #define MPIDR_LEVEL_SHIFT(level) \ - (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT) + (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) =20 #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ - ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) + (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) =20 #define AFFINITY_MASK(level) ~((_AC(0x1,UL) << MPIDR_LEVEL_SHIFT(level)= ) - 1) =20 --=20 2.34.1 From nobody Tue May 21 23:30:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660938297; cv=none; d=zohomail.com; s=zohoarc; b=Dn+n5NzNDDLyzEYB8Su9EXFe/gSTHK+p8spXsPpR6Uxr4s+zm1v8ji8i+5f7ig0Zn5qpAU/XiLyG5HNF1KaCvBC1cSFW1SWECDFZ6ummGV0kirQ8FrXZmdsSmVU0K+5jwSq7sxL1eFWO41AVOatKauox0ZLHZCTCV1NMJ9wH4N8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660938297; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zr3W75+rbEgAY973OCuXKMwBZmftg9FAYuo83VpG87U=; b=QeZH8G87VPIihPjyXIqtUeEn7T/MJNB1q+l+fo3d0bAYQkWTRlpkvq+BQkE2aU7NTXrl6ZIcrIAL8GJz1ncFDUxsH5Jxay4c+ID1QYWV1ULluUqvLD/WLw5jVOFxB+ILcU5n8FprlEsHizqPRdBIhIleH4E8h6mnCg/PmhVqGCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660938297246895.8671298532406; Fri, 19 Aug 2022 12:44:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390443.627933 (Exim 4.92) (envelope-from ) id 1oP7v3-0006TQ-5t; Fri, 19 Aug 2022 19:44:37 +0000 Received: by outflank-mailman (output) from mailman id 390443.627933; Fri, 19 Aug 2022 19:44:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7v2-0006SM-UN; Fri, 19 Aug 2022 19:44:36 +0000 Received: by outflank-mailman (input) for mailman id 390443; Fri, 19 Aug 2022 19:44:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oP7v2-0004jK-1v for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 19:44:36 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a7a5940-1ff7-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 21:44:35 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id j8so10624606ejx.9 for ; Fri, 19 Aug 2022 12:44:35 -0700 (PDT) Received: from uni.. (adsl-47.176.58.181.tellas.gr. [176.58.181.47]) by smtp.googlemail.com with ESMTPSA id r17-20020a1709061bb100b00731745a7e62sm2695059ejg.28.2022.08.19.12.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:44:34 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a7a5940-1ff7-11ed-bd2e-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=zr3W75+rbEgAY973OCuXKMwBZmftg9FAYuo83VpG87U=; b=MYnAcV536pEaEaP0C6uceSAbrybRsXc9/E4l5wAvvDYBaL6BbePOnwFLMQeZPDwdga OzzOJGfX/7CpmiX26pcuUCQTTp5mvHIwc5czAiasUxHB9lY7dlXQkGAExPvsaNBQ5/K0 kmr1gF80EcA82jxzlUw+yS4pnMKcotbCe+34c1waapot3zGWpUUhMVLUmaLLbZvq4k/m AImjiFFdXDp9g8pCRl2YkxwzahRZ4NqtlOooisZT4Ue0ufW1gmZBpTR1R6kGslW54mXt da7I5VW+/Y+ly/v16RaEMz4t2GAqLkpYIoqyJ3FyBr09+LH+yRBWUddErWImQeQAVeEy ivfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=zr3W75+rbEgAY973OCuXKMwBZmftg9FAYuo83VpG87U=; b=VY8d6sUEihLgl6KLFMHwLYtg0ZBlvI77NBGxpX+1BUOYXbeGtDZTUKN2iJNDeugZa6 FDU1kTa29QatbNFKLF5BhP6jAb6gA+1AWrRes3xq6QhLjNtzXxSqYIIR4YVHIs00uw9X YipQaehsLg75PTs/Bpcr4xQbzcQHcOMRlIb1QR2MSpaQwRyRsHTUcjAUlqxjmYPmjp95 f/Tscbh4XVnp0XUvn0H1Fah2BWQI2ZdPQCoiiP5E2WnRq9dLiS1tB574nlWu6Ayv8qNl CqshKttmZwEm1+vigMUMCmXpA/EIPfahhTE11X/FctvkzKSGC20CW4RYZK8UmP6Oeor0 y7eg== X-Gm-Message-State: ACgBeo3MUs6NDf3TEcHGgU+HIqLOUGQ60bLGDdDdlj18XzXH7cqURC+4 vj4HF2elRz/gAlnGxNpIig3bZq32ukQ= X-Google-Smtp-Source: AA6agR47Pk7lxiJRD6PZ1L4Ihi7zuJngGMMqd4+Jq8z+75Wg1oy3/iLdambiobOITRK3GnkFklNIaQ== X-Received: by 2002:a17:906:84f0:b0:731:8572:80ab with SMTP id zp16-20020a17090684f000b00731857280abmr5769836ejb.254.1660938274860; Fri, 19 Aug 2022 12:44:34 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall Subject: [PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations Date: Fri, 19 Aug 2022 22:43:59 +0300 Message-Id: <20220819194359.1196539-8-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819194359.1196539-1-burzalodowa@gmail.com> References: <20220819194359.1196539-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660938297957100015 Content-Type: text/plain; charset="utf-8" In macros dt_for_each_property_node(), dt_for_each_device_node() and dt_for_each_child_node(), add parentheses around the macro parameters that have the arrow operator applied, to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- xen/include/xen/device_tree.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 430a1ef445..6e4391c126 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -222,13 +222,13 @@ dt_find_interrupt_controller(const struct dt_device_m= atch *matches); #define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 =20 #define dt_for_each_property_node(dn, pp) \ - for ( pp =3D dn->properties; pp !=3D NULL; pp =3D pp->next ) + for ( pp =3D (dn)->properties; pp !=3D NULL; pp =3D (pp)->next ) =20 #define dt_for_each_device_node(dt, dn) \ - for ( dn =3D dt; dn !=3D NULL; dn =3D dn->allnext ) + for ( dn =3D dt; dn !=3D NULL; dn =3D (dn)->allnext ) =20 #define dt_for_each_child_node(dt, dn) \ - for ( dn =3D dt->child; dn !=3D NULL; dn =3D dn->sibling ) + for ( dn =3D (dt)->child; dn !=3D NULL; dn =3D (dn)->sibling ) =20 /* Helper to read a big number; size is in cells (not bytes) */ static inline u64 dt_read_number(const __be32 *cell, int size) --=20 2.34.1