From nobody Fri Nov 29 02:40:18 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D17CCA49B for ; Wed, 8 Jun 2022 14:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243071AbiFHOsG (ORCPT ); Wed, 8 Jun 2022 10:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242174AbiFHOq6 (ORCPT ); Wed, 8 Jun 2022 10:46:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89FD71D5A86; Wed, 8 Jun 2022 07:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=F6PB1BepzhzXddHr1ut7n1kgQmvFEr/OgkB1cnk1WPs=; b=M1tCXyGnbstCdvvtQ6/mZ12wfv +hr+FYDVrB35l8sZT0TTdCikLVIUmFfj6NCuF5T8qgOzzSP3eAZudz5T6mIBNivroM+BT4eJldpE9 7+Nnin03YehIhXL00k8dYiLlUce04mN5y6Ve+yhirYQRYF7ZJS7t2XyylndNROV2N8dfM1PpTU/jz C1KdUd9/P80+q0ZbUHi4gev9nD3XryZhgPN6/lHDLu9WiEScUhG3xTkiznMw9GW8m2H5YeEzUF4I7 K4pDvTrIND321JNLvo0AQr3NAc7PiLRPH3zuBWzcqsQzz70MHALRsvHj1fvGnpMkOMw7xp7tYxu8W voqbkDkQ==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nywwz-00ChWJ-8n; Wed, 08 Jun 2022 14:46:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BCE92302E08; Wed, 8 Jun 2022 16:46:22 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 625B720C10EA1; Wed, 8 Jun 2022 16:46:18 +0200 (CEST) Message-ID: <20220608144516.552202452@infradead.org> User-Agent: quilt/0.66 Date: Wed, 08 Jun 2022 16:27:33 +0200 From: Peter Zijlstra To: peterz@infradead.org Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org Subject: [PATCH 10/36] cpuidle,omap3: Push RCU-idle into driver References: <20220608142723.103523089@infradead.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Doing RCU-idle outside the driver, only to then teporarily enable it again before going idle is daft. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren --- arch/arm/mach-omap2/cpuidle34xx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) --- a/arch/arm/mach-omap2/cpuidle34xx.c +++ b/arch/arm/mach-omap2/cpuidle34xx.c @@ -133,7 +133,9 @@ static int omap3_enter_idle(struct cpuid } =20 /* Execute ARM wfi */ + rcu_idle_enter(); omap_sram_idle(); + rcu_idle_exit(); =20 /* * Call idle CPU PM enter notifier chain to restore @@ -265,6 +267,7 @@ static struct cpuidle_driver omap3_idle_ .owner =3D THIS_MODULE, .states =3D { { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 2 + 2, .target_residency =3D 5, @@ -272,6 +275,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU ON + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 10 + 10, .target_residency =3D 30, @@ -279,6 +283,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU ON + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 50 + 50, .target_residency =3D 300, @@ -286,6 +291,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU RET + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 1500 + 1800, .target_residency =3D 4000, @@ -293,6 +299,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU OFF + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 2500 + 7500, .target_residency =3D 12000, @@ -300,6 +307,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU RET + CORE RET", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 3000 + 8500, .target_residency =3D 15000, @@ -307,6 +315,7 @@ static struct cpuidle_driver omap3_idle_ .desc =3D "MPU OFF + CORE RET", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 10000 + 30000, .target_residency =3D 30000, @@ -328,6 +337,7 @@ static struct cpuidle_driver omap3430_id .owner =3D THIS_MODULE, .states =3D { { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 110 + 162, .target_residency =3D 5, @@ -335,6 +345,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU ON + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 106 + 180, .target_residency =3D 309, @@ -342,6 +353,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU ON + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 107 + 410, .target_residency =3D 46057, @@ -349,6 +361,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU RET + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 121 + 3374, .target_residency =3D 46057, @@ -356,6 +369,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU OFF + CORE ON", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 855 + 1146, .target_residency =3D 46057, @@ -363,6 +377,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU RET + CORE RET", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 7580 + 4134, .target_residency =3D 484329, @@ -370,6 +385,7 @@ static struct cpuidle_driver omap3430_id .desc =3D "MPU OFF + CORE RET", }, { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D omap3_enter_idle_bm, .exit_latency =3D 7505 + 15274, .target_residency =3D 484329,