From nobody Tue Feb 10 20:49:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1653048653; cv=none; d=zohomail.com; s=zohoarc; b=cF5EtSEbhbNYwAc1iC96HolE7XY/R3Sct5AI0DyVZ06fVZrjBgleJJDeu+L2x6T8dzzZ5IOrM9QNXKG4jUM9zu0eZTjt8VDe1FXvL+Kho8PEJiBa7QO9wyonGeaOgi9H8dGtH9KE33s9I8ZZ4VsAgVpUn3f9Vba937cDy808k+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653048653; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P+NWrrFhs3KxS6dDexgzIQNemrzeLTVuO4hodlzBMxc=; b=Q2tAahdY01gBK+QsTdKI1HWKzW3DYO3z+6+naj4OFXR0CcTfronPYepuJEjLIE9SABkQmRNYZm9n7430sOk7ZDryDegHqsro99OQkDA7WAykLOSDuz9VN5sEQPEeWTWrfA6J6ORo0S/mT+kLSdNJHMoVkYBVphLvcgpUXMeYCgs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 165304865374039.7148590542281; Fri, 20 May 2022 05:10:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.333904.557882 (Exim 4.92) (envelope-from ) id 1ns1Sj-0006uT-D5; Fri, 20 May 2022 12:10:33 +0000 Received: by outflank-mailman (output) from mailman id 333904.557882; Fri, 20 May 2022 12:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sj-0006sQ-16; Fri, 20 May 2022 12:10:33 +0000 Received: by outflank-mailman (input) for mailman id 333904; Fri, 20 May 2022 12:10:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sh-0006dX-SG for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sh-0005pF-L3; Fri, 20 May 2022 12:10:31 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sh-0001lI-DD; Fri, 20 May 2022 12:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=P+NWrrFhs3KxS6dDexgzIQNemrzeLTVuO4hodlzBMxc=; b=zpjOljw9eKfhAEkzKFoZ951lxC Lsinhm3LjaJqyo4Goz9AVjTRs64vMfo4jrGxslDEQIJxWNutHUQyzjHDO3hV09Ngp0NhBITbRafrt TiyAFlXDMbz93Yx3biv7GJXzfYXus1p+7GYdgi31lWg5fZilsgWfirwNXOk3sWsJ6fzY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 07/16] xen/arm: mm: Allocate xen page tables in domheap rather than xenheap Date: Fri, 20 May 2022 13:09:28 +0100 Message-Id: <20220520120937.28925-8-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) X-ZM-MESSAGEID: 1653048655719100002 Content-Type: text/plain; charset="utf-8" From: Julien Grall xen_{un,}map_table() already uses the helper to map/unmap pages on-demand (note this is currently a NOP on arm64). So switching to domheap don't have any disavantage. But this as the benefit: - to keep the page tables unmapped if an arch decided to do so - reduce xenheap use on arm32 which can be pretty small Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v3: - Add Stefano's acked-by Changes in v2: - New patch --- xen/arch/arm/mm.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 47c2111c36a4..252114d67df5 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -988,21 +988,6 @@ void *ioremap(paddr_t pa, size_t len) return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); } =20 -static int create_xen_table(lpae_t *entry) -{ - void *p; - lpae_t pte; - - p =3D alloc_xenheap_page(); - if ( p =3D=3D NULL ) - return -ENOMEM; - clear_page(p); - pte =3D mfn_to_xen_entry(virt_to_mfn(p), MT_NORMAL); - pte.pt.table =3D 1; - write_pte(entry, pte); - return 0; -} - static lpae_t *xen_map_table(mfn_t mfn) { /* @@ -1043,6 +1028,27 @@ static void xen_unmap_table(const lpae_t *table) unmap_domain_page(table); } =20 +static int create_xen_table(lpae_t *entry) +{ + struct page_info *pg; + void *p; + lpae_t pte; + + pg =3D alloc_domheap_page(NULL, 0); + if ( pg =3D=3D NULL ) + return -ENOMEM; + + p =3D xen_map_table(page_to_mfn(pg)); + clear_page(p); + xen_unmap_table(p); + + pte =3D mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL); + pte.pt.table =3D 1; + write_pte(entry, pte); + + return 0; +} + #define XEN_TABLE_MAP_FAILED 0 #define XEN_TABLE_SUPER_PAGE 1 #define XEN_TABLE_NORMAL_PAGE 2 --=20 2.32.0