From nobody Sat Apr 20 11:45:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1651892123190169.35716091828067; Fri, 6 May 2022 19:55:23 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.323537.545259 (Exim 4.92) (envelope-from ) id 1nnAav-00047Y-9M; Sat, 07 May 2022 02:54:57 +0000 Received: by outflank-mailman (output) from mailman id 323537.545259; Sat, 07 May 2022 02:54:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAav-00047R-6E; Sat, 07 May 2022 02:54:57 +0000 Received: by outflank-mailman (input) for mailman id 323537; Sat, 07 May 2022 02:54:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAat-00046g-T0 for xen-devel@lists.xenproject.org; Sat, 07 May 2022 02:54:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1280da6d-cdb1-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 04:54:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DECB14BF; Fri, 6 May 2022 19:54:54 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 922923F800; Fri, 6 May 2022 19:54:49 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1280da6d-cdb1-11ec-8fc4-03012f2f19d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v3 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Date: Sat, 7 May 2022 10:54:33 +0800 Message-Id: <20220507025434.1063710-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507025434.1063710-1-Henry.Wang@arm.com> References: <20220507025434.1063710-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1651892126106100001 Content-Type: text/plain; charset="utf-8" With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <=3D 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. Moving the call of request_irq() past local_irq_enable() on secondary cores will make sure the assertion condition in alloc_xenheap_pages(), i.e. !in_irq && local_irq_enabled() is satisfied. It is also safe because the timer and GIC maintenance interrupt will not be used until the CPU is fully online. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- v2 -> v3: - No changes. v1 -> v2: - Explain why the moving of code is safe in the commit message and add comments. --- xen/arch/arm/smpboot.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7bfd0a73a7..9bb32a301a 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -361,9 +361,6 @@ void start_secondary(void) =20 init_secondary_IRQ(); =20 - init_maintenance_interrupt(); - init_timer_interrupt(); - set_current(idle_vcpu[cpuid]); =20 setup_cpu_sibling_map(cpuid); @@ -380,6 +377,15 @@ void start_secondary(void) cpumask_set_cpu(cpuid, &cpu_online_map); =20 local_irq_enable(); + + /* + * Calling request_irq() after local_irq_enable() on secondary cores + * will make sure the assertion condition in alloc_xenheap_pages(), + * i.e. !in_irq && local_irq_enabled() is satisfied. + */ + init_maintenance_interrupt(); + init_timer_interrupt(); + local_abort_enable(); =20 check_local_cpu_errata(); --=20 2.25.1 From nobody Sat Apr 20 11:45:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1651892126868466.52079342897366; Fri, 6 May 2022 19:55:26 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.323539.545271 (Exim 4.92) (envelope-from ) id 1nnAb3-0004Ta-IT; Sat, 07 May 2022 02:55:05 +0000 Received: by outflank-mailman (output) from mailman id 323539.545271; Sat, 07 May 2022 02:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAb3-0004TM-FO; Sat, 07 May 2022 02:55:05 +0000 Received: by outflank-mailman (input) for mailman id 323539; Sat, 07 May 2022 02:55:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAb2-0003pQ-Iu for xen-devel@lists.xenproject.org; Sat, 07 May 2022 02:55:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 17b6c4e7-cdb1-11ec-a406-831a346695d4; Sat, 07 May 2022 04:55:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD24F14BF; Fri, 6 May 2022 19:55:02 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4D3233F800; Fri, 6 May 2022 19:54:58 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17b6c4e7-cdb1-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v3 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Date: Sat, 7 May 2022 10:54:34 +0800 Message-Id: <20220507025434.1063710-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507025434.1063710-1-Henry.Wang@arm.com> References: <20220507025434.1063710-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1651892127619100003 Content-Type: text/plain; charset="utf-8" xmalloc() will use a pool for allocation smaller than a page. The pool is extended only when there are no more space. At which point, alloc_xenheap_pages() is called to add more memory. xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in alloc_xenheap_pages(). Hence, this commit moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). For consistency, the same assertion should be used in xfree(), and the position of the assertion should be at the beginning of the xfree(). Also take the opportunity to enhance the non-static functions xmem_pool_{alloc,free}() with the same assertion so that future callers of these two functions can be benefited. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang Acked-by: Julien Grall Tested-by: Julien Grall --- v2 -> v3: - Add ASSERT_ALLOC_CONTEXT in xmem_pool_{alloc,free}() - Also change the assertion in xfree to ASSERT_ALLOC_CONTEXT and move the position of assertion to the beginning of the function. v1 -> v2: - No changes --- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 10 +++++++--- xen/include/xen/irq.h | 7 +++++++ 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e866e0d864..ea59cd1a4a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -162,13 +162,6 @@ static char __initdata opt_badpage[100] =3D ""; string_param("badpage", opt_badpage); =20 -/* - * Heap allocations may need TLB flushes which may require IRQs to be - * enabled (except when only 1 PCPU is online). - */ -#define ASSERT_ALLOC_CONTEXT() \ - ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <=3D = 1)) - /* * no-bootscrub -> Free pages are not zeroed during boot. */ diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index d2ad909502..75bdf18c4e 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -378,6 +378,8 @@ void *xmem_pool_alloc(unsigned long size, struct xmem_p= ool *pool) int fl, sl; unsigned long tmp_size; =20 + ASSERT_ALLOC_CONTEXT(); + if ( size < MIN_BLOCK_SIZE ) size =3D MIN_BLOCK_SIZE; else @@ -456,6 +458,8 @@ void xmem_pool_free(void *ptr, struct xmem_pool *pool) struct bhdr *b, *tmp_b; int fl =3D 0, sl =3D 0; =20 + ASSERT_ALLOC_CONTEXT(); + if ( unlikely(ptr =3D=3D NULL) ) return; =20 @@ -594,7 +598,7 @@ void *_xmalloc(unsigned long size, unsigned long align) { void *p =3D NULL; =20 - ASSERT(!in_irq()); + ASSERT_ALLOC_CONTEXT(); =20 if ( !size ) return ZERO_BLOCK_PTR; @@ -697,11 +701,11 @@ void *_xrealloc(void *ptr, unsigned long size, unsign= ed long align) =20 void xfree(void *p) { + ASSERT_ALLOC_CONTEXT(); + if ( p =3D=3D NULL || p =3D=3D ZERO_BLOCK_PTR ) return; =20 - ASSERT(!in_irq()); - if ( !((unsigned long)p & (PAGE_SIZE - 1)) ) { unsigned long size =3D PFN_ORDER(virt_to_page(p)); diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index d8beadd16b..300625e56d 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -10,6 +10,13 @@ #include #include =20 +/* + * Heap allocations may need TLB flushes which may require IRQs to be + * enabled (except when only 1 PCPU is online). + */ +#define ASSERT_ALLOC_CONTEXT() \ + ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <=3D = 1)) + struct irqaction { void (*handler)(int, void *, struct cpu_user_regs *); const char *name; --=20 2.25.1