From nobody Fri May 17 20:44:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1646055366; cv=none; d=zohomail.com; s=zohoarc; b=LucD9K/nkRyhKC0a8CL14NE3vNL/U0rrGqp9cMdsx/wBHbvojm9vG6ZHUiPNV1B7z1ptHGU8WQa24WGfaaq7XXtod4ybXx5OvMnY7aDziUP3dqz6pvT1QSI5OV/PkMomnoZ3wn8c/1+Um7QFtI+TNbQtIGGY0Ko1LA2ObpbQDXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646055366; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Bn4hKvD9tCHF+9EbFmzzBxbr9GyN25lLdXJIPYnrD3g=; b=OoGEd95jIzS9e3oQxnxrhJEOqlv2FRWWxoBVZABuIUDpgA5UCgzjQaATA33DDZq1tUK+lrQTydffkv1UAYIqDNEZNL7t7QDKJzUPhI0GQr3DNwT9OYxpr5l27/IUU6f1KcWLPMOw2nN+jhOHx7KlfmJ/rWrzWzd4aecKWg4qssQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1646055366596399.66354603461355; Mon, 28 Feb 2022 05:36:06 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.280565.478546 (Exim 4.92) (envelope-from ) id 1nOgBo-00089o-Ji; Mon, 28 Feb 2022 13:35:48 +0000 Received: by outflank-mailman (output) from mailman id 280565.478546; Mon, 28 Feb 2022 13:35:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOgBo-00089h-F7; Mon, 28 Feb 2022 13:35:48 +0000 Received: by outflank-mailman (input) for mailman id 280565; Mon, 28 Feb 2022 13:35:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOgBn-00089b-HQ for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:35:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOgBn-000650-95; Mon, 28 Feb 2022 13:35:47 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nOgBn-00044y-11; Mon, 28 Feb 2022 13:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=Bn4hKvD9tCHF+9EbFmzzBxbr9GyN25lLdXJIPYnrD3g=; b=Dr8F1w cKuWsyhC+ytpO2SIPHUHY/3hQHUek69ei/AmJ/gE3lZmJtdyxIKf+LdH25c+WsSONqoxSiJsXBTX1 dj+txc3Z46+WZcH5QKLKcIEv7fWOyNqT3YS2t2lBFEitZczZ943q8FSJ5myePkupJij3UXaWwXt8L d/q+tgZdXAA=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: michal.orzel@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] xen/arm32: head: Don't set r12 and update the documentation Date: Mon, 28 Feb 2022 13:35:36 +0000 Message-Id: <20220228133536.57004-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) X-ZM-MESSAGEID: 1646055369204100001 Content-Type: text/plain; charset="utf-8" From: Julien Grall Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document launch()"), the boot code is setting r12 but not read it. So remove the two instructions setting r12 and update the documentation to show r12 has no specific purpose. Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Reviewed-by: Michal Orzel --- Changes in v2: - Don't set r12. --- xen/arch/arm/arm32/head.S | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 13cfc837d39c..7a906167efca 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -79,7 +79,7 @@ * r9 - paddr(start) * r10 - phys offset * r11 - UART address - * r12 - is_secondary_cpu + * r12 - * r13 - SP * r14 - LR * r15 - PC @@ -166,8 +166,6 @@ past_zImage: #endif PRINT("- Boot CPU booting -\r\n") =20 - mov r12, #0 /* r12 :=3D is_secondary_cpu */ - bl check_cpu_mode bl cpu_init bl create_page_tables @@ -206,8 +204,6 @@ GLOBAL(init_secondary) adr r9, start /* r9 :=3D paddr (start) */ sub r10, r9, r0 /* r10 :=3D phys-offset */ =20 - mov r12, #1 /* r12 :=3D is_secondary_cpu */ - mrc CP32(r1, MPIDR) bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID = */ =20 --=20 2.32.0