From nobody Tue Feb 10 04:15:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1645802055; cv=none; d=zohomail.com; s=zohoarc; b=fI8q6o/E+u1CodmioK8RIEpUtNdMY5YQSKnonoFhL9xz2PPJ0wjkDFnUCvMDu/21JenqqkIooqGNn0hl+qdB8gdMfU3v1SzcAeni13eKNJjcAZmTqmLd6UlfLsKnPo+ACVvcrB4bfF/MY0kUhhZpjWuvzIVV4Ubq+DILEF/U/mQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645802055; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hzspNkb8ZMSYKqARt6ErFOmHQLgJX5JngtdG5RLn4kI=; b=SHqjFQzFl9qGZ8X9qabF7fNuwH4Qy+vGlLIr312ao2+dHG5NDZM0Arrgik6uIVuretIDeySYMwe6QSEMq2458kZdWmaRSBpAMYLLsxQuF9vwHuo4lJcyhYieVxVB2Xd3+r9izfmQ4p2FGaV5mf2T0mA2ZcHpcGsrKSnseHZ9spY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1645802055964483.3330923099089; Fri, 25 Feb 2022 07:14:15 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.279188.476866 (Exim 4.92) (envelope-from ) id 1nNcIA-0001YA-Rz; Fri, 25 Feb 2022 15:13:58 +0000 Received: by outflank-mailman (output) from mailman id 279188.476866; Fri, 25 Feb 2022 15:13:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nNcIA-0001Xa-Ll; Fri, 25 Feb 2022 15:13:58 +0000 Received: by outflank-mailman (input) for mailman id 279188; Fri, 25 Feb 2022 15:13:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nNcI8-0006fy-FH for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:56 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8af36756-964d-11ec-8539-5f4723681683; Fri, 25 Feb 2022 16:13:54 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8af36756-964d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1645802034; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PsH7X2yVeRIwZGaTHcN3WknuPqURtR6v199OPOJQpsM=; b=eAU7I2/TBmrBo7+9gVKkVDUdQUjMBvi+VAfFXr9b2rL86r6sLqrC56kh KnfCDi9HVBhVX8v+U5sJ0030DqN9SO1yaV4naZiKlACsfMYjao7mcO0bs scDsZnFSY0eULUv4d/1Vvukv50YTpZt0cZ6IHj7X+3l6fXfANtWD1zcF+ A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 67264742 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:a1ypo6ll8X08Ba4+jWCeC1Po5gyLJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIcDGDVPPaNYzHwf91ya4jg8EkO6p+AzdQyTAFp+ytnRSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSwhwPfHWs78mVSIINw0gZYpp1Jn5CC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJHNmAxMEucOXWjPH82KcwMtaShwUDgTANSkUy3m6At73bcmVkZPL/Fb4OOJ43iqd9utkSXv GXd5EziHwoXcteYzFKt8G+oh+LJtTP2XsQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa60iDXtT7GRqirxa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpatN/t5MsbmcR0 GTZu/+3XRtAnJurYCfInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6 3XT9XVl2e1P5SIe//jjpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX UToeeDCvYji7rnXzURhpdnh+pnztp5p1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYif3MvMuP9/pU5xypUQFKTgDfqqFBjapSsIsHDJrAQk0PRLAt4wTuBJEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrXbc1o+RTp4UKe5LHFIU9UNopm5X9zgp hmVMnK0AnKm7ZEbAW1mskxeVY4= IronPort-HdrOrdr: A9a23:IzpogKgnKbNH4PsvRxw1oQxXm3BQXuIji2hC6mlwRA09TySZ// rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; d="scan'208";a="67264742" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu , "Juergen Gross" , Julien Grall Subject: [XEN PATCH v2 11/29] tools/xenstore: Cleanup makefile Date: Fri, 25 Feb 2022 15:13:03 +0000 Message-ID: <20220225151321.44126-12-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com> References: <20220225151321.44126-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1645802058034100005 Content-Type: text/plain; charset="utf-8" Regroup *FLAGS together, use $(LDLIBS). Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't decribe how to link to a potential libxenstored.so, instead add the value to $(LDLIBS) of xenstored. Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS). Remove the "-I." from $(CFLAGS), it shouldn't be needed. Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included in $(CFLAGS) and both aren't used anyway. Rename ALL_TARGETS to TARGETS. Only add programmes we want to build in $(TARGETS), not phony-targets (replace "clients"). Store all `xenstored` objs into $(XENSTORED_OBJS-y). Replace one $< by $^ even if there's only one dependency, (xenstore-control). clean: "init-xenstore-domain" isn't built here any more, so stop trying to remove it, remove $(TARGETS). Also regroup all files to be removed in one command, using $(RM). Drop $(MAJOR) and $(MINOR), they aren't used anymore. Drop ".SECONDARY:", it doesn't appear there's intermediate files that would be deleted anymore. Drop "tarball:" target. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross --- Notes: v2: - drop MAJOR and MINOR variables - drop tarball rule - drop ".SECONDARY:" - rework "clean:" to have one command tools/xenstore/Makefile | 91 +++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 48 deletions(-) diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index c86278fdb1..830052c65f 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -1,11 +1,7 @@ XEN_ROOT=3D$(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk =20 -MAJOR =3D 3.0 -MINOR =3D 3 - CFLAGS +=3D -Werror -CFLAGS +=3D -I. # Include configure output (config.h) CFLAGS +=3D -include $(XEN_ROOT)/tools/config.h CFLAGS +=3D -I./include @@ -16,71 +12,77 @@ CFLAGS +=3D $(CFLAGS_libxentoolcore) CFLAGS +=3D -DXEN_LIB_STORED=3D"\"$(XEN_LIB_STORED)\"" CFLAGS +=3D -DXEN_RUN_STORED=3D"\"$(XEN_RUN_STORED)\"" =20 -CFLAGS +=3D $(CFLAGS-y) -LDFLAGS +=3D $(LDFLAGS-y) +ifdef CONFIG_STUBDOM +CFLAGS +=3D -DNO_SOCKETS=3D1 +endif =20 -CLIENTS :=3D xenstore-exists xenstore-list xenstore-read xenstore-rm xenst= ore-chmod -CLIENTS +=3D xenstore-write xenstore-ls xenstore-watch +XENSTORED_OBJS-y :=3D xenstored_core.o xenstored_watch.o xenstored_domain.o +XENSTORED_OBJS-y +=3D xenstored_transaction.o xenstored_control.o +XENSTORED_OBJS-y +=3D xs_lib.o talloc.o utils.o tdb.o hashtable.o =20 -XENSTORED_OBJS =3D xenstored_core.o xenstored_watch.o xenstored_domain.o -XENSTORED_OBJS +=3D xenstored_transaction.o xenstored_control.o -XENSTORED_OBJS +=3D xs_lib.o talloc.o utils.o tdb.o hashtable.o +XENSTORED_OBJS-$(CONFIG_Linux) +=3D xenstored_posix.o +XENSTORED_OBJS-$(CONFIG_NetBSD) +=3D xenstored_posix.o +XENSTORED_OBJS-$(CONFIG_FreeBSD) +=3D xenstored_posix.o +XENSTORED_OBJS-$(CONFIG_MiniOS) +=3D xenstored_minios.o =20 -XENSTORED_OBJS_$(CONFIG_Linux) =3D xenstored_posix.o -XENSTORED_OBJS_$(CONFIG_NetBSD) =3D xenstored_posix.o -XENSTORED_OBJS_$(CONFIG_FreeBSD) =3D xenstored_posix.o -XENSTORED_OBJS_$(CONFIG_MiniOS) =3D xenstored_minios.o +$(XENSTORED_OBJS-y): CFLAGS +=3D $(CFLAGS_libxengnttab) =20 -XENSTORED_OBJS +=3D $(XENSTORED_OBJS_y) -LDLIBS_xenstored +=3D -lrt +xenstored: LDLIBS +=3D $(LDLIBS_libxenevtchn) +xenstored: LDLIBS +=3D $(LDLIBS_libxengnttab) +xenstored: LDLIBS +=3D $(LDLIBS_libxenctrl) +xenstored: LDLIBS +=3D -lrt +xenstored: LDLIBS +=3D $(SOCKET_LIBS) =20 -ALL_TARGETS =3D clients -ifeq ($(XENSTORE_XENSTORED),y) -ALL_TARGETS +=3D xs_tdb_dump xenstored +ifeq ($(CONFIG_SYSTEMD),y) +$(XENSTORED_OBJS-y): CFLAGS +=3D $(SYSTEMD_CFLAGS) +xenstored: LDLIBS +=3D $(SYSTEMD_LIBS) endif =20 -ifdef CONFIG_STUBDOM -CFLAGS +=3D -DNO_SOCKETS=3D1 +xenstore: LDLIBS +=3D $(LDLIBS_libxenstore) +xenstore: LDLIBS +=3D $(LDLIBS_libxentoolcore) +xenstore: LDLIBS +=3D $(SOCKET_LIBS) + +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenstore) +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenctrl) +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenguest) +xenstore-control: LDLIBS +=3D $(LDLIBS_libxentoolcore) +xenstore-control: LDLIBS +=3D $(SOCKET_LIBS) + +CLIENTS :=3D xenstore-exists xenstore-list xenstore-read xenstore-rm xenst= ore-chmod +CLIENTS +=3D xenstore-write xenstore-ls xenstore-watch + +TARGETS :=3D xenstore $(CLIENTS) xenstore-control +ifeq ($(XENSTORE_XENSTORED),y) +TARGETS +=3D xs_tdb_dump xenstored endif =20 .PHONY: all -all: $(ALL_TARGETS) +all: $(TARGETS) =20 .PHONY: clients clients: xenstore $(CLIENTS) xenstore-control =20 -ifeq ($(CONFIG_SYSTEMD),y) -$(XENSTORED_OBJS): CFLAGS +=3D $(SYSTEMD_CFLAGS) -xenstored: LDFLAGS +=3D $(SYSTEMD_LIBS) -endif - -$(XENSTORED_OBJS): CFLAGS +=3D $(CFLAGS_libxengnttab) - -xenstored: $(XENSTORED_OBJS) - $(CC) $^ $(LDFLAGS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIB= S_libxenctrl) $(LDLIBS_xenstored) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS) +xenstored: $(XENSTORED_OBJS-y) + $(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS) =20 -xenstored.a: $(XENSTORED_OBJS) +xenstored.a: $(XENSTORED_OBJS-y) $(AR) cr $@ $^ =20 $(CLIENTS): xenstore ln -f xenstore $@ =20 xenstore: xenstore_client.o xs_lib.o - $(CC) $^ $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCK= ET_LIBS) -o $@ $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS) =20 xenstore-control: xenstore_control.o - $(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_l= ibxenguest) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS) =20 xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o - $(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS) =20 .PHONY: clean clean: - rm -f *.a *.o - rm -f xenstored - rm -f xs_tdb_dump xenstore-control init-xenstore-domain - rm -f xenstore $(CLIENTS) - $(RM) $(DEPS_RM) + $(RM) *.a *.o $(TARGETS) $(DEPS_RM) =20 .PHONY: distclean distclean: clean @@ -89,10 +91,6 @@ distclean: clean TAGS: etags `find . -name '*.[ch]'` =20 -.PHONY: tarball -tarball: clean - cd .. && tar -c -j -v -h -f xenstore.tar.bz2 xenstore/ - .PHONY: install install: all $(INSTALL_DIR) $(DESTDIR)$(bindir) @@ -135,6 +133,3 @@ clients-install: clients done =20 -include $(DEPS_INCLUDE) - -# never delete any intermediate files. -.SECONDARY: --=20 Anthony PERARD