From nobody Sun May 19 04:34:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1644306193; cv=none; d=zohomail.com; s=zohoarc; b=KYLlEc/HLqQIrpLEFOIWhAwFpkt7D8Ow687QeGMxgEBd+6pZ9utdM1cwOPDtE09ileJJCELGQ/767WvoYB2J4IeArdE7ntJ+LDqlTAp225Z7abBUhBsOO2AVXGD55SS3nZOeWZgVJgV0APaZv2/83WNuB4CKZXt8Y8BMelzqgJA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644306193; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=RkNVJ8B50ZJGLSJsqgFPrNnsyQy6qOKAOEmYrLaw3oU=; b=VQs7KXLqGgEHS5g0ltPMzZ3/M6THwI4CkxsYmj3ihTMplGG+8nV5cYwmHd92ET81dt1/1UletvBLM5fpSyDSTkl4MQ+TOWd81U8TgSeEz8lwvG5hk5v8dWUSrgUgwZ1uYIEGpq0RZKgAKGgLcvn0zKjK0F2IR/6k3U28Y/AQkQg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1644306193774471.23428433288836; Mon, 7 Feb 2022 23:43:13 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.267619.461365 (Exim 4.92) (envelope-from ) id 1nHL91-0008GE-0z; Tue, 08 Feb 2022 07:42:35 +0000 Received: by outflank-mailman (output) from mailman id 267619.461365; Tue, 08 Feb 2022 07:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nHL90-0008G7-Se; Tue, 08 Feb 2022 07:42:34 +0000 Received: by outflank-mailman (input) for mailman id 267619; Tue, 08 Feb 2022 07:42:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nHL90-0008G1-4h for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:42:34 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acf2fee5-88b2-11ec-8f75-fffcc8bd4f1a; Tue, 08 Feb 2022 08:42:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 997AE1F37C; Tue, 8 Feb 2022 07:42:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51BC513310; Tue, 8 Feb 2022 07:42:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6UiREugeAmJuKgAAMHmgww (envelope-from ); Tue, 08 Feb 2022 07:42:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acf2fee5-88b2-11ec-8f75-fffcc8bd4f1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1644306152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RkNVJ8B50ZJGLSJsqgFPrNnsyQy6qOKAOEmYrLaw3oU=; b=eddlgDv8TnhY8YtMap9NK02ImSBXAh/JBx2Ts438iP7aS+v58Ua0GrnTDviKSk2P0zdvga Jn25nqZbJxS52lxXkd9xQF+Mu2dAnpT8OGw4HEVhfZM39FER9VKHf6oLn0fKEn/TJg8A/X Nex1jCoezOeQv/HAoMInxwsDxYp6ERI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2] xen/public: add comment to struct xen_mem_acquire_resource Date: Tue, 8 Feb 2022 08:42:30 +0100 Message-Id: <20220208074230.7901-1-jgross@suse.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1644306195982100001 Content-Type: text/plain; charset="utf-8" Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible way. Unfortunately the changed parts were already in use in the Linux kernel, so an update of the header in the kernel would result in a build breakage. As the change of above commit was in a section originally meant to be not stable, it was the usage in the kernel which was wrong. Add a comment to the modified struct for not reusing the now removed bit, in order to avoid kernels using it stumbling over a possible new meaning of the bit. In case the kernel is updating to a new version of the header, the wrong use case must be removed first. Signed-off-by: Juergen Gross --- V2: - only add comment instead of reverting commit 7c7f7e8fba01 (Jan Beulich) --- xen/include/public/memory.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index 383a9468c3..86513057f7 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -662,6 +662,11 @@ struct xen_mem_acquire_resource { * two calls. */ uint32_t nr_frames; + /* + * Padding field, must be zero on input. + * The lowest bit was named XENMEM_rsrc_acq_caller_owned in a previous + * version and should not be reused in future. + */ uint32_t pad; /* * IN - the index of the initial frame to be mapped. This parameter --=20 2.34.1