From nobody Thu Apr 25 15:53:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1641913962; cv=none; d=zohomail.com; s=zohoarc; b=bJNAMQOK+xOUWBTLhRk9GrtYE5Hh6dL7M9MDwGEBsuPXtwuvW1q7cbaf0v37IK6FFTJaQGfPrzG/TT6K5RRVqupezSivlUhb1YOM8yOFRronYjUkCvd8srDcG6aGUmkuYym/M5GEdzLmwwpfqreuF3gwwnnQmLH5Xcz9OyzE1rA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641913962; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jVhuzq1ru9rCdLBgGyz4Ec9Qdw5HVMOj866c/uvvnJ8=; b=CNdXGrhPOz3OztAmoygm3siKsUNOHGRYJfqEO4decAAL4q8/P8RvA/UQUpnHw7aGaEGeYgWrF74eNthuyRK67wpFKXq+MEUldqZQ4d7i36f8Nnlt35ipcAs0MxC0qikqCv+q9oJUgJK76GISj0UxcT8iy+v/eoidULA5smrNqZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1641913962592971.0011268087685; Tue, 11 Jan 2022 07:12:42 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.255876.438796 (Exim 4.92) (envelope-from ) id 1n7Ip3-0004AF-FM; Tue, 11 Jan 2022 15:12:29 +0000 Received: by outflank-mailman (output) from mailman id 255876.438796; Tue, 11 Jan 2022 15:12:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n7Ip2-00045B-H8; Tue, 11 Jan 2022 15:12:28 +0000 Received: by outflank-mailman (input) for mailman id 255876; Tue, 11 Jan 2022 15:12:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n7Ioz-0002Fw-DT for xen-devel@lists.xenproject.org; Tue, 11 Jan 2022 15:12:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddef8a1b-72f0-11ec-81c1-a30af7de8005; Tue, 11 Jan 2022 16:12:18 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 43AEB1F3B1; Tue, 11 Jan 2022 15:12:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1886213DDD; Tue, 11 Jan 2022 15:12:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EL60BFKe3WG8AwAAMHmgww (envelope-from ); Tue, 11 Jan 2022 15:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddef8a1b-72f0-11ec-81c1-a30af7de8005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1641913938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jVhuzq1ru9rCdLBgGyz4Ec9Qdw5HVMOj866c/uvvnJ8=; b=fyJ4xFFUjaB4MnesIRmrqRCUyyfsdRLZi/4jAokXUD4t39jqDelNiYROsMocP1Jn8duNF5 3aXoFY79DAEDfznK9s5FKTjKbNTmsAm4DM/K6s+zw14+ofdru7KNAIy+Y4wnFdCIr+Zlo6 tgL1v0m2i/UlH2Hrb05Ko68zCifDARI= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 07/12] mini-os: use get_file_from_fd() in netfront Date: Tue, 11 Jan 2022 16:12:10 +0100 Message-Id: <20220111151215.22955-8-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20220111151215.22955-1-jgross@suse.com> References: <20220111151215.22955-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1641913963822100001 Content-Type: text/plain; charset="utf-8" Instead of directly accessing the files[] array use get_file_from_fd(). Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- include/lib.h | 3 +-- lib/sys.c | 23 ------------------ netfront.c | 64 ++++++++++++++++++++++++++++++++++++++++++++------- 3 files changed, 57 insertions(+), 33 deletions(-) diff --git a/include/lib.h b/include/lib.h index 05f5083..aa8036e 100644 --- a/include/lib.h +++ b/include/lib.h @@ -163,8 +163,7 @@ void sanity_check(void); #define FTYPE_SAVEFILE 5 #define FTYPE_FB 6 #define FTYPE_KBD 7 -#define FTYPE_TAP 8 -#define FTYPE_N 9 +#define FTYPE_N 8 #define FTYPE_SPARE 16 =20 typedef int file_read_func(int fd, void *buf, size_t nbytes); diff --git a/lib/sys.c b/lib/sys.c index f84fedd..7f2e11f 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -303,17 +303,6 @@ int read(int fd, void *buf, size_t nbytes) case FTYPE_SOCKET: return lwip_read(files[fd].fd, buf, nbytes); #endif -#ifdef CONFIG_NETFRONT - case FTYPE_TAP: { - ssize_t ret; - ret =3D netfront_receive(files[fd].dev, buf, nbytes); - if (ret <=3D 0) { - errno =3D EAGAIN; - return -1; - } - return ret; - } -#endif #ifdef CONFIG_KBDFRONT case FTYPE_KBD: { int ret, n; @@ -369,11 +358,6 @@ int write(int fd, const void *buf, size_t nbytes) #ifdef HAVE_LWIP case FTYPE_SOCKET: return lwip_write(files[fd].fd, (void*) buf, nbytes); -#endif -#ifdef CONFIG_NETFRONT - case FTYPE_TAP: - netfront_xmit(files[fd].dev, (void*) buf, nbytes); - return nbytes; #endif default: break; @@ -459,11 +443,6 @@ int close(int fd) res =3D lwip_close(files[fd].fd); break; #endif -#ifdef CONFIG_NETFRONT - case FTYPE_TAP: - shutdown_netfront(files[fd].dev); - break; -#endif #ifdef CONFIG_KBDFRONT case FTYPE_KBD: shutdown_kbdfront(files[fd].dev); @@ -640,7 +619,6 @@ static const char *file_types[] =3D { [FTYPE_NONE] =3D "none", [FTYPE_CONSOLE] =3D "console", [FTYPE_SOCKET] =3D "socket", - [FTYPE_TAP] =3D "net", [FTYPE_KBD] =3D "kbd", [FTYPE_FB] =3D "fb", }; @@ -817,7 +795,6 @@ static int select_poll(int nfds, fd_set *readfds, fd_se= t *writefds, fd_set *exce n++; FD_CLR(i, exceptfds); break; - case FTYPE_TAP: case FTYPE_KBD: case FTYPE_FB: if (FD_ISSET(i, readfds)) { diff --git a/netfront.c b/netfront.c index 7696451..f86c6a2 100644 --- a/netfront.c +++ b/netfront.c @@ -248,14 +248,14 @@ void netfront_select_handler(evtchn_port_t port, stru= ct pt_regs *regs, void *dat { int flags; struct netfront_dev *dev =3D data; - int fd =3D dev->fd; + struct file *file =3D get_file_from_fd(dev->fd); =20 local_irq_save(flags); network_tx_buf_gc(dev); local_irq_restore(flags); =20 - if (fd !=3D -1) - files[fd].read =3D true; + if ( file ) + file->read =3D true; wake_up(&netfront_queue); } #endif @@ -565,8 +565,54 @@ error: } =20 #ifdef HAVE_LIBC +static int netfront_read(int fd, void *buf, size_t nbytes) +{ + ssize_t ret; + struct file *file =3D get_file_from_fd(fd); + + ret =3D netfront_receive(file->dev, buf, nbytes); + if ( ret <=3D 0 ) + { + errno =3D EAGAIN; + return -1; + } + + return ret; +} + +static int netfront_write(int fd, const void *buf, size_t nbytes) +{ + struct file *file =3D get_file_from_fd(fd); + + netfront_xmit(file->dev, (void *)buf, nbytes); + + return nbytes; +} + +static int netfront_close_fd(int fd) +{ + struct file *file =3D get_file_from_fd(fd); + + shutdown_netfront(file->dev); + + return 0; +} + +static struct file_ops netfront_ops =3D { + .name =3D "net", + .read =3D netfront_read, + .write =3D netfront_write, + .close =3D netfront_close_fd, + .select_rd =3D select_read_flag, +}; + int netfront_tap_open(char *nodename) { struct netfront_dev *dev; + struct file *file; + static unsigned int ftype_netfront; + + if ( !ftype_netfront ) + ftype_netfront =3D alloc_file_type(&netfront_ops); =20 dev =3D init_netfront(nodename, NETIF_SELECT_RX, NULL, NULL); if (!dev) { @@ -574,9 +620,10 @@ int netfront_tap_open(char *nodename) { errno =3D EIO; return -1; } - dev->fd =3D alloc_fd(FTYPE_TAP); + dev->fd =3D alloc_fd(ftype_netfront); printk("tap_open(%s) -> %d\n", nodename, dev->fd); - files[dev->fd].dev =3D dev; + file =3D get_file_from_fd(dev->fd); + file->dev =3D dev; return dev->fd; } #endif @@ -772,7 +819,8 @@ void netfront_xmit(struct netfront_dev *dev, unsigned c= har* data,int len) ssize_t netfront_receive(struct netfront_dev *dev, unsigned char *data, si= ze_t len) { unsigned long flags; - int fd =3D dev->fd; + struct file *file =3D get_file_from_fd(dev->fd); + ASSERT(current =3D=3D main_thread); =20 dev->rlen =3D 0; @@ -781,9 +829,9 @@ ssize_t netfront_receive(struct netfront_dev *dev, unsi= gned char *data, size_t l =20 local_irq_save(flags); network_rx(dev); - if (!dev->rlen && fd !=3D -1) + if ( !dev->rlen && file ) /* No data for us, make select stop returning */ - files[fd].read =3D false; + file->read =3D false; /* Before re-enabling the interrupts, in case a packet just arrived in= the * meanwhile. */ local_irq_restore(flags); --=20 2.26.2