From nobody Sun May 5 03:54:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1640276616; cv=none; d=zohomail.com; s=zohoarc; b=jE87Yo39PqRyl+uiWfcpr54X3yDdJ1pHSxTfKtNV84M5lU+auElPOLf5Y40lA5gmZTCPHPlEhPNjDPsZTPcHcSOWjZlgrNEzwWhInpI9GaKPYq/jmp8mQSTdA7dFzdQIMWbq5ftOBjL7dOScUT44PEtycthzgVNkzMde1TSRwgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640276616; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Ou1IfBuESkkhjeWzkLgi/UfZVBqEChLDkLw90k0MiD8=; b=h9SXT/YC7UVnxYeOq5sKTLCrWCuaqFYjN9VyMkM7JxMKE/N9bahDkzbz2KqyGR1Lj9bq9VFuDFYD6/wRJ2RWL/A3fnr48F9RwJgX8OVE+xbLGupYmVd+g8uwFC46zVgSdWCVliGLmhWSbeajhqXXmJtmGo2WGzxGy9WB7v+0H6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1640276616142430.88613223279856; Thu, 23 Dec 2021 08:23:36 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.251127.432371 (Exim 4.92) (envelope-from ) id 1n0Qs1-00005i-2r; Thu, 23 Dec 2021 16:23:09 +0000 Received: by outflank-mailman (output) from mailman id 251127.432371; Thu, 23 Dec 2021 16:23:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n0Qs0-00005a-W2; Thu, 23 Dec 2021 16:23:08 +0000 Received: by outflank-mailman (input) for mailman id 251127; Thu, 23 Dec 2021 16:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n0Qrz-00005U-Ry for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 16:23:07 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ad197f2-640c-11ec-bb0b-79c175774b5d; Thu, 23 Dec 2021 17:23:05 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ad197f2-640c-11ec-bb0b-79c175774b5d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1640276585; h=from:to:cc:subject:date:message-id:mime-version; bh=7hzbK3gy7YX7ljX+ayb8kqwNfu76Q1Tcy0UrKhN4VcY=; b=cSpmZPo7eRv0VjteKXMCxbrlmhkFQpm8I82l8aN1b6LnSqIvjVHHXRYq HSpSkf67C8X/TDq7OMRTj/NpHc3ZcO1A1uMbfHBbSo4XRfXEFyBoS6fRh H5LwWpRWEnAyRK+S84sauxOxdvxoa+wuv2CdTFFgCOsA2b2J5KaTn+nmQ g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QEEgBh/VahF6FDSr1YkqcGf6/2CmgYw1Dt+Gx5KQPLtpZ94teh7fSWXMeFNP5nNRnfW/NAdvoD eD9WiANW5StGd2wYMOl3uGAAs/sYhNE/3MLo+Su5RlmWrCWXI/ecsTEUmktvFIIFRoEttsiPEX Xi2yo07lHu7FAPyAoNCSUDZST5GpRxQVAc+jGsq4QQPnOhU0vmkCqc3v4GdQPT6BzDUxS77I1S rvrZcbH9ahZABHGJsNbXdlCmXGyXYICS75GhNpwUpY+Hx1WP2gGacyrtXX18ZuUr6GUameEIQA ThEnOO7iklhfFwTsZIdXW2mM X-SBRS: 5.1 X-MesageID: 60692699 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qCbN0qtv9BkSt/KN9lJ1BI5u9+fnVH1ZMUV32f8akzHdYApBsoF/q tZmKWqEOKqKNjSkKo8nbIjg9x5UvMCEyYc3TVM4r380RCwV+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24PhWGthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl5bDqcVgYNaz3teUGWStlIxhjGrIZweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP 5RIM2Q+PXwsZTV1HV0YKZ4Ou97xg0nnSjoB93aUiZQetj27IAtZj+G2bYu9lsaxbcdahEGDv Urd4n/0RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPWZXutHg1BT4AYgGb RVJpGx+9sDe6XBHUPGtc0eA/0+PvyUxWsFaIdAK0Ryq1fXttlPx6nc/chZNb9kvtckTTDMs1 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL+dlr1nryosBf/LlZZzEfMRX52 Hi0oSc3nN3/ZuZbhvzgrTgrb99Bz6UlrzLZBC2LDwpJDSsjPeZJgrBEDnCBsp59wH6xFAXpg ZT9s5H2ABoyJZ+MjjeRZ+4GAauk4f2IWBWF3wI3Rshxpmr8oCP5FWy13N2ZDB02WvvohBezO BOD0e+vzMI70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGAfUM71isvrb+F69H hQ2H5Li9iizmdbWOkH/mbP/53hTRZTiLZyp+cFRaMCZJQ9qRDMoB/PLmOtzcI15haVF0OzP+ yjlCENfzVP+g1zBKBmLNS8/OO++A84noCJpJzEoMHapx2MnPdSl4pAAesZlZrIg7uFik6J5F qFXZ8WaD/1TYT3b4DBBP4LlpYlveU3z1wKDNiaoehYleJtkS1Cb89PoZFK3piIPEjC2pY01p Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8rBhnGONhefkno4bNGES2pg69lOdwIJDXC2iCei 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzIIcAuaFeTfRCDH99Km4P LgHyvj9NLsMnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLjZtVq6lA5r5Fog/nC EuA9+5TNaiNJM64QkUaIxAob7jb2PwZ8tUIAS/Z/KkuCPdLwYe6 IronPort-HdrOrdr: A9a23:lRR/CqqaTWoJJmA8llnJ04UaV5o9eYIsimQD101hICG8cqSj+f xG/c5rsiMc5wxwZJhNo7y90cq7MBfhHPxOkOos1N6ZNWGM0gaVxelZnO7fKlbbehEWmNQz6U 4ZSdkdNOHN X-IronPort-AV: E=Sophos;i="5.88,230,1635220800"; d="scan'208";a="60692699" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Juergen Gross Subject: [PATCH] tools/libxc: Drop copy-in in xc_physinfo() Date: Thu, 23 Dec 2021 16:22:44 +0000 Message-ID: <20211223162244.16198-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1640276617609100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The first thing XEN_SYSCTL_physinfo does is zero op->u.physinfo. Do not copy-in. It's pointless, and most callers don't initialise their xc_physinfo_t buffer to begin with. Remove the pointless zeroing from the remaining callers. Spotted by Coverity. Signed-off-by: Andrew Cooper Reviewed-by: Wei Chen --- CC: Anthony PERARD CC: Juergen Gross --- tools/libs/ctrl/xc_misc.c | 2 -- tools/libs/light/libxl.c | 2 +- tools/libs/stat/xenstat.c | 2 +- tools/misc/xenpm.c | 2 +- tools/xenmon/xenbaked.c | 2 +- tools/xentrace/xentrace.c | 2 +- 6 files changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 3820394413a9..265f15ec2da3 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -195,8 +195,6 @@ int xc_physinfo(xc_interface *xch, =20 sysctl.cmd =3D XEN_SYSCTL_physinfo; =20 - memcpy(&sysctl.u.physinfo, put_info, sizeof(*put_info)); - if ( (ret =3D do_sysctl(xch, &sysctl)) !=3D 0 ) return ret; =20 diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index a77aa856fdd6..667ae6409be7 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -351,7 +351,7 @@ const char *libxl_defbool_to_string(libxl_defbool b) /*************************************************************************= *****/ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) { - xc_physinfo_t xcphysinfo =3D { 0 }; + xc_physinfo_t xcphysinfo; int rc; long l; GC_INIT(ctx); diff --git a/tools/libs/stat/xenstat.c b/tools/libs/stat/xenstat.c index e49689aa2da9..8bab2e66a7fe 100644 --- a/tools/libs/stat/xenstat.c +++ b/tools/libs/stat/xenstat.c @@ -135,7 +135,7 @@ xenstat_node *xenstat_get_node(xenstat_handle * handle,= unsigned int flags) { #define DOMAIN_CHUNK_SIZE 256 xenstat_node *node; - xc_physinfo_t physinfo =3D { 0 }; + xc_physinfo_t physinfo; xc_domaininfo_t domaininfo[DOMAIN_CHUNK_SIZE]; int new_domains; unsigned int i; diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index d0191d498484..4f8cde690a7c 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -1244,7 +1244,7 @@ struct { int main(int argc, char *argv[]) { int i, ret =3D 0; - xc_physinfo_t physinfo =3D { 0 }; + xc_physinfo_t physinfo; int nr_matches =3D 0; int matches_main_options[ARRAY_SIZE(main_options)]; =20 diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c index 1ed34334c824..7591de7c609f 100644 --- a/tools/xenmon/xenbaked.c +++ b/tools/xenmon/xenbaked.c @@ -436,7 +436,7 @@ static struct t_struct *map_tbufs(unsigned long tbufs_m= fn, unsigned int num, */ static unsigned int get_num_cpus(void) { - xc_physinfo_t physinfo =3D { 0 }; + xc_physinfo_t physinfo; xc_interface *xc_handle =3D xc_interface_open(0,0,0); int ret; =20 diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index a8903ebf4625..864e30d50cc3 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -589,7 +589,7 @@ static void set_evt_mask(uint32_t mask) */ static unsigned int get_num_cpus(void) { - xc_physinfo_t physinfo =3D { 0 }; + xc_physinfo_t physinfo; int ret; =20 ret =3D xc_physinfo(xc_handle, &physinfo); --=20 2.11.0