From nobody Sat May 4 03:42:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1639646486; cv=none; d=zohomail.com; s=zohoarc; b=i6EDyWHgNb2M6d+/Loksdt/Jf7m9r1i1XFlD65QSf+aMN6Kt2lJ5cygzmQwCfy81xHc2XBJUMjOL2Kan271Ui/Ck28pZUdhwYQR9v4ThEhWMEgZuJdBNr8NQLMMpMwTrOCUE/jtK8hIhfWb90liHV1r8x/bYzv+RK4xxjMnj+Io= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639646486; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Iuth5XsbDrWkm5iT/WaAfM9cu6MAAjKuz8s34xSL6SA=; b=DAjmckMETvjRlskHHK/SLFE1BdJKQD2I6zx8rIvGiRDuoRTlJ0pKAUOek597zdMkNXl1wZhisjOpLw86oSv6U/mIsHSG+/d3YEil1tl6U7OXN8Qy7+xXDlKICdVNwDv4LtQCs2UqFBmQsFjtaiwxULRi9oFZBl+6idg7Td/o3Jk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1639646486343764.640714009349; Thu, 16 Dec 2021 01:21:26 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.247775.427260 (Exim 4.92) (envelope-from ) id 1mxmwO-0008Bo-L9; Thu, 16 Dec 2021 09:20:44 +0000 Received: by outflank-mailman (output) from mailman id 247775.427260; Thu, 16 Dec 2021 09:20:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxmwO-0008Bh-Hq; Thu, 16 Dec 2021 09:20:44 +0000 Received: by outflank-mailman (input) for mailman id 247775; Thu, 16 Dec 2021 09:20:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxmwN-0008Bb-Vr for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:20:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f878b22-5e51-11ec-9e60-abaf8a552007; Thu, 16 Dec 2021 10:20:41 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f878b22-5e51-11ec-9e60-abaf8a552007 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1639646441; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Eenr6lVD8mBTFntcyKC5oakyauxRxLv4WtMuAgZ9/Ls=; b=ZYvLpJxIgdceuXz/l95s5nUrb/iAvcr/bvyJ+hdEWhWXhN/nePvf45hZ 6q8G+m53llCRYi6N3SsKMzs7ILEG9/P92MWyLS8Vjr5bxuU7Ji+EFKYJO fRlvGIy5BxVRU/xrIsPRthgb1JMycURSxi4Y4a09Wy9CBLlNjGx2Lrc13 c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EPJrtohJ8BvwO4jZmg+19QEbZHVQU9XnQqndS0RlQysaEVXV731Fz/mjNvyVMokAk0I8K0E5SG mXGLuq3ZLV8/90mRrZW4YYvzZlUVA5TJoVp2iNUuhmr83mAgID8gnOHBpysbCbpFruYPKWrDZP lGZLi374vmxQSrgfc8V8Dd9AXG4KXdeOH3XT2AmTFoeOXtnqnPPIyj2vSmQ8t9WoHSnKtRsQV5 0QczDLZ6p4V/0GqW3rRDX1l4nojIBqSasPFhZgiFo8OCV9zN+f14di7zTYw8wJilWBbPzx80Fc wR1j/jQ/l7j1aKpQSBNHBngf X-SBRS: 5.1 X-MesageID: 60104168 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HvPiOKOyF+Puxr7vrR0GkMFynXyQoLVcMsEvi/4bfWQNrUoi1mMEy GYbX2vQbvbYZ2Cmc95xad6y8k4Hv5TUnNIySgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s9w7RRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2SXvtRSx cxSjKPqdgl1D4TFp9wjSzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgm9p3pwXQ6a2i 8wxaTlNVwyYPxZ1CE5QM7Zuuva4j37fSmgNwL6SjfVuuDWCpOBr65DvLd7Ud9qiVchT2EGCq QruwWP9BR0LMc2F/hCM+Hmsm+znkDvyXcQZE7jQ3vRnmkGJz2ofThgfT0KmoOKRg1S7HdlYL iQ85S4GvaU0skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQEnsIrQT0h1 neSgsjkQzdotdW9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHeTJob10yVCIw5Sejs04OzSWqYL y22QDYW1qsyie0GzrqCwgr4jW6dj5H2djAtz1CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQc3R8FJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5yYCkfiI+TfNDKm8gj9yjn5ZLlXvEMZGPxH44owVuBJw+ZzTw L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2IFM2qlEv3jODGPxZ5rIvp1nPUNIjVC4ve/23oH yt3bZPWm32zrsWgCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF7rrE+lqAtE KFeEyhCa9wWIgn6F/0mRcGVhORfmN6D3Gpi5gKpP2oyeYBOXQvM9oO2dwfj7nBWXCG2qdE/s /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aYcMNOfEjM8ZRxL3CjhPEAPMxRew7IwSGX1 ljKDE5A9/XNuYI87PLAmbuA89WyC+J7E0cDRzvb4L+6ODP05G2mxYMcAu+EcSqEDDH/+bm4Z PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpRSyZYU6qB7VsJmi98fNO7qAdlKVEvQaWW 16U/oUIM7u+J864QkUaIxAob7rf2KhMyCXS9/k8PG7z+DRzoOicSUxXMhSB1H5dIb9yPN93y OstopdLuQm2ix5sOdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cHdcchIP2krP iSQ1fjLiLlrz0bfd2Y+SCrW1u1HiJVS4B1HwTfu/bhSdgYpUhPv4CBszA== IronPort-HdrOrdr: A9a23:9+iBW64RUYRvDIzaOQPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; d="scan'208";a="60104168" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , "Bertrand Marquis" Subject: [PATCH] xen/build: Fix `make cscope` rune Date: Thu, 16 Dec 2021 09:20:14 +0000 Message-ID: <20211216092014.707-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1639646487217100001 There are two problems, both in the all_sources definition. First, everything in arch/*/include gets double hits with cscope queries, because they end up getting listed twice in cscope.files. Drop the first `find` rune of the three, because it's redundant with the th= ird rune following c/s 725381a5eab3 ("xen: move include/asm-* to arch/*/include/asm"). Second, and this way for a long time: $ make cscope ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -pri= nt; find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) > cscope.files cscope -k -b -q cscope: cannot find file arch/x86/efi/efi.h cscope: cannot find file arch/x86/efi/ebmalloc.c cscope: cannot find file arch/x86/efi/compat.c cscope: cannot find file arch/x86/efi/pe.c cscope: cannot find file arch/x86/efi/boot.c cscope: cannot find file arch/x86/efi/runtime.c This is caused by these being symlinks to common/efi. Restrict all find ru= nes to `-type f` to skip symlinks, because common/efi/*.c are already listed. Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Reviewed-by: Volodymyr Babchuk --- CC: Anthony PERARD CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis Anthony: I looked through the remainder of your build series and I cant spot any edits to all_sources. Apologies if I missed it. --- xen/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 2ad7da7ad67b..dc6bdc44c7a2 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -468,9 +468,8 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offs= ets.s =20 SUBDIRS =3D xsm arch/$(TARGET_ARCH) common drivers lib test define all_sources - ( find arch/$(TARGET_ARCH)/include -name '*.h' -print; \ - find include -name '*.h' -print; \ - find $(SUBDIRS) -name '*.[chS]' -print ) + ( find include -type f -name '*.h' -print; \ + find $(SUBDIRS) -type f -name '*.[chS]' -print ) endef =20 define set_exuberant_flags --=20 2.11.0