From nobody Mon May 6 20:42:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1635493817; cv=none; d=zohomail.com; s=zohoarc; b=LYvwS8eydHfo+ZRiASKYHmgqCsIQYxuzZYZqUyNYSbpCk7lX9kJYsfrRBkh8s8jz83X4r1M5XzAV0toDqydP2bbAlUZNsAATgR1C5NDTxUq1qODzoDFjpFj1qQV9kL0H4qqGyhR53n6fvFr0ET4K+lYpr237qz4Xos9gBjyQDAE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635493817; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cEHSevouYw8lnbcB9mvJJwAH561ddSGhR9uQkll/Ybg=; b=Ek1gh0yRprS+v4CgtCFO+dyMkkMuMZL1OIxkZlkqYXwDizTQNcqUkqPcr+bbttL9D0jmHFRZMwZ/pvpvsagzdAKfz+IVTfbFFY5TYTNkFAFYsQvM8F1g0FCzMzpS5RLhNBJPXXv4j/xnP7hP7AY3He5yXu9NQMMw5Q7rq/EQD6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1635493817090172.34007028856365; Fri, 29 Oct 2021 00:50:17 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.218417.378838 (Exim 4.92) (envelope-from ) id 1mgMe1-0002IL-Dz; Fri, 29 Oct 2021 07:49:45 +0000 Received: by outflank-mailman (output) from mailman id 218417.378838; Fri, 29 Oct 2021 07:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mgMe1-0002IE-Av; Fri, 29 Oct 2021 07:49:45 +0000 Received: by outflank-mailman (input) for mailman id 218417; Fri, 29 Oct 2021 07:49:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mgMdz-0002I8-U5 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 07:49:43 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4c048f91-eead-4040-80f2-0b5ef99f4a1f; Fri, 29 Oct 2021 07:49:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13B7921971; Fri, 29 Oct 2021 07:49:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C937C13B27; Fri, 29 Oct 2021 07:49:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HHUYL5Wne2GPfwAAMHmgww (envelope-from ); Fri, 29 Oct 2021 07:49:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c048f91-eead-4040-80f2-0b5ef99f4a1f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1635493782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cEHSevouYw8lnbcB9mvJJwAH561ddSGhR9uQkll/Ybg=; b=ZmMFSg7HmY3N5x7iTSAMm4Y3XP4uycpYHsJ/QcagIeHfvd81YwIObys7En+h15ENPVGFm3 oWCRhBglR/uMGpRzFe2Q/ZGTb/lHyzzufZBszoMQL5le4q4uYWgxPtsthnpAvypCTgPqgJ elxeVELo3y5KwimhI58Sg0m/AxIZTaM= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH v2] xen/balloon: add late_initcall_sync() for initial ballooning done Date: Fri, 29 Oct 2021 09:49:31 +0200 Message-Id: <20211029074931.20657-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1635493818045100001 When running as PVH or HVM guest with actual memory < max memory the hypervisor is using "populate on demand" in order to allow the guest to balloon down from its maximum memory size. For this to work correctly the guest must not touch more memory pages than its target memory size as otherwise the PoD cache will be exhausted and the guest is crashed as a result of that. In extreme cases ballooning down might not be finished today before the init process is started, which can consume lots of memory. In order to avoid random boot crashes in such cases, add a late init call to wait for ballooning down having finished for PVH/HVM guests. Warn on console if ballooning stalls for more than 1 minute, panic() after stalling for more than 3 minutes. Cc: Reported-by: Marek Marczykowski-G=C3=B3recki Signed-off-by: Juergen Gross --- V2: - add warning and panic() when stalling (Marek Marczykowski-G=C3=B3recki) - don't wait if credit > 0 --- drivers/xen/balloon.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 3a50f097ed3e..c0c1c754e515 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -765,3 +765,38 @@ static int __init balloon_init(void) return 0; } subsys_initcall(balloon_init); + +static int __init balloon_wait_finish(void) +{ + long credit, last_credit =3D 0; + unsigned long last_changed; + + if (!xen_domain()) + return -ENODEV; + + /* PV guests don't need to wait. */ + if (xen_pv_domain() || !current_credit()) + return 0; + + pr_info("Waiting for initial ballooning down having finished.\n"); + + while ((credit =3D current_credit()) < 0) { + if (credit !=3D last_credit) { + last_changed =3D jiffies; + last_credit =3D credit; + } + if (jiffies - last_changed >=3D HZ * 60) { + pr_warn_once("Initial ballooning stalling for 60s, %ld pages need to be= freed.\n", + -credit); + } + if (jiffies - last_changed >=3D 3 * HZ * 60) + panic("Initial ballooning failed!\n"); + + schedule_timeout_interruptible(HZ / 10); + } + + pr_info("Initial ballooning down finished.\n"); + + return 0; +} +late_initcall_sync(balloon_wait_finish); --=20 2.26.2