From nobody Mon May 6 09:46:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1635256634; cv=none; d=zohomail.com; s=zohoarc; b=W48UqSbma2r1xXnrfiRJyMqG2xIm37m/CKq66/LmZDdSEzGLFOS0ICCGCsaBWMcxl01epOukkkZbkG/PpRwfbCi9yhrdksHlR4DXn70fj2tKXIJs7aKFnkZR1/uGvnes5w5QiR/36ThCCM2nRZOP+IwJnNGxOqBhsTTASBB0wt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635256634; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=H03k2PldCmMg5lMqnhyq49VN6e7pFnyJAuAX5qZZoXg=; b=mr+NyoMpP1cyvZVHNGn2K3DT1oLHj8OnAt699lsRMWAjfZcfoL0kjmPzmWYy2etu73pWT6V0TOQ3V1B+4wWwP6+GUSBmyAvS8HQNjKXu6eNtaSOUIQ0Ji1f6NZQXIVVd/vVgqIVOZyxRDN2JK4PypDsCFeypSIaCrH+IrCohGGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1635256634936657.0072056362468; Tue, 26 Oct 2021 06:57:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.216453.376067 (Exim 4.92) (envelope-from ) id 1mfMwf-0002fc-S2; Tue, 26 Oct 2021 13:56:53 +0000 Received: by outflank-mailman (output) from mailman id 216453.376067; Tue, 26 Oct 2021 13:56:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mfMwf-0002fV-P0; Tue, 26 Oct 2021 13:56:53 +0000 Received: by outflank-mailman (input) for mailman id 216453; Tue, 26 Oct 2021 13:56:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mfMwf-0002fP-3p for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 13:56:53 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 91e8f656-3664-11ec-842f-12813bfff9fa; Tue, 26 Oct 2021 13:56:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 14CD31FCA3; Tue, 26 Oct 2021 13:56:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E78B913B06; Tue, 26 Oct 2021 13:56:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t86+NiIJeGFEBgAAMHmgww (envelope-from ); Tue, 26 Oct 2021 13:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91e8f656-3664-11ec-842f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1635256611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=H03k2PldCmMg5lMqnhyq49VN6e7pFnyJAuAX5qZZoXg=; b=nHhvKuAASQcpxTJy/kZkGvd04FyiLxxPQnQbLZXm5++PoXLystNQ/OYbWhDtnxAVF4UvWo WejCB+3ZPrPBy948pycfbRXcPgWh4cHdiilUbQ6lCnO3qGuTBN6X0YCL5/wofV3YSJxz2T 5Ar5Ujn6fmO4OhvNB718yH7XpfVMQc4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Juergen Gross Subject: [PATCH] osstest: explicitly set either enable or disable qemu-traditional Date: Tue, 26 Oct 2021 15:56:45 +0200 Message-Id: <20211026135645.31488-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1635256636395100001 Content-Type: text/plain; charset="utf-8" Instead of setting "--enable-qemu-traditional" or not, switch to setting "--enable-qemu-traditional" or "--disable-qemu-traditional". This avoids a latent bug in the disable case, as the availability of the option is tested via grep, which will otherwise grep for nothing. Reported-by: Ian Jackson Signed-off-by: Juergen Gross Reviewed-by: Ian Jackson --- ts-xen-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-xen-build b/ts-xen-build index fdf55521..ccb2aba2 100755 --- a/ts-xen-build +++ b/ts-xen-build @@ -144,7 +144,7 @@ END sub build () { my $xend_opt=3D $r{enable_xend} =3D~ m/true/ ? "--enable-xend" : "--di= sable-xend"; my $ovmf_opt=3D $r{enable_ovmf} =3D~ m/true/ ? "--enable-ovmf" : "--di= sable-ovmf"; - my $qemutrad_opt =3D $r{arch} =3D~ m/amd64|i386/ ? "--enable-qemu-trad= itional" : ""; + my $qemutrad_opt =3D $r{arch} =3D~ m/amd64|i386/ ? "--enable-qemu-trad= itional" : "--disable-qemu-traditional"; =20 my $configure_prefix =3D $r{cmdprefix_configure} // ''; my $configure_suffix =3D $r{cmdsuffix_configure} // ''; --=20 2.26.2