From nobody Fri May 3 09:56:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1634642536; cv=none; d=zohomail.com; s=zohoarc; b=Cut3XzbIO32/pchJ2RhxJyUIpDYAPjA75MZCJEW2m7Vn4zBPVulImu72BMd5ZI7nAp6AXNO+aSsHvgsCPNRQimS6AASnSUuxunpIqa4WWNNQO5UQ00GkBhVIwHLfmdHJhiuL2CiI/3N1Z/OiYr8IcBPrT6nPFtwmetZLV4Y8dGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634642536; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Bsjm34oU7y3pSkCQQqWxgmwlC+hZeXr6taiQjgu1WUA=; b=jZLJcmX/pQXT8p+gkbAAsLpXpuYFMCys28Ri1o89h34SlJKyuoBGS1DTk13BlYOP7FYu45Ub1t+VK+cmsg8mHuUarlLAH9MAnFn1U9wGnY29DX/eDWPpzosyxVRAUB/gLsWK1z+n558gMfnR9DAwtHnm9R1Z/8cHEizZ8+XKV30= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1634642536814172.5758392901049; Tue, 19 Oct 2021 04:22:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.213028.371117 (Exim 4.92) (envelope-from ) id 1mcnBh-0000dU-86; Tue, 19 Oct 2021 11:21:45 +0000 Received: by outflank-mailman (output) from mailman id 213028.371117; Tue, 19 Oct 2021 11:21:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mcnBh-0000dN-4q; Tue, 19 Oct 2021 11:21:45 +0000 Received: by outflank-mailman (input) for mailman id 213028; Tue, 19 Oct 2021 11:21:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mcnBg-0000dH-HC for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:21:44 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ec1c0218-679b-49d5-b6c0-69dc2d4f7723; Tue, 19 Oct 2021 11:21:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9251621A5D; Tue, 19 Oct 2021 11:21:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6F0AD13B64; Tue, 19 Oct 2021 11:21:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id obzHGUaqbmHvbAAAMHmgww (envelope-from ); Tue, 19 Oct 2021 11:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec1c0218-679b-49d5-b6c0-69dc2d4f7723 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634642502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Bsjm34oU7y3pSkCQQqWxgmwlC+hZeXr6taiQjgu1WUA=; b=J8GtlNiEgia7Z5PVFRhYonYLv4mz4AuqppfaXY5AX71VWg5A77IlAQGqvTzQaRF9S7EOFZ AR+zGxCSp/rKKPTktAUujF4HZoRtpaB7cAVMR+1LzludHraZp7XWQdByiukHu6jkRRVy5/ 5ki32Y+OGNIBdeq1IfnXFk6n7LGFsNM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH v2] tools: fix oom setting of xenstored Date: Tue, 19 Oct 2021 13:21:40 +0200 Message-Id: <20211019112140.26988-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1634642537659100003 Content-Type: text/plain; charset="utf-8" Commit f282182af32939 ("tools/xenstore: set oom score for xenstore daemon on Linux") introduced a regression when not setting the oom value in the xencommons file. Fix that. Fixes: f282182af32939 ("tools/xenstore: set oom score for xenstore daemon o= n Linux") Signed-off-by: Juergen Gross Reviewed-by: Ian Jackson --- V2: use ${var:-} (Jan Beulich) --- tools/hotplug/Linux/launch-xenstore.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/l= aunch-xenstore.in index 8438af9977..e854ca1eb8 100644 --- a/tools/hotplug/Linux/launch-xenstore.in +++ b/tools/hotplug/Linux/launch-xenstore.in @@ -60,8 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @C= ONFIG_DIR@/@CONFIG_LEAF echo "No xenstored found" exit 1 } - [ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=3D50 - XS_OOM_SCORE=3D-$(($XENSTORED_OOM_MEM_THRESHOLD * 10)) + XS_OOM_SCORE=3D-$((${XENSTORED_OOM_MEM_THRESHOLD:-50} * 10)) =20 [ "$XENSTORED_MAX_OPEN_FDS" =3D "unlimited" ] || { [ -z "${XENSTORED_MAX_OPEN_FDS//[0-9]}" ] && --=20 2.26.2