From nobody Sun Apr 28 18:35:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=canonical.com ARC-Seal: i=1; a=rsa-sha256; t=1634143932; cv=none; d=zohomail.com; s=zohoarc; b=bqHQZGC/+rbvGF46eX5M7Ms4xVH47fGm10ox2JMahikUpRite1pMwL59sQ8JFZJK4u5EbeT6BYyWmHxTamxPWJMaIvy3X+ksKIFb5SjlUpclRSI5X4bIf4mhy8umAGxB+5jtpzv6qfWyxnGvlApNrZqCBlWlOMBk92OXe0SBzt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634143932; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nspxtz40p65DZu4TYJBabtEkFf22gqNZfGTLya7Yrd8=; b=LlPUE6G4Fss7zZRsf+NySXt/+AeMLt/KcUoEU4oKidWQNw5IYarBLtHO8f8VmDEtGthewhZYIIUPTSqT8BLxCdge/qGL1IXW+5H3BB25xxFmptNkpFgbPj5X2VAwle/eTglFioqmYOcO5tBtxoDgL+OX8ZWvx/fUDVIyJtu0hgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 163414393297288.32699503420315; Wed, 13 Oct 2021 09:52:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.208757.364997 (Exim 4.92) (envelope-from ) id 1mahTr-0002xH-85; Wed, 13 Oct 2021 16:51:51 +0000 Received: by outflank-mailman (output) from mailman id 208757.364997; Wed, 13 Oct 2021 16:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mahTr-0002xA-4k; Wed, 13 Oct 2021 16:51:51 +0000 Received: by outflank-mailman (input) for mailman id 208757; Wed, 13 Oct 2021 16:51:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mahTp-0002x4-KZ for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:51:49 +0000 Received: from smtp-relay-canonical-0.canonical.com (unknown [185.125.188.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a4c81883-5fa5-43b7-8664-926cbe58f904; Wed, 13 Oct 2021 16:51:48 +0000 (UTC) Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id F11133FFDC; Wed, 13 Oct 2021 16:51:42 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4c81883-5fa5-43b7-8664-926cbe58f904 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634143903; bh=nspxtz40p65DZu4TYJBabtEkFf22gqNZfGTLya7Yrd8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=jHQ+xQpZT3ySNZvfc7Mv2IO5uEBq9duWF1MlPWpGZvYeJHiVcz9A7rRAAkuRwsAWD L0aC8QkbNLM/Ovd66WAmrejidVQGrzhN/CM3WyfiuZ67P2/G4AsejdKw/iNfhdcvLf r8uEJeG5anV0ARNJ+4MVgIKMi6VYnOWCUlnwC6OShxeUQqiw8abRiFgcNeSpyHUHCF a0MLlhJasei7LHS5hQPlNdEOtLCQ/Fpytil4ruNAnNd2LOKPm8bLRwLRwztOhSb6zl 7fo6dG70HRDukksIb7Qk8FDlv02QO//kgN80AcJNgMvrord248FTEehqNUeiLyynrG vcou6qPyVlE6A== From: Colin King To: Wei Liu , Paul Durrant , "David S . Miller" , Jakub Kicinski , xen-devel@lists.xenproject.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen-netback: Remove redundant initialization of variable err Date: Wed, 13 Oct 2021 17:51:42 +0100 Message-Id: <20211013165142.135795-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @canonical.com) X-ZM-MESSAGEID: 1634143934264100001 From: Colin Ian King The variable err is being initialized with a value that is never read, it is being updated immediately afterwards. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/ne= tback.c index 32d5bc4919d8..0f7fd159f0f2 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1474,7 +1474,7 @@ int xenvif_map_frontend_data_rings(struct xenvif_queu= e *queue, struct xen_netif_tx_sring *txs; struct xen_netif_rx_sring *rxs; RING_IDX rsp_prod, req_prod; - int err =3D -ENOMEM; + int err; =20 err =3D xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif), &tx_ring_ref, 1, &addr); --=20 2.32.0