From nobody Fri Mar 29 15:39:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=huawei.com Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1633679156753721.2494747836854; Fri, 8 Oct 2021 00:45:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.204464.359610 (Exim 4.92) (envelope-from ) id 1mYkZU-00016Q-53; Fri, 08 Oct 2021 07:45:36 +0000 Received: by outflank-mailman (output) from mailman id 204464.359610; Fri, 08 Oct 2021 07:45:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYkZU-00016J-1i; Fri, 08 Oct 2021 07:45:36 +0000 Received: by outflank-mailman (input) for mailman id 204464; Fri, 08 Oct 2021 07:45:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYkZS-00015s-5Q for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 07:45:34 +0000 Received: from szxga02-in.huawei.com (unknown [45.249.212.188]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b66476de-280b-11ec-8024-12813bfff9fa; Fri, 08 Oct 2021 07:45:32 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HQg8n2vzdz909M; Fri, 8 Oct 2021 15:40:41 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Fri, 8 Oct 2021 15:45:23 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Fri, 8 Oct 2021 15:45:23 +0800 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b66476de-280b-11ec-8024-12813bfff9fa From: YueHaibing To: , , CC: , , YueHaibing Subject: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init() Date: Fri, 8 Oct 2021 15:44:17 +0800 Message-ID: <20211008074417.8260-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected X-ZM-MESSAGEID: 1633679158899100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return NULL instead of passing to ERR_PTR while err is zero, this fix smatch warnings: drivers/xen/xen-pciback/conf_space_capability.c:163 pm_ctrl_init() warn: passing zero to 'ERR_PTR' Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup so= me code.") Signed-off-by: YueHaibing Reviewed-by: Juergen Gross --- drivers/xen/xen-pciback/conf_space_capability.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/= xen-pciback/conf_space_capability.c index 22f13abbe913..5e53b4817f16 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -160,7 +160,7 @@ static void *pm_ctrl_init(struct pci_dev *dev, int offs= et) } =20 out: - return ERR_PTR(err); + return err ? ERR_PTR(err) : NULL; } =20 static const struct config_field caplist_pm[] =3D { --=20 2.17.1