From nobody Fri Nov 29 18:50:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1632269177; cv=none; d=zohomail.com; s=zohoarc; b=M2WRt1JFMl002L/qSERLYM2DWle7xKUyFDtP0EHeTYrDWecViVNEjT90eKk4POnbCIHdjV0NZzQHSSkQ+q4hEXeQAT2utycjWDZ2A87GEJn2Zy/tVNy8OA5H/CDbZCJXV9Lb2U9rRU8WfrOFBRdFcFxzcWLOfj9t6jon0webkxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632269177; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=6hT+pcsgsamW9lRK8DKVDgsjod6WnUckxdik+rJgRjs=; b=O0wyEySI9y2fJQyYjqMxNfSgoWQ2lQIaXQCQ5hPBerw94aLHOJ0m/Yhua1IsdoOD+swULYhXQKEf3ecIV5XAEjG+re5YDs8gQeBVh3iJd6oW8f2KpF2zTJ3PMB6xFPMBXvUWZRiZg9sQcCSSiPdtQ4EhTHjgIUr+akBTeEeOWNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1632269177855318.41706967994105; Tue, 21 Sep 2021 17:06:17 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.191987.342217 (Exim 4.92) (envelope-from ) id 1mSpm1-0002Ff-W0; Wed, 22 Sep 2021 00:06:05 +0000 Received: by outflank-mailman (output) from mailman id 191987.342217; Wed, 22 Sep 2021 00:06:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSpm1-0002FU-RN; Wed, 22 Sep 2021 00:06:05 +0000 Received: by outflank-mailman (input) for mailman id 191987; Wed, 22 Sep 2021 00:06:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSpm0-0000pt-Ph for xen-devel@lists.xenproject.org; Wed, 22 Sep 2021 00:06:04 +0000 Received: from mail-qv1-xf4a.google.com (unknown [2607:f8b0:4864:20::f4a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de9e703c-caa3-44d4-9029-60a5873a67ca; Wed, 22 Sep 2021 00:05:52 +0000 (UTC) Received: by mail-qv1-xf4a.google.com with SMTP id b17-20020a056214135100b0037eaf39cb1fso7685292qvw.11 for ; Tue, 21 Sep 2021 17:05:52 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de9e703c-caa3-44d4-9029-60a5873a67ca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=6hT+pcsgsamW9lRK8DKVDgsjod6WnUckxdik+rJgRjs=; b=Bj8VBEV1iZnqxOhTLHlm7aJLEpzWR4VK7K7aD+jVIOItnRKO4fixETcLObR8Fp3wpi qen4ySzqMv29aPJAGQYTFE7wmMMI1j5Rtph6tALMy5t0Vpqs3rbEz84bRIN0kMxKLv8c UqqsOh2SdMvnju4og/DFPHA2mwLIV2Kbl8jNiHyAx8ZaTn+CIt8xR9Nfe8u7VO9K9/eN +2x8JLd22AxcRq3kDSstvt/WqN7tY/+xYd3wvpQsDoKFQCmzoF+iYRzBtZMgOAMbDudK wnTLWwmn+3bAAzltBQAbNmJfxESz4LUX9Bp79xTAk2sjGVMJKof74Y995u9shdQ30fbC IW7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=6hT+pcsgsamW9lRK8DKVDgsjod6WnUckxdik+rJgRjs=; b=Yo6WmVZ4/NNSZzK/7rSKIADmJazIeY/K6kOrYpRc4Eez3kGBRMpevGTnuDjgCraXbL cw/1R/q7Iii7p63bs6sULS7czLLBsx41itmO03QrVVRV3y685m6c4G/UvkNbhL7MOjS5 YAsZCAT7ewxI7UxzHXUyuEHiVGd+vYqbNzq/QR4dRMka6S41frigneKxQAYlq8h6r0Cj MBIcv7fGyFOjWNQy2nZTMzyR7RoP0BQ0rAiRoP4gVghpVrmNvuYjGr0GUg52kHMqQD8A GAerlrHrp1RGab7La1SHPrDu0mbkbMWGHcA9X6ikDM/1gfcNHIq+9wsG7QTxVVMCmb0G aHAA== X-Gm-Message-State: AOAM533yJNetrg2CqKxRIfxnERiwITiI87YNOFXAkkjxNVUAKeoBMug7 QDe52NdUyvV8PCKR3V5ofbnOR3y5CKA= X-Google-Smtp-Source: ABdhPJw55E4dI/IAyKkR+ZKkmH8bPHTaStHFj1pC0lhS1Eeb6cv6+uuItqqgA18GAeXeV2SBtT0zyEX+kRs= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:b022:92d6:d37b:686c]) (user=seanjc job=sendgmr) by 2002:a0c:8e83:: with SMTP id x3mr34844810qvb.40.1632269152245; Tue, 21 Sep 2021 17:05:52 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 21 Sep 2021 17:05:21 -0700 In-Reply-To: <20210922000533.713300-1-seanjc@google.com> Message-Id: <20210922000533.713300-5-seanjc@google.com> Mime-Version: 1.0 References: <20210922000533.713300-1-seanjc@google.com> X-Mailer: git-send-email 2.33.0.464.g1972c5931b-goog Subject: [PATCH v3 04/16] perf: Stop pretending that perf can handle multiple guest callbacks From: Sean Christopherson To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1632269179765100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the 'int' return value from the perf (un)register callbacks helpers and stop pretending perf can support multiple callbacks. The 'int' returns are not future proofing anything as none of the callers take action on an error. It's also not obvious that there will ever be co-tenant hypervisors, and if there are, that allowing multiple callbacks to be registered is desirable or even correct. Opportunistically rename callbacks=3D>cbs in the affected declarations to match their definitions. No functional change intended. Signed-off-by: Sean Christopherson Reviewed-by: Paolo Bonzini --- arch/arm64/include/asm/kvm_host.h | 4 ++-- arch/arm64/kvm/perf.c | 8 ++++---- include/linux/perf_event.h | 12 ++++++------ kernel/events/core.c | 16 ++++------------ 4 files changed, 16 insertions(+), 24 deletions(-) diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm= _host.h index 41911585ae0c..ed940aec89e0 100644 --- a/arch/arm64/include/asm/kvm_host.h +++ b/arch/arm64/include/asm/kvm_host.h @@ -670,8 +670,8 @@ unsigned long kvm_mmio_read_buf(const void *buf, unsign= ed int len); int kvm_handle_mmio_return(struct kvm_vcpu *vcpu); int io_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa); =20 -int kvm_perf_init(void); -int kvm_perf_teardown(void); +void kvm_perf_init(void); +void kvm_perf_teardown(void); =20 long kvm_hypercall_pv_features(struct kvm_vcpu *vcpu); gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu); diff --git a/arch/arm64/kvm/perf.c b/arch/arm64/kvm/perf.c index 151c31fb9860..c37c0cf1bfe9 100644 --- a/arch/arm64/kvm/perf.c +++ b/arch/arm64/kvm/perf.c @@ -48,15 +48,15 @@ static struct perf_guest_info_callbacks kvm_guest_cbs = =3D { .get_guest_ip =3D kvm_get_guest_ip, }; =20 -int kvm_perf_init(void) +void kvm_perf_init(void) { if (kvm_pmu_probe_pmuver() !=3D 0xf && !is_protected_kvm_enabled()) static_branch_enable(&kvm_arm_pmu_available); =20 - return perf_register_guest_info_callbacks(&kvm_guest_cbs); + perf_register_guest_info_callbacks(&kvm_guest_cbs); } =20 -int kvm_perf_teardown(void) +void kvm_perf_teardown(void) { - return perf_unregister_guest_info_callbacks(&kvm_guest_cbs); + perf_unregister_guest_info_callbacks(&kvm_guest_cbs); } diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 6b0405e578c1..317d4658afe9 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1245,8 +1245,8 @@ static inline struct perf_guest_info_callbacks *perf_= get_guest_cbs(void) /* Prevent reloading between a !NULL check and dereferences. */ return READ_ONCE(perf_guest_cbs); } -extern int perf_register_guest_info_callbacks(struct perf_guest_info_callb= acks *callbacks); -extern int perf_unregister_guest_info_callbacks(struct perf_guest_info_cal= lbacks *callbacks); +extern void perf_register_guest_info_callbacks(struct perf_guest_info_call= backs *cbs); +extern void perf_unregister_guest_info_callbacks(struct perf_guest_info_ca= llbacks *cbs); =20 extern void perf_event_exec(void); extern void perf_event_comm(struct task_struct *tsk, bool exec); @@ -1489,10 +1489,10 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs = *regs, u64 addr) { } static inline void perf_bp_event(struct perf_event *event, void *data) { } =20 -static inline int perf_register_guest_info_callbacks -(struct perf_guest_info_callbacks *callbacks) { return 0; } -static inline int perf_unregister_guest_info_callbacks -(struct perf_guest_info_callbacks *callbacks) { return 0; } +static inline void perf_register_guest_info_callbacks +(struct perf_guest_info_callbacks *cbs) { } +static inline void perf_unregister_guest_info_callbacks +(struct perf_guest_info_callbacks *cbs) { } =20 static inline void perf_event_mmap(struct vm_area_struct *vma) { } =20 diff --git a/kernel/events/core.c b/kernel/events/core.c index 80ff050a7b55..d90a43572400 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6482,31 +6482,23 @@ static void perf_pending_event(struct irq_work *ent= ry) perf_swevent_put_recursion_context(rctx); } =20 -/* - * We assume there is only KVM supporting the callbacks. - * Later on, we might change it to a list if there is - * another virtualization implementation supporting the callbacks. - */ struct perf_guest_info_callbacks *perf_guest_cbs; - -int perf_register_guest_info_callbacks(struct perf_guest_info_callbacks *c= bs) +void perf_register_guest_info_callbacks(struct perf_guest_info_callbacks *= cbs) { if (WARN_ON_ONCE(perf_guest_cbs)) - return -EBUSY; + return; =20 WRITE_ONCE(perf_guest_cbs, cbs); - return 0; } EXPORT_SYMBOL_GPL(perf_register_guest_info_callbacks); =20 -int perf_unregister_guest_info_callbacks(struct perf_guest_info_callbacks = *cbs) +void perf_unregister_guest_info_callbacks(struct perf_guest_info_callbacks= *cbs) { if (WARN_ON_ONCE(perf_guest_cbs !=3D cbs)) - return -EINVAL; + return; =20 WRITE_ONCE(perf_guest_cbs, NULL); synchronize_rcu(); - return 0; } EXPORT_SYMBOL_GPL(perf_unregister_guest_info_callbacks); =20 --=20 2.33.0.464.g1972c5931b-goog