From nobody Fri Mar 29 13:41:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1631249338257784.2209419373594; Thu, 9 Sep 2021 21:48:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.183928.332354 (Exim 4.92) (envelope-from ) id 1mOYSx-0006oV-Bd; Fri, 10 Sep 2021 04:48:43 +0000 Received: by outflank-mailman (output) from mailman id 183928.332354; Fri, 10 Sep 2021 04:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOYSx-0006o8-3K; Fri, 10 Sep 2021 04:48:43 +0000 Received: by outflank-mailman (input) for mailman id 183928; Fri, 10 Sep 2021 03:59:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOXhL-00006t-Cu for xen-devel@lists.xenproject.org; Fri, 10 Sep 2021 03:59:31 +0000 Received: from cstnet.cn (unknown [159.226.251.21]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 816f1de5-a5e7-4008-9a2d-5a6e2fe09e7d; Fri, 10 Sep 2021 03:59:26 +0000 (UTC) Received: from localhost.localdomain (unknown [124.16.141.243]) by APP-01 (Coremail) with SMTP id qwCowABX2dgZ2Dpho9EOAA--.30793S2; Fri, 10 Sep 2021 11:59:22 +0800 (CST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 816f1de5-a5e7-4008-9a2d-5a6e2fe09e7d From: Xu Wang To: Damien.LeMoal@wdc.com, konrad.wilk@oracle.com, roger.pau@citrix.com, axboe@kernel.dk, xen-devel@lists.xenproject.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] xen-blkback: Remove needless request_queue NULL pointer check Date: Fri, 10 Sep 2021 03:59:18 +0000 Message-Id: <20210910035918.24907-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: qwCowABX2dgZ2Dpho9EOAA--.30793S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZw43Kry8uF4xXF47Wr1xXwb_yoWDKrc_Wr 18ZrZaqr1v9rs09w1DCFnay340k3WkZFy09an2qFWaq347AFyaq3y7Zrn5Gw47uayUKrn5 CFyUG3W2yr1xAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbwAYjsxI4VWkCwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Gr1j6F 4UJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l 4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67 AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8I cVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI 8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAF wI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j1_M3UUUUU= X-Originating-IP: [124.16.141.243] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCQoAA102ag5bSAAAsc X-ZM-MESSAGEID: 1631249340479100001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The request_queue pointer returned from bdev_get_queue() shall never be NULL, so the null check is unnecessary, just remove it. Signed-off-by: Xu Wang Acked-by: Roger Pau Monn=C3=A9 --- Changes since v2: - Add missing parenthesis. - Remove another null pointer check. --- drivers/block/xen-blkback/xenbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback= /xenbus.c index 33eba3df4dd9..aac08b4369ac 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -516,10 +516,10 @@ static int xen_vbd_create(struct xen_blkif *blkif, bl= kif_vdev_t handle, vbd->type |=3D VDISK_REMOVABLE; =20 q =3D bdev_get_queue(bdev); - if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags)) + if (test_bit(QUEUE_FLAG_WC, &q->queue_flags)) vbd->flush_support =3D true; =20 - if (q && blk_queue_secure_erase(q)) + if (blk_queue_secure_erase(q)) vbd->discard_secure =3D true; =20 vbd->feature_gnt_persistent =3D feature_persistent; --=20 2.17.1