From nobody Thu Apr 25 02:19:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1631191784; cv=none; d=zohomail.com; s=zohoarc; b=jpy0VqckM7r4JAc+ClOuFKCNUE7ufbS7Q/w96HbWq34hie/sQ4/GBYI7/HbIvpRJIf5t+y6yMP45Y0e8jOUdpu3kHtTucSR5RkWy7+zAD/Ce/u1EJanM+Oqb3oyDBnPS3q5A/1BIe1kufXS9ALMQs4JEnFFiUHRwdiRxQZx21NY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631191784; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=apPVVY/Or6068NSgAcAK1NyxZlsZ0S/Udfzjsh8c7Lc=; b=JwZ5gHlVIjEYir1NOqeeZTZeLANmjN6+UqN9SJmKVt1+vJ++3Irfp7wNTqqD5f82TFyMTZ0ejQe9YURMuB3l86NASFD3hYaXQMvjLY0ivclZ2kIs/ZBPBQs8K1RFid4lrWR8X0WeNW+laTzH0Ps9JFOg9XOO16BngWRnFSUlayE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1631191784633580.416622484434; Thu, 9 Sep 2021 05:49:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.183220.331268 (Exim 4.92) (envelope-from ) id 1mOJUg-0004kR-RJ; Thu, 09 Sep 2021 12:49:30 +0000 Received: by outflank-mailman (output) from mailman id 183220.331268; Thu, 09 Sep 2021 12:49:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUg-0004kK-Nb; Thu, 09 Sep 2021 12:49:30 +0000 Received: by outflank-mailman (input) for mailman id 183220; Thu, 09 Sep 2021 12:49:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUf-0004iJ-5N for xen-devel@lists.xenproject.org; Thu, 09 Sep 2021 12:49:29 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 600b41ca-0bd0-4bd4-b3f9-5f9e83374f20; Thu, 09 Sep 2021 12:49:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7D5EE222FA; Thu, 9 Sep 2021 12:49:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 242D513CC1; Thu, 9 Sep 2021 12:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QB9TB9cCOmEyAgAAMHmgww (envelope-from ); Thu, 09 Sep 2021 12:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 600b41ca-0bd0-4bd4-b3f9-5f9e83374f20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631191767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=apPVVY/Or6068NSgAcAK1NyxZlsZ0S/Udfzjsh8c7Lc=; b=E1vtToLOsUatlm7chF20KBa/molARloaccxU0c3pKL4bDfD7/pgwUnIA6P4vc8qYJDbiRK kNY5hXJyJZLDjEvJZip43BDoF2f+8gbrdmjgl5jC23MCp133QAIJdXIi6bRxU2zuiTGebd WNsnqvVMjYS58fqH0YUQxEKT7qwJIzE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault Subject: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub Date: Thu, 9 Sep 2021 14:49:22 +0200 Message-Id: <20210909124924.1698-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210909124924.1698-1-jgross@suse.com> References: <20210909124924.1698-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1631191785373100002 Content-Type: text/plain; charset="utf-8" Today the build will fail if --disable-pv-grub as a parameter of configure, as the main Makefile will unconditionally try to build a 32-bit pv-grub stubdom. Fix that by introducing a pv-grub32 target in stubdom/Makefile taking care of this situation. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- Makefile | 4 ++-- stubdom/Makefile | 13 +++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 96d32cfd50..5b5cef3e49 100644 --- a/Makefile +++ b/Makefile @@ -72,7 +72,7 @@ build-tools-oxenstored: build-tools-public-headers build-stubdom: mini-os-dir build-tools-public-headers $(MAKE) -C stubdom build ifeq (x86_64,$(XEN_TARGET_ARCH)) - XEN_TARGET_ARCH=3Dx86_32 $(MAKE) -C stubdom pv-grub + XEN_TARGET_ARCH=3Dx86_32 $(MAKE) -C stubdom pv-grub32 endif =20 .PHONY: build-docs @@ -143,7 +143,7 @@ install-tools: install-tools-public-headers install-stubdom: mini-os-dir install-tools $(MAKE) -C stubdom install ifeq (x86_64,$(XEN_TARGET_ARCH)) - XEN_TARGET_ARCH=3Dx86_32 $(MAKE) -C stubdom install-grub + XEN_TARGET_ARCH=3Dx86_32 $(MAKE) -C stubdom install-grub32 endif =20 .PHONY: tools/firmware/seabios-dir-force-update diff --git a/stubdom/Makefile b/stubdom/Makefile index 06aa69d8bc..b339ae701c 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -531,6 +531,13 @@ vtpmmgr-stubdom: mini-os-$(XEN_TARGET_ARCH)-vtpmmgr vt= pmmgr pv-grub: mini-os-$(XEN_TARGET_ARCH)-grub libxenguest grub DEF_CPPFLAGS=3D"$(TARGET_CPPFLAGS)" DEF_CFLAGS=3D"$(TARGET_CFLAGS)" DEF_L= DFLAGS=3D"$(TARGET_LDFLAGS)" MINIOS_CONFIG=3D"$(CURDIR)/grub/minios.cfg" $(= MAKE) DESTDIR=3D -C $(MINI_OS) OBJ_DIR=3D$(CURDIR)/$< APP_OBJS=3D$(CURDIR)/= grub-$(XEN_TARGET_ARCH)/main.a =20 +.PHONY: pv-grub32 +ifneq ($(filter grub,$(STUBDOM_TARGETS)),) +pv-grub32: pv-grub +else +pv-grub32: +endif + .PHONY: xenstore-stubdom xenstore-stubdom: mini-os-$(XEN_TARGET_ARCH)-xenstore libxenguest xenstore DEF_CPPFLAGS=3D"$(TARGET_CPPFLAGS)" DEF_CFLAGS=3D"$(TARGET_CFLAGS)" DEF_L= DFLAGS=3D"$(TARGET_LDFLAGS)" MINIOS_CONFIG=3D"$(CURDIR)/xenstore-minios.cfg= " $(MAKE) DESTDIR=3D -C $(MINI_OS) OBJ_DIR=3D$(CURDIR)/$< APP_OBJS=3D$(CURD= IR)/xenstore/xenstored.a @@ -560,6 +567,12 @@ install-grub: pv-grub $(INSTALL_DIR) "$(DESTDIR)$(XENFIRMWAREDIR)" $(INSTALL_DATA) mini-os-$(XEN_TARGET_ARCH)-grub/mini-os.gz "$(DESTDIR)$(X= ENFIRMWAREDIR)/pv-grub-$(XEN_TARGET_ARCH).gz" =20 +ifneq ($(filter grub,$(STUBDOM_TARGETS)),) +install-grub32: install-grub +else +install-grub32: +endif + install-c: c-stubdom =20 install-caml: caml-stubdom --=20 2.26.2 From nobody Thu Apr 25 02:19:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1631191794; cv=none; d=zohomail.com; s=zohoarc; b=exuCSRXwBilfuc1CGzhvFAayGmwaJ57wQu7orp9xSjAEIKJqSJBweojDINO/eko0Ho+P+4IMJolCD6nA6tm9LuQQwZLHE0Pau2kDFGRtZoDjzb3Yw5+tB8BuDLDeY3baXh0NQdiSnI7ySn/Qy3W6UqpEbiiRLKCjEfre+kGQy1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631191794; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VDnmS7PEHavwjTjDgrskPsWB2O0plcriin7YJuNthnc=; b=I+ezSRT37B2UVpsHjtYLxvJUUxs3928oW5Sup7bscLl8lakrN8loSP7OuwQauEYeTAnU3ejr00R4GCqM0G/w5ujcurN6po5Dtp/AstdpyFQL8DQyYAQKO84BRIkS9GRrZ2LW2gGlbpolFhwa1f2ZViWgGLLVMjckiFzDhlcXBtA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1631191794006148.60788101865353; Thu, 9 Sep 2021 05:49:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.183222.331284 (Exim 4.92) (envelope-from ) id 1mOJUl-00059x-J5; Thu, 09 Sep 2021 12:49:35 +0000 Received: by outflank-mailman (output) from mailman id 183222.331284; Thu, 09 Sep 2021 12:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUl-000591-BH; Thu, 09 Sep 2021 12:49:35 +0000 Received: by outflank-mailman (input) for mailman id 183222; Thu, 09 Sep 2021 12:49:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUk-0004iJ-4C for xen-devel@lists.xenproject.org; Thu, 09 Sep 2021 12:49:34 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bf1dbd9c-3e4d-415e-b987-b6d84d2fc777; Thu, 09 Sep 2021 12:49:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C0AA320041; Thu, 9 Sep 2021 12:49:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 851A513C53; Thu, 9 Sep 2021 12:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4GAOH9cCOmEyAgAAMHmgww (envelope-from ); Thu, 09 Sep 2021 12:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf1dbd9c-3e4d-415e-b987-b6d84d2fc777 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631191767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VDnmS7PEHavwjTjDgrskPsWB2O0plcriin7YJuNthnc=; b=fDk4sR4I11DrMQkGj9VBRnyVivX+WpBqLZ2Wt8VK2Q8AMahd+4X8MeZ8cHUD29gqP8k4yt Aco/LHI7UwU4qX3Ij87PACYNREoJOT1KSZWA6obPmLcUexrpLM6ZiYje4bwuywen7eJ07k isdjQUvxfsYEavqhg6UUH8b+OzeVe3c= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Community Manager , Samuel Thibault , Wei Liu Subject: [PATCH v2 2/3] stubdom: disable building pv-grub Date: Thu, 9 Sep 2021 14:49:23 +0200 Message-Id: <20210909124924.1698-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210909124924.1698-1-jgross@suse.com> References: <20210909124924.1698-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1631191794286100001 Content-Type: text/plain; charset="utf-8" The stubdom based pv-grub is using a very outdated version of grub (0.97) and should not be used any longer. Mainline grub has support for PV guests for a long time now, so that should be used as a boot loader of a PV domain. So disable building pv-grub per default. In case someone really wants to continue using it he/she can still use a pv-grub binary from an older Xen version or manually enable building it via: configure --enable-pv-grub Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - add CHANGELOG.md entry (Jan Beulich) --- CHANGELOG.md | 2 ++ stubdom/configure | 8 ++------ stubdom/configure.ac | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 22cfdb4298..e7107ac3de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ The format is based on [Keep a Changelog](https://keepach= angelog.com/en/1.0.0/) appearing in 4.12.2 and 4.11.4). Prior (4.13...4.15-like) behavior can = be arranged for either by enabling the IOMMU_QUARANTINE_SCRATCH_PAGE setting at build (= configuration) time or by passing "iommu=3Dquarantine=3Dscratch-page" on the hypervisor com= mand line. + - pv-grub stubdoms will no longer be built per default. In order to be ab= le to use pv-grub + configure needs to be called with "--enable-pv-grub" as parameter. =20 ## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsho= rtlog;h=3DRELEASE-4.15.0) - TBD =20 diff --git a/stubdom/configure b/stubdom/configure index aa48df986d..df31532abb 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -1342,7 +1342,7 @@ Optional Features: --enable-ioemu-stubdom Build and install ioemu-stubdom --enable-c-stubdom Build and install c-stubdom (default is DISABLED) --enable-caml-stubdom Build and install caml-stubdom (default is DISAB= LED) - --disable-pv-grub Build and install pv-grub (default is ENABLED) + --enable-pv-grub Build and install pv-grub (default is DISABLED) --disable-xenstore-stubdom Build and install xenstore-stubdom (default is ENABLED) @@ -2129,11 +2129,7 @@ fi else =20 =20 -grub=3Dy -STUBDOM_TARGETS=3D"$STUBDOM_TARGETS grub" -STUBDOM_BUILD=3D"$STUBDOM_BUILD pv-grub" -STUBDOM_INSTALL=3D"$STUBDOM_INSTALL install-grub" -STUBDOM_UNINSTALL=3D"$STUBDOM_UNINSTALL install-grub" +grub=3Dn =20 =20 fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index bd6f765929..a07a1edae5 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -21,7 +21,7 @@ m4_include([../m4/fetcher.m4]) AX_STUBDOM_CONDITIONAL([ioemu-stubdom], [ioemu]) AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c]) AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml]) -AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub]) +AX_STUBDOM_DEFAULT_DISABLE([pv-grub], [grub]) AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore]) AX_STUBDOM_DEFAULT_ENABLE([xenstorepvh-stubdom], [xenstorepvh]) AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm]) --=20 2.26.2 From nobody Thu Apr 25 02:19:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1631191798; cv=none; d=zohomail.com; s=zohoarc; b=UXVyab+hTZrTRGb/iT89QnErSS6lmC0RqnCGD7iyjWFTXLWxZvNc4ZdzfeAF/gC6aHUnPWPUtgU7/wyohVQawJOTFeLfaomafQ9xGA2ZDT5a+J+vxHWRSWIflmjo7hxY+tXqpbyUAEfdH6dH7waj0HI24WlqT8a3I6ujHeUlDCE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631191798; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KD1KyoxklKM5WAWgMLa0ZRJlvuuDos+1D1Wk4QJhI1s=; b=kLwADVYKsECMX1sl9alItAIvg5qPoJb0TdWB/+Q6UuvjqC4wvIwaCEa4b5FIxOk5nD4M1sGPgdYcbt7/jo90SKljNrzIxrPKFKeKHudW0cCURYuMxWCsJfLAFTgDB1OlyharWHtDBAUafvr8Y8LeNQMnt2WFyoaH46BChMnrrYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1631191798273839.6633250778738; Thu, 9 Sep 2021 05:49:58 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.183226.331301 (Exim 4.92) (envelope-from ) id 1mOJUq-0005ld-OL; Thu, 09 Sep 2021 12:49:40 +0000 Received: by outflank-mailman (output) from mailman id 183226.331301; Thu, 09 Sep 2021 12:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUq-0005lK-Kc; Thu, 09 Sep 2021 12:49:40 +0000 Received: by outflank-mailman (input) for mailman id 183226; Thu, 09 Sep 2021 12:49:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOJUp-0004iJ-4X for xen-devel@lists.xenproject.org; Thu, 09 Sep 2021 12:49:39 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe8db3fc-2966-4895-adef-34f3a31ca3dc; Thu, 09 Sep 2021 12:49:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 05F7E22300; Thu, 9 Sep 2021 12:49:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C518E13CC1; Thu, 9 Sep 2021 12:49:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ANOoLtcCOmEyAgAAMHmgww (envelope-from ); Thu, 09 Sep 2021 12:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe8db3fc-2966-4895-adef-34f3a31ca3dc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631191768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KD1KyoxklKM5WAWgMLa0ZRJlvuuDos+1D1Wk4QJhI1s=; b=pjAHshmH4I+RV8YoVguibbSPyGf4Khskbk9ziNGNUWHnlj0pZzEMgTLNsq4D5riR9hMeLN 5cDW8wdiBzzJNOYqLkA4NSamEV17siLZw8CVw/m5EvN0GiCNVbbvR5heI837ugyrVm3LP3 FKvjoOjVQfCPtAj7CYXQ14p105NVPuY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Community Manager , Samuel Thibault , Wei Liu Subject: [PATCH v2 3/3] tools: disable building qemu-trad per default Date: Thu, 9 Sep 2021 14:49:24 +0200 Message-Id: <20210909124924.1698-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210909124924.1698-1-jgross@suse.com> References: <20210909124924.1698-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1631191800644100001 Content-Type: text/plain; charset="utf-8" Using qemu-traditional as device model is deprecated for some time now. So change the default for building it to "disable". This will affect ioemu-stubdom, too, as there is a direct dependency between the two. Today it is possible to use a PVH/HVM Linux-based stubdom as device model. Additionally using ioemu-stubdom isn't really helping for security, as it requires to run a very old and potentially buggy qemu version in a PV domain. This is adding probably more security problems than it is removing by using a stubdom. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - new patch --- CHANGELOG.md | 3 +++ stubdom/configure | 8 -------- stubdom/configure.ac | 8 +------- tools/configure | 17 ++--------------- tools/configure.ac | 13 +------------ 5 files changed, 7 insertions(+), 42 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e7107ac3de..e5ab49e779 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,9 @@ The format is based on [Keep a Changelog](https://keepach= angelog.com/en/1.0.0/) or by passing "iommu=3Dquarantine=3Dscratch-page" on the hypervisor com= mand line. - pv-grub stubdoms will no longer be built per default. In order to be ab= le to use pv-grub configure needs to be called with "--enable-pv-grub" as parameter. + - qemu-traditional based device models (both, qemu-traditional and ioemu-= stubdom) will + no longer be built per default. In order to be able to use those, confi= gure needs to + be called with "--enable-qemu-traditional" as parameter. =20 ## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dsho= rtlog;h=3DRELEASE-4.15.0) - TBD =20 diff --git a/stubdom/configure b/stubdom/configure index df31532abb..07b709f998 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -2286,14 +2286,6 @@ fi # Check whether --enable-qemu-traditional was given. if test "${enable_qemu_traditional+set}" =3D set; then : enableval=3D$enable_qemu_traditional; -else - - case "$host_cpu" in - i[3456]86|x86_64) - enable_qemu_traditional=3D"yes";; - *) enable_qemu_traditional=3D"no";; - esac - fi =20 if test "x$enable_qemu_traditional" =3D "xyes"; then : diff --git a/stubdom/configure.ac b/stubdom/configure.ac index a07a1edae5..e20d99edac 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -27,13 +27,7 @@ AX_STUBDOM_DEFAULT_ENABLE([xenstorepvh-stubdom], [xensto= repvh]) AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm]) AX_STUBDOM_CONDITIONAL([vtpmmgr-stubdom], [vtpmmgr]) =20 -AC_ARG_ENABLE([qemu-traditional],,,[ - case "$host_cpu" in - i[[3456]]86|x86_64) - enable_qemu_traditional=3D"yes";; - *) enable_qemu_traditional=3D"no";; - esac -]) +AC_ARG_ENABLE([qemu-traditional]) AS_IF([test "x$enable_qemu_traditional" =3D "xyes"], [ qemu_traditional=3Dy],[ qemu_traditional=3Dn diff --git a/tools/configure b/tools/configure index 33814b24b3..8bf8fe75b8 100755 --- a/tools/configure +++ b/tools/configure @@ -1502,8 +1502,8 @@ Optional Features: --disable-seabios Disable SeaBIOS (default is ENABLED) --disable-golang Disable Go tools (default is ENABLED) --enable-qemu-traditional - Enable qemu traditional device model, (DEFAULT i= s on - for Linux or NetBSD x86, otherwise off) + Enable qemu traditional device model, (DEFAULT is + off) --enable-rombios Enable ROMBIOS, (DEFAULT is on if qemu-tradition= al is enabled, otherwise off) --disable-ipxe Enable in-tree IPXE, (DEFAULT is on if rombios is @@ -4287,19 +4287,6 @@ LINUX_BACKEND_MODULES=3D"`eval echo $LINUX_BACKEND_M= ODULES`" # Check whether --enable-qemu-traditional was given. if test "${enable_qemu_traditional+set}" =3D set; then : enableval=3D$enable_qemu_traditional; -else - - case "$host_cpu" in - i[3456]86|x86_64) - enable_qemu_traditional=3D"yes";; - *) enable_qemu_traditional=3D"no";; - esac - case "$host_os" in - freebsd*) - enable_qemu_traditional=3D"no";; - esac - - fi =20 if test "x$enable_qemu_traditional" =3D "xyes"; then : diff --git a/tools/configure.ac b/tools/configure.ac index 6414fcbb44..a713fd34d6 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -120,18 +120,7 @@ AC_SUBST(LINUX_BACKEND_MODULES) =20 AC_ARG_ENABLE([qemu-traditional], AS_HELP_STRING([--enable-qemu-traditional], - [Enable qemu traditional device model, (DEFAULT is on f= or Linux or NetBSD x86, otherwise off)]),,[ - case "$host_cpu" in - i[[3456]]86|x86_64) - enable_qemu_traditional=3D"yes";; - *) enable_qemu_traditional=3D"no";; - esac - case "$host_os" in - freebsd*) - enable_qemu_traditional=3D"no";; - esac - -]) + [Enable qemu traditional device model, (DEFAULT is off)= ])) AS_IF([test "x$enable_qemu_traditional" =3D "xyes"], [ AC_DEFINE([HAVE_QEMU_TRADITIONAL], [1], [Qemu traditional enabled]) qemu_traditional=3Dy],[ --=20 2.26.2