From nobody Sat May 4 04:36:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629872580; cv=none; d=zohomail.com; s=zohoarc; b=hNEPttHiAkr/SwGjc+SvAXy4Ynd+ntSowRCMa7ovnrtBtRnod4uKqXQ1OUPdbEGDPgDfbn+Z6J0ITzQ5bU18qPBdexKqXFXArTxa+PKH0A43BXLYZcgBGt/1SyaWmqSYJYVLxRa+Ix7pSXTyxJo0wi5zbpLs3o7re3GhV/4HYz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629872580; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=izl1y+WlTmO5QOWs7e/KaDQxMK8mxtFtlYdxklpsPvo=; b=YrETjqS9oMzBVxqqweaeLMP3rVxRehR5RFUYmIN3M58cNXvxdBILjAasPAjqR+nt43wEuzHOdJLu6fYo1jS/jWBTk13nN2ixvPkX+kcjKQtMFCJ3s6eL4M6peYlQEUik6eMCRPSWC3U1GZrt78N3jf2txhfWH09t27B24Rr5EY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 162987258023884.87139165872043; Tue, 24 Aug 2021 23:23:00 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.171786.313471 (Exim 4.92) (envelope-from ) id 1mImIy-0007Qg-UA; Wed, 25 Aug 2021 06:22:32 +0000 Received: by outflank-mailman (output) from mailman id 171786.313471; Wed, 25 Aug 2021 06:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mImIy-0007QZ-QG; Wed, 25 Aug 2021 06:22:32 +0000 Received: by outflank-mailman (input) for mailman id 171786; Wed, 25 Aug 2021 06:22:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mImIx-0007QT-DF for xen-devel@lists.xenproject.org; Wed, 25 Aug 2021 06:22:31 +0000 Received: from mail-qk1-x72c.google.com (unknown [2607:f8b0:4864:20::72c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24d099ed-94c9-43b7-9347-24b4ace46ac8; Wed, 25 Aug 2021 06:22:30 +0000 (UTC) Received: by mail-qk1-x72c.google.com with SMTP id e14so25955165qkg.3 for ; Tue, 24 Aug 2021 23:22:30 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id s204sm12320061qke.109.2021.08.24.23.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 23:22:30 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24d099ed-94c9-43b7-9347-24b4ace46ac8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=izl1y+WlTmO5QOWs7e/KaDQxMK8mxtFtlYdxklpsPvo=; b=aj9dQlbVIy1l2igc9/Dx/Jr1171aaG5ecch0A7PrWTkRJG1Vbq/pIECncWQiwlZnkw UJ1OjMyNB+F+IkqQ4VA4K7cPEqZ+KGDDMwd4fFCCtWMKJwOBuMmAUYSiE6jdyQyLduh+ C5bAYELEMAwwDfffmGEWGrHKKAB4Z/cpVmzZnuQ7RvSIgrCiu+daRDx+mXGQTAaQVi6D mIoor09h6qFFHcpP52aqDyMaaX+/otNEcDi5oVCVZ3jtEpGpHKHMWQpT1o5cdEY8C4wp 9gTTlYqkww+Z1uPZzUh0kqBwlfZWEMdvOk0MWqrLMkKLRkVkQZIhZ//a/nI5IAemVjui gVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=izl1y+WlTmO5QOWs7e/KaDQxMK8mxtFtlYdxklpsPvo=; b=ZKXjk/qhnH2qxGrYjQfRZD/ekgVV5qg0M8eRGfKgHopfv/kaMJAR0N7Ymf6+k5wU7R +o6O54g7Du8hebvFppb2n7L7qln73crLt9zVSrXjMUY5eZpU0WOZGYHtbmJngl9WC3qM XckRGDMxt0IgvBP5JJt5UcLlcwz3QPYHIkEkZNDt01HfWGdptdrhWYRRRpIs9cAbwvev JKCJXgxjIVw3mdqFbtgCrKP147z6L6hbktkj3Q9LG7fU9O4P+sY0dAHbvWcqe9U2IZhT zk/MZZkoCVQHrVVltNvykoJReHmmaoHjPgimjUbZ+LbnTqYD5mGFKKr3kQ0jW8GUb62D vT/w== X-Gm-Message-State: AOAM5312OtZcpnjAIvcNd7gOodiRBOfeksEfusvJnOSm8ftZxUKTlflv oNJuCBo6+KOTDGtlnVPgtd0= X-Google-Smtp-Source: ABdhPJz1LgGGzugmNR0aeLcfgcWj1FHNGUyFGNVbR9VpGZjQATq3ZO7MRmIkOyfCei1aznQI6pyR1A== X-Received: by 2002:a05:620a:95e:: with SMTP id w30mr28822303qkw.157.1629872550317; Tue, 24 Aug 2021 23:22:30 -0700 (PDT) From: CGEL X-Google-Original-From: CGEL To: Boris Ostrovsky Cc: Juergen Gross , Stefano Stabellini , Thomas Gleixner , Wei Liu , Jan Beulich , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot Subject: [PATCH linux-next] drivers/xen/events/events_base.c: fix bugon.cocci warnings Date: Tue, 24 Aug 2021 23:22:22 -0700 Message-Id: <20210825062222.69936-1-deng.changcheng@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629872581127100001 Content-Type: text/plain; charset="utf-8" From: Jing Yangyang Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci Reported-by: Zeal Robot Signed-off-by: Jing Yangyang --- drivers/xen/events/events_base.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_b= ase.c index a78704a..dd44019 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -818,8 +818,7 @@ static void xen_evtchn_close(evtchn_port_t port) struct evtchn_close close; =20 close.port =3D port; - if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) !=3D 0) - BUG(); + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) !=3D 0); } =20 /* Not called for lateeoi events. */ @@ -1270,9 +1269,8 @@ static int bind_ipi_to_irq(unsigned int ipi, unsigned= int cpu) handle_percpu_irq, "ipi"); =20 bind_ipi.vcpu =3D xen_vcpu_nr(cpu); - if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_ipi, - &bind_ipi) !=3D 0) - BUG(); + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_bind_ipi, + &bind_ipi) !=3D 0); evtchn =3D bind_ipi.port; =20 ret =3D xen_irq_info_ipi_setup(cpu, irq, evtchn, ipi); @@ -1983,9 +1981,8 @@ static void restore_cpu_virqs(unsigned int cpu) /* Get a new binding from Xen. */ bind_virq.virq =3D virq; bind_virq.vcpu =3D xen_vcpu_nr(cpu); - if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq, - &bind_virq) !=3D 0) - BUG(); + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq, + &bind_virq) !=3D 0); evtchn =3D bind_virq.port; =20 /* Record the new mapping. */ @@ -2009,9 +2006,8 @@ static void restore_cpu_ipis(unsigned int cpu) =20 /* Get a new binding from Xen. */ bind_ipi.vcpu =3D xen_vcpu_nr(cpu); - if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_ipi, - &bind_ipi) !=3D 0) - BUG(); + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_bind_ipi, + &bind_ipi) !=3D 0); evtchn =3D bind_ipi.port; =20 /* Record the new mapping. */ @@ -2063,8 +2059,7 @@ void xen_poll_irq_timeout(int irq, u64 timeout) poll.timeout =3D timeout; set_xen_guest_handle(poll.ports, &evtchn); =20 - if (HYPERVISOR_sched_op(SCHEDOP_poll, &poll) !=3D 0) - BUG(); + BUG_ON(HYPERVISOR_sched_op(SCHEDOP_poll, &poll) !=3D 0); } } EXPORT_SYMBOL(xen_poll_irq_timeout); --=20 1.8.3.1