From nobody Fri May 3 12:59:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1629120953; cv=none; d=zohomail.com; s=zohoarc; b=ZnD2A3Evc63NvfFIlm2G6Jp8POhZmPnBVASscCGen9mEWC/ofbx8ncmFF4JAOMtt20lD+A+pmL4XPRfrdJ1bRHi7N+YBIaS1CFN5WgR7B1NOjikdgSSS1DWcqBdjpxvhS1TwgV2Gh5olBJrDooSXBM4fVLIBHdjjRvviggDI1wM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629120953; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=e75W3zgaWYGdzzseLT7SVREqfEAD1xJjilGfKJmGgiw=; b=WNse+plmR90JxP4v7kmMI+QrLIn5RaYXKrgd61Cqfbpfa3oyHj0NJBNPOiBGv8KL0TB248Ted32gDE1ROTLj5fz6Uk+KZ/bfzO18ocfkfAECUx2BEQX/sfQ3eDGP/hCRaFTLF7Mssw4AkC7pChtLth0gqIM5LvGtMGwZ6bAapQU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1629120953411800.7601718435334; Mon, 16 Aug 2021 06:35:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.167348.305459 (Exim 4.92) (envelope-from ) id 1mFclo-0005Wm-AL; Mon, 16 Aug 2021 13:35:16 +0000 Received: by outflank-mailman (output) from mailman id 167348.305459; Mon, 16 Aug 2021 13:35:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mFclo-0005Wf-6t; Mon, 16 Aug 2021 13:35:16 +0000 Received: by outflank-mailman (input) for mailman id 167348; Mon, 16 Aug 2021 13:35:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mFclm-0005WX-JT for xen-devel@lists.xenproject.org; Mon, 16 Aug 2021 13:35:14 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9cd43071-3a08-48ee-867c-bef8d2ab4669; Mon, 16 Aug 2021 13:35:13 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cd43071-3a08-48ee-867c-bef8d2ab4669 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1629120913; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=J3Rz2pdrx18ZZ+7VvhEz+bCgJyTqT/VHf8O3JBJwNHM=; b=g11IB4PSQH4/8zcca4O/Aon7Q3Lyj0Bb88vNwdpCebJJTry6xKa9uzSB RhmsDDa21grmvuz1baYHUI9VycLAnefQIGe60qRjJbNsIQQbrRXeOrHE5 P+ZksRqV/jZAtivifpFZBTLkLj1s9ZJRz29J2qrudbsuJf2h97KqziSSs Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: nNue01P5FLgoYh+xBhs4YIh16TNPfWBgrZvqWI45iUDd17kox+qCjxF8ZoZ78XKeucBIrNKjSL eSDUOOWACCfmsmNH9epUiwlc6cL6qw6Zf4Q4q98khZ19Uz0d1KEq5vkdMe8xpdXLEtHnqC95CS iUbY+8n2g8ClNObjX9AsmsN0dQLE8NnPFYSh1x2w9HsHl5VTvxsz2qlY96xgEmgh5MznpWEENh tVGVzGoFiK4aYtN68B8l7TjS5xbPgRqwhatU86wxtvoYzVENosqEu+HctFebxEyNlH3UFJrJf6 1IZipsiKRNENmBX7AXsPb6yT X-SBRS: 5.1 X-MesageID: 50526644 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Gp7mI6Psp5xmS8BcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.84,326,1620705600"; d="scan'208";a="50526644" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/ACPI: Insert missing newlines into FACS error messages Date: Mon, 16 Aug 2021 14:35:05 +0100 Message-ID: <20210816133505.32484-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) X-ZM-MESSAGEID: 1629120954171100001 Booting Xen as a PVH guest currently yields: (XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0] (XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010<2>ACPI: wakeup_vec[fc= 00101c], vec_size[20] (XEN) ACPI: Local APIC address 0xfee00000 Insert newlines as appropriate. Fixes: d3faf9badf52 ("[host s3] Retrieve necessary sleep information from p= lain-text ACPI tables (FADT/FACS), and keep one hypercall remained for slee= p notification.") Fixes: 0f089bbf43ec ("x86/ACPI: fix S3 wakeup vector mapping") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu As to why the FACS is misaligned, clearly that is a bug in the domain build= er for PVH guests, but I don't have time to go debugging. --- xen/arch/x86/acpi/boot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index ff4685279f68..8fe2d6fe0f42 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -432,19 +432,19 @@ acpi_fadt_parse_sleep_info(const struct acpi_table_fa= dt *fadt) } =20 if (facs->length < 24) { - printk(KERN_ERR PREFIX "Invalid FACS table length: %#x", + printk(KERN_ERR PREFIX "Invalid FACS table length: %#x\n", facs->length); goto done; } =20 if (facs->length < 64) printk(KERN_WARNING PREFIX - "FACS is shorter than ACPI spec allow: %#x", + "FACS is shorter than ACPI spec allow: %#x\n", facs->length); =20 if (facs_pa % 64) printk(KERN_WARNING PREFIX - "FACS is not 64-byte aligned: %#lx", + "FACS is not 64-byte aligned: %#lx\n", facs_pa); =20 acpi_sinfo.wakeup_vector =3D facs_pa +=20 --=20 2.11.0