From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172481; cv=pass; d=zohomail.com; s=zohoarc; b=Rl0zdwiyUraR/4HSivhySUMdjImOi79wlCUzdD/rYAfBwhCK1L0LcjHJ7kTb/OjhfLmKaBZ2kmfvIWav4KUEsNnwubXMVFuiegrx4TqiO8khQUJDO5XDLVeThwrr+bXJ1EaMDJwr7axlX9v/QAbBxBNxSTP8pyWOyhen1G1Z6Ro= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172481; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pE9Z45Jk5+X07ZGFhuHKmX3SCjV8QdnUfGDxFvvXjqU=; b=f3OYlYSlVwzcGZQms3U7wcwlRP7zgKNf5mCYxysOgr88wSwHdCqKhaB4iPkijfyJfTe9uwVYhkz/Fzxo4gm1mjVMfExd2kQLJi5lPXWuSFF2KoNCgmRkE57DmGew/HN0cE+scHXYMaZ30sXvqkKLbTR4UXykgnhhaz/fu28I8x8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1628172481084657.3165935883815; Thu, 5 Aug 2021 07:08:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164246.300505 (Exim 4.92) (envelope-from ) id 1mBe22-0001Zc-3e; Thu, 05 Aug 2021 14:07:34 +0000 Received: by outflank-mailman (output) from mailman id 164246.300505; Thu, 05 Aug 2021 14:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe22-0001ZV-09; Thu, 05 Aug 2021 14:07:34 +0000 Received: by outflank-mailman (input) for mailman id 164246; Thu, 05 Aug 2021 14:07:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe20-0001Yx-Rq for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:07:32 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dec50b14-c45e-4bcd-acbf-8eb5e34fe270; Thu, 05 Aug 2021 14:07:31 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1628172443284500.89520364699354; Thu, 5 Aug 2021 07:07:23 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dec50b14-c45e-4bcd-acbf-8eb5e34fe270 ARC-Seal: i=1; a=rsa-sha256; t=1628172446; cv=none; d=zohomail.com; s=zohoarc; b=DGH50UT2gM9fPgR/WQd1uWw50iQnqZ8P96lNgjAMyhfkLtqJ7L7b6Rx1TQlhzgsteOUNHA2jG2ZR3YlVrX53W/R05YkV/jI2lsNy4HlIi4iodMytzvUmt7g4KUX2+un8LK5cAwQtMgEX2PD9yQ1Cpo/Cf33diNUywsS/6blh/1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172446; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=pE9Z45Jk5+X07ZGFhuHKmX3SCjV8QdnUfGDxFvvXjqU=; b=MBz/+ql5HkK1HJGj7CdQnBRB4Kmu7eKqWXJt8vIZzS+Ez8VWesI9kz9P8n8xLe1DO/DovOWk9Dw1NEC6mH2GeeH0e+ppxtSu5Lnv85cUS8guo3zfhNXjIx2FE1rnyKa8Rj/hk0UVfxmuyCjGd2z0Ytntr5EMgFFv8sY1ZbcymE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172446; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=pE9Z45Jk5+X07ZGFhuHKmX3SCjV8QdnUfGDxFvvXjqU=; b=Qa6UhUeTfz7MkJpWXM04BQh8qNhZ9izLg0fOdQqq+nqp/dlPTScfx8OJjIhj+6qx +B8IqErqhFwZG63wsEkX7Twoj4caEcYx1Fn1m86ODzxVP5CyHnqzfAY/ePKZhhlExSl 3yBNR8EBZkLa/V5akaRJ9IT3/2oIxac+41+pssk8= From: "Daniel P. Smith" To: Wei Liu , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , "Daniel P . Smith" , Jan Beulich , George Dunlap , Ian Jackson Subject: [PATCH v3 1/7] xen: Implement xen/alternative-call.h for use in common code Date: Thu, 5 Aug 2021 10:06:38 -0400 Message-Id: <20210805140644.357-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172481764100001 From: Andrew Cooper The alternative call infrastructure is x86-only for now, but the common iom= mu code has a variant and more common code wants to use the infrastructure. Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so common code can use the optimisation when available, without requiring all architectures to implement no-op stubs. Write some documentation, which was thus far entirely absent, covering the requirements for an architecture to implement this optimsiation, and how to use the infrastructure in general code. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bob Eshleman CC: Alistair Francis CC: Connor Davis CC: Daniel P. Smith v3: * Drop __alt_call_maybe_initconst This is a pre-requisite to "xsm: refactor xsm_ops handling" to avoid breaki= ng the ARM build. Build test for the XSM code: diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 5eab21e1b168..592074e8f41c 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -195,6 +195,16 @@ bool __init has_xsm_magic(paddr_t start) } #endif +#include +struct foo { + int (*bar)(void *); +} foo __alt_call_maybe_initdata; + +int test_alternative_call(void) +{ + return alternative_call(foo.bar, NULL); +} + int __init register_xsm(struct xsm_operations *ops) { if ( verify(ops) ) --- xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 3 ++ xen/include/xen/alternative-call.h | 63 ++++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+) create mode 100644 xen/include/xen/alternative-call.h diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 9b164db641..1f83518ee0 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -6,6 +6,7 @@ config X86 def_bool y select ACPI select ACPI_LEGACY_TABLES_LOOKUP + select ALTERNATIVE_CALL select ARCH_SUPPORTS_INT128 select CORE_PARKING select HAS_ALTERNATIVE diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0ddd18e11a..ac5491b1cc 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -22,6 +22,9 @@ config GRANT_TABLE =20 If unsure, say Y. =20 +config ALTERNATIVE_CALL + bool + config HAS_ALTERNATIVE bool =20 diff --git a/xen/include/xen/alternative-call.h b/xen/include/xen/alternati= ve-call.h new file mode 100644 index 0000000000..95ebd66728 --- /dev/null +++ b/xen/include/xen/alternative-call.h @@ -0,0 +1,63 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef XEN_ALTERNATIVE_CALL +#define XEN_ALTERNATIVE_CALL + +/* + * Some subsystems in Xen may have multiple implementions, which can be + * resolved to a single implementation at boot time. By default, this will + * result in the use of function pointers. + * + * Some architectures may have mechanisms for dynamically modifying .text. + * Using this mechnaism, function pointers can be converted to direct calls + * which are typically more efficient at runtime. + * + * For architectures to support: + * + * - Implement alternative_{,v}call() in asm/alternative.h. Code generati= on + * requirements are to emit a function pointer call at build time, and s= tash + * enough metadata to simplify the call at boot once the implementation = has + * been resolved. + * - Select ALTERNATIVE_CALL in Kconfig. + * + * To use: + * + * Consider the following simplified example. + * + * 1) struct foo_ops __alt_call_maybe_initdata ops; + * + * 2) const struct foo_ops __initconst foo_a_ops =3D { ... }; + * const struct foo_ops __initconst foo_b_ops =3D { ... }; + * + * void foo_init(void) + * { + * ... + * if ( use_impl_a ) + * ops =3D *foo_a_ops; + * else if ( use_impl_b ) + * ops =3D *foo_b_ops; + * ... + * } + * + * 3) alternative_call(ops.bar, ...); + * + * There needs to a single ops object (1) which will eventually contain the + * function pointers. This should be populated in foo's init() function (= 2) + * by one of the available implementations. To call functions, use + * alternative_{,v}call() referencing the main ops object (3). + */ + +#ifdef CONFIG_ALTERNATIVE_CALL + +#include + +#define __alt_call_maybe_initdata __initdata + +#else + +#define alternative_call(func, args...) (func)(args) +#define alternative_vcall(func, args...) (func)(args) + +#define __alt_call_maybe_initdata + +#endif /* !CONFIG_ALTERNATIVE_CALL */ +#endif /* XEN_ALTERNATIVE_CALL */ --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172482; cv=pass; d=zohomail.com; s=zohoarc; b=TFkRiJLiTPIUUNorzvEO08E2qRgumpnON8F5l9cL3RiLazIC/xC8jDYgBJ9EuvvClU+TLqAGM6q+sy8u3bhEcZUM/XpNBOfkqySi9iOvMJyAmag9ohWrj7CFoDZbh85DHnJxHekOBlRnh8ZAkjjVxaecZ22NkGZBvCxYgoOZT98= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172482; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oBtJAYzQJ3xOPC4nmZs464PFZEvqwBEbkKJJO08ZKyQ=; b=SV9YvTmhRSP8oCXNZNAEYPM52CEn5ca/3XY30FUAWnAoGjl83l5Lbd6MJtv6qNU/xZvn2kWtK/zGxa+Ob9Y0xoxoW29C/1n46BjhuGuGH4RO9nUUFrkRyl7QSHaI53GQoE/2npuknImhjxc/guwlVGJB4A9RkZr10+s6cCd338E= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1628172482411822.6644822329663; Thu, 5 Aug 2021 07:08:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164252.300517 (Exim 4.92) (envelope-from ) id 1mBe2H-00029u-D5; Thu, 05 Aug 2021 14:07:49 +0000 Received: by outflank-mailman (output) from mailman id 164252.300517; Thu, 05 Aug 2021 14:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2H-00029n-99; Thu, 05 Aug 2021 14:07:49 +0000 Received: by outflank-mailman (input) for mailman id 164252; Thu, 05 Aug 2021 14:07:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2G-0001zB-Da for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:07:48 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 184f06bb-dc13-495d-9fc9-36a59ee35e1c; Thu, 05 Aug 2021 14:07:47 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 162817244586698.78117808058039; Thu, 5 Aug 2021 07:07:25 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 184f06bb-dc13-495d-9fc9-36a59ee35e1c ARC-Seal: i=1; a=rsa-sha256; t=1628172453; cv=none; d=zohomail.com; s=zohoarc; b=LrgabP+/WrfB8/58NDSrdZl8XfMrI1k8C5srWUD9ZOR+3kM+khDUIv+kAmM4hsOEbXXfPwLI5IcY3mpNrewnZcJXUvMGjcDSRZAfi+tIhXUHPbqDn9q8lv+fuzUMsN5lZd9LpujYeBcMUzW8+vgXYd89EAHm8UBpRNp5WS2JVC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172453; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=oBtJAYzQJ3xOPC4nmZs464PFZEvqwBEbkKJJO08ZKyQ=; b=PKSUS4+JnBYPN4X/yoVRQ26POggrQjg3stq6DVXQ59KT6UISdT/IuXd5KSoceOBzJWmOr+R/Q72uqmXwcHO0N2LV+ticzAMtEDPnxl1efKEvGkUCGxbdsHfXegHD9EIoR3p8aXXjqRamLMO7JT+ZAl6vntNYoaAFf7J1LH2A7P8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172453; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=oBtJAYzQJ3xOPC4nmZs464PFZEvqwBEbkKJJO08ZKyQ=; b=XB3STg4hlk3olDoIWK5H3yvE3dgP/2j8c4oAPcGn9VhsYe1tAe3Nmw+nPcv4cGL1 wNRqXS8mI+vQ/uQCqlTE5klTl8k6wE4bxzQoukuA5FOLgPAjAuQlsWHF3NjPaarFXAY bZM3KlARlDVJfwdfcTVY0HocNEL1wbJuXZL8j8Jo= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf Subject: [PATCH v3 2/7] xsm: remove the ability to disable flask Date: Thu, 5 Aug 2021 10:06:39 -0400 Message-Id: <20210805140644.357-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172483780100003 Content-Type: text/plain; charset="utf-8" On Linux when SELinux is put into permissive mode the descretionary access controls are still in place. Whereas for Xen when the enforcing state of fl= ask is set to permissive, all operations for all domains would succeed, i.e. it does not fall back to the default access controls. To provide a means to mi= mic a similar but not equivalent behavior, a flask op is present to allow a one-time switch back to the default access controls, aka the "dummy policy". This patch removes this flask op to enforce a consistent XSM usage model th= at a reboot of Xen is required to change the XSM policy module in use. Signed-off-by: Daniel P. Smith --- xen/include/public/xsm/flask_op.h | 2 +- xen/xsm/flask/flask_op.c | 30 ------------------------------ 2 files changed, 1 insertion(+), 31 deletions(-) diff --git a/xen/include/public/xsm/flask_op.h b/xen/include/public/xsm/fla= sk_op.h index 16af7bc22f..b41dd6dac8 100644 --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -188,7 +188,7 @@ struct xen_flask_op { #define FLASK_SETBOOL 12 #define FLASK_COMMITBOOLS 13 #define FLASK_MLS 14 -#define FLASK_DISABLE 15 +#define FLASK_DISABLE 15 /* No longer implemented */ #define FLASK_GETAVC_THRESHOLD 16 #define FLASK_SETAVC_THRESHOLD 17 #define FLASK_AVC_HASHSTATS 18 diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c index 01e52138a1..f41c025391 100644 --- a/xen/xsm/flask/flask_op.c +++ b/xen/xsm/flask/flask_op.c @@ -223,32 +223,6 @@ static int flask_security_sid(struct xen_flask_sid_con= text *arg) =20 #ifndef COMPAT =20 -static int flask_disable(void) -{ - static int flask_disabled =3D 0; - - if ( ss_initialized ) - { - /* Not permitted after initial policy load. */ - return -EINVAL; - } - - if ( flask_disabled ) - { - /* Only do this once. */ - return -EINVAL; - } - - printk("Flask: Disabled at runtime.\n"); - - flask_disabled =3D 1; - - /* Reset xsm_ops to the original module. */ - xsm_ops =3D &dummy_xsm_ops; - - return 0; -} - static int flask_security_setavc_threshold(struct xen_flask_setavc_thresho= ld *arg) { int rv =3D 0; @@ -698,10 +672,6 @@ ret_t do_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_f= lask_op) rv =3D flask_mls_enabled; break; =20 =20 - case FLASK_DISABLE: - rv =3D flask_disable(); - break; - case FLASK_GETAVC_THRESHOLD: rv =3D avc_cache_threshold; break; --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172514; cv=pass; d=zohomail.com; s=zohoarc; b=OjoT73cjep9vLXUW4GinUgz5182R3ZGJRknPWeIMzu15mQx54T/Q/4aOwSM/icJZN7yDO5L+YZTslezcsBll1l3oSk3GEs7YNfijQAv6Yu7rC232rcPrsJunSSyujllZNFsaZknxauBnyC3vY2pQ4Xz77dh+STSZII9PtUWRv8c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172514; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7WON7HcT99RPILN4S/fXQmxUWCY7IAO9j/BEnR/e9Rk=; b=hTG0+Rg5uXCufw7JwIUi28uHBPhTKibeCKZ7C1ZtoMA6SB+d2Mn0LrE5emooj1IR1HsTkTVenw5iJ2kThDA+J9PaEMh47FtZnG/HHWjwSTloVxhvz3rZFWy5YJOvCd7mp6nt73olCCrR/NlAmWJC20uzduPJW/BE3EAJR6Gu6Io= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1628172514048329.6520570606075; Thu, 5 Aug 2021 07:08:34 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164262.300529 (Exim 4.92) (envelope-from ) id 1mBe2g-0002wA-M7; Thu, 05 Aug 2021 14:08:14 +0000 Received: by outflank-mailman (output) from mailman id 164262.300529; Thu, 05 Aug 2021 14:08:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2g-0002w3-Ij; Thu, 05 Aug 2021 14:08:14 +0000 Received: by outflank-mailman (input) for mailman id 164262; Thu, 05 Aug 2021 14:08:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2e-0002du-HB for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:08:12 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8ea5d2c4-f5f6-11eb-9c12-12813bfff9fa; Thu, 05 Aug 2021 14:08:07 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 162817244761489.22386118944542; Thu, 5 Aug 2021 07:07:27 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ea5d2c4-f5f6-11eb-9c12-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1628172458; cv=none; d=zohomail.com; s=zohoarc; b=iEbV3nRdbze1iaWC9Bi0VdZYKT9VuXaBAHjcIjrxgumQ19Px2lH7o9AGYmEBVUnmyMTswUep99FenHv8AgUiIjqdX5yFVnOuH//g9zD3yWWQ25UtyP68MXT+xe7QuSTa5fgv3V3Q2pgvlEIxfdXudc5EK9DoaJxBeCmnG9cswtI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172458; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7WON7HcT99RPILN4S/fXQmxUWCY7IAO9j/BEnR/e9Rk=; b=A/Wv85z2sbfi9NDEefbkssW1YISGP9OKbZUOrS/VMYPK4b+wxNfo9WNIrpMLFZNc2REZOvT1DUm6+xvf2tSO5wbeYjgDz658D5qxyUI/KLozsmZlgaQ6oSlXh4ffNNGyL+2iN/R0q3BiB3XeI1kVFXe3zrj5D17jDyZyRGBLWjQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172458; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=7WON7HcT99RPILN4S/fXQmxUWCY7IAO9j/BEnR/e9Rk=; b=TJDahQ471ksXIh7COU4z2Ehik+4pldgZHNeI1hmJ8gIW0aOzZekM0f6vNIcn1czw IFk21Dz6aPHTg/dBxIyS9g3eCDLI1Mzekh5CBb4WI0YqHGI+0NRaQZz0cFyDKuyxjIB 7EAaPR0Pld9NOCReQUlb/EwYrZolMLdGLbF2d4yo= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v3 3/7] xsm: refactor xsm_ops handling Date: Thu, 5 Aug 2021 10:06:40 -0400 Message-Id: <20210805140644.357-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172514968100003 Content-Type: text/plain; charset="utf-8" This renames the `struct xsm_operations` to the shorter `struct xsm_ops` and converts the global xsm_ops from being a pointer to an explicit instance. As part of this conversion, it reworks the XSM modules init function to return their xsm_ops struct which is copied in to the global xsm_ops instance. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 221 +++++++++++++++++++++--------------------- xen/xsm/dummy.c | 4 +- xen/xsm/flask/hooks.c | 12 +-- xen/xsm/silo.c | 7 +- xen/xsm/xsm_core.c | 72 +++++++------- 5 files changed, 161 insertions(+), 155 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index ad3cddbf7d..aefca46c30 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -43,7 +43,7 @@ enum xsm_default { }; typedef enum xsm_default xsm_default_t; =20 -struct xsm_operations { +struct xsm_ops { void (*security_domaininfo) (struct domain *d, struct xen_domctl_getdomaininfo *i= nfo); int (*domain_create) (struct domain *d, u32 ssidref); @@ -191,295 +191,295 @@ struct xsm_operations { =20 #ifdef CONFIG_XSM =20 -extern struct xsm_operations *xsm_ops; +extern struct xsm_ops xsm_ops; =20 #ifndef XSM_NO_WRAPPERS =20 static inline void xsm_security_domaininfo (struct domain *d, struct xen_domctl_getdomaininfo *i= nfo) { - xsm_ops->security_domaininfo(d, info); + xsm_ops.security_domaininfo(d, info); } =20 static inline int xsm_domain_create (xsm_default_t def, struct domain *d, = u32 ssidref) { - return xsm_ops->domain_create(d, ssidref); + return xsm_ops.domain_create(d, ssidref); } =20 static inline int xsm_getdomaininfo (xsm_default_t def, struct domain *d) { - return xsm_ops->getdomaininfo(d); + return xsm_ops.getdomaininfo(d); } =20 static inline int xsm_domctl_scheduler_op (xsm_default_t def, struct domai= n *d, int cmd) { - return xsm_ops->domctl_scheduler_op(d, cmd); + return xsm_ops.domctl_scheduler_op(d, cmd); } =20 static inline int xsm_sysctl_scheduler_op (xsm_default_t def, int cmd) { - return xsm_ops->sysctl_scheduler_op(cmd); + return xsm_ops.sysctl_scheduler_op(cmd); } =20 static inline int xsm_set_target (xsm_default_t def, struct domain *d, str= uct domain *e) { - return xsm_ops->set_target(d, e); + return xsm_ops.set_target(d, e); } =20 static inline int xsm_domctl (xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->domctl(d, cmd); + return xsm_ops.domctl(d, cmd); } =20 static inline int xsm_sysctl (xsm_default_t def, int cmd) { - return xsm_ops->sysctl(cmd); + return xsm_ops.sysctl(cmd); } =20 static inline int xsm_readconsole (xsm_default_t def, uint32_t clear) { - return xsm_ops->readconsole(clear); + return xsm_ops.readconsole(clear); } =20 static inline int xsm_evtchn_unbound (xsm_default_t def, struct domain *d1= , struct evtchn *chn, domid_= t id2) { - return xsm_ops->evtchn_unbound(d1, chn, id2); + return xsm_ops.evtchn_unbound(d1, chn, id2); } =20 static inline int xsm_evtchn_interdomain (xsm_default_t def, struct domain= *d1, struct evtchn *chan1, struct domain *d2, struct evtchn *ch= an2) { - return xsm_ops->evtchn_interdomain(d1, chan1, d2, chan2); + return xsm_ops.evtchn_interdomain(d1, chan1, d2, chan2); } =20 static inline void xsm_evtchn_close_post (struct evtchn *chn) { - xsm_ops->evtchn_close_post(chn); + xsm_ops.evtchn_close_post(chn); } =20 static inline int xsm_evtchn_send (xsm_default_t def, struct domain *d, st= ruct evtchn *chn) { - return xsm_ops->evtchn_send(d, chn); + return xsm_ops.evtchn_send(d, chn); } =20 static inline int xsm_evtchn_status (xsm_default_t def, struct domain *d, = struct evtchn *chn) { - return xsm_ops->evtchn_status(d, chn); + return xsm_ops.evtchn_status(d, chn); } =20 static inline int xsm_evtchn_reset (xsm_default_t def, struct domain *d1, = struct domain *d2) { - return xsm_ops->evtchn_reset(d1, d2); + return xsm_ops.evtchn_reset(d1, d2); } =20 static inline int xsm_grant_mapref (xsm_default_t def, struct domain *d1, = struct domain *d2, uint32_t f= lags) { - return xsm_ops->grant_mapref(d1, d2, flags); + return xsm_ops.grant_mapref(d1, d2, flags); } =20 static inline int xsm_grant_unmapref (xsm_default_t def, struct domain *d1= , struct domain *d2) { - return xsm_ops->grant_unmapref(d1, d2); + return xsm_ops.grant_unmapref(d1, d2); } =20 static inline int xsm_grant_setup (xsm_default_t def, struct domain *d1, s= truct domain *d2) { - return xsm_ops->grant_setup(d1, d2); + return xsm_ops.grant_setup(d1, d2); } =20 static inline int xsm_grant_transfer (xsm_default_t def, struct domain *d1= , struct domain *d2) { - return xsm_ops->grant_transfer(d1, d2); + return xsm_ops.grant_transfer(d1, d2); } =20 static inline int xsm_grant_copy (xsm_default_t def, struct domain *d1, st= ruct domain *d2) { - return xsm_ops->grant_copy(d1, d2); + return xsm_ops.grant_copy(d1, d2); } =20 static inline int xsm_grant_query_size (xsm_default_t def, struct domain *= d1, struct domain *d2) { - return xsm_ops->grant_query_size(d1, d2); + return xsm_ops.grant_query_size(d1, d2); } =20 static inline int xsm_alloc_security_domain (struct domain *d) { - return xsm_ops->alloc_security_domain(d); + return xsm_ops.alloc_security_domain(d); } =20 static inline void xsm_free_security_domain (struct domain *d) { - xsm_ops->free_security_domain(d); + xsm_ops.free_security_domain(d); } =20 static inline int xsm_alloc_security_evtchns( struct evtchn chn[], unsigned int nr) { - return xsm_ops->alloc_security_evtchns(chn, nr); + return xsm_ops.alloc_security_evtchns(chn, nr); } =20 static inline void xsm_free_security_evtchns( struct evtchn chn[], unsigned int nr) { - xsm_ops->free_security_evtchns(chn, nr); + xsm_ops.free_security_evtchns(chn, nr); } =20 static inline char *xsm_show_security_evtchn (struct domain *d, const stru= ct evtchn *chn) { - return xsm_ops->show_security_evtchn(d, chn); + return xsm_ops.show_security_evtchn(d, chn); } =20 static inline int xsm_init_hardware_domain (xsm_default_t def, struct doma= in *d) { - return xsm_ops->init_hardware_domain(d); + return xsm_ops.init_hardware_domain(d); } =20 static inline int xsm_get_pod_target (xsm_default_t def, struct domain *d) { - return xsm_ops->get_pod_target(d); + return xsm_ops.get_pod_target(d); } =20 static inline int xsm_set_pod_target (xsm_default_t def, struct domain *d) { - return xsm_ops->set_pod_target(d); + return xsm_ops.set_pod_target(d); } =20 static inline int xsm_memory_exchange (xsm_default_t def, struct domain *d) { - return xsm_ops->memory_exchange(d); + return xsm_ops.memory_exchange(d); } =20 static inline int xsm_memory_adjust_reservation (xsm_default_t def, struct= domain *d1, struct domain= *d2) { - return xsm_ops->memory_adjust_reservation(d1, d2); + return xsm_ops.memory_adjust_reservation(d1, d2); } =20 static inline int xsm_memory_stat_reservation (xsm_default_t def, struct d= omain *d1, struct domain = *d2) { - return xsm_ops->memory_stat_reservation(d1, d2); + return xsm_ops.memory_stat_reservation(d1, d2); } =20 static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1= , struct domain *d2, struct page_info *page) { - return xsm_ops->memory_pin_page(d1, d2, page); + return xsm_ops.memory_pin_page(d1, d2, page); } =20 static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1,= struct domain *d2) { - return xsm_ops->add_to_physmap(d1, d2); + return xsm_ops.add_to_physmap(d1, d2); } =20 static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain= *d1, struct domain *d2) { - return xsm_ops->remove_from_physmap(d1, d2); + return xsm_ops.remove_from_physmap(d1, d2); } =20 static inline int xsm_map_gmfn_foreign (xsm_default_t def, struct domain *= d, struct domain *t) { - return xsm_ops->map_gmfn_foreign(d, t); + return xsm_ops.map_gmfn_foreign(d, t); } =20 static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) { - return xsm_ops->claim_pages(d); + return xsm_ops.claim_pages(d); } =20 static inline int xsm_console_io (xsm_default_t def, struct domain *d, int= cmd) { - return xsm_ops->console_io(d, cmd); + return xsm_ops.console_io(d, cmd); } =20 static inline int xsm_profile (xsm_default_t def, struct domain *d, int op) { - return xsm_ops->profile(d, op); + return xsm_ops.profile(d, op); } =20 static inline int xsm_kexec (xsm_default_t def) { - return xsm_ops->kexec(); + return xsm_ops.kexec(); } =20 static inline int xsm_schedop_shutdown (xsm_default_t def, struct domain *= d1, struct domain *d2) { - return xsm_ops->schedop_shutdown(d1, d2); + return xsm_ops.schedop_shutdown(d1, d2); } =20 static inline char *xsm_show_irq_sid (int irq) { - return xsm_ops->show_irq_sid(irq); + return xsm_ops.show_irq_sid(irq); } =20 static inline int xsm_map_domain_pirq (xsm_default_t def, struct domain *d) { - return xsm_ops->map_domain_pirq(d); + return xsm_ops.map_domain_pirq(d); } =20 static inline int xsm_map_domain_irq (xsm_default_t def, struct domain *d,= int irq, void *data) { - return xsm_ops->map_domain_irq(d, irq, data); + return xsm_ops.map_domain_irq(d, irq, data); } =20 static inline int xsm_unmap_domain_pirq (xsm_default_t def, struct domain = *d) { - return xsm_ops->unmap_domain_pirq(d); + return xsm_ops.unmap_domain_pirq(d); } =20 static inline int xsm_unmap_domain_irq (xsm_default_t def, struct domain *= d, int irq, void *data) { - return xsm_ops->unmap_domain_irq(d, irq, data); + return xsm_ops.unmap_domain_irq(d, irq, data); } =20 static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops->bind_pt_irq(d, bind); + return xsm_ops.bind_pt_irq(d, bind); } =20 static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops->unbind_pt_irq(d, bind); + return xsm_ops.unbind_pt_irq(d, bind); } =20 static inline int xsm_irq_permission (xsm_default_t def, struct domain *d,= int pirq, uint8_t allow) { - return xsm_ops->irq_permission(d, pirq, allow); + return xsm_ops.irq_permission(d, pirq, allow); } =20 static inline int xsm_iomem_permission (xsm_default_t def, struct domain *= d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops->iomem_permission(d, s, e, allow); + return xsm_ops.iomem_permission(d, s, e, allow); } =20 static inline int xsm_iomem_mapping (xsm_default_t def, struct domain *d, = uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops->iomem_mapping(d, s, e, allow); + return xsm_ops.iomem_mapping(d, s, e, allow); } =20 static inline int xsm_pci_config_permission (xsm_default_t def, struct dom= ain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access) { - return xsm_ops->pci_config_permission(d, machine_bdf, start, end, acce= ss); + return xsm_ops.pci_config_permission(d, machine_bdf, start, end, acces= s); } =20 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine= _bdf) { - return xsm_ops->get_device_group(machine_bdf); + return xsm_ops.get_device_group(machine_bdf); } =20 static inline int xsm_assign_device(xsm_default_t def, struct domain *d, u= int32_t machine_bdf) { - return xsm_ops->assign_device(d, machine_bdf); + return xsm_ops.assign_device(d, machine_bdf); } =20 static inline int xsm_deassign_device(xsm_default_t def, struct domain *d,= uint32_t machine_bdf) { - return xsm_ops->deassign_device(d, machine_bdf); + return xsm_ops.deassign_device(d, machine_bdf); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ =20 @@ -487,240 +487,240 @@ static inline int xsm_deassign_device(xsm_default_t= def, struct domain *d, uint3 static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops->assign_dtdevice(d, dtpath); + return xsm_ops.assign_dtdevice(d, dtpath); } =20 static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *= d, const char *dtpath) { - return xsm_ops->deassign_dtdevice(d, dtpath); + return xsm_ops.deassign_dtdevice(d, dtpath); } =20 #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ =20 static inline int xsm_resource_plug_pci (xsm_default_t def, uint32_t machi= ne_bdf) { - return xsm_ops->resource_plug_pci(machine_bdf); + return xsm_ops.resource_plug_pci(machine_bdf); } =20 static inline int xsm_resource_unplug_pci (xsm_default_t def, uint32_t mac= hine_bdf) { - return xsm_ops->resource_unplug_pci(machine_bdf); + return xsm_ops.resource_unplug_pci(machine_bdf); } =20 static inline int xsm_resource_plug_core (xsm_default_t def) { - return xsm_ops->resource_plug_core(); + return xsm_ops.resource_plug_core(); } =20 static inline int xsm_resource_unplug_core (xsm_default_t def) { - return xsm_ops->resource_unplug_core(); + return xsm_ops.resource_unplug_core(); } =20 static inline int xsm_resource_setup_pci (xsm_default_t def, uint32_t mach= ine_bdf) { - return xsm_ops->resource_setup_pci(machine_bdf); + return xsm_ops.resource_setup_pci(machine_bdf); } =20 static inline int xsm_resource_setup_gsi (xsm_default_t def, int gsi) { - return xsm_ops->resource_setup_gsi(gsi); + return xsm_ops.resource_setup_gsi(gsi); } =20 static inline int xsm_resource_setup_misc (xsm_default_t def) { - return xsm_ops->resource_setup_misc(); + return xsm_ops.resource_setup_misc(); } =20 static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) { - return xsm_ops->page_offline(cmd); + return xsm_ops.page_offline(cmd); } =20 static inline int xsm_hypfs_op(xsm_default_t def) { - return xsm_ops->hypfs_op(); + return xsm_ops.hypfs_op(); } =20 static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) { - return xsm_ops->do_xsm_op(op); + return xsm_ops.do_xsm_op(op); } =20 #ifdef CONFIG_COMPAT static inline int xsm_do_compat_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) { - return xsm_ops->do_compat_op(op); + return xsm_ops.do_compat_op(op); } #endif =20 static inline int xsm_hvm_param (xsm_default_t def, struct domain *d, unsi= gned long op) { - return xsm_ops->hvm_param(d, op); + return xsm_ops.hvm_param(d, op); } =20 static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, uns= igned long op) { - return xsm_ops->hvm_control(d, op); + return xsm_ops.hvm_control(d, op); } =20 static inline int xsm_hvm_param_altp2mhvm (xsm_default_t def, struct domai= n *d) { - return xsm_ops->hvm_param_altp2mhvm(d); + return xsm_ops.hvm_param_altp2mhvm(d); } =20 static inline int xsm_hvm_altp2mhvm_op (xsm_default_t def, struct domain *= d, uint64_t mode, uint32_t op) { - return xsm_ops->hvm_altp2mhvm_op(d, mode, op); + return xsm_ops.hvm_altp2mhvm_op(d, mode, op); } =20 static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d) { - return xsm_ops->get_vnumainfo(d); + return xsm_ops.get_vnumainfo(d); } =20 static inline int xsm_vm_event_control (xsm_default_t def, struct domain *= d, int mode, int op) { - return xsm_ops->vm_event_control(d, mode, op); + return xsm_ops.vm_event_control(d, mode, op); } =20 #ifdef CONFIG_MEM_ACCESS static inline int xsm_mem_access (xsm_default_t def, struct domain *d) { - return xsm_ops->mem_access(d); + return xsm_ops.mem_access(d); } #endif =20 #ifdef CONFIG_MEM_PAGING static inline int xsm_mem_paging (xsm_default_t def, struct domain *d) { - return xsm_ops->mem_paging(d); + return xsm_ops.mem_paging(d); } #endif =20 #ifdef CONFIG_MEM_SHARING static inline int xsm_mem_sharing (xsm_default_t def, struct domain *d) { - return xsm_ops->mem_sharing(d); + return xsm_ops.mem_sharing(d); } #endif =20 static inline int xsm_platform_op (xsm_default_t def, uint32_t op) { - return xsm_ops->platform_op(op); + return xsm_ops.platform_op(op); } =20 #ifdef CONFIG_X86 static inline int xsm_do_mca(xsm_default_t def) { - return xsm_ops->do_mca(); + return xsm_ops.do_mca(); } =20 static inline int xsm_shadow_control (xsm_default_t def, struct domain *d,= uint32_t op) { - return xsm_ops->shadow_control(d, op); + return xsm_ops.shadow_control(d, op); } =20 static inline int xsm_mem_sharing_op (xsm_default_t def, struct domain *d,= struct domain *cd, int op) { - return xsm_ops->mem_sharing_op(d, cd, op); + return xsm_ops.mem_sharing_op(d, cd, op); } =20 static inline int xsm_apic (xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->apic(d, cmd); + return xsm_ops.apic(d, cmd); } =20 static inline int xsm_memtype (xsm_default_t def, uint32_t access) { - return xsm_ops->memtype(access); + return xsm_ops.memtype(access); } =20 static inline int xsm_machine_memory_map(xsm_default_t def) { - return xsm_ops->machine_memory_map(); + return xsm_ops.machine_memory_map(); } =20 static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *= d) { - return xsm_ops->domain_memory_map(d); + return xsm_ops.domain_memory_map(d); } =20 static inline int xsm_mmu_update (xsm_default_t def, struct domain *d, str= uct domain *t, struct domain *f, uint32_t flags) { - return xsm_ops->mmu_update(d, t, f, flags); + return xsm_ops.mmu_update(d, t, f, flags); } =20 static inline int xsm_mmuext_op (xsm_default_t def, struct domain *d, stru= ct domain *f) { - return xsm_ops->mmuext_op(d, f); + return xsm_ops.mmuext_op(d, f); } =20 static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *= d, struct domain *f, l1_pgentry_t p= te) { - return xsm_ops->update_va_mapping(d, f, pte); + return xsm_ops.update_va_mapping(d, f, pte); } =20 static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, st= ruct domain *t) { - return xsm_ops->priv_mapping(d, t); + return xsm_ops.priv_mapping(d, t); } =20 static inline int xsm_ioport_permission (xsm_default_t def, struct domain = *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops->ioport_permission(d, s, e, allow); + return xsm_ops.ioport_permission(d, s, e, allow); } =20 static inline int xsm_ioport_mapping (xsm_default_t def, struct domain *d,= uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops->ioport_mapping(d, s, e, allow); + return xsm_ops.ioport_mapping(d, s, e, allow); } =20 static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigne= d int op) { - return xsm_ops->pmu_op(d, op); + return xsm_ops.pmu_op(d, op); } =20 #endif /* CONFIG_X86 */ =20 static inline int xsm_dm_op(xsm_default_t def, struct domain *d) { - return xsm_ops->dm_op(d); + return xsm_ops.dm_op(d); } =20 static inline int xsm_xen_version (xsm_default_t def, uint32_t op) { - return xsm_ops->xen_version(op); + return xsm_ops.xen_version(op); } =20 static inline int xsm_domain_resource_map(xsm_default_t def, struct domain= *d) { - return xsm_ops->domain_resource_map(d); + return xsm_ops.domain_resource_map(d); } =20 #ifdef CONFIG_ARGO static inline int xsm_argo_enable(const struct domain *d) { - return xsm_ops->argo_enable(d); + return xsm_ops.argo_enable(d); } =20 static inline int xsm_argo_register_single_source(const struct domain *d, const struct domain *t) { - return xsm_ops->argo_register_single_source(d, t); + return xsm_ops.argo_register_single_source(d, t); } =20 static inline int xsm_argo_register_any_source(const struct domain *d) { - return xsm_ops->argo_register_any_source(d); + return xsm_ops.argo_register_any_source(d); } =20 static inline int xsm_argo_send(const struct domain *d, const struct domai= n *t) { - return xsm_ops->argo_send(d, t); + return xsm_ops.argo_send(d, t); } =20 #endif /* CONFIG_ARGO */ @@ -747,16 +747,16 @@ extern int xsm_dt_policy_init(void **policy_buffer, s= ize_t *policy_size); extern bool has_xsm_magic(paddr_t); #endif =20 -extern int register_xsm(struct xsm_operations *ops); - -extern struct xsm_operations dummy_xsm_ops; -extern void xsm_fixup_ops(struct xsm_operations *ops); +extern void xsm_fixup_ops(struct xsm_ops *ops); =20 #ifdef CONFIG_XSM_FLASK -extern void flask_init(const void *policy_buffer, size_t policy_size); +extern const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size); #else -static inline void flask_init(const void *policy_buffer, size_t policy_siz= e) +static inline struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size) { + return NULL; } #endif =20 @@ -766,9 +766,12 @@ extern const unsigned int xsm_flask_init_policy_size; #endif =20 #ifdef CONFIG_XSM_SILO -extern void silo_init(void); +extern const struct xsm_ops *silo_init(void); #else -static inline void silo_init(void) {} +static inline struct xsm_ops *silo_init(void) +{ + return NULL; +} #endif =20 #else /* CONFIG_XSM */ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index de44b10130..d8c935328e 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -13,15 +13,13 @@ #define XSM_NO_WRAPPERS #include =20 -struct xsm_operations dummy_xsm_ops; - #define set_to_dummy_if_null(ops, function) \ do { \ if ( !ops->function ) \ ops->function =3D xsm_##function; \ } while (0) =20 -void __init xsm_fixup_ops (struct xsm_operations *ops) +void __init xsm_fixup_ops (struct xsm_ops *ops) { set_to_dummy_if_null(ops, security_domaininfo); set_to_dummy_if_null(ops, domain_create); diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index f1a1217c98..c1f31d8e4a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1745,7 +1745,7 @@ static int flask_argo_send(const struct domain *d, co= nst struct domain *t) long do_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op); int compat_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op); =20 -static struct xsm_operations flask_ops =3D { +static const struct xsm_ops __initconst flask_ops =3D { .security_domaininfo =3D flask_security_domaininfo, .domain_create =3D flask_domain_create, .getdomaininfo =3D flask_getdomaininfo, @@ -1883,7 +1883,8 @@ static struct xsm_operations flask_ops =3D { #endif }; =20 -void __init flask_init(const void *policy_buffer, size_t policy_size) +const struct xsm_ops *__init flask_init(const void *policy_buffer, + size_t policy_size) { int ret =3D -ENOENT; =20 @@ -1891,7 +1892,7 @@ void __init flask_init(const void *policy_buffer, siz= e_t policy_size) { case FLASK_BOOTPARAM_DISABLED: printk(XENLOG_INFO "Flask: Disabled at boot.\n"); - return; + return NULL; =20 case FLASK_BOOTPARAM_PERMISSIVE: flask_enforcing =3D 0; @@ -1908,9 +1909,6 @@ void __init flask_init(const void *policy_buffer, siz= e_t policy_size) =20 avc_init(); =20 - if ( register_xsm(&flask_ops) ) - panic("Flask: Unable to register with XSM\n"); - if ( policy_size && flask_bootparam !=3D FLASK_BOOTPARAM_LATELOAD ) ret =3D security_load_policy(policy_buffer, policy_size); =20 @@ -1923,6 +1921,8 @@ void __init flask_init(const void *policy_buffer, siz= e_t policy_size) printk(XENLOG_INFO "Flask: Starting in enforcing mode.\n"); else printk(XENLOG_INFO "Flask: Starting in permissive mode.\n"); + + return &flask_ops; } =20 /* diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index fc2ca5cd2d..3a2dea13fe 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -100,7 +100,7 @@ static int silo_argo_send(const struct domain *d1, cons= t struct domain *d2) =20 #endif =20 -static struct xsm_operations silo_xsm_ops =3D { +static const struct xsm_ops __initconst silo_xsm_ops =3D { .evtchn_unbound =3D silo_evtchn_unbound, .evtchn_interdomain =3D silo_evtchn_interdomain, .grant_mapref =3D silo_grant_mapref, @@ -112,12 +112,11 @@ static struct xsm_operations silo_xsm_ops =3D { #endif }; =20 -void __init silo_init(void) +const struct xsm_ops *__init silo_init(void) { printk("Initialising XSM SILO mode\n"); =20 - if ( register_xsm(&silo_xsm_ops) ) - panic("SILO: Unable to register with XSM\n"); + return &silo_xsm_ops; } =20 /* diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 5eab21e1b1..b5219dff78 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -28,9 +28,17 @@ #include #endif =20 -#define XSM_FRAMEWORK_VERSION "1.0.0" +#define XSM_FRAMEWORK_VERSION "1.0.1" =20 -struct xsm_operations *xsm_ops; +struct xsm_ops xsm_ops; + +enum xsm_ops_state { + XSM_OPS_UNREGISTERED, + XSM_OPS_REG_FAILED, + XSM_OPS_REGISTERED, +}; + +static enum xsm_ops_state xsm_ops_registered =3D XSM_OPS_UNREGISTERED; =20 enum xsm_bootparam { XSM_BOOTPARAM_DUMMY, @@ -68,17 +76,10 @@ static int __init parse_xsm_param(const char *s) } custom_param("xsm", parse_xsm_param); =20 -static inline int verify(struct xsm_operations *ops) -{ - /* verify the security_operations structure exists */ - if ( !ops ) - return -EINVAL; - xsm_fixup_ops(ops); - return 0; -} - static int __init xsm_core_init(const void *policy_buffer, size_t policy_s= ize) { + const struct xsm_ops *ops =3D NULL; + #ifdef CONFIG_XSM_FLASK_POLICY if ( policy_size =3D=3D 0 ) { @@ -87,25 +88,35 @@ static int __init xsm_core_init(const void *policy_buff= er, size_t policy_size) } #endif =20 - if ( verify(&dummy_xsm_ops) ) + if ( xsm_ops_registered !=3D XSM_OPS_UNREGISTERED ) { - printk(XENLOG_ERR "Could not verify dummy_xsm_ops structure\n"); + printk(XENLOG_ERR + "Could not init XSM, xsm_ops register already attempted\n"); return -EIO; } =20 - xsm_ops =3D &dummy_xsm_ops; - switch ( xsm_bootparam ) { case XSM_BOOTPARAM_DUMMY: + xsm_ops_registered =3D XSM_OPS_REGISTERED; break; =20 case XSM_BOOTPARAM_FLASK: - flask_init(policy_buffer, policy_size); + ops =3D flask_init(policy_buffer, policy_size); + if ( ops ) + { + xsm_ops_registered =3D XSM_OPS_REGISTERED; + xsm_ops =3D *ops; + } break; =20 case XSM_BOOTPARAM_SILO: - silo_init(); + ops =3D silo_init(); + if ( ops ) + { + xsm_ops_registered =3D XSM_OPS_REGISTERED; + xsm_ops =3D *ops; + } break; =20 default: @@ -113,6 +124,17 @@ static int __init xsm_core_init(const void *policy_buf= fer, size_t policy_size) break; } =20 + /* + * This handles three cases, + * - dummy policy module was selected + * - a policy module does not provide all handlers + * - a policy module failed to init + */ + xsm_fixup_ops(&xsm_ops); + + if ( xsm_ops_registered !=3D XSM_OPS_REGISTERED ) + xsm_ops_registered =3D XSM_OPS_REG_FAILED; + return 0; } =20 @@ -195,22 +217,6 @@ bool __init has_xsm_magic(paddr_t start) } #endif =20 -int __init register_xsm(struct xsm_operations *ops) -{ - if ( verify(ops) ) - { - printk(XENLOG_ERR "Could not verify xsm_operations structure\n"); - return -EINVAL; - } - - if ( xsm_ops !=3D &dummy_xsm_ops ) - return -EAGAIN; - - xsm_ops =3D ops; - - return 0; -} - #endif =20 long do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172518; cv=pass; d=zohomail.com; s=zohoarc; b=ckYbXqIY6fYhC7Aoo+eaGv7lc+p5yo8/3GmTX+WiFrht37H0QjC/Fqze0K63iE+HV1E20ZtV/SjwL3RyCtwuB3N/Il4PiExvnxQ/I4Y+NfQLyb5eEmmRsjqioolv3RYPOSzJCyY2xdJSJHRisu2YPDek5QCsDefgfK0O67rsdgk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172518; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NtvoeQYWOhnYbx5fcCjmz9fQL9ZSlw45KedPaunTMSQ=; b=ivOI+hq+BzvaeMx8fkQUNsiAeVoyqlmhAk+3ZnoZXpBDkPp1k5+jNkfd5x4pECFa2mPfMqEe8CLUKWEz2S8MAKaqRUQ9+WhPwDwgOl5/rgHr2+2Hj5dsv1KoiCidtNw8PeHIpChkjjfJmGnGy5GD5Xq7kZ0E+pEbdKGoRpC4vpg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1628172518407911.2152471147944; Thu, 5 Aug 2021 07:08:38 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164267.300541 (Exim 4.92) (envelope-from ) id 1mBe2p-0003Ic-5F; Thu, 05 Aug 2021 14:08:23 +0000 Received: by outflank-mailman (output) from mailman id 164267.300541; Thu, 05 Aug 2021 14:08:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2p-0003IN-1T; Thu, 05 Aug 2021 14:08:23 +0000 Received: by outflank-mailman (input) for mailman id 164267; Thu, 05 Aug 2021 14:08:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2o-0003EW-HW for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:08:22 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 94f5ee20-f5f6-11eb-9c12-12813bfff9fa; Thu, 05 Aug 2021 14:08:18 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1628172448491141.0208042737005; Thu, 5 Aug 2021 07:07:28 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94f5ee20-f5f6-11eb-9c12-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1628172459; cv=none; d=zohomail.com; s=zohoarc; b=RPpjRzlNOPUKiv3yZClCZtyGXp1gkFC1C1WaugGgpjrZEZxt3MS3Y//S5VBbo2DXy4iY6tFszrTSKI287YSw9Gcz4OY6nqjgC/1InKSRn3HeZww821SAnQqlZBcekdjf0WXOstTexEzkxmo5up/Lzt1deMWNzC/uMi0vDmXYfqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172459; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NtvoeQYWOhnYbx5fcCjmz9fQL9ZSlw45KedPaunTMSQ=; b=JeZfVsRshvEpCkhZaP00sZFn2yBGXvxJZ5rEOTYvl35LoV7y+g3Oo9yh8bDLOeW4PA30YyYh/sR/IMPGXQqAxRRiCIXwajC9Ih3yBbayOEKdstjSF2tqbFbieT8M2VBDekU4g39PhyRNc00r4zfBKGq5E8UmhZ8SvSFNjqTlVM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172459; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=NtvoeQYWOhnYbx5fcCjmz9fQL9ZSlw45KedPaunTMSQ=; b=GAdv3OcM/POkuYMB09rU66yLRbgThr0iISrfBOGQJPohe9AhKWzQE+aWdyo967D3 mxkmbKy72i7MV0dBzlCvwStjqiAW18d/i/aVFVT58vsyYjZ5FyVVFJsyLReXeuHVdHD j82igmAphGdgOpp1Rv2WM45YtxCjAQ647qCq5XxE= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Daniel De Graaf Subject: [PATCH v3 4/7] xsm: convert xsm_ops hook calls to alternative call Date: Thu, 5 Aug 2021 10:06:41 -0400 Message-Id: <20210805140644.357-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172519962100001 Content-Type: text/plain; charset="utf-8" To reduce retpolines convert all the pointer function calls of the xsm_ops hooks over to the alternative_call infrastructure. Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper --- xen/include/xsm/xsm.h | 193 +++++++++++++++++++++--------------------- 1 file changed, 97 insertions(+), 96 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index aefca46c30..6a54ee883c 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -15,6 +15,7 @@ #ifndef __XSM_H__ #define __XSM_H__ =20 +#include #include #include =20 @@ -198,288 +199,288 @@ extern struct xsm_ops xsm_ops; static inline void xsm_security_domaininfo (struct domain *d, struct xen_domctl_getdomaininfo *i= nfo) { - xsm_ops.security_domaininfo(d, info); + alternative_vcall(xsm_ops.security_domaininfo, d, info); } =20 static inline int xsm_domain_create (xsm_default_t def, struct domain *d, = u32 ssidref) { - return xsm_ops.domain_create(d, ssidref); + return alternative_call(xsm_ops.domain_create, d, ssidref); } =20 static inline int xsm_getdomaininfo (xsm_default_t def, struct domain *d) { - return xsm_ops.getdomaininfo(d); + return alternative_call(xsm_ops.getdomaininfo, d); } =20 static inline int xsm_domctl_scheduler_op (xsm_default_t def, struct domai= n *d, int cmd) { - return xsm_ops.domctl_scheduler_op(d, cmd); + return alternative_call(xsm_ops.domctl_scheduler_op, d, cmd); } =20 static inline int xsm_sysctl_scheduler_op (xsm_default_t def, int cmd) { - return xsm_ops.sysctl_scheduler_op(cmd); + return alternative_call(xsm_ops.sysctl_scheduler_op, cmd); } =20 static inline int xsm_set_target (xsm_default_t def, struct domain *d, str= uct domain *e) { - return xsm_ops.set_target(d, e); + return alternative_call(xsm_ops.set_target, d, e); } =20 static inline int xsm_domctl (xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.domctl(d, cmd); + return alternative_call(xsm_ops.domctl, d, cmd); } =20 static inline int xsm_sysctl (xsm_default_t def, int cmd) { - return xsm_ops.sysctl(cmd); + return alternative_call(xsm_ops.sysctl, cmd); } =20 static inline int xsm_readconsole (xsm_default_t def, uint32_t clear) { - return xsm_ops.readconsole(clear); + return alternative_call(xsm_ops.readconsole, clear); } =20 static inline int xsm_evtchn_unbound (xsm_default_t def, struct domain *d1= , struct evtchn *chn, domid_= t id2) { - return xsm_ops.evtchn_unbound(d1, chn, id2); + return alternative_call(xsm_ops.evtchn_unbound, d1, chn, id2); } =20 static inline int xsm_evtchn_interdomain (xsm_default_t def, struct domain= *d1, struct evtchn *chan1, struct domain *d2, struct evtchn *ch= an2) { - return xsm_ops.evtchn_interdomain(d1, chan1, d2, chan2); + return alternative_call(xsm_ops.evtchn_interdomain, d1, chan1, d2, cha= n2); } =20 static inline void xsm_evtchn_close_post (struct evtchn *chn) { - xsm_ops.evtchn_close_post(chn); + alternative_vcall(xsm_ops.evtchn_close_post, chn); } =20 static inline int xsm_evtchn_send (xsm_default_t def, struct domain *d, st= ruct evtchn *chn) { - return xsm_ops.evtchn_send(d, chn); + return alternative_call(xsm_ops.evtchn_send, d, chn); } =20 static inline int xsm_evtchn_status (xsm_default_t def, struct domain *d, = struct evtchn *chn) { - return xsm_ops.evtchn_status(d, chn); + return alternative_call(xsm_ops.evtchn_status, d, chn); } =20 static inline int xsm_evtchn_reset (xsm_default_t def, struct domain *d1, = struct domain *d2) { - return xsm_ops.evtchn_reset(d1, d2); + return alternative_call(xsm_ops.evtchn_reset, d1, d2); } =20 static inline int xsm_grant_mapref (xsm_default_t def, struct domain *d1, = struct domain *d2, uint32_t f= lags) { - return xsm_ops.grant_mapref(d1, d2, flags); + return alternative_call(xsm_ops.grant_mapref, d1, d2, flags); } =20 static inline int xsm_grant_unmapref (xsm_default_t def, struct domain *d1= , struct domain *d2) { - return xsm_ops.grant_unmapref(d1, d2); + return alternative_call(xsm_ops.grant_unmapref, d1, d2); } =20 static inline int xsm_grant_setup (xsm_default_t def, struct domain *d1, s= truct domain *d2) { - return xsm_ops.grant_setup(d1, d2); + return alternative_call(xsm_ops.grant_setup, d1, d2); } =20 static inline int xsm_grant_transfer (xsm_default_t def, struct domain *d1= , struct domain *d2) { - return xsm_ops.grant_transfer(d1, d2); + return alternative_call(xsm_ops.grant_transfer, d1, d2); } =20 static inline int xsm_grant_copy (xsm_default_t def, struct domain *d1, st= ruct domain *d2) { - return xsm_ops.grant_copy(d1, d2); + return alternative_call(xsm_ops.grant_copy, d1, d2); } =20 static inline int xsm_grant_query_size (xsm_default_t def, struct domain *= d1, struct domain *d2) { - return xsm_ops.grant_query_size(d1, d2); + return alternative_call(xsm_ops.grant_query_size, d1, d2); } =20 static inline int xsm_alloc_security_domain (struct domain *d) { - return xsm_ops.alloc_security_domain(d); + return alternative_call(xsm_ops.alloc_security_domain, d); } =20 static inline void xsm_free_security_domain (struct domain *d) { - xsm_ops.free_security_domain(d); + alternative_vcall(xsm_ops.free_security_domain, d); } =20 static inline int xsm_alloc_security_evtchns( struct evtchn chn[], unsigned int nr) { - return xsm_ops.alloc_security_evtchns(chn, nr); + return alternative_call(xsm_ops.alloc_security_evtchns, chn, nr); } =20 static inline void xsm_free_security_evtchns( struct evtchn chn[], unsigned int nr) { - xsm_ops.free_security_evtchns(chn, nr); + alternative_vcall(xsm_ops.free_security_evtchns, chn, nr); } =20 static inline char *xsm_show_security_evtchn (struct domain *d, const stru= ct evtchn *chn) { - return xsm_ops.show_security_evtchn(d, chn); + return alternative_call(xsm_ops.show_security_evtchn, d, chn); } =20 static inline int xsm_init_hardware_domain (xsm_default_t def, struct doma= in *d) { - return xsm_ops.init_hardware_domain(d); + return alternative_call(xsm_ops.init_hardware_domain, d); } =20 static inline int xsm_get_pod_target (xsm_default_t def, struct domain *d) { - return xsm_ops.get_pod_target(d); + return alternative_call(xsm_ops.get_pod_target, d); } =20 static inline int xsm_set_pod_target (xsm_default_t def, struct domain *d) { - return xsm_ops.set_pod_target(d); + return alternative_call(xsm_ops.set_pod_target, d); } =20 static inline int xsm_memory_exchange (xsm_default_t def, struct domain *d) { - return xsm_ops.memory_exchange(d); + return alternative_call(xsm_ops.memory_exchange, d); } =20 static inline int xsm_memory_adjust_reservation (xsm_default_t def, struct= domain *d1, struct domain= *d2) { - return xsm_ops.memory_adjust_reservation(d1, d2); + return alternative_call(xsm_ops.memory_adjust_reservation, d1, d2); } =20 static inline int xsm_memory_stat_reservation (xsm_default_t def, struct d= omain *d1, struct domain = *d2) { - return xsm_ops.memory_stat_reservation(d1, d2); + return alternative_call(xsm_ops.memory_stat_reservation, d1, d2); } =20 static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1= , struct domain *d2, struct page_info *page) { - return xsm_ops.memory_pin_page(d1, d2, page); + return alternative_call(xsm_ops.memory_pin_page, d1, d2, page); } =20 static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1,= struct domain *d2) { - return xsm_ops.add_to_physmap(d1, d2); + return alternative_call(xsm_ops.add_to_physmap, d1, d2); } =20 static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain= *d1, struct domain *d2) { - return xsm_ops.remove_from_physmap(d1, d2); + return alternative_call(xsm_ops.remove_from_physmap, d1, d2); } =20 static inline int xsm_map_gmfn_foreign (xsm_default_t def, struct domain *= d, struct domain *t) { - return xsm_ops.map_gmfn_foreign(d, t); + return alternative_call(xsm_ops.map_gmfn_foreign, d, t); } =20 static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) { - return xsm_ops.claim_pages(d); + return alternative_call(xsm_ops.claim_pages, d); } =20 static inline int xsm_console_io (xsm_default_t def, struct domain *d, int= cmd) { - return xsm_ops.console_io(d, cmd); + return alternative_call(xsm_ops.console_io, d, cmd); } =20 static inline int xsm_profile (xsm_default_t def, struct domain *d, int op) { - return xsm_ops.profile(d, op); + return alternative_call(xsm_ops.profile, d, op); } =20 static inline int xsm_kexec (xsm_default_t def) { - return xsm_ops.kexec(); + return alternative_call(xsm_ops.kexec); } =20 static inline int xsm_schedop_shutdown (xsm_default_t def, struct domain *= d1, struct domain *d2) { - return xsm_ops.schedop_shutdown(d1, d2); + return alternative_call(xsm_ops.schedop_shutdown, d1, d2); } =20 static inline char *xsm_show_irq_sid (int irq) { - return xsm_ops.show_irq_sid(irq); + return alternative_call(xsm_ops.show_irq_sid, irq); } =20 static inline int xsm_map_domain_pirq (xsm_default_t def, struct domain *d) { - return xsm_ops.map_domain_pirq(d); + return alternative_call(xsm_ops.map_domain_pirq, d); } =20 static inline int xsm_map_domain_irq (xsm_default_t def, struct domain *d,= int irq, void *data) { - return xsm_ops.map_domain_irq(d, irq, data); + return alternative_call(xsm_ops.map_domain_irq, d, irq, data); } =20 static inline int xsm_unmap_domain_pirq (xsm_default_t def, struct domain = *d) { - return xsm_ops.unmap_domain_pirq(d); + return alternative_call(xsm_ops.unmap_domain_pirq, d); } =20 static inline int xsm_unmap_domain_irq (xsm_default_t def, struct domain *= d, int irq, void *data) { - return xsm_ops.unmap_domain_irq(d, irq, data); + return alternative_call(xsm_ops.unmap_domain_irq, d, irq, data); } =20 static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops.bind_pt_irq(d, bind); + return alternative_call(xsm_ops.bind_pt_irq, d, bind); } =20 static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops.unbind_pt_irq(d, bind); + return alternative_call(xsm_ops.unbind_pt_irq, d, bind); } =20 static inline int xsm_irq_permission (xsm_default_t def, struct domain *d,= int pirq, uint8_t allow) { - return xsm_ops.irq_permission(d, pirq, allow); + return alternative_call(xsm_ops.irq_permission, d, pirq, allow); } =20 static inline int xsm_iomem_permission (xsm_default_t def, struct domain *= d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops.iomem_permission(d, s, e, allow); + return alternative_call(xsm_ops.iomem_permission, d, s, e, allow); } =20 static inline int xsm_iomem_mapping (xsm_default_t def, struct domain *d, = uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops.iomem_mapping(d, s, e, allow); + return alternative_call(xsm_ops.iomem_mapping, d, s, e, allow); } =20 static inline int xsm_pci_config_permission (xsm_default_t def, struct dom= ain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access) { - return xsm_ops.pci_config_permission(d, machine_bdf, start, end, acces= s); + return alternative_call(xsm_ops.pci_config_permission, d, machine_bdf,= start, end, access); } =20 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine= _bdf) { - return xsm_ops.get_device_group(machine_bdf); + return alternative_call(xsm_ops.get_device_group, machine_bdf); } =20 static inline int xsm_assign_device(xsm_default_t def, struct domain *d, u= int32_t machine_bdf) { - return xsm_ops.assign_device(d, machine_bdf); + return alternative_call(xsm_ops.assign_device, d, machine_bdf); } =20 static inline int xsm_deassign_device(xsm_default_t def, struct domain *d,= uint32_t machine_bdf) { - return xsm_ops.deassign_device(d, machine_bdf); + return alternative_call(xsm_ops.deassign_device, d, machine_bdf); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ =20 @@ -487,60 +488,60 @@ static inline int xsm_deassign_device(xsm_default_t d= ef, struct domain *d, uint3 static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops.assign_dtdevice(d, dtpath); + return alternative_call(xsm_ops.assign_dtdevice, d, dtpath); } =20 static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *= d, const char *dtpath) { - return xsm_ops.deassign_dtdevice(d, dtpath); + return alternative_call(xsm_ops.deassign_dtdevice, d, dtpath); } =20 #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ =20 static inline int xsm_resource_plug_pci (xsm_default_t def, uint32_t machi= ne_bdf) { - return xsm_ops.resource_plug_pci(machine_bdf); + return alternative_call(xsm_ops.resource_plug_pci, machine_bdf); } =20 static inline int xsm_resource_unplug_pci (xsm_default_t def, uint32_t mac= hine_bdf) { - return xsm_ops.resource_unplug_pci(machine_bdf); + return alternative_call(xsm_ops.resource_unplug_pci, machine_bdf); } =20 static inline int xsm_resource_plug_core (xsm_default_t def) { - return xsm_ops.resource_plug_core(); + return alternative_call(xsm_ops.resource_plug_core); } =20 static inline int xsm_resource_unplug_core (xsm_default_t def) { - return xsm_ops.resource_unplug_core(); + return alternative_call(xsm_ops.resource_unplug_core); } =20 static inline int xsm_resource_setup_pci (xsm_default_t def, uint32_t mach= ine_bdf) { - return xsm_ops.resource_setup_pci(machine_bdf); + return alternative_call(xsm_ops.resource_setup_pci, machine_bdf); } =20 static inline int xsm_resource_setup_gsi (xsm_default_t def, int gsi) { - return xsm_ops.resource_setup_gsi(gsi); + return alternative_call(xsm_ops.resource_setup_gsi, gsi); } =20 static inline int xsm_resource_setup_misc (xsm_default_t def) { - return xsm_ops.resource_setup_misc(); + return alternative_call(xsm_ops.resource_setup_misc); } =20 static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) { - return xsm_ops.page_offline(cmd); + return alternative_call(xsm_ops.page_offline, cmd); } =20 static inline int xsm_hypfs_op(xsm_default_t def) { - return xsm_ops.hypfs_op(); + return alternative_call(xsm_ops.hypfs_op); } =20 static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) @@ -557,105 +558,105 @@ static inline int xsm_do_compat_op (XEN_GUEST_HANDL= E_PARAM(xsm_op_t) op) =20 static inline int xsm_hvm_param (xsm_default_t def, struct domain *d, unsi= gned long op) { - return xsm_ops.hvm_param(d, op); + return alternative_call(xsm_ops.hvm_param, d, op); } =20 static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, uns= igned long op) { - return xsm_ops.hvm_control(d, op); + return alternative_call(xsm_ops.hvm_control, d, op); } =20 static inline int xsm_hvm_param_altp2mhvm (xsm_default_t def, struct domai= n *d) { - return xsm_ops.hvm_param_altp2mhvm(d); + return alternative_call(xsm_ops.hvm_param_altp2mhvm, d); } =20 static inline int xsm_hvm_altp2mhvm_op (xsm_default_t def, struct domain *= d, uint64_t mode, uint32_t op) { - return xsm_ops.hvm_altp2mhvm_op(d, mode, op); + return alternative_call(xsm_ops.hvm_altp2mhvm_op, d, mode, op); } =20 static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d) { - return xsm_ops.get_vnumainfo(d); + return alternative_call(xsm_ops.get_vnumainfo, d); } =20 static inline int xsm_vm_event_control (xsm_default_t def, struct domain *= d, int mode, int op) { - return xsm_ops.vm_event_control(d, mode, op); + return alternative_call(xsm_ops.vm_event_control, d, mode, op); } =20 #ifdef CONFIG_MEM_ACCESS static inline int xsm_mem_access (xsm_default_t def, struct domain *d) { - return xsm_ops.mem_access(d); + return alternative_call(xsm_ops.mem_access, d); } #endif =20 #ifdef CONFIG_MEM_PAGING static inline int xsm_mem_paging (xsm_default_t def, struct domain *d) { - return xsm_ops.mem_paging(d); + return alternative_call(xsm_ops.mem_paging, d); } #endif =20 #ifdef CONFIG_MEM_SHARING static inline int xsm_mem_sharing (xsm_default_t def, struct domain *d) { - return xsm_ops.mem_sharing(d); + return alternative_call(xsm_ops.mem_sharing, d); } #endif =20 static inline int xsm_platform_op (xsm_default_t def, uint32_t op) { - return xsm_ops.platform_op(op); + return alternative_call(xsm_ops.platform_op, op); } =20 #ifdef CONFIG_X86 static inline int xsm_do_mca(xsm_default_t def) { - return xsm_ops.do_mca(); + return alternative_call(xsm_ops.do_mca); } =20 static inline int xsm_shadow_control (xsm_default_t def, struct domain *d,= uint32_t op) { - return xsm_ops.shadow_control(d, op); + return alternative_call(xsm_ops.shadow_control, d, op); } =20 static inline int xsm_mem_sharing_op (xsm_default_t def, struct domain *d,= struct domain *cd, int op) { - return xsm_ops.mem_sharing_op(d, cd, op); + return alternative_call(xsm_ops.mem_sharing_op, d, cd, op); } =20 static inline int xsm_apic (xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.apic(d, cmd); + return alternative_call(xsm_ops.apic, d, cmd); } =20 static inline int xsm_memtype (xsm_default_t def, uint32_t access) { - return xsm_ops.memtype(access); + return alternative_call(xsm_ops.memtype, access); } =20 static inline int xsm_machine_memory_map(xsm_default_t def) { - return xsm_ops.machine_memory_map(); + return alternative_call(xsm_ops.machine_memory_map); } =20 static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *= d) { - return xsm_ops.domain_memory_map(d); + return alternative_call(xsm_ops.domain_memory_map, d); } =20 static inline int xsm_mmu_update (xsm_default_t def, struct domain *d, str= uct domain *t, struct domain *f, uint32_t flags) { - return xsm_ops.mmu_update(d, t, f, flags); + return alternative_call(xsm_ops.mmu_update, d, t, f, flags); } =20 static inline int xsm_mmuext_op (xsm_default_t def, struct domain *d, stru= ct domain *f) { - return xsm_ops.mmuext_op(d, f); + return alternative_call(xsm_ops.mmuext_op, d, f); } =20 static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *= d, struct domain *f, @@ -666,61 +667,61 @@ static inline int xsm_update_va_mapping(xsm_default_t= def, struct domain *d, str =20 static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, st= ruct domain *t) { - return xsm_ops.priv_mapping(d, t); + return alternative_call(xsm_ops.priv_mapping, d, t); } =20 static inline int xsm_ioport_permission (xsm_default_t def, struct domain = *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops.ioport_permission(d, s, e, allow); + return alternative_call(xsm_ops.ioport_permission, d, s, e, allow); } =20 static inline int xsm_ioport_mapping (xsm_default_t def, struct domain *d,= uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops.ioport_mapping(d, s, e, allow); + return alternative_call(xsm_ops.ioport_mapping, d, s, e, allow); } =20 static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigne= d int op) { - return xsm_ops.pmu_op(d, op); + return alternative_call(xsm_ops.pmu_op, d, op); } =20 #endif /* CONFIG_X86 */ =20 static inline int xsm_dm_op(xsm_default_t def, struct domain *d) { - return xsm_ops.dm_op(d); + return alternative_call(xsm_ops.dm_op, d); } =20 static inline int xsm_xen_version (xsm_default_t def, uint32_t op) { - return xsm_ops.xen_version(op); + return alternative_call(xsm_ops.xen_version, op); } =20 static inline int xsm_domain_resource_map(xsm_default_t def, struct domain= *d) { - return xsm_ops.domain_resource_map(d); + return alternative_call(xsm_ops.domain_resource_map, d); } =20 #ifdef CONFIG_ARGO static inline int xsm_argo_enable(const struct domain *d) { - return xsm_ops.argo_enable(d); + return alternative_call(xsm_ops.argo_enable, d); } =20 static inline int xsm_argo_register_single_source(const struct domain *d, const struct domain *t) { - return xsm_ops.argo_register_single_source(d, t); + return alternative_call(xsm_ops.argo_register_single_source, d, t); } =20 static inline int xsm_argo_register_any_source(const struct domain *d) { - return xsm_ops.argo_register_any_source(d); + return alternative_call(xsm_ops.argo_register_any_source, d); } =20 static inline int xsm_argo_send(const struct domain *d, const struct domai= n *t) { - return xsm_ops.argo_send(d, t); + return alternative_call(xsm_ops.argo_send, d, t); } =20 #endif /* CONFIG_ARGO */ --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172528; cv=pass; d=zohomail.com; s=zohoarc; b=j+AU6SgsgF3XONp5TeySaVztEAGZupWWAgKypW1SCjlgW8lzlfyiTNrJJO2HO6u0Fu36Ot2iWeKz5GHx/LOEOw74P+OoCMvdz7QjrdijMAYxd65m5MuVTac+85UnjmcWkexUsRl8VrUeodSZznRNChFPlkI7NuqymEW5ePkvsJU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172528; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OsJ56cAFTIRJaLZzm10Zbl6V8Iu59lcLFE8LvnXHX0Q=; b=jQhYrhrwZwoyM5oLXg0clQ1eWgdsf7EEiRwYGRGWXQnvHlNPn/cyB5d/C/yugivBjg1A0ctl3OoEzLW4LiLPbKRt9Uy+EYN1KjpuuV0mqOmc50uGedJ+b58EZrwZVBfHuJAmaFqSd0rvoc/M0v1hVmQUr10P9KfSLAP/syATn68= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 162817252874228.871449715066774; Thu, 5 Aug 2021 07:08:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164270.300553 (Exim 4.92) (envelope-from ) id 1mBe2w-0003il-DZ; Thu, 05 Aug 2021 14:08:30 +0000 Received: by outflank-mailman (output) from mailman id 164270.300553; Thu, 05 Aug 2021 14:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2w-0003iX-AI; Thu, 05 Aug 2021 14:08:30 +0000 Received: by outflank-mailman (input) for mailman id 164270; Thu, 05 Aug 2021 14:08:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe2v-0003hf-IP for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:08:29 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9a3e2bd6-f5f6-11eb-9c12-12813bfff9fa; Thu, 05 Aug 2021 14:08:27 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1628172449431990.6205406548489; Thu, 5 Aug 2021 07:07:29 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a3e2bd6-f5f6-11eb-9c12-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1628172460; cv=none; d=zohomail.com; s=zohoarc; b=aRvE5GeE/mjvWRGEYn5eDptPa9DT6SSCPeEq2emdruFNL1StLFOLzXq/jr4p0w32OfK0NzWV5YeaB8jD1N5IY71sqVRuEX971xkkVdwu/RIRfxcMhQQMUvlt+Qo3DRepUBt9Ze99gvekJaPxrSeWbMuGDb0E3TVyqL212/Liij4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172460; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OsJ56cAFTIRJaLZzm10Zbl6V8Iu59lcLFE8LvnXHX0Q=; b=PeQRpegv7BwhRehtQ6X+HGF/Lvo6k02r6P6UgN5h3kt2AmFUAv0d0A9cTu9QUwIt/AYGcHkKh5heIIJ3rqv4M3a54CPWFse/pVapVmMjPOmbb+IBQRktVjoUPLfOiXOEsXPXegqztWrpqI5CUNgwI4nCxco3j/BsIJ1H5pTw87w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172460; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=OsJ56cAFTIRJaLZzm10Zbl6V8Iu59lcLFE8LvnXHX0Q=; b=m/DElJ99YkAbnlaau6lMZtUnM4DfB0uJmlXbGIBJndi+TsuJkUrw53fZsKBrkhh3 aJdtAy7sxaUA8DyEUUylzqpNZ6jWpc7TY+zhcfruaN1yErwJhTdrKcU7rJWIGK58vYg KPVotNnb/lazidCuddYZhl1GR+9VqlKF44zIi//I= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v3 5/7] xsm: decouple xsm header inclusion selection Date: Thu, 5 Aug 2021 10:06:42 -0400 Message-Id: <20210805140644.357-6-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172530458100001 Content-Type: text/plain; charset="utf-8" Multiple preprocessor defines were used as a mechanism to selective include parts of the xsm.h header file. This makes it difficult to know which porti= on is being included at any one time. This commit works to simplify this by separating the core structures and functions of XSM into xsm-core.h away fr= om the wrapper functions which remain in xsm.h and dummy.h. Signed-off-by: Daniel P. Smith Acked-by: Jan Beulich --- xen/include/xsm/dummy.h | 2 +- xen/include/xsm/xsm-core.h | 273 +++++++++++++++++++++++++++++++++++++ xen/include/xsm/xsm.h | 243 +-------------------------------- xen/xsm/dummy.c | 1 - xen/xsm/silo.c | 1 - 5 files changed, 275 insertions(+), 245 deletions(-) create mode 100644 xen/include/xsm/xsm-core.h diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 363c6d7798..c445c5681b 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -16,7 +16,7 @@ */ =20 #include -#include +#include #include =20 /* Cannot use BUILD_BUG_ON here because the expressions we check are not diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h new file mode 100644 index 0000000000..49b00d688c --- /dev/null +++ b/xen/include/xsm/xsm-core.h @@ -0,0 +1,273 @@ +/* + * This file contains the XSM hook definitions for Xen. + * + * This work is based on the LSM implementation in Linux 2.6.13.4. + * + * Author: George Coker, + * + * Contributors: Michael LeMay, + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, + * as published by the Free Software Foundation. + */ + +#ifndef __XSM_CORE_H__ +#define __XSM_CORE_H__ + +#include +#include + +typedef void xsm_op_t; +DEFINE_XEN_GUEST_HANDLE(xsm_op_t); + +/* policy magic number (defined by XSM_MAGIC) */ +typedef uint32_t xsm_magic_t; + +#ifdef CONFIG_XSM_FLASK +#define XSM_MAGIC 0xf97cff8c +#else +#define XSM_MAGIC 0x0 +#endif + +/* These annotations are used by callers and in dummy.h to document the + * default actions of XSM hooks. They should be compiled out otherwise. + */ +enum xsm_default { + XSM_HOOK, /* Guests can normally access the hypercall */ + XSM_DM_PRIV, /* Device model can perform on its target domain */ + XSM_TARGET, /* Can perform on self or your target domain */ + XSM_PRIV, /* Privileged - normally restricted to dom0 */ + XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations */ + XSM_OTHER /* Something more complex */ +}; +typedef enum xsm_default xsm_default_t; + +struct xsm_ops { + void (*security_domaininfo) (struct domain *d, + struct xen_domctl_getdomaininfo *info); + int (*domain_create) (struct domain *d, uint32_t ssidref); + int (*getdomaininfo) (struct domain *d); + int (*domctl_scheduler_op) (struct domain *d, int op); + int (*sysctl_scheduler_op) (int op); + int (*set_target) (struct domain *d, struct domain *e); + int (*domctl) (struct domain *d, int cmd); + int (*sysctl) (int cmd); + int (*readconsole) (uint32_t clear); + + int (*evtchn_unbound) (struct domain *d, struct evtchn *chn, domid_t i= d2); + int (*evtchn_interdomain) (struct domain *d1, struct evtchn *chn1, + struct domain *d2, struct evtchn *chn2); + void (*evtchn_close_post) (struct evtchn *chn); + int (*evtchn_send) (struct domain *d, struct evtchn *chn); + int (*evtchn_status) (struct domain *d, struct evtchn *chn); + int (*evtchn_reset) (struct domain *d1, struct domain *d2); + + int (*grant_mapref) (struct domain *d1, struct domain *d2, uint32_t fl= ags); + int (*grant_unmapref) (struct domain *d1, struct domain *d2); + int (*grant_setup) (struct domain *d1, struct domain *d2); + int (*grant_transfer) (struct domain *d1, struct domain *d2); + int (*grant_copy) (struct domain *d1, struct domain *d2); + int (*grant_query_size) (struct domain *d1, struct domain *d2); + + int (*alloc_security_domain) (struct domain *d); + void (*free_security_domain) (struct domain *d); + int (*alloc_security_evtchns) (struct evtchn chn[], unsigned int nr); + void (*free_security_evtchns) (struct evtchn chn[], unsigned int nr); + char *(*show_security_evtchn) (struct domain *d, const struct evtchn *= chn); + int (*init_hardware_domain) (struct domain *d); + + int (*get_pod_target) (struct domain *d); + int (*set_pod_target) (struct domain *d); + int (*memory_exchange) (struct domain *d); + int (*memory_adjust_reservation) (struct domain *d1, struct domain *d2= ); + int (*memory_stat_reservation) (struct domain *d1, struct domain *d2); + int (*memory_pin_page) (struct domain *d1, struct domain *d2, + struct page_info *page); + int (*add_to_physmap) (struct domain *d1, struct domain *d2); + int (*remove_from_physmap) (struct domain *d1, struct domain *d2); + int (*map_gmfn_foreign) (struct domain *d, struct domain *t); + int (*claim_pages) (struct domain *d); + + int (*console_io) (struct domain *d, int cmd); + + int (*profile) (struct domain *d, int op); + + int (*kexec) (void); + int (*schedop_shutdown) (struct domain *d1, struct domain *d2); + + char *(*show_irq_sid) (int irq); + int (*map_domain_pirq) (struct domain *d); + int (*map_domain_irq) (struct domain *d, int irq, const void *data); + int (*unmap_domain_pirq) (struct domain *d); + int (*unmap_domain_irq) (struct domain *d, int irq, const void *data); + int (*bind_pt_irq) (struct domain *d, struct xen_domctl_bind_pt_irq *b= ind); + int (*unbind_pt_irq) (struct domain *d, + struct xen_domctl_bind_pt_irq *bind); + int (*irq_permission) (struct domain *d, int pirq, uint8_t allow); + int (*iomem_permission) (struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*iomem_mapping) (struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*pci_config_permission) (struct domain *d, uint32_t machine_bdf, + uint16_t start, uint16_t end, uint8_t ac= cess); + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) + int (*get_device_group) (uint32_t machine_bdf); + int (*assign_device) (struct domain *d, uint32_t machine_bdf); + int (*deassign_device) (struct domain *d, uint32_t machine_bdf); +#endif + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) + int (*assign_dtdevice) (struct domain *d, const char *dtpath); + int (*deassign_dtdevice) (struct domain *d, const char *dtpath); +#endif + + int (*resource_plug_core) (void); + int (*resource_unplug_core) (void); + int (*resource_plug_pci) (uint32_t machine_bdf); + int (*resource_unplug_pci) (uint32_t machine_bdf); + int (*resource_setup_pci) (uint32_t machine_bdf); + int (*resource_setup_gsi) (int gsi); + int (*resource_setup_misc) (void); + + int (*page_offline)(uint32_t cmd); + int (*hypfs_op)(void); + + long (*do_xsm_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); +#ifdef CONFIG_COMPAT + int (*do_compat_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); +#endif + + int (*hvm_param) (struct domain *d, unsigned long op); + int (*hvm_control) (struct domain *d, unsigned long op); + int (*hvm_param_altp2mhvm) (struct domain *d); + int (*hvm_altp2mhvm_op) (struct domain *d, uint64_t mode, uint32_t op); + int (*get_vnumainfo) (struct domain *d); + + int (*vm_event_control) (struct domain *d, int mode, int op); + +#ifdef CONFIG_MEM_ACCESS + int (*mem_access) (struct domain *d); +#endif + +#ifdef CONFIG_MEM_PAGING + int (*mem_paging) (struct domain *d); +#endif + +#ifdef CONFIG_MEM_SHARING + int (*mem_sharing) (struct domain *d); +#endif + + int (*platform_op) (uint32_t cmd); + +#ifdef CONFIG_X86 + int (*do_mca) (void); + int (*shadow_control) (struct domain *d, uint32_t op); + int (*mem_sharing_op) (struct domain *d, struct domain *cd, int op); + int (*apic) (struct domain *d, int cmd); + int (*memtype) (uint32_t access); + int (*machine_memory_map) (void); + int (*domain_memory_map) (struct domain *d); +#define XSM_MMU_UPDATE_READ 1 +#define XSM_MMU_UPDATE_WRITE 2 +#define XSM_MMU_NORMAL_UPDATE 4 +#define XSM_MMU_MACHPHYS_UPDATE 8 + int (*mmu_update) (struct domain *d, struct domain *t, + struct domain *f, uint32_t flags); + int (*mmuext_op) (struct domain *d, struct domain *f); + int (*update_va_mapping) (struct domain *d, struct domain *f, + l1_pgentry_t pte); + int (*priv_mapping) (struct domain *d, struct domain *t); + int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*pmu_op) (struct domain *d, unsigned int op); +#endif + int (*dm_op) (struct domain *d); + int (*xen_version) (uint32_t cmd); + int (*domain_resource_map) (struct domain *d); +#ifdef CONFIG_ARGO + int (*argo_enable) (const struct domain *d); + int (*argo_register_single_source) (const struct domain *d, + const struct domain *t); + int (*argo_register_any_source) (const struct domain *d); + int (*argo_send) (const struct domain *d, const struct domain *t); +#endif +}; + +extern void xsm_fixup_ops(struct xsm_ops *ops); + +#ifdef CONFIG_XSM + +#ifdef CONFIG_MULTIBOOT +extern int xsm_multiboot_init(unsigned long *module_map, + const multiboot_info_t *mbi); +extern int xsm_multiboot_policy_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void **policy_buffer, + size_t *policy_size); +#endif + +#ifdef CONFIG_HAS_DEVICE_TREE +/* + * Initialize XSM + * + * On success, return 1 if using SILO mode else 0. + */ +extern int xsm_dt_init(void); +extern int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); +extern bool has_xsm_magic(paddr_t); +#endif + +#ifdef CONFIG_XSM_FLASK +extern const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size); +#else +static inline const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size) +{ + return NULL; +} +#endif + +#ifdef CONFIG_XSM_FLASK_POLICY +extern const unsigned char xsm_flask_init_policy[]; +extern const unsigned int xsm_flask_init_policy_size; +#endif + +#ifdef CONFIG_XSM_SILO +extern const struct xsm_ops *silo_init(void); +#else +static const inline struct xsm_ops *silo_init(void) +{ + return NULL; +} +#endif + +#else /* CONFIG_XSM */ + +#ifdef CONFIG_MULTIBOOT +static inline int xsm_multiboot_init (unsigned long *module_map, + const multiboot_info_t *mbi) +{ + return 0; +} +#endif + +#ifdef CONFIG_HAS_DEVICE_TREE +static inline int xsm_dt_init(void) +{ + return 0; +} + +static inline bool has_xsm_magic(paddr_t start) +{ + return false; +} +#endif /* CONFIG_HAS_DEVICE_TREE */ + +#endif /* CONFIG_XSM */ + +#endif /* __XSM_CORE_H */ diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 6a54ee883c..673b818ac7 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -18,184 +18,12 @@ #include #include #include - -typedef void xsm_op_t; -DEFINE_XEN_GUEST_HANDLE(xsm_op_t); - -/* policy magic number (defined by XSM_MAGIC) */ -typedef u32 xsm_magic_t; - -#ifdef CONFIG_XSM_FLASK -#define XSM_MAGIC 0xf97cff8c -#else -#define XSM_MAGIC 0x0 -#endif - -/* These annotations are used by callers and in dummy.h to document the - * default actions of XSM hooks. They should be compiled out otherwise. - */ -enum xsm_default { - XSM_HOOK, /* Guests can normally access the hypercall */ - XSM_DM_PRIV, /* Device model can perform on its target domain */ - XSM_TARGET, /* Can perform on self or your target domain */ - XSM_PRIV, /* Privileged - normally restricted to dom0 */ - XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations */ - XSM_OTHER /* Something more complex */ -}; -typedef enum xsm_default xsm_default_t; - -struct xsm_ops { - void (*security_domaininfo) (struct domain *d, - struct xen_domctl_getdomaininfo *i= nfo); - int (*domain_create) (struct domain *d, u32 ssidref); - int (*getdomaininfo) (struct domain *d); - int (*domctl_scheduler_op) (struct domain *d, int op); - int (*sysctl_scheduler_op) (int op); - int (*set_target) (struct domain *d, struct domain *e); - int (*domctl) (struct domain *d, int cmd); - int (*sysctl) (int cmd); - int (*readconsole) (uint32_t clear); - - int (*evtchn_unbound) (struct domain *d, struct evtchn *chn, domid_t i= d2); - int (*evtchn_interdomain) (struct domain *d1, struct evtchn *chn1, - struct domain *d2, struct evtchn *= chn2); - void (*evtchn_close_post) (struct evtchn *chn); - int (*evtchn_send) (struct domain *d, struct evtchn *chn); - int (*evtchn_status) (struct domain *d, struct evtchn *chn); - int (*evtchn_reset) (struct domain *d1, struct domain *d2); - - int (*grant_mapref) (struct domain *d1, struct domain *d2, uint32_t fl= ags); - int (*grant_unmapref) (struct domain *d1, struct domain *d2); - int (*grant_setup) (struct domain *d1, struct domain *d2); - int (*grant_transfer) (struct domain *d1, struct domain *d2); - int (*grant_copy) (struct domain *d1, struct domain *d2); - int (*grant_query_size) (struct domain *d1, struct domain *d2); - - int (*alloc_security_domain) (struct domain *d); - void (*free_security_domain) (struct domain *d); - int (*alloc_security_evtchns) (struct evtchn chn[], unsigned int nr); - void (*free_security_evtchns) (struct evtchn chn[], unsigned int nr); - char *(*show_security_evtchn) (struct domain *d, const struct evtchn *= chn); - int (*init_hardware_domain) (struct domain *d); - - int (*get_pod_target) (struct domain *d); - int (*set_pod_target) (struct domain *d); - int (*memory_exchange) (struct domain *d); - int (*memory_adjust_reservation) (struct domain *d1, struct domain *d2= ); - int (*memory_stat_reservation) (struct domain *d1, struct domain *d2); - int (*memory_pin_page) (struct domain *d1, struct domain *d2, struct p= age_info *page); - int (*add_to_physmap) (struct domain *d1, struct domain *d2); - int (*remove_from_physmap) (struct domain *d1, struct domain *d2); - int (*map_gmfn_foreign) (struct domain *d, struct domain *t); - int (*claim_pages) (struct domain *d); - - int (*console_io) (struct domain *d, int cmd); - - int (*profile) (struct domain *d, int op); - - int (*kexec) (void); - int (*schedop_shutdown) (struct domain *d1, struct domain *d2); - - char *(*show_irq_sid) (int irq); - int (*map_domain_pirq) (struct domain *d); - int (*map_domain_irq) (struct domain *d, int irq, const void *data); - int (*unmap_domain_pirq) (struct domain *d); - int (*unmap_domain_irq) (struct domain *d, int irq, const void *data); - int (*bind_pt_irq) (struct domain *d, struct xen_domctl_bind_pt_irq *b= ind); - int (*unbind_pt_irq) (struct domain *d, struct xen_domctl_bind_pt_irq = *bind); - int (*irq_permission) (struct domain *d, int pirq, uint8_t allow); - int (*iomem_permission) (struct domain *d, uint64_t s, uint64_t e, uin= t8_t allow); - int (*iomem_mapping) (struct domain *d, uint64_t s, uint64_t e, uint8_= t allow); - int (*pci_config_permission) (struct domain *d, uint32_t machine_bdf, = uint16_t start, uint16_t end, uint8_t access); - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) - int (*get_device_group) (uint32_t machine_bdf); - int (*assign_device) (struct domain *d, uint32_t machine_bdf); - int (*deassign_device) (struct domain *d, uint32_t machine_bdf); -#endif - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) - int (*assign_dtdevice) (struct domain *d, const char *dtpath); - int (*deassign_dtdevice) (struct domain *d, const char *dtpath); -#endif - - int (*resource_plug_core) (void); - int (*resource_unplug_core) (void); - int (*resource_plug_pci) (uint32_t machine_bdf); - int (*resource_unplug_pci) (uint32_t machine_bdf); - int (*resource_setup_pci) (uint32_t machine_bdf); - int (*resource_setup_gsi) (int gsi); - int (*resource_setup_misc) (void); - - int (*page_offline)(uint32_t cmd); - int (*hypfs_op)(void); - - long (*do_xsm_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); -#ifdef CONFIG_COMPAT - int (*do_compat_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); -#endif - - int (*hvm_param) (struct domain *d, unsigned long op); - int (*hvm_control) (struct domain *d, unsigned long op); - int (*hvm_param_altp2mhvm) (struct domain *d); - int (*hvm_altp2mhvm_op) (struct domain *d, uint64_t mode, uint32_t op); - int (*get_vnumainfo) (struct domain *d); - - int (*vm_event_control) (struct domain *d, int mode, int op); - -#ifdef CONFIG_MEM_ACCESS - int (*mem_access) (struct domain *d); -#endif - -#ifdef CONFIG_MEM_PAGING - int (*mem_paging) (struct domain *d); -#endif - -#ifdef CONFIG_MEM_SHARING - int (*mem_sharing) (struct domain *d); -#endif - - int (*platform_op) (uint32_t cmd); - -#ifdef CONFIG_X86 - int (*do_mca) (void); - int (*shadow_control) (struct domain *d, uint32_t op); - int (*mem_sharing_op) (struct domain *d, struct domain *cd, int op); - int (*apic) (struct domain *d, int cmd); - int (*memtype) (uint32_t access); - int (*machine_memory_map) (void); - int (*domain_memory_map) (struct domain *d); -#define XSM_MMU_UPDATE_READ 1 -#define XSM_MMU_UPDATE_WRITE 2 -#define XSM_MMU_NORMAL_UPDATE 4 -#define XSM_MMU_MACHPHYS_UPDATE 8 - int (*mmu_update) (struct domain *d, struct domain *t, - struct domain *f, uint32_t flags); - int (*mmuext_op) (struct domain *d, struct domain *f); - int (*update_va_mapping) (struct domain *d, struct domain *f, l1_pgent= ry_t pte); - int (*priv_mapping) (struct domain *d, struct domain *t); - int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, ui= nt8_t allow); - int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, uint8= _t allow); - int (*pmu_op) (struct domain *d, unsigned int op); -#endif - int (*dm_op) (struct domain *d); - int (*xen_version) (uint32_t cmd); - int (*domain_resource_map) (struct domain *d); -#ifdef CONFIG_ARGO - int (*argo_enable) (const struct domain *d); - int (*argo_register_single_source) (const struct domain *d, - const struct domain *t); - int (*argo_register_any_source) (const struct domain *d); - int (*argo_send) (const struct domain *d, const struct domain *t); -#endif -}; +#include =20 #ifdef CONFIG_XSM =20 extern struct xsm_ops xsm_ops; =20 -#ifndef XSM_NO_WRAPPERS - static inline void xsm_security_domaininfo (struct domain *d, struct xen_domctl_getdomaininfo *i= nfo) { @@ -726,79 +554,10 @@ static inline int xsm_argo_send(const struct domain *= d, const struct domain *t) =20 #endif /* CONFIG_ARGO */ =20 -#endif /* XSM_NO_WRAPPERS */ - -#ifdef CONFIG_MULTIBOOT -extern int xsm_multiboot_init(unsigned long *module_map, - const multiboot_info_t *mbi); -extern int xsm_multiboot_policy_init(unsigned long *module_map, - const multiboot_info_t *mbi, - void **policy_buffer, - size_t *policy_size); -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -/* - * Initialize XSM - * - * On success, return 1 if using SILO mode else 0. - */ -extern int xsm_dt_init(void); -extern int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); -extern bool has_xsm_magic(paddr_t); -#endif - -extern void xsm_fixup_ops(struct xsm_ops *ops); - -#ifdef CONFIG_XSM_FLASK -extern const struct xsm_ops *flask_init(const void *policy_buffer, - size_t policy_size); -#else -static inline struct xsm_ops *flask_init(const void *policy_buffer, - size_t policy_size) -{ - return NULL; -} -#endif - -#ifdef CONFIG_XSM_FLASK_POLICY -extern const unsigned char xsm_flask_init_policy[]; -extern const unsigned int xsm_flask_init_policy_size; -#endif - -#ifdef CONFIG_XSM_SILO -extern const struct xsm_ops *silo_init(void); -#else -static inline struct xsm_ops *silo_init(void) -{ - return NULL; -} -#endif - #else /* CONFIG_XSM */ =20 #include =20 -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init (unsigned long *module_map, - const multiboot_info_t *mbi) -{ - return 0; -} -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -static inline int xsm_dt_init(void) -{ - return 0; -} - -static inline bool has_xsm_magic(paddr_t start) -{ - return false; -} -#endif /* CONFIG_HAS_DEVICE_TREE */ - #endif /* CONFIG_XSM */ =20 #endif /* __XSM_H */ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index d8c935328e..b848580eaa 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -10,7 +10,6 @@ * as published by the Free Software Foundation. */ =20 -#define XSM_NO_WRAPPERS #include =20 #define set_to_dummy_if_null(ops, function) \ diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index 3a2dea13fe..4ef40bd712 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -17,7 +17,6 @@ * You should have received a copy of the GNU General Public License along= with * this program; If not, see . */ -#define XSM_NO_WRAPPERS #include =20 /* --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172537; cv=pass; d=zohomail.com; s=zohoarc; b=SskT6r9euLPuHAO3/LQUGZFdbUXxWubwCBSfOVyD7sR0Xax51Cn5rND9HBcNvnzNzeIkT2Vysxo0L7dxEMcMqq5hr5LiIwlmb6wmuhRfl1GBf/x0DyEU9PAlrciFNEyAJ47PA1XVzHox4CeUHABkU2ZH+r/3lopLxAY8sdLvK78= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172537; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+34+h6RYBNDx8+NRBy9hHDiKcY7OZY/fR2RxH8zvDwA=; b=PaTGf5TQmcLjdkR4miR2PjmbmZsA5ktisOChunuAFdMohNpSDxQWf8WaEBYgjKHrnpPOPNgTivcf1a/XbTn1/vqqdyzkTZ1KOcaTWkLd4n9JVMgYSwBCqijfic394TbLqBfLSPeZ6Q7Mfo7sXBwC+E1Y3X/gVlCXdQGcUpeH18g= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 162817253768081.33010777715435; Thu, 5 Aug 2021 07:08:57 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164281.300565 (Exim 4.92) (envelope-from ) id 1mBe39-0004Tp-Tr; Thu, 05 Aug 2021 14:08:43 +0000 Received: by outflank-mailman (output) from mailman id 164281.300565; Thu, 05 Aug 2021 14:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe39-0004Te-Pz; Thu, 05 Aug 2021 14:08:43 +0000 Received: by outflank-mailman (input) for mailman id 164281; Thu, 05 Aug 2021 14:08:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe38-0003hf-I3 for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:08:42 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9ff038ee-f5f6-11eb-9c12-12813bfff9fa; Thu, 05 Aug 2021 14:08:36 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1628172450550595.1687159804446; Thu, 5 Aug 2021 07:07:30 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ff038ee-f5f6-11eb-9c12-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1628172466; cv=none; d=zohomail.com; s=zohoarc; b=ZqsvYH/jB604kH1cHhu3g5Uhuuk2zCR0JWdM8wWQPFCIx0UhFYnIvX7fOinzVnHiNmIAtT0b96UwGBC0XxxyTtau+ROPl0c01Dzz1qoZWcZSWJLBNhxecN6H82DeYrwAQD1Msi5Si6s1sY6eCVzzKw9sIri2n/UOjidUVKKQriY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172466; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+34+h6RYBNDx8+NRBy9hHDiKcY7OZY/fR2RxH8zvDwA=; b=GFcK5W/ADbd5NURmbbWRRE0je3r7GRHNpINuzlPDTIKvTaGDU+w40gc7CnoE+owNw/FhppDS+Q8APq/9OIzESVfVg44Br8tEe+7HEss69m12IpQqXw3VojcdCV2dlNZd4BPr2Wo8OD8GzHa/bmiCZt/GH98tkwP9rw98Qu3vM6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172466; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=+34+h6RYBNDx8+NRBy9hHDiKcY7OZY/fR2RxH8zvDwA=; b=EXXD3Gy9Sh2+hMccOagPv8+NVgav7YFbYRX0pTC11x5NSZ/NEHqHNZeeRSGN+ASh gE9no+b6RNMJgngTvFZytKZX9bU/Ichl2A3xShnSMCEqjqq0DE1DI/Q6R4xFKpRmIWj JwVfAziAl48Wv/CzeWznJEgI/+UhT1HSSfw8HAzk= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 6/7] xsm: drop generic event channel labeling exclusion Date: Thu, 5 Aug 2021 10:06:43 -0400 Message-Id: <20210805140644.357-7-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172538537100001 Content-Type: text/plain; charset="utf-8" The internal define flag is not used by any XSM module, removing the #ifdef leaving the generic event channel labeling as always present. Signed-off-by: Daniel P. Smith --- xen/include/xen/sched.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 28146ee404..b089324510 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -120,15 +120,12 @@ struct evtchn unsigned short notify_vcpu_id; /* VCPU for local delivery notification= */ uint32_t fifo_lastq; /* Data for identifying last queue. */ =20 -#ifdef CONFIG_XSM union { -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID /* * If an XSM module needs more space for its event channel context, * this pointer stores the necessary data for the security server. */ void *generic; -#endif #ifdef CONFIG_XSM_FLASK /* * Inlining the contents of the structure for FLASK avoids unneeded @@ -138,7 +135,6 @@ struct evtchn uint32_t flask_sid; #endif } ssid; -#endif } __attribute__((aligned(64))); =20 int evtchn_init(struct domain *d, unsigned int max_port); --=20 2.20.1 From nobody Sat May 4 04:38:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) ARC-Seal: i=2; a=rsa-sha256; t=1628172566; cv=pass; d=zohomail.com; s=zohoarc; b=Wi6QECR9eym4Bbw+qHay3TMK8fFu/qEc5iy6iPWDJDYmJ6cCpQ/to15iYIaq1FHVImTkueWvXwEzUj+jFDizVLRDzhK85cnB+S656uLh+rSqi+3H7CbBK8wEf+nowzDjRGtwI8mwNPo01kALEUAGVLilA+qsF0EEWWScG/rUk7c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172566; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q7jgyJ8ZGFGpTWfi3wABfXyMxTdJNqrYNBaoXvoh/R8=; b=fwl2kgD+BMB/3plswaKjVGchPEKBunBfpQbeymwlz6/bHxs47JiqlAKE/vdjOEopYXEscT/u919naB/9qgcIgTjlWgLQAYmY33O1BlGerUf9MnYvLLEL7vGlvP9y0DX95v9kpRhvuw8pZJCs0H8AYX/W/Azg8xMoS1UUWAdPs9A= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dpsmith@apertussolutions.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=apertussolutions.com) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1628172566356730.3073893354791; Thu, 5 Aug 2021 07:09:26 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.164292.300577 (Exim 4.92) (envelope-from ) id 1mBe3R-0005J2-8E; Thu, 05 Aug 2021 14:09:01 +0000 Received: by outflank-mailman (output) from mailman id 164292.300577; Thu, 05 Aug 2021 14:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe3R-0005Iv-4q; Thu, 05 Aug 2021 14:09:01 +0000 Received: by outflank-mailman (input) for mailman id 164292; Thu, 05 Aug 2021 14:09:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mBe3Q-0004pc-Dr for xen-devel@lists.xenproject.org; Thu, 05 Aug 2021 14:09:00 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 27b45565-39e6-4539-ab91-d932a9758084; Thu, 05 Aug 2021 14:08:53 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1628172452553862.2810177690948; Thu, 5 Aug 2021 07:07:32 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27b45565-39e6-4539-ab91-d932a9758084 ARC-Seal: i=1; a=rsa-sha256; t=1628172467; cv=none; d=zohomail.com; s=zohoarc; b=KTYiIi4o0HTfPDd6ilBumdaFyDSkqFDTALC9EFQEkMc3rmgJnBLB1CTCSWpZgW9253jQ/pYdhpOV+ZXFNykY+q0yIgDDkImLVw6kLXPbLrcF+DYSczM4c0E5g3xy5/37wKoDYqnp9rl0ePj5ikOTg3iUyhKAT7Mh8XKGhcuyHYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628172467; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Q7jgyJ8ZGFGpTWfi3wABfXyMxTdJNqrYNBaoXvoh/R8=; b=ZjQ26eV/PQUQtbLSZwyUNmgyoAQFFOZMCXOnKEVOZu8hAZJr4Wv9nPYK9RM0ovStnz5Hj98XJpnmGqV+JGPrH2mK22sVQRUzR/2n+Tmy8pCePzG2/EbalN4JA5QpPi20rKcUL8Qs02OiXMRcY0IoG95EWPeDkeQw47xc5JjeN6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1628172467; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=Q7jgyJ8ZGFGpTWfi3wABfXyMxTdJNqrYNBaoXvoh/R8=; b=VICtg7xzrTaZHipBo07iTy7hD17rXEOxumRGknr3zLr34VFlqhhe5UcEP2r3ho+J P1dDHtCaxcwoX4UQUBcSYJtPkG92nRMO2ouq8HBMlKqETBDCBjqbEZMBlQ8kapdZHLb 3WdQ9YN00wLWr2Bych2j3CKrn0djuLyBtmM//UgY= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf Subject: [PATCH v3 7/7] xsm: removing facade that XSM can be enabled/disabled Date: Thu, 5 Aug 2021 10:06:44 -0400 Message-Id: <20210805140644.357-8-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210805140644.357-1-dpsmith@apertussolutions.com> References: <20210805140644.357-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-ZohoMail-DKIM: pass (identity dpsmith@apertussolutions.com) X-ZM-MESSAGEID: 1628172567355100001 Content-Type: text/plain; charset="utf-8" The XSM facilities are always in use by Xen with the facade of being able to turn XSM on and off. This option is in fact about allowing the selection of which policies are available and which are used at runtime. To provide this facade a complicated serious of #ifdef's are used to selective include different headers or portions of headers. This series of #ifdef gyrations switches between two different versions of the XSM hook interfaces and their respective backing implementation. All of this is done to provide a minimal size/performance optimization for when alternative policies are disabled. To unwind the #ifdef gyrations a series of changes were necessary, * replace CONFIG_XSM with XSM_CONFIGURABLE to allow visibility of selecting alternate XSM policy modules to those that require it * adjusted CONFIG_XSM_SILO, CONFIG_XSM_FLASK, and the default module selection to sensible defaults * collapsed the "dummy/defualt" XSM interface and implementation with t= he "multiple policy" interface to provide a single inlined implementation that attempts to use a registered hook and falls back to the check fr= om the dummy implementation * the collapse to a single interface broke code relying on the alternate interface, specifically SILO, this was reworked to remove the indirection/abstraction making SILO explicit in its access control decisions * with the change of the XSM hooks to fall back to enforcing the dummy policy, it is no longer necessary to fill NULL entries in the struct xsm_ops returned by an XSM module's init Signed-off-by: Daniel P. Smith --- xen/common/Kconfig | 47 +- xen/include/xsm/dummy.h | 709 +---------------------------- xen/include/xsm/xsm-core.h | 26 -- xen/include/xsm/xsm.h | 904 ++++++++++++++++++++++++++++--------- xen/xsm/Makefile | 3 +- xen/xsm/dummy.c | 157 ------- xen/xsm/silo.c | 15 +- xen/xsm/xsm_core.c | 18 +- 8 files changed, 726 insertions(+), 1153 deletions(-) delete mode 100644 xen/xsm/dummy.c diff --git a/xen/common/Kconfig b/xen/common/Kconfig index ac5491b1cc..3c5980a336 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -200,23 +200,15 @@ config XENOPROF =20 If unsure, say Y. =20 -config XSM - bool "Xen Security Modules support" - default ARM - ---help--- - Enables the security framework known as Xen Security Modules which - allows administrators fine-grained control over a Xen domain and - its capabilities by defining permissible interactions between domains, - the hypervisor itself, and related resources such as memory and - devices. - - If unsure, say N. +config XSM_CONFIGURABLE + bool "Enable Configuring Xen Security Modules" =20 config XSM_FLASK - def_bool y - prompt "FLux Advanced Security Kernel support" - depends on XSM - ---help--- + bool "FLux Advanced Security Kernel support" + default n + depends on XSM_CONFIGURABLE + select XSM_EVTCHN_LABELING + help Enables FLASK (FLux Advanced Security Kernel) as the access control mechanism used by the XSM framework. This provides a mandatory access control framework by which security enforcement, isolation, and @@ -226,10 +218,10 @@ config XSM_FLASK If unsure, say Y. =20 config XSM_FLASK_AVC_STATS - def_bool y - prompt "Maintain statistics on the FLASK access vector cache" if EXPERT + bool "Maintain statistics on the FLASK access vector cache" if EXPERT + default y depends on XSM_FLASK - ---help--- + help Maintain counters on the access vector cache that can be viewed using the FLASK_AVC_CACHESTATS sub-op of the xsm_op hypercall. Disabling this will save a tiny amount of memory and time to update the stats. @@ -240,7 +232,7 @@ config XSM_FLASK_POLICY bool "Compile Xen with a built-in FLASK security policy" default y if "$(XEN_HAS_CHECKPOLICY)" =3D "y" depends on XSM_FLASK - ---help--- + help This includes a default XSM policy in the hypervisor so that the bootloader does not need to load a policy to get sane behavior from an XSM-enabled hypervisor. If this is disabled, a policy must be @@ -253,10 +245,11 @@ config XSM_FLASK_POLICY If unsure, say Y. =20 config XSM_SILO - def_bool y - prompt "SILO support" - depends on XSM - ---help--- + bool "SILO support" + default y if ARM + default n + depends on XSM_CONFIGURABLE + help Enables SILO as the access control mechanism used by the XSM framework. This is not the default module, add boot parameter xsm=3Dsilo to choose it. This will deny any unmediated communication channels (grant tables @@ -265,14 +258,14 @@ config XSM_SILO If unsure, say Y. =20 choice - prompt "Default XSM implementation" - depends on XSM + prompt "Default XSM module" default XSM_SILO_DEFAULT if XSM_SILO && ARM default XSM_FLASK_DEFAULT if XSM_FLASK default XSM_SILO_DEFAULT if XSM_SILO default XSM_DUMMY_DEFAULT + depends on XSM_CONFIGURABLE config XSM_DUMMY_DEFAULT - bool "Match non-XSM behavior" + bool "Classic Dom0 behavior" config XSM_FLASK_DEFAULT bool "FLux Advanced Security Kernel" if XSM_FLASK config XSM_SILO_DEFAULT @@ -282,7 +275,7 @@ endchoice config LATE_HWDOM bool "Dedicated hardware domain" default n - depends on XSM && X86 + depends on XSM_FLASK && X86 ---help--- Allows the creation of a dedicated hardware domain distinct from domain 0 that manages devices without needing access to other diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index c445c5681b..eb8d61216b 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -1,18 +1,11 @@ /* - * Default XSM hooks - IS_PRIV and IS_PRIV_FOR checks + * Default XSM hook check - enforces basic access control decisions * * Author: Daniel De Graaf * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. - * - * - * Each XSM hook implementing an access check should have its first param= eter - * preceded by XSM_DEFAULT_ARG (or use XSM_DEFAULT_VOID if it has no - * arguments). The first non-declaration statement shold be XSM_ASSERT_AC= TION - * with the expected type of the hook, which will either define or check = the - * value of action. */ =20 #include @@ -42,33 +35,8 @@ static inline void __xsm_action_mismatch_detected(void) void __xsm_action_mismatch_detected(void); #endif =20 -#ifdef CONFIG_XSM - -/* In CONFIG_XSM builds, this header file is included from xsm/dummy.c, and - * contains static (not inline) functions compiled to the dummy XSM module. - * There is no xsm_default_t argument available, so the value from the ass= ertion - * is used to initialize the variable. - */ -#define XSM_INLINE __maybe_unused - -#define XSM_DEFAULT_ARG /* */ -#define XSM_DEFAULT_VOID void -#define XSM_ASSERT_ACTION(def) xsm_default_t action =3D def; (void)action - -#else /* CONFIG_XSM */ - -/* In !CONFIG_XSM builds, this header file is included from xsm/xsm.h, and - * contains inline functions for each XSM hook. These functions also perfo= rm - * compile-time checks on the xsm_default_t argument to ensure that the be= havior - * of the dummy XSM module is the same as the behavior with XSM disabled. - */ -#define XSM_INLINE always_inline -#define XSM_DEFAULT_ARG xsm_default_t action, -#define XSM_DEFAULT_VOID xsm_default_t action #define XSM_ASSERT_ACTION(def) LINKER_BUG_ON(def !=3D action) =20 -#endif /* CONFIG_XSM */ - static always_inline int xsm_default_action( xsm_default_t action, struct domain *src, struct domain *target) { @@ -97,678 +65,3 @@ static always_inline int xsm_default_action( return -EPERM; } } - -static XSM_INLINE void xsm_security_domaininfo(struct domain *d, - struct xen_domctl_getdomaininfo *info) -{ - return; -} - -static XSM_INLINE int xsm_domain_create(XSM_DEFAULT_ARG struct domain *d, = u32 ssidref) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_getdomaininfo(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_domctl_scheduler_op(XSM_DEFAULT_ARG struct domai= n *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_sysctl_scheduler_op(XSM_DEFAULT_ARG int cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_set_target(XSM_DEFAULT_ARG struct domain *d, str= uct domain *e) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_domctl(XSM_DEFAULT_ARG struct domain *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( cmd ) - { - case XEN_DOMCTL_ioport_mapping: - case XEN_DOMCTL_memory_mapping: - case XEN_DOMCTL_bind_pt_irq: - case XEN_DOMCTL_unbind_pt_irq: - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - case XEN_DOMCTL_getdomaininfo: - return xsm_default_action(XSM_XS_PRIV, current->domain, d); - default: - return xsm_default_action(XSM_PRIV, current->domain, d); - } -} - -static XSM_INLINE int xsm_sysctl(XSM_DEFAULT_ARG int cmd) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_readconsole(XSM_DEFAULT_ARG uint32_t clear) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_alloc_security_domain(struct domain *d) -{ - return 0; -} - -static XSM_INLINE void xsm_free_security_domain(struct domain *d) -{ - return; -} - -static XSM_INLINE int xsm_grant_mapref(XSM_DEFAULT_ARG struct domain *d1, = struct domain *d2, - uint32_t f= lags) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_unmapref(XSM_DEFAULT_ARG struct domain *d1= , struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_setup(XSM_DEFAULT_ARG struct domain *d1, s= truct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_transfer(XSM_DEFAULT_ARG struct domain *d1= , struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_copy(XSM_DEFAULT_ARG struct domain *d1, st= ruct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_query_size(XSM_DEFAULT_ARG struct domain *= d1, struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_exchange(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_memory_adjust_reservation(XSM_DEFAULT_ARG struct= domain *d1, - struct domain = *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_stat_reservation(XSM_DEFAULT_ARG struct d= omain *d1, struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_console_io(XSM_DEFAULT_ARG struct domain *d, int= cmd) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - if ( d->is_console ) - return xsm_default_action(XSM_HOOK, d, NULL); -#ifdef CONFIG_VERBOSE_DEBUG - if ( cmd =3D=3D CONSOLEIO_write ) - return xsm_default_action(XSM_HOOK, d, NULL); -#endif - return xsm_default_action(XSM_PRIV, d, NULL); -} - -static XSM_INLINE int xsm_profile(XSM_DEFAULT_ARG struct domain *d, int op) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_kexec(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_schedop_shutdown(XSM_DEFAULT_ARG struct domain *= d1, struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_pin_page(XSM_DEFAULT_ARG struct domain *d= 1, struct domain *d2, - struct page_info *page) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_unbound(XSM_DEFAULT_ARG struct domain *d,= struct evtchn *chn, - domid_t id2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_interdomain(XSM_DEFAULT_ARG struct domain= *d1, struct evtchn - *chan1, struct domain *d2, struct evtchn *= chan2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) -{ - return; -} - -static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, st= ruct evtchn *chn) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, = struct evtchn *chn) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, = struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_alloc_security_evtchns( - struct evtchn chn[], unsigned int nr) -{ - return 0; -} - -static XSM_INLINE void xsm_free_security_evtchns( - struct evtchn chn[], unsigned int nr) -{ - return; -} - -static XSM_INLINE char *xsm_show_security_evtchn(struct domain *d, const s= truct evtchn *chn) -{ - return NULL; -} - -static XSM_INLINE int xsm_init_hardware_domain(XSM_DEFAULT_ARG struct doma= in *d) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_get_pod_target(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_set_pod_target(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_get_vnumainfo(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) -static XSM_INLINE int xsm_get_device_group(XSM_DEFAULT_ARG uint32_t machin= e_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_assign_device(XSM_DEFAULT_ARG struct domain *d, = uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d= , uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -#endif /* HAS_PASSTHROUGH && HAS_PCI */ - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) -static XSM_INLINE int xsm_assign_dtdevice(XSM_DEFAULT_ARG struct domain *d, - const char *dtpath) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_deassign_dtdevice(XSM_DEFAULT_ARG struct domain = *d, - const char *dtpath) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -#endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ - -static XSM_INLINE int xsm_resource_plug_core(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_unplug_core(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_plug_pci(XSM_DEFAULT_ARG uint32_t machi= ne_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_unplug_pci(XSM_DEFAULT_ARG uint32_t mac= hine_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_pci(XSM_DEFAULT_ARG uint32_t mach= ine_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_misc(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_page_offline(XSM_DEFAULT_ARG uint32_t cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_hypfs_op(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) -{ - return -ENOSYS; -} - -#ifdef CONFIG_COMPAT -static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) -{ - return -ENOSYS; -} -#endif - -static XSM_INLINE char *xsm_show_irq_sid(int irq) -{ - return NULL; -} - -static XSM_INLINE int xsm_map_domain_pirq(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_map_domain_irq(XSM_DEFAULT_ARG struct domain *d, - int irq, const void *data) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unmap_domain_pirq(XSM_DEFAULT_ARG struct domain = *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_bind_pt_irq(XSM_DEFAULT_ARG struct domain *d, st= ruct xen_domctl_bind_pt_irq *bind) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unbind_pt_irq(XSM_DEFAULT_ARG struct domain *d, = struct xen_domctl_bind_pt_irq *bind) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unmap_domain_irq(XSM_DEFAULT_ARG struct domain *= d, - int irq, const void *data) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_irq_permission(XSM_DEFAULT_ARG struct domain *d,= int pirq, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_iomem_permission(XSM_DEFAULT_ARG struct domain *= d, uint64_t s, uint64_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_iomem_mapping(XSM_DEFAULT_ARG struct domain *d, = uint64_t s, uint64_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_pci_config_permission(XSM_DEFAULT_ARG struct dom= ain *d, uint32_t machine_bdf, - uint16_t start, uint16_t end, - uint8_t access) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1= , struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struct domai= n *d1, struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain *= d, struct domain *t) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, t); -} - -static XSM_INLINE int xsm_hvm_param(XSM_DEFAULT_ARG struct domain *d, unsi= gned long op) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_control(XSM_DEFAULT_ARG struct domain *d, un= signed long op) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_param_altp2mhvm(XSM_DEFAULT_ARG struct domai= n *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_altp2mhvm_op(XSM_DEFAULT_ARG struct domain *= d, uint64_t mode, uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - - switch ( mode ) - { - case XEN_ALTP2M_mixed: - return xsm_default_action(XSM_TARGET, current->domain, d); - case XEN_ALTP2M_external: - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - case XEN_ALTP2M_limited: - if ( HVMOP_altp2m_vcpu_enable_notify =3D=3D op ) - return xsm_default_action(XSM_TARGET, current->domain, d); - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - default: - return -EPERM; - } -} - -static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *= d, int mode, int op) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -#ifdef CONFIG_MEM_ACCESS -static XSM_INLINE int xsm_mem_access(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -#ifdef CONFIG_MEM_PAGING -static XSM_INLINE int xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -#ifdef CONFIG_MEM_SHARING -static XSM_INLINE int xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -static XSM_INLINE int xsm_platform_op(XSM_DEFAULT_ARG uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -#ifdef CONFIG_X86 -static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_shadow_control(XSM_DEFAULT_ARG struct domain *d,= uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_mem_sharing_op(XSM_DEFAULT_ARG struct domain *d,= struct domain *cd, int op) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, cd); -} - -static XSM_INLINE int xsm_apic(XSM_DEFAULT_ARG struct domain *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_machine_memory_map(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_domain_memory_map(XSM_DEFAULT_ARG struct domain = *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_mmu_update(XSM_DEFAULT_ARG struct domain *d, str= uct domain *t, - struct domain *f, uint32_t flags) -{ - int rc =3D 0; - XSM_ASSERT_ACTION(XSM_TARGET); - if ( f !=3D dom_io ) - rc =3D xsm_default_action(action, d, f); - if ( evaluate_nospec(t) && !rc ) - rc =3D xsm_default_action(action, d, t); - return rc; -} - -static XSM_INLINE int xsm_mmuext_op(XSM_DEFAULT_ARG struct domain *d, stru= ct domain *f) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, f); -} - -static XSM_INLINE int xsm_update_va_mapping(XSM_DEFAULT_ARG struct domain = *d, struct domain *f,=20 - l1_pgentry_t p= te) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, f); -} - -static XSM_INLINE int xsm_priv_mapping(XSM_DEFAULT_ARG struct domain *d, s= truct domain *t) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, t); -} - -static XSM_INLINE int xsm_ioport_permission(XSM_DEFAULT_ARG struct domain = *d, uint32_t s, uint32_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_ioport_mapping(XSM_DEFAULT_ARG struct domain *d,= uint32_t s, uint32_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, unsign= ed int op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( op ) - { - case XENPMU_init: - case XENPMU_finish: - case XENPMU_lvtpc_set: - case XENPMU_flush: - return xsm_default_action(XSM_HOOK, d, current->domain); - default: - return xsm_default_action(XSM_PRIV, d, current->domain); - } -} - -#endif /* CONFIG_X86 */ - -static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -#ifdef CONFIG_ARGO -static XSM_INLINE int xsm_argo_enable(const struct domain *d) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_register_single_source(const struct domain = *d, - const struct domain = *t) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_register_any_source(const struct domain *d) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_send(const struct domain *d, - const struct domain *t) -{ - return 0; -} - -#endif /* CONFIG_ARGO */ - -#include -static XSM_INLINE int xsm_xen_version (XSM_DEFAULT_ARG uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( op ) - { - case XENVER_version: - case XENVER_platform_parameters: - case XENVER_get_features: - /* These sub-ops ignore the permission checks and return data. */ - block_speculation(); - return 0; - case XENVER_extraversion: - case XENVER_compile_info: - case XENVER_capabilities: - case XENVER_changeset: - case XENVER_pagesize: - case XENVER_guest_handle: - /* These MUST always be accessible to any guest by default. */ - return xsm_default_action(XSM_HOOK, current->domain, NULL); - default: - return xsm_default_action(XSM_PRIV, current->domain, NULL); - } -} - -static XSM_INLINE int xsm_domain_resource_map(XSM_DEFAULT_ARG struct domai= n *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h index 49b00d688c..dfe9378cb2 100644 --- a/xen/include/xsm/xsm-core.h +++ b/xen/include/xsm/xsm-core.h @@ -199,8 +199,6 @@ struct xsm_ops { =20 extern void xsm_fixup_ops(struct xsm_ops *ops); =20 -#ifdef CONFIG_XSM - #ifdef CONFIG_MULTIBOOT extern int xsm_multiboot_init(unsigned long *module_map, const multiboot_info_t *mbi); @@ -246,28 +244,4 @@ static const inline struct xsm_ops *silo_init(void) } #endif =20 -#else /* CONFIG_XSM */ - -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init (unsigned long *module_map, - const multiboot_info_t *mbi) -{ - return 0; -} -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -static inline int xsm_dt_init(void) -{ - return 0; -} - -static inline bool has_xsm_magic(paddr_t start) -{ - return false; -} -#endif /* CONFIG_HAS_DEVICE_TREE */ - -#endif /* CONFIG_XSM */ - #endif /* __XSM_CORE_H */ diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 673b818ac7..deb3a39062 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -19,545 +19,1023 @@ #include #include #include - -#ifdef CONFIG_XSM +#include +#include =20 extern struct xsm_ops xsm_ops; =20 -static inline void xsm_security_domaininfo (struct domain *d, - struct xen_domctl_getdomaininfo *i= nfo) +static inline void xsm_security_domaininfo( + struct domain *d, + struct xen_domctl_getdomaininfo *info) { - alternative_vcall(xsm_ops.security_domaininfo, d, info); + if ( xsm_ops.security_domaininfo ) + alternative_vcall(xsm_ops.security_domaininfo, d, info); } =20 -static inline int xsm_domain_create (xsm_default_t def, struct domain *d, = u32 ssidref) +static inline int xsm_domain_create(xsm_default_t action, struct domain *d, + u32 ssidref) { - return alternative_call(xsm_ops.domain_create, d, ssidref); + if ( xsm_ops.domain_create ) + return alternative_call(xsm_ops.domain_create, d, ssidref); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_getdomaininfo (xsm_default_t def, struct domain *d) +static inline int xsm_getdomaininfo(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.getdomaininfo, d); + if ( xsm_ops.getdomaininfo ) + return alternative_call(xsm_ops.getdomaininfo, d); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_domctl_scheduler_op (xsm_default_t def, struct domai= n *d, int cmd) +static inline int xsm_domctl_scheduler_op(xsm_default_t action, struct dom= ain *d, + int cmd) { - return alternative_call(xsm_ops.domctl_scheduler_op, d, cmd); + if ( xsm_ops.domctl_scheduler_op ) + return alternative_call(xsm_ops.domctl_scheduler_op, d, cmd); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_sysctl_scheduler_op (xsm_default_t def, int cmd) +static inline int xsm_sysctl_scheduler_op(xsm_default_t action, int cmd) { - return alternative_call(xsm_ops.sysctl_scheduler_op, cmd); + if ( xsm_ops.sysctl_scheduler_op ) + return alternative_call(xsm_ops.sysctl_scheduler_op, cmd); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_set_target (xsm_default_t def, struct domain *d, str= uct domain *e) +static inline int xsm_set_target(xsm_default_t action, struct domain *d, + struct domain *e) { - return alternative_call(xsm_ops.set_target, d, e); + if ( xsm_ops.set_target ) + return alternative_call(xsm_ops.set_target, d, e); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_domctl (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_domctl(xsm_default_t action, struct domain *d, int c= md) { - return alternative_call(xsm_ops.domctl, d, cmd); + if ( xsm_ops.domctl ) + return alternative_call(xsm_ops.domctl, d, cmd); + + XSM_ASSERT_ACTION(XSM_OTHER); + switch ( cmd ) + { + case XEN_DOMCTL_ioport_mapping: + case XEN_DOMCTL_memory_mapping: + case XEN_DOMCTL_bind_pt_irq: + case XEN_DOMCTL_unbind_pt_irq: + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + case XEN_DOMCTL_getdomaininfo: + return xsm_default_action(XSM_XS_PRIV, current->domain, d); + default: + return xsm_default_action(XSM_PRIV, current->domain, d); + } } =20 -static inline int xsm_sysctl (xsm_default_t def, int cmd) +static inline int xsm_sysctl(xsm_default_t action, int cmd) { - return alternative_call(xsm_ops.sysctl, cmd); + if ( xsm_ops.sysctl ) + return alternative_call(xsm_ops.sysctl, cmd); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_readconsole (xsm_default_t def, uint32_t clear) +static inline int xsm_readconsole(xsm_default_t action, uint32_t clear) { - return alternative_call(xsm_ops.readconsole, clear); + if ( xsm_ops.readconsole ) + return alternative_call(xsm_ops.readconsole, clear); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_evtchn_unbound (xsm_default_t def, struct domain *d1= , struct evtchn *chn, - domid_= t id2) +static inline int xsm_evtchn_unbound(xsm_default_t action, struct domain *= d1, + struct evtchn *chn, domid_t id2) { - return alternative_call(xsm_ops.evtchn_unbound, d1, chn, id2); + if ( xsm_ops.evtchn_unbound ) + return alternative_call(xsm_ops.evtchn_unbound, d1, chn, id2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d1); } =20 -static inline int xsm_evtchn_interdomain (xsm_default_t def, struct domain= *d1, - struct evtchn *chan1, struct domain *d2, struct evtchn *ch= an2) +static inline int xsm_evtchn_interdomain(xsm_default_t action, + struct domain *d1, + struct evtchn *chan1, + struct domain *d2, + struct evtchn *chan2) { - return alternative_call(xsm_ops.evtchn_interdomain, d1, chan1, d2, cha= n2); + if ( xsm_ops.evtchn_interdomain ) + return alternative_call(xsm_ops.evtchn_interdomain, d1, chan1, d2, + chan2); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline void xsm_evtchn_close_post (struct evtchn *chn) +static inline void xsm_evtchn_close_post(struct evtchn *chn) { - alternative_vcall(xsm_ops.evtchn_close_post, chn); + if ( xsm_ops.evtchn_close_post ) + alternative_vcall(xsm_ops.evtchn_close_post, chn); } =20 -static inline int xsm_evtchn_send (xsm_default_t def, struct domain *d, st= ruct evtchn *chn) +static inline int xsm_evtchn_send(xsm_default_t action, struct domain *d, + struct evtchn *chn) { - return alternative_call(xsm_ops.evtchn_send, d, chn); + if ( xsm_ops.evtchn_send ) + return alternative_call(xsm_ops.evtchn_send, d, chn); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d, NULL); } =20 -static inline int xsm_evtchn_status (xsm_default_t def, struct domain *d, = struct evtchn *chn) +static inline int xsm_evtchn_status(xsm_default_t action, struct domain *d, + struct evtchn *chn) { - return alternative_call(xsm_ops.evtchn_status, d, chn); + if ( xsm_ops.evtchn_status ) + return alternative_call(xsm_ops.evtchn_status, d, chn); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_evtchn_reset (xsm_default_t def, struct domain *d1, = struct domain *d2) +static inline int xsm_evtchn_reset(xsm_default_t action, struct domain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.evtchn_reset, d1, d2); + if ( xsm_ops.evtchn_reset ) + return alternative_call(xsm_ops.evtchn_reset, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_mapref (xsm_default_t def, struct domain *d1, = struct domain *d2, - uint32_t f= lags) +static inline int xsm_grant_mapref(xsm_default_t action, struct domain *d1, + struct domain *d2, uint32_t flags) { - return alternative_call(xsm_ops.grant_mapref, d1, d2, flags); + if ( xsm_ops.grant_mapref ) + return alternative_call(xsm_ops.grant_mapref, d1, d2, flags); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_unmapref (xsm_default_t def, struct domain *d1= , struct domain *d2) +static inline int xsm_grant_unmapref(xsm_default_t action, struct domain *= d1, + struct domain *d2) { - return alternative_call(xsm_ops.grant_unmapref, d1, d2); + if ( xsm_ops.grant_unmapref ) + return alternative_call(xsm_ops.grant_unmapref, d1, d2); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_setup (xsm_default_t def, struct domain *d1, s= truct domain *d2) +static inline int xsm_grant_setup(xsm_default_t action, struct domain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.grant_setup, d1, d2); + if ( xsm_ops.grant_setup ) + return alternative_call(xsm_ops.grant_setup, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_transfer (xsm_default_t def, struct domain *d1= , struct domain *d2) +static inline int xsm_grant_transfer(xsm_default_t action, struct domain *= d1, + struct domain *d2) { - return alternative_call(xsm_ops.grant_transfer, d1, d2); + if ( xsm_ops.grant_transfer ) + return alternative_call(xsm_ops.grant_transfer, d1, d2); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_copy (xsm_default_t def, struct domain *d1, st= ruct domain *d2) +static inline int xsm_grant_copy(xsm_default_t action, struct domain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.grant_copy, d1, d2); + if ( xsm_ops.grant_copy ) + return alternative_call(xsm_ops.grant_copy, d1, d2); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_grant_query_size (xsm_default_t def, struct domain *= d1, struct domain *d2) +static inline int xsm_grant_query_size(xsm_default_t action, struct domain= *d1, + struct domain *d2) { - return alternative_call(xsm_ops.grant_query_size, d1, d2); + if ( xsm_ops.grant_query_size ) + return alternative_call(xsm_ops.grant_query_size, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_alloc_security_domain (struct domain *d) +static inline int xsm_alloc_security_domain(struct domain *d) { - return alternative_call(xsm_ops.alloc_security_domain, d); + if ( xsm_ops.alloc_security_domain ) + return alternative_call(xsm_ops.alloc_security_domain, d); + + return 0; } =20 -static inline void xsm_free_security_domain (struct domain *d) +static inline void xsm_free_security_domain(struct domain *d) { - alternative_vcall(xsm_ops.free_security_domain, d); + if ( xsm_ops.free_security_domain ) + alternative_vcall(xsm_ops.free_security_domain, d); } =20 -static inline int xsm_alloc_security_evtchns( - struct evtchn chn[], unsigned int nr) +static inline int xsm_alloc_security_evtchns(struct evtchn chn[], + unsigned int nr) { - return alternative_call(xsm_ops.alloc_security_evtchns, chn, nr); + if ( xsm_ops.alloc_security_evtchns ) + return alternative_call(xsm_ops.alloc_security_evtchns, chn, nr); + + return 0; } =20 -static inline void xsm_free_security_evtchns( - struct evtchn chn[], unsigned int nr) +static inline void xsm_free_security_evtchns(struct evtchn chn[], + unsigned int nr) { - alternative_vcall(xsm_ops.free_security_evtchns, chn, nr); + if ( xsm_ops.free_security_evtchns ) + alternative_vcall(xsm_ops.free_security_evtchns, chn, nr); } =20 -static inline char *xsm_show_security_evtchn (struct domain *d, const stru= ct evtchn *chn) +static inline char *xsm_show_security_evtchn(struct domain *d, + const struct evtchn *chn) { - return alternative_call(xsm_ops.show_security_evtchn, d, chn); + if ( xsm_ops.show_security_evtchn ) + return alternative_call(xsm_ops.show_security_evtchn, d, chn); + + return NULL; } =20 -static inline int xsm_init_hardware_domain (xsm_default_t def, struct doma= in *d) +static inline int xsm_init_hardware_domain(xsm_default_t action, struct do= main *d) { - return alternative_call(xsm_ops.init_hardware_domain, d); + if ( xsm_ops.init_hardware_domain ) + return alternative_call(xsm_ops.init_hardware_domain, d); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_get_pod_target (xsm_default_t def, struct domain *d) +static inline int xsm_get_pod_target(xsm_default_t action, struct domain *= d) { - return alternative_call(xsm_ops.get_pod_target, d); + if ( xsm_ops.get_pod_target ) + return alternative_call(xsm_ops.get_pod_target, d); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_set_pod_target (xsm_default_t def, struct domain *d) +static inline int xsm_set_pod_target(xsm_default_t action, struct domain *= d) { - return alternative_call(xsm_ops.set_pod_target, d); + if ( xsm_ops.set_pod_target ) + return alternative_call(xsm_ops.set_pod_target, d); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_memory_exchange (xsm_default_t def, struct domain *d) +static inline int xsm_memory_exchange(xsm_default_t action, struct domain = *d) { - return alternative_call(xsm_ops.memory_exchange, d); + if ( xsm_ops.memory_exchange ) + return alternative_call(xsm_ops.memory_exchange, d); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_memory_adjust_reservation (xsm_default_t def, struct= domain *d1, struct - domain= *d2) +static inline int xsm_memory_adjust_reservation(xsm_default_t action, + struct domain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.memory_adjust_reservation, d1, d2); + if ( xsm_ops.memory_adjust_reservation ) + return alternative_call(xsm_ops.memory_adjust_reservation, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_memory_stat_reservation (xsm_default_t def, struct d= omain *d1, - struct domain = *d2) +static inline int xsm_memory_stat_reservation(xsm_default_t action, + struct domain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.memory_stat_reservation, d1, d2); + if ( xsm_ops.memory_stat_reservation ) + return alternative_call(xsm_ops.memory_stat_reservation, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1= , struct domain *d2, - struct page_info *page) +static inline int xsm_memory_pin_page(xsm_default_t action, struct domain = *d1, + struct domain *d2, struct page_info = *page) { - return alternative_call(xsm_ops.memory_pin_page, d1, d2, page); + if ( xsm_ops.memory_pin_page ) + return alternative_call(xsm_ops.memory_pin_page, d1, d2, page); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1,= struct domain *d2) +static inline int xsm_add_to_physmap(xsm_default_t action, struct domain *= d1, + struct domain *d2) { - return alternative_call(xsm_ops.add_to_physmap, d1, d2); + if ( xsm_ops.add_to_physmap ) + return alternative_call(xsm_ops.add_to_physmap, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain= *d1, struct domain *d2) +static inline int xsm_remove_from_physmap(xsm_default_t action, struct dom= ain *d1, + struct domain *d2) { - return alternative_call(xsm_ops.remove_from_physmap, d1, d2); + if ( xsm_ops.remove_from_physmap ) + return alternative_call(xsm_ops.remove_from_physmap, d1, d2); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); } =20 -static inline int xsm_map_gmfn_foreign (xsm_default_t def, struct domain *= d, struct domain *t) +static inline int xsm_map_gmfn_foreign(xsm_default_t action, struct domain= *d, + struct domain *t) { - return alternative_call(xsm_ops.map_gmfn_foreign, d, t); + if ( xsm_ops.map_gmfn_foreign ) + return alternative_call(xsm_ops.map_gmfn_foreign, d, t); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); } =20 -static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) +static inline int xsm_claim_pages(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.claim_pages, d); + if ( xsm_ops.claim_pages ) + return alternative_call(xsm_ops.claim_pages, d); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_console_io (xsm_default_t def, struct domain *d, int= cmd) +static inline int xsm_console_io(xsm_default_t action, struct domain *d, i= nt cmd) { - return alternative_call(xsm_ops.console_io, d, cmd); + if ( xsm_ops.console_io ) + return alternative_call(xsm_ops.console_io, d, cmd); + + XSM_ASSERT_ACTION(XSM_OTHER); + if ( d->is_console ) + return xsm_default_action(XSM_HOOK, d, NULL); +#ifdef CONFIG_VERBOSE_DEBUG + if ( cmd =3D=3D CONSOLEIO_write ) + return xsm_default_action(XSM_HOOK, d, NULL); +#endif + return xsm_default_action(XSM_PRIV, d, NULL); } =20 -static inline int xsm_profile (xsm_default_t def, struct domain *d, int op) +static inline int xsm_profile(xsm_default_t action, struct domain *d, int = op) { - return alternative_call(xsm_ops.profile, d, op); + if ( xsm_ops.profile ) + return alternative_call(xsm_ops.profile, d, op); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, d, NULL); } =20 -static inline int xsm_kexec (xsm_default_t def) +static inline int xsm_kexec (xsm_default_t action) { - return alternative_call(xsm_ops.kexec); + if ( xsm_ops.kexec ) + return alternative_call(xsm_ops.kexec); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_schedop_shutdown (xsm_default_t def, struct domain *= d1, struct domain *d2) +static inline int xsm_schedop_shutdown(xsm_default_t action, struct domain= *d1, + struct domain *d2) { - return alternative_call(xsm_ops.schedop_shutdown, d1, d2); + if ( xsm_ops.schedop_shutdown ) + return alternative_call(xsm_ops.schedop_shutdown, d1, d2); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, d1, d2); } =20 -static inline char *xsm_show_irq_sid (int irq) +static inline char *xsm_show_irq_sid(int irq) { - return alternative_call(xsm_ops.show_irq_sid, irq); + if ( xsm_ops.show_irq_sid ) + return alternative_call(xsm_ops.show_irq_sid, irq); + + return NULL; } =20 -static inline int xsm_map_domain_pirq (xsm_default_t def, struct domain *d) +static inline int xsm_map_domain_pirq(xsm_default_t action, struct domain = *d) { - return alternative_call(xsm_ops.map_domain_pirq, d); + if ( xsm_ops.map_domain_pirq ) + return alternative_call(xsm_ops.map_domain_pirq, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_map_domain_irq (xsm_default_t def, struct domain *d,= int irq, void *data) +static inline int xsm_map_domain_irq(xsm_default_t action, struct domain *= d, + int irq, void *data) { - return alternative_call(xsm_ops.map_domain_irq, d, irq, data); + if ( xsm_ops.map_domain_irq ) + return alternative_call(xsm_ops.map_domain_irq, d, irq, data); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_unmap_domain_pirq (xsm_default_t def, struct domain = *d) +static inline int xsm_unmap_domain_pirq(xsm_default_t action, struct domai= n *d) { - return alternative_call(xsm_ops.unmap_domain_pirq, d); + if ( xsm_ops.unmap_domain_pirq ) + return alternative_call(xsm_ops.unmap_domain_pirq, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_unmap_domain_irq (xsm_default_t def, struct domain *= d, int irq, void *data) +static inline int xsm_unmap_domain_irq(xsm_default_t action, struct domain= *d, + int irq, void *data) { - return alternative_call(xsm_ops.unmap_domain_irq, d, irq, data); + if ( xsm_ops.unmap_domain_irq ) + return alternative_call(xsm_ops.unmap_domain_irq, d, irq, data); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, +static inline int xsm_bind_pt_irq(xsm_default_t action, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return alternative_call(xsm_ops.bind_pt_irq, d, bind); + if ( xsm_ops.bind_pt_irq ) + return alternative_call(xsm_ops.bind_pt_irq, d, bind); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, +static inline int xsm_unbind_pt_irq(xsm_default_t action, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return alternative_call(xsm_ops.unbind_pt_irq, d, bind); + if ( xsm_ops.unbind_pt_irq ) + return alternative_call(xsm_ops.unbind_pt_irq, d, bind); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_irq_permission (xsm_default_t def, struct domain *d,= int pirq, uint8_t allow) +static inline int xsm_irq_permission(xsm_default_t action, struct domain *= d, + int pirq, uint8_t allow) { - return alternative_call(xsm_ops.irq_permission, d, pirq, allow); + if ( xsm_ops.irq_permission ) + return alternative_call(xsm_ops.irq_permission, d, pirq, allow); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_iomem_permission (xsm_default_t def, struct domain *= d, uint64_t s, uint64_t e, uint8_t allow) +static inline int xsm_iomem_permission(xsm_default_t action, struct domain= *d, + uint64_t s, uint64_t e, uint8_t all= ow) { - return alternative_call(xsm_ops.iomem_permission, d, s, e, allow); + if ( xsm_ops.iomem_permission ) + return alternative_call(xsm_ops.iomem_permission, d, s, e, allow); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_iomem_mapping (xsm_default_t def, struct domain *d, = uint64_t s, uint64_t e, uint8_t allow) +static inline int xsm_iomem_mapping(xsm_default_t action, struct domain *d, + uint64_t s, uint64_t e, uint8_t allow) { - return alternative_call(xsm_ops.iomem_mapping, d, s, e, allow); + if ( xsm_ops.iomem_mapping ) + return alternative_call(xsm_ops.iomem_mapping, d, s, e, allow); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_pci_config_permission (xsm_default_t def, struct dom= ain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access) +static inline int xsm_pci_config_permission(xsm_default_t action, + struct domain *d, + uint32_t machine_bdf, + uint16_t start, + uint16_t end, + uint8_t access) { - return alternative_call(xsm_ops.pci_config_permission, d, machine_bdf,= start, end, access); + if ( xsm_ops.pci_config_permission ) + return alternative_call(xsm_ops.pci_config_permission, d, machine_= bdf, start, end, access); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) -static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine= _bdf) +static inline int xsm_get_device_group(xsm_default_t action, uint32_t mach= ine_bdf) { - return alternative_call(xsm_ops.get_device_group, machine_bdf); + if ( xsm_ops.get_device_group ) + return alternative_call(xsm_ops.get_device_group, machine_bdf); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_assign_device(xsm_default_t def, struct domain *d, u= int32_t machine_bdf) +static inline int xsm_assign_device(xsm_default_t action, struct domain *d, + uint32_t machine_bdf) { - return alternative_call(xsm_ops.assign_device, d, machine_bdf); + if ( xsm_ops.assign_device ) + return alternative_call(xsm_ops.assign_device, d, machine_bdf); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_deassign_device(xsm_default_t def, struct domain *d,= uint32_t machine_bdf) +static inline int xsm_deassign_device(xsm_default_t action, struct domain = *d, + uint32_t machine_bdf) { - return alternative_call(xsm_ops.deassign_device, d, machine_bdf); + if ( xsm_ops.deassign_device ) + return alternative_call(xsm_ops.deassign_device, d, machine_bdf); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ =20 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) -static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, +static inline int xsm_assign_dtdevice(xsm_default_t action, struct domain = *d, const char *dtpath) { - return alternative_call(xsm_ops.assign_dtdevice, d, dtpath); + if ( xsm_ops.assign_dtdevice ) + return alternative_call(xsm_ops.assign_dtdevice, d, dtpath); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *= d, +static inline int xsm_deassign_dtdevice(xsm_default_t action, struct domai= n *d, const char *dtpath) { - return alternative_call(xsm_ops.deassign_dtdevice, d, dtpath); + if ( xsm_ops.deassign_dtdevice ) + return alternative_call(xsm_ops.deassign_dtdevice, d, dtpath); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ =20 -static inline int xsm_resource_plug_pci (xsm_default_t def, uint32_t machi= ne_bdf) +static inline int xsm_resource_plug_pci(xsm_default_t action, uint32_t mac= hine_bdf) { - return alternative_call(xsm_ops.resource_plug_pci, machine_bdf); + if ( xsm_ops.resource_plug_pci ) + return alternative_call(xsm_ops.resource_plug_pci, machine_bdf); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_unplug_pci (xsm_default_t def, uint32_t mac= hine_bdf) +static inline int xsm_resource_unplug_pci(xsm_default_t action, + uint32_t machine_bdf) { - return alternative_call(xsm_ops.resource_unplug_pci, machine_bdf); + if ( xsm_ops.resource_unplug_pci ) + return alternative_call(xsm_ops.resource_unplug_pci, machine_bdf); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_plug_core (xsm_default_t def) +static inline int xsm_resource_plug_core(xsm_default_t action) { - return alternative_call(xsm_ops.resource_plug_core); + if ( xsm_ops.resource_plug_core ) + return alternative_call(xsm_ops.resource_plug_core); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_unplug_core (xsm_default_t def) +static inline int xsm_resource_unplug_core(xsm_default_t action) { - return alternative_call(xsm_ops.resource_unplug_core); + if ( xsm_ops.resource_unplug_core ) + return alternative_call(xsm_ops.resource_unplug_core); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_setup_pci (xsm_default_t def, uint32_t mach= ine_bdf) +static inline int xsm_resource_setup_pci(xsm_default_t action, + uint32_t machine_bdf) { - return alternative_call(xsm_ops.resource_setup_pci, machine_bdf); + if ( xsm_ops.resource_setup_pci ) + return alternative_call(xsm_ops.resource_setup_pci, machine_bdf); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_setup_gsi (xsm_default_t def, int gsi) +static inline int xsm_resource_setup_gsi(xsm_default_t action, int gsi) { - return alternative_call(xsm_ops.resource_setup_gsi, gsi); + if ( xsm_ops.resource_setup_gsi ) + return alternative_call(xsm_ops.resource_setup_gsi, gsi); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_resource_setup_misc (xsm_default_t def) +static inline int xsm_resource_setup_misc (xsm_default_t action) { - return alternative_call(xsm_ops.resource_setup_misc); + if ( xsm_ops.resource_setup_misc ) + return alternative_call(xsm_ops.resource_setup_misc); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) +static inline int xsm_page_offline(xsm_default_t action, uint32_t cmd) { - return alternative_call(xsm_ops.page_offline, cmd); + if ( xsm_ops.page_offline ) + return alternative_call(xsm_ops.page_offline, cmd); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_hypfs_op(xsm_default_t def) +static inline int xsm_hypfs_op(xsm_default_t action) { - return alternative_call(xsm_ops.hypfs_op); + if ( xsm_ops.hypfs_op ) + return alternative_call(xsm_ops.hypfs_op); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) { - return xsm_ops.do_xsm_op(op); + if ( xsm_ops.do_xsm_op ) + return xsm_ops.do_xsm_op(op); + + return -ENOSYS; } =20 #ifdef CONFIG_COMPAT -static inline int xsm_do_compat_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) { - return xsm_ops.do_compat_op(op); + if ( xsm_ops.do_compat_op ) + return xsm_ops.do_compat_op(op); + + return -ENOSYS; } #endif =20 -static inline int xsm_hvm_param (xsm_default_t def, struct domain *d, unsi= gned long op) +static inline int xsm_hvm_param(xsm_default_t action, struct domain *d, + unsigned long op) { - return alternative_call(xsm_ops.hvm_param, d, op); + if ( xsm_ops.hvm_param ) + return alternative_call(xsm_ops.hvm_param, d, op); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, uns= igned long op) +static inline int xsm_hvm_control(xsm_default_t action, struct domain *d, + unsigned long op) { - return alternative_call(xsm_ops.hvm_control, d, op); + if ( xsm_ops.hvm_control ) + return alternative_call(xsm_ops.hvm_control, d, op); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_hvm_param_altp2mhvm (xsm_default_t def, struct domai= n *d) +static inline int xsm_hvm_param_altp2mhvm(xsm_default_t action, struct dom= ain *d) { - return alternative_call(xsm_ops.hvm_param_altp2mhvm, d); + if ( xsm_ops.hvm_param_altp2mhvm ) + return alternative_call(xsm_ops.hvm_param_altp2mhvm, d); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_hvm_altp2mhvm_op (xsm_default_t def, struct domain *= d, uint64_t mode, uint32_t op) +static inline int xsm_hvm_altp2mhvm_op(xsm_default_t action, struct domain= *d, + uint64_t mode, uint32_t op) { - return alternative_call(xsm_ops.hvm_altp2mhvm_op, d, mode, op); + if ( xsm_ops.hvm_altp2mhvm_op ) + return alternative_call(xsm_ops.hvm_altp2mhvm_op, d, mode, op); + + XSM_ASSERT_ACTION(XSM_OTHER); + + switch ( mode ) + { + case XEN_ALTP2M_mixed: + return xsm_default_action(XSM_TARGET, current->domain, d); + case XEN_ALTP2M_external: + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + case XEN_ALTP2M_limited: + if ( HVMOP_altp2m_vcpu_enable_notify =3D=3D op ) + return xsm_default_action(XSM_TARGET, current->domain, d); + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + default: + return -EPERM; + } } =20 -static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d) +static inline int xsm_get_vnumainfo(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.get_vnumainfo, d); + if ( xsm_ops.get_vnumainfo ) + return alternative_call(xsm_ops.get_vnumainfo, d); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_vm_event_control (xsm_default_t def, struct domain *= d, int mode, int op) +static inline int xsm_vm_event_control(xsm_default_t action, struct domain= *d, + int mode, int op) { - return alternative_call(xsm_ops.vm_event_control, d, mode, op); + if ( xsm_ops.vm_event_control ) + return alternative_call(xsm_ops.vm_event_control, d, mode, op); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 #ifdef CONFIG_MEM_ACCESS -static inline int xsm_mem_access (xsm_default_t def, struct domain *d) +static inline int xsm_mem_access(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.mem_access, d); + if ( xsm_ops.mem_access ) + return alternative_call(xsm_ops.mem_access, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } #endif =20 #ifdef CONFIG_MEM_PAGING -static inline int xsm_mem_paging (xsm_default_t def, struct domain *d) +static inline int xsm_mem_paging(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.mem_paging, d); + if ( xsm_ops.mem_paging ) + return alternative_call(xsm_ops.mem_paging, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } #endif =20 #ifdef CONFIG_MEM_SHARING -static inline int xsm_mem_sharing (xsm_default_t def, struct domain *d) +static inline int xsm_mem_sharing(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.mem_sharing, d); + if ( xsm_ops.mem_sharing ) + return alternative_call(xsm_ops.mem_sharing, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } #endif =20 -static inline int xsm_platform_op (xsm_default_t def, uint32_t op) +static inline int xsm_platform_op(xsm_default_t action, uint32_t op) { - return alternative_call(xsm_ops.platform_op, op); + if ( xsm_ops.platform_op ) + return alternative_call(xsm_ops.platform_op, op); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 #ifdef CONFIG_X86 -static inline int xsm_do_mca(xsm_default_t def) +static inline int xsm_do_mca(xsm_default_t action) { - return alternative_call(xsm_ops.do_mca); + if ( xsm_ops.do_mca ) + return alternative_call(xsm_ops.do_mca); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_shadow_control (xsm_default_t def, struct domain *d,= uint32_t op) +static inline int xsm_shadow_control(xsm_default_t action, struct domain *= d, + uint32_t op) { - return alternative_call(xsm_ops.shadow_control, d, op); + if ( xsm_ops.shadow_control ) + return alternative_call(xsm_ops.shadow_control, d, op); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_mem_sharing_op (xsm_default_t def, struct domain *d,= struct domain *cd, int op) +static inline int xsm_mem_sharing_op(xsm_default_t action, struct domain *= d, + struct domain *cd, int op) { - return alternative_call(xsm_ops.mem_sharing_op, d, cd, op); + if ( xsm_ops.mem_sharing_op ) + return alternative_call(xsm_ops.mem_sharing_op, d, cd, op); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, cd); } =20 -static inline int xsm_apic (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_apic(xsm_default_t action, struct domain *d, int cmd) { - return alternative_call(xsm_ops.apic, d, cmd); + if ( xsm_ops.apic ) + return alternative_call(xsm_ops.apic, d, cmd); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, d, NULL); } =20 -static inline int xsm_memtype (xsm_default_t def, uint32_t access) +/* No longer called */ +static inline int xsm_memtype(xsm_default_t action, uint32_t access) { - return alternative_call(xsm_ops.memtype, access); + if ( xsm_ops.memtype ) + return alternative_call(xsm_ops.memtype, access); } =20 -static inline int xsm_machine_memory_map(xsm_default_t def) +static inline int xsm_machine_memory_map(xsm_default_t action) { - return alternative_call(xsm_ops.machine_memory_map); + if ( xsm_ops.machine_memory_map ) + return alternative_call(xsm_ops.machine_memory_map); + + XSM_ASSERT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); } =20 -static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *= d) +static inline int xsm_domain_memory_map(xsm_default_t action, struct domai= n *d) { - return alternative_call(xsm_ops.domain_memory_map, d); + if ( xsm_ops.domain_memory_map ) + return alternative_call(xsm_ops.domain_memory_map, d); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_mmu_update (xsm_default_t def, struct domain *d, str= uct domain *t, - struct domain *f, uint32_t flags) +static inline int xsm_mmu_update(xsm_default_t action, struct domain *d, + struct domain *t, struct domain *f, + uint32_t flags) { - return alternative_call(xsm_ops.mmu_update, d, t, f, flags); + int rc =3D 0; + + if ( xsm_ops.mmu_update ) + return alternative_call(xsm_ops.mmu_update, d, t, f, flags); + + XSM_ASSERT_ACTION(XSM_TARGET); + if ( f !=3D dom_io ) + rc =3D xsm_default_action(action, d, f); + if ( evaluate_nospec(t) && !rc ) + rc =3D xsm_default_action(action, d, t); + return rc; } =20 -static inline int xsm_mmuext_op (xsm_default_t def, struct domain *d, stru= ct domain *f) +static inline int xsm_mmuext_op(xsm_default_t action, struct domain *d, + struct domain *f) { - return alternative_call(xsm_ops.mmuext_op, d, f); + if ( xsm_ops.mmuext_op ) + return alternative_call(xsm_ops.mmuext_op, d, f); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, f); } =20 -static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *= d, struct domain *f, - l1_pgentry_t p= te) +static inline int xsm_update_va_mapping(xsm_default_t action, struct domai= n *d, + struct domain *f, l1_pgentry_t pte) { - return xsm_ops.update_va_mapping(d, f, pte); + if ( xsm_ops.update_va_mapping ) + return xsm_ops.update_va_mapping(d, f, pte); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, f); } =20 -static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, st= ruct domain *t) +static inline int xsm_priv_mapping(xsm_default_t action, struct domain *d, + struct domain *t) { - return alternative_call(xsm_ops.priv_mapping, d, t); + if ( xsm_ops.priv_mapping ) + return alternative_call(xsm_ops.priv_mapping, d, t); + + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); } =20 -static inline int xsm_ioport_permission (xsm_default_t def, struct domain = *d, uint32_t s, uint32_t e, uint8_t allow) +static inline int xsm_ioport_permission(xsm_default_t action, struct domai= n *d, + uint32_t s, uint32_t e, uint8_t al= low) { - return alternative_call(xsm_ops.ioport_permission, d, s, e, allow); + if ( xsm_ops.ioport_permission ) + return alternative_call(xsm_ops.ioport_permission, d, s, e, allow); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_ioport_mapping (xsm_default_t def, struct domain *d,= uint32_t s, uint32_t e, uint8_t allow) +static inline int xsm_ioport_mapping(xsm_default_t action, struct domain *= d, + uint32_t s, uint32_t e, uint8_t allow) { - return alternative_call(xsm_ops.ioport_mapping, d, s, e, allow); + if ( xsm_ops.ioport_mapping ) + return alternative_call(xsm_ops.ioport_mapping, d, s, e, allow); + + XSM_ASSERT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigne= d int op) +static inline int xsm_pmu_op(xsm_default_t action, struct domain *d, + unsigned int op) { - return alternative_call(xsm_ops.pmu_op, d, op); + if ( xsm_ops.pmu_op ) + return alternative_call(xsm_ops.pmu_op, d, op); + + XSM_ASSERT_ACTION(XSM_OTHER); + switch ( op ) + { + case XENPMU_init: + case XENPMU_finish: + case XENPMU_lvtpc_set: + case XENPMU_flush: + return xsm_default_action(XSM_HOOK, d, current->domain); + default: + return xsm_default_action(XSM_PRIV, d, current->domain); + } } =20 #endif /* CONFIG_X86 */ =20 -static inline int xsm_dm_op(xsm_default_t def, struct domain *d) +static inline int xsm_dm_op(xsm_default_t action, struct domain *d) { - return alternative_call(xsm_ops.dm_op, d); + if ( xsm_ops.dm_op ) + return alternative_call(xsm_ops.dm_op, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 -static inline int xsm_xen_version (xsm_default_t def, uint32_t op) +static inline int xsm_xen_version(xsm_default_t action, uint32_t op) { - return alternative_call(xsm_ops.xen_version, op); + if ( xsm_ops.xen_version ) + return alternative_call(xsm_ops.xen_version, op); + + XSM_ASSERT_ACTION(XSM_OTHER); + switch ( op ) + { + case XENVER_version: + case XENVER_platform_parameters: + case XENVER_get_features: + /* These sub-ops ignore the permission checks and return data. */ + block_speculation(); + return 0; + case XENVER_extraversion: + case XENVER_compile_info: + case XENVER_capabilities: + case XENVER_changeset: + case XENVER_pagesize: + case XENVER_guest_handle: + /* These MUST always be accessible to any guest by default. */ + return xsm_default_action(XSM_HOOK, current->domain, NULL); + default: + return xsm_default_action(XSM_PRIV, current->domain, NULL); + } } =20 -static inline int xsm_domain_resource_map(xsm_default_t def, struct domain= *d) +static inline int xsm_domain_resource_map(xsm_default_t action, struct dom= ain *d) { - return alternative_call(xsm_ops.domain_resource_map, d); + if ( xsm_ops.domain_resource_map ) + return alternative_call(xsm_ops.domain_resource_map, d); + + XSM_ASSERT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); } =20 #ifdef CONFIG_ARGO static inline int xsm_argo_enable(const struct domain *d) { - return alternative_call(xsm_ops.argo_enable, d); + if ( xsm_ops.argo_enable ) + return alternative_call(xsm_ops.argo_enable, d); + + return 0; } =20 static inline int xsm_argo_register_single_source(const struct domain *d, const struct domain *t) { - return alternative_call(xsm_ops.argo_register_single_source, d, t); + if ( xsm_ops.argo_register_single_source ) + return alternative_call(xsm_ops.argo_register_single_source, d, t); + + return 0; } =20 static inline int xsm_argo_register_any_source(const struct domain *d) { - return alternative_call(xsm_ops.argo_register_any_source, d); + if ( xsm_ops.argo_register_any_source ) + return alternative_call(xsm_ops.argo_register_any_source, d); + + return 0; } =20 static inline int xsm_argo_send(const struct domain *d, const struct domai= n *t) { - return alternative_call(xsm_ops.argo_send, d, t); + if ( xsm_ops.argo_send ) + return alternative_call(xsm_ops.argo_send, d, t); + + return 0; } =20 #endif /* CONFIG_ARGO */ =20 -#else /* CONFIG_XSM */ - -#include - -#endif /* CONFIG_XSM */ - #endif /* __XSM_H */ diff --git a/xen/xsm/Makefile b/xen/xsm/Makefile index cf0a728f1c..ab1fb74edc 100644 --- a/xen/xsm/Makefile +++ b/xen/xsm/Makefile @@ -1,6 +1,5 @@ obj-y +=3D xsm_core.o -obj-$(CONFIG_XSM) +=3D xsm_policy.o -obj-$(CONFIG_XSM) +=3D dummy.o +obj-y +=3D xsm_policy.o obj-$(CONFIG_XSM_SILO) +=3D silo.o =20 obj-$(CONFIG_XSM_FLASK) +=3D flask/ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c deleted file mode 100644 index b848580eaa..0000000000 --- a/xen/xsm/dummy.c +++ /dev/null @@ -1,157 +0,0 @@ -/* - * This work is based on the LSM implementation in Linux 2.6.13.4. - * - * Author: George Coker, - * - * Contributors: Michael LeMay, - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, - * as published by the Free Software Foundation. - */ - -#include - -#define set_to_dummy_if_null(ops, function) \ - do { \ - if ( !ops->function ) \ - ops->function =3D xsm_##function; \ - } while (0) - -void __init xsm_fixup_ops (struct xsm_ops *ops) -{ - set_to_dummy_if_null(ops, security_domaininfo); - set_to_dummy_if_null(ops, domain_create); - set_to_dummy_if_null(ops, getdomaininfo); - set_to_dummy_if_null(ops, domctl_scheduler_op); - set_to_dummy_if_null(ops, sysctl_scheduler_op); - set_to_dummy_if_null(ops, set_target); - set_to_dummy_if_null(ops, domctl); - set_to_dummy_if_null(ops, sysctl); - set_to_dummy_if_null(ops, readconsole); - - set_to_dummy_if_null(ops, evtchn_unbound); - set_to_dummy_if_null(ops, evtchn_interdomain); - set_to_dummy_if_null(ops, evtchn_close_post); - set_to_dummy_if_null(ops, evtchn_send); - set_to_dummy_if_null(ops, evtchn_status); - set_to_dummy_if_null(ops, evtchn_reset); - - set_to_dummy_if_null(ops, grant_mapref); - set_to_dummy_if_null(ops, grant_unmapref); - set_to_dummy_if_null(ops, grant_setup); - set_to_dummy_if_null(ops, grant_transfer); - set_to_dummy_if_null(ops, grant_copy); - set_to_dummy_if_null(ops, grant_query_size); - - set_to_dummy_if_null(ops, alloc_security_domain); - set_to_dummy_if_null(ops, free_security_domain); - set_to_dummy_if_null(ops, alloc_security_evtchns); - set_to_dummy_if_null(ops, free_security_evtchns); - set_to_dummy_if_null(ops, show_security_evtchn); - set_to_dummy_if_null(ops, init_hardware_domain); - - set_to_dummy_if_null(ops, get_pod_target); - set_to_dummy_if_null(ops, set_pod_target); - - set_to_dummy_if_null(ops, memory_exchange); - set_to_dummy_if_null(ops, memory_adjust_reservation); - set_to_dummy_if_null(ops, memory_stat_reservation); - set_to_dummy_if_null(ops, memory_pin_page); - set_to_dummy_if_null(ops, claim_pages); - - set_to_dummy_if_null(ops, console_io); - - set_to_dummy_if_null(ops, profile); - - set_to_dummy_if_null(ops, kexec); - set_to_dummy_if_null(ops, schedop_shutdown); - - set_to_dummy_if_null(ops, show_irq_sid); - set_to_dummy_if_null(ops, map_domain_pirq); - set_to_dummy_if_null(ops, map_domain_irq); - set_to_dummy_if_null(ops, unmap_domain_pirq); - set_to_dummy_if_null(ops, unmap_domain_irq); - set_to_dummy_if_null(ops, bind_pt_irq); - set_to_dummy_if_null(ops, unbind_pt_irq); - set_to_dummy_if_null(ops, irq_permission); - set_to_dummy_if_null(ops, iomem_permission); - set_to_dummy_if_null(ops, iomem_mapping); - set_to_dummy_if_null(ops, pci_config_permission); - set_to_dummy_if_null(ops, get_vnumainfo); - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) - set_to_dummy_if_null(ops, get_device_group); - set_to_dummy_if_null(ops, assign_device); - set_to_dummy_if_null(ops, deassign_device); -#endif - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) - set_to_dummy_if_null(ops, assign_dtdevice); - set_to_dummy_if_null(ops, deassign_dtdevice); -#endif - - set_to_dummy_if_null(ops, resource_plug_core); - set_to_dummy_if_null(ops, resource_unplug_core); - set_to_dummy_if_null(ops, resource_plug_pci); - set_to_dummy_if_null(ops, resource_unplug_pci); - set_to_dummy_if_null(ops, resource_setup_pci); - set_to_dummy_if_null(ops, resource_setup_gsi); - set_to_dummy_if_null(ops, resource_setup_misc); - - set_to_dummy_if_null(ops, page_offline); - set_to_dummy_if_null(ops, hypfs_op); - set_to_dummy_if_null(ops, hvm_param); - set_to_dummy_if_null(ops, hvm_control); - set_to_dummy_if_null(ops, hvm_param_altp2mhvm); - set_to_dummy_if_null(ops, hvm_altp2mhvm_op); - - set_to_dummy_if_null(ops, do_xsm_op); -#ifdef CONFIG_COMPAT - set_to_dummy_if_null(ops, do_compat_op); -#endif - - set_to_dummy_if_null(ops, add_to_physmap); - set_to_dummy_if_null(ops, remove_from_physmap); - set_to_dummy_if_null(ops, map_gmfn_foreign); - - set_to_dummy_if_null(ops, vm_event_control); - -#ifdef CONFIG_MEM_ACCESS - set_to_dummy_if_null(ops, mem_access); -#endif - -#ifdef CONFIG_MEM_PAGING - set_to_dummy_if_null(ops, mem_paging); -#endif - -#ifdef CONFIG_MEM_SHARING - set_to_dummy_if_null(ops, mem_sharing); -#endif - - set_to_dummy_if_null(ops, platform_op); -#ifdef CONFIG_X86 - set_to_dummy_if_null(ops, do_mca); - set_to_dummy_if_null(ops, shadow_control); - set_to_dummy_if_null(ops, mem_sharing_op); - set_to_dummy_if_null(ops, apic); - set_to_dummy_if_null(ops, machine_memory_map); - set_to_dummy_if_null(ops, domain_memory_map); - set_to_dummy_if_null(ops, mmu_update); - set_to_dummy_if_null(ops, mmuext_op); - set_to_dummy_if_null(ops, update_va_mapping); - set_to_dummy_if_null(ops, priv_mapping); - set_to_dummy_if_null(ops, ioport_permission); - set_to_dummy_if_null(ops, ioport_mapping); - set_to_dummy_if_null(ops, pmu_op); -#endif - set_to_dummy_if_null(ops, dm_op); - set_to_dummy_if_null(ops, xen_version); - set_to_dummy_if_null(ops, domain_resource_map); -#ifdef CONFIG_ARGO - set_to_dummy_if_null(ops, argo_enable); - set_to_dummy_if_null(ops, argo_register_single_source); - set_to_dummy_if_null(ops, argo_register_any_source); - set_to_dummy_if_null(ops, argo_send); -#endif -} diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index 4ef40bd712..0455e1eb4b 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -17,6 +17,7 @@ * You should have received a copy of the GNU General Public License along= with * this program; If not, see . */ +#include #include =20 /* @@ -43,7 +44,7 @@ static int silo_evtchn_unbound(struct domain *d1, struct = evtchn *chn, else { if ( silo_mode_dom_check(d1, d2) ) - rc =3D xsm_evtchn_unbound(d1, chn, id2); + rc =3D xsm_default_action(XSM_TARGET, current->domain, d1); rcu_unlock_domain(d2); } =20 @@ -54,7 +55,7 @@ static int silo_evtchn_interdomain(struct domain *d1, str= uct evtchn *chan1, struct domain *d2, struct evtchn *chan2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_evtchn_interdomain(d1, chan1, d2, chan2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } =20 @@ -62,21 +63,21 @@ static int silo_grant_mapref(struct domain *d1, struct = domain *d2, uint32_t flags) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_mapref(d1, d2, flags); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } =20 static int silo_grant_transfer(struct domain *d1, struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_transfer(d1, d2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } =20 static int silo_grant_copy(struct domain *d1, struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_copy(d1, d2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } =20 @@ -86,14 +87,14 @@ static int silo_argo_register_single_source(const struc= t domain *d1, const struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_argo_register_single_source(d1, d2); + return 0; return -EPERM; } =20 static int silo_argo_send(const struct domain *d1, const struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_argo_send(d1, d2); + return 0; return -EPERM; } =20 diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index b5219dff78..75bd2678ef 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -18,8 +18,6 @@ #include #include =20 -#ifdef CONFIG_XSM - #ifdef CONFIG_MULTIBOOT #include #endif @@ -124,16 +122,12 @@ static int __init xsm_core_init(const void *policy_bu= ffer, size_t policy_size) break; } =20 - /* - * This handles three cases, - * - dummy policy module was selected - * - a policy module does not provide all handlers - * - a policy module failed to init - */ - xsm_fixup_ops(&xsm_ops); - - if ( xsm_ops_registered !=3D XSM_OPS_REGISTERED ) + if ( xsm_ops_registered !=3D XSM_OPS_REGISTERED ) { xsm_ops_registered =3D XSM_OPS_REG_FAILED; + printk(XENLOG_ERR + "Could not init XSM, xsm_ops register failed\n"); + return -EFAULT; + } =20 return 0; } @@ -217,8 +211,6 @@ bool __init has_xsm_magic(paddr_t start) } #endif =20 -#endif - long do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) { return xsm_do_xsm_op(op); --=20 2.20.1