From nobody Sun May 5 00:21:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1624546042; cv=none; d=zohomail.com; s=zohoarc; b=DY+SMc7Ud41knJClBM1OUeWTBExXQJmxnywNusqICtttFFUo0kI6kjOZPDvbTbdbYUWvGfYJoVszbiTYPlAr0h4eddkCZak6mdIV2DlekQjyglAlqGvQ4Sa5+Odl4SDnXqxVmy05ALoTsPXi20jrRRv7zaOgCKvblUYbeH8sYG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624546041; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=XCk4lQYg4y7RtUs31wkreOLsu7v4xKjO1fVnBgQiBnI=; b=aIcVNIwLkfv0+IItkSJIZ+QG+txr9NBNqM/L5ZRqMeF9jrqBqibFQOm1JcoEYlIbCSsRFrqFa9bYsaxm6jIOn0TKe4DcWfIzf6eHzaKDZQEJ9LCkC8IgIw9jkVjw3YdPLZyZhvAXpjV6QAqRzvUMO7L2C+9no8EY3bHuJbRR+mk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1624546041908392.23316251642984; Thu, 24 Jun 2021 07:47:21 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.146858.270374 (Exim 4.92) (envelope-from ) id 1lwQdC-0006KW-0j; Thu, 24 Jun 2021 14:47:02 +0000 Received: by outflank-mailman (output) from mailman id 146858.270374; Thu, 24 Jun 2021 14:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQdB-0006KP-Sb; Thu, 24 Jun 2021 14:47:01 +0000 Received: by outflank-mailman (input) for mailman id 146858; Thu, 24 Jun 2021 14:47:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQdA-0006KJ-FR for xen-devel@lists.xenproject.org; Thu, 24 Jun 2021 14:47:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwQd9-0002Dh-37; Thu, 24 Jun 2021 14:46:59 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQd8-000486-Qr; Thu, 24 Jun 2021 14:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=XCk4lQYg4y7RtUs31wkreOLsu7v4xKjO1fVnBgQiBnI=; b=Iz6av1pTXigGNWzHmUoHkt75Ma Lik//fCZyrpXmjwZKn2Of2WY34tTTZxOaeqF2C9HjsuOmCqeV3FzN76ySatBmMojx8FBmMlAaR7DS i+RwO+3omLZ8i01DXN1tT3Bc1+Otzu6rjGm7X0UXUmPcQlIMY1vr8J67k70WSULxKvRo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH] tools/xenstored: Remove redundant check in socket_can_process() Date: Thu, 24 Jun 2021 15:46:55 +0100 Message-Id: <20210624144655.12900-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall Commit 3adfb50315d9 ("tools/xenstored: Introduce a wrapper for conn->funcs->can_{read, write}") consolidated the check !conn->is_ignored in two new wrappers. This means the check in socket_can_process() is now redundant. In fact it should have been removed in orignal commit (as it was done for the domain helpers). Reported-by: Raphael Ning Reviewed-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_cor= e.c index 9ffd2ac66d3e..cf7297a96cb1 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1752,7 +1752,7 @@ static bool socket_can_process(struct connection *con= n, int mask) return false; } =20 - return (fds[conn->pollfd_idx].revents & mask) && !conn->is_ignored; + return (fds[conn->pollfd_idx].revents & mask); } =20 static bool socket_can_write(struct connection *conn) --=20 2.17.1