From nobody Wed May 8 00:13:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1621357456; cv=none; d=zohomail.com; s=zohoarc; b=IWlo5eeTROSc8ximOOVDZ7GFEIYOwyxRWvl/MJifsr+6brKmsK0EAvchh65oT3qtlTus0IT58dzEOQkK5ssGUh973noOAbU1Ul4AJiSOWBr/+g4Mza0fYLNvlpI6PrSgzl8PxFzKgqvXNHw4O+WFvvNcpMCSvzZM73NlA+Xw2tM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621357456; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=V2fnyoE48qQ6Hp55cFrx3NNSfeosJA7sSVYcgqQFi8k=; b=Ej7ihKJ8W6jNyWPztljmLm6Ynjoqt3yray7GqvXjhft2F4Xt8I2buaorFj6Am2S6zwpgyHXv8NjXiJsrBSPoGQbfx2Cxxcr9qOU0puO28q/Jc3jfj03neZPps8fmbPc7+xchWTUBxM6Hu8e1EvatWa4b3LP5Etun3ShGitc1tr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1621357456052984.235743851331; Tue, 18 May 2021 10:04:16 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.129498.243049 (Exim 4.92) (envelope-from ) id 1lj38K-0001yN-3A; Tue, 18 May 2021 17:03:52 +0000 Received: by outflank-mailman (output) from mailman id 129498.243049; Tue, 18 May 2021 17:03:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj38K-0001yG-0E; Tue, 18 May 2021 17:03:52 +0000 Received: by outflank-mailman (input) for mailman id 129498; Tue, 18 May 2021 17:03:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj38I-0001yA-Vx for xen-devel@lists.xenproject.org; Tue, 18 May 2021 17:03:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj38H-0007pL-Oe; Tue, 18 May 2021 17:03:49 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj38H-0006eg-FU; Tue, 18 May 2021 17:03:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=V2fnyoE48qQ6Hp55cFrx3NNSfeosJA7sSVYcgqQFi8k=; b=L0X4SzIKPssOfA1dn/4wmVhzoq 2e0sCMC7H5CRHo0P5nYI2a60W5Ohr7tRCKM13HnABbexF19JJIFVleZSaKI9O4Z8xOwhfG4A5vAqA pGXqGUWhvXyotW51qhDAIVQgoQqo0STEMfFOsXk1xbOU8fTVKqvN0Qd4XO9cPCRt8pUk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu Subject: [PATCH] tools/libs: guest: Fix Arm build after 8fc4916daf2a Date: Tue, 18 May 2021 18:03:39 +0100 Message-Id: <20210518170339.29706-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall Gitlab CI spotted an issue when building the tools Arm: xg_dom_arm.c: In function 'meminit': xg_dom_arm.c:401:50: error: passing argument 3 of 'set_mode' discards 'cons= t' qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 401 | rc =3D set_mode(dom->xch, dom->guest_domid, dom->guest_type); | ~~~^~~~~~~~~~~~ This is because the const was not propagated in the Arm code. Fix it by constifying the 3rd parameter of set_mode(). Fixes: 8fc4916daf2a ("tools/libs: guest: Use const whenever we point to lit= eral strings") Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- tools/libs/guest/xg_dom_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c index b4c24f15fb27..01e85e0ea9c7 100644 --- a/tools/libs/guest/xg_dom_arm.c +++ b/tools/libs/guest/xg_dom_arm.c @@ -195,7 +195,7 @@ static int vcpu_arm64(struct xc_dom_image *dom) =20 /* -----------------------------------------------------------------------= - */ =20 -static int set_mode(xc_interface *xch, uint32_t domid, char *guest_type) +static int set_mode(xc_interface *xch, uint32_t domid, const char *guest_t= ype) { static const struct { char *guest; --=20 2.17.1