From nobody Sat Apr 27 17:54:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1621351325; cv=none; d=zohomail.com; s=zohoarc; b=XU/5ocCfO71RRSXCAWoSnFfYJYCu3W0gTLpsU/571yH/P8X1a10J3LbH+tJG0fwS/CReg7HEakUVBay4kzNoYMd0D6OQSuG4QR5AwfrB1Tzz2MYco9csDIvPqdpfv+S+4Ow+6vV5DcAgraEw31NAD4tTECyXZdb+tj1mLgTWz0o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621351325; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=bihKm/0I5e2904VEtD9FhHuR9ZFEzgsDrIr7s+Qg+Yk=; b=Lyb4j+Ez53uM+Mqu3VrPjv89okDNiAFPTeIMKtwGVsRn+yhYFL3AMZ2jHy/trdyqacnk54u17m7E4wIrLJOjouHapAGmAZ+21z4oU8Tc3yGfWRyg0cfZUjFWaUiYghU8eznkbBVcA4OWOC6sJx+Yk+gCLoJWf0GSUQsOxBrOvGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1621351325725803.5944969004246; Tue, 18 May 2021 08:22:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.129349.242800 (Exim 4.92) (envelope-from ) id 1lj1XW-0006Xk-Kp; Tue, 18 May 2021 15:21:46 +0000 Received: by outflank-mailman (output) from mailman id 129349.242800; Tue, 18 May 2021 15:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj1XW-0006Xd-H9; Tue, 18 May 2021 15:21:46 +0000 Received: by outflank-mailman (input) for mailman id 129349; Tue, 18 May 2021 15:21:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj1XV-0006XX-Ko for xen-devel@lists.xenproject.org; Tue, 18 May 2021 15:21:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lj1XV-0005Wi-GD; Tue, 18 May 2021 15:21:45 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj1XV-0000Gt-7e; Tue, 18 May 2021 15:21:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=bihKm/0I5e2904VEtD9FhHuR9ZFEzgsDrIr7s+Qg+Yk=; b=jwjiEbVEp6SoBekt84khga6jzN TowDPHVP/SKdmNJhrs0KH57rsRRzbkhvmMtAFEioVQnfpXspgWK1J5+QLpXBAJuJGq5oKQVbB5Nbw ZeZ4mxpz8RsaRVdfoQkiT+X0qp7KOPmvCoi6czFW7R0Sm1nnuU7R61EhwGGsKNslRxHo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, Julien Grall Subject: [PATCH] tools/xenstored: Remove unused parameter in check_domains() Date: Tue, 18 May 2021 16:21:40 +0100 Message-Id: <20210518152140.6333-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall The parameter of check_domains() is not used within the function. In fact, this was a left over of the original implementation as the version merged doesn't need to know whether we are restoring. So remove it. Signed-off-by: Julien Grall --- tools/xenstore/xenstored_control.c | 2 +- tools/xenstore/xenstored_domain.c | 4 ++-- tools/xenstore/xenstored_domain.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_= control.c index 8e470f2b2056..07458d7b48d0 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -589,7 +589,7 @@ void lu_read_state(void) * have died while we were live-updating. So check all the domains are * still alive. */ - check_domains(true); + check_domains(); } =20 static const char *lu_activate_binary(const void *ctx) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_d= omain.c index 3d4d0649a243..0e4bae9a9dd6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, xc_domi= nfo_t *dominfo) dominfo->domid =3D=3D domid; } =20 -void check_domains(bool restore) +void check_domains(void) { xc_dominfo_t dominfo; struct domain *domain; @@ -277,7 +277,7 @@ void handle_event(void) barf_perror("Failed to read from event fd"); =20 if (port =3D=3D virq_port) - check_domains(false); + check_domains(); =20 if (xenevtchn_unmask(xce_handle, port) =3D=3D -1) barf_perror("Failed to write to event fd"); diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_d= omain.h index dc9759171317..cc5147d7e747 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -21,7 +21,7 @@ =20 void handle_event(void); =20 -void check_domains(bool restore); +void check_domains(void); =20 /* domid, mfn, eventchn, path */ int do_introduce(struct connection *conn, struct buffered_data *in); --=20 2.17.1