From nobody Fri Nov 29 23:49:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1620840980; cv=none; d=zohomail.com; s=zohoarc; b=AwCSM6Yy36aXCLtQQ7jQ9fo6FkWcZQF9Pq/GS1StTP83NO2x8iDU2tqBw+B7tbi3C70fbwm+LfQ3hSe+7p4IoPivyj9x+nHhbTaYXQ0MAnOUZUDMphswdb6n8z7Wn8BrB41WfaSwc5RBmAhNJ9NCrqi67VV5Rn8dAcbJhf/zzlg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620840980; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=OA06v4DNmwymHkROXKnzWmQ6sFacjCJ8GkVTi9Nj6H8=; b=Hc4otWIPUtXLplsk71l4Wow4Xk9Mgr1H/pyy0KCZs1JTrkywOI8CTh53hPoyuHElfo/bm6S1eYqZrMJ8NU/ywQ9xfzNAfObnGkVMuFdLda5kC7JUwsmqUx6ONS55C7owR+lLynHcl/6ZI9hVvdAXuNzGDT2o+z+x0D3KlLE4XBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1620840980506533.8491303196813; Wed, 12 May 2021 10:36:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.126329.237820 (Exim 4.92) (envelope-from ) id 1lgsm2-0001Hr-EO; Wed, 12 May 2021 17:35:54 +0000 Received: by outflank-mailman (output) from mailman id 126329.237820; Wed, 12 May 2021 17:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgsm2-0001Hk-Bb; Wed, 12 May 2021 17:35:54 +0000 Received: by outflank-mailman (input) for mailman id 126329; Wed, 12 May 2021 17:35:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgsm1-0001He-Mo for xen-devel@lists.xenproject.org; Wed, 12 May 2021 17:35:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgsm1-00087v-5g; Wed, 12 May 2021 17:35:53 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgsm0-0000Tq-Se; Wed, 12 May 2021 17:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=OA06v4DNmwymHkROXKnzWmQ6sFacjCJ8GkVTi9Nj6H8=; b=aqbMCoMQnkevTLAg16qekpF+av 6R6i2Fc4crbn/MYpl/RqhmM/8DaIzyrQLo9c4Vuz1MizPmZQ9r7Ch77AneJIDgncEW5p3giJEX2o6 SAYA+w8A45Uav1g04ucSY3e4Ye7IJ2XblJzkro5ya3e8egvTz2s1RxJHlrPvMVjkVXCs=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: michal.orzel@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: gic-v3: Add missing breaks gicv3_read_apr() Date: Wed, 12 May 2021 18:35:48 +0100 Message-Id: <20210512173548.27244-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall Commit 78e67c99eb3f "arm/gic: Get rid of READ/WRITE_SYSREG32" mistakenly converted all the cases in gicv3_read_apr() to fall-through. Rather than re-instating a return per case, add the missing break and keep a single return at the end of the fucntion. Fixes: 78e67c99eb3f ("arm/gic: Get rid of READ/WRITE_SYSREG32") Signed-off-by: Julien Grall --- xen/arch/arm/gic-v3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index b86f04058947..9a3a175ad7d2 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1167,12 +1167,15 @@ static unsigned int gicv3_read_apr(int apr_reg) case 0: ASSERT(gicv3.nr_priorities > 4 && gicv3.nr_priorities < 8); apr =3D READ_SYSREG(ICH_AP1R0_EL2); + break; case 1: ASSERT(gicv3.nr_priorities > 5 && gicv3.nr_priorities < 8); apr =3D READ_SYSREG(ICH_AP1R1_EL2); + break; case 2: ASSERT(gicv3.nr_priorities > 6 && gicv3.nr_priorities < 8); apr =3D READ_SYSREG(ICH_AP1R2_EL2); + break; default: BUG(); } --=20 2.17.1